- 08 Apr, 2020 40 commits
-
-
Shengfa Lin authored
Modify session_commands Get/Set Window Position/Size to use Get/Set WindowRect from chrome Combine getWindowSize and getWindowPosition to getWindowRect. Change window_commands::ExecuteGetWindowRect to use it instead. Change-Id: Ifcc70bfaaab6c89908e404bac03decb8a6adacd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141612 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757561}
-
Piotr Bialecki authored
Other changes: - rename anchor and plane pose in mojo to mojo_from_xxxxxx to match convention - adjust samples to account for the possibility that anchors and planes can have their poses unknown - send null poses from device if tracking is paused - ARCore device now does not treat planes and anchors whose tracking is paused as removed - add DVLOGs all around to help with issue investigation - add test page for experiments with local space stability & drift Note: the test mentioned above is not exposed via proposals/index.html. Change-Id: I786e86d69b69badbace57ce62585e3d5fd1ae756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130778Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#757560}
-
Kyle Horimoto authored
This reverts commit 3e252473. Reason for revert: Original CL did not cause the flake; flake was fixed in separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/2141113 Original change's description: > Revert "[CrOS settings] Fix printing new route in settings page" > > This reverts commit 4c027362. > > Reason for revert: Potentially breaking https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4672 > > Original change's description: > > [CrOS settings] Fix printing new route in settings page > > > > https://chromium-review.googlesource.com/c/chromium/src/+/2126332 > > Changes the routes to printing pages in settings. os_printing_page has a > > route that was missed. This CL updates the route in > > os_printing_page.html to match the new route, from /printing to > > osPrinting. > > > > Fix: 1068322 > > Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: jimmy gong <jimmyxgong@chromium.org> > > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > > Cr-Commit-Position: refs/heads/master@{#756949} > > TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com > > Change-Id: I50d29f93d85233a198f62baec0e65b4c5eda9b4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139172 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756973} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,melzhang@chromium.org,tjohnsonkanu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1068322 Change-Id: I25cee2d65483a5a48b70d80c0469b6058d298f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142137 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757559}
-
Jan Krcal authored
This CL deletes dead code and thus prepares the ground for removing code for favicon sync. Because of these future plans some sync-related unit tests (that used this dead code) are simply removed instead of keeping the dead functions and marking them ForTest. Bug: 978775 Change-Id: I05f4b00a354cfd3f8528d6899761592ec76c5bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142114Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757558}
-
Guido Urdaneta authored
This test verifies that both key and delta frames are sent and received. Bug: 1068468 Change-Id: Idef4a4769de436504eef0e3e1709f6b6f7787a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142266Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#757557}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/475c8941a1ee..5d56a75005e3 git log 475c8941a1ee..5d56a75005e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 bsheedy@chromium.org [Telemetry] Fix GetFile quoting Created with: gclient setdep -r src/third_party/catapult@5d56a75005e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055225 Tbr: eseckler@google.com Change-Id: Ib1b9ae59096c0d903ff7630ade1de0c48c3be178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757556}
-
Mugdha Lakhani authored
This gets ChromeSecurityStateModelDelegate through ChromePageInfoClient, thus removing the need for (Chrome)SecurityStateModelDelegate.java. All references to the above have been removed. This goes towards removing chrome:// deps from PageInfoController.java so it can be componentized. Bug: 1052375 Change-Id: Ib254f9b9a7f274dc8da11095bfbd48d1bee362ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134305 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757555}
-
Aaron Leventhal authored
Bug: None Change-Id: I561ffe518dbd54a896a99e3d97bc0e03b919589e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140099 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#757554}
-
Garrett Beaty authored
The following changes were made to the console ordering: * The windows debug category appear before the windows release category, which matches the order for the other OS categories in the console. Bug: 1067057 Change-Id: I34e4ce8196742587a401019ef526a98ee8bfc0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140068 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#757553}
-
Charlie Hu authored
This CL lets DocumentPolicyParser::Parse return early when the input is empty. This avoids initializing static maps when there is actually no need to initialize them. Change-Id: I2ac3b7c6e9995c35fef97e76bc4969e236b6b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140199Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#757552}
-
Stephen McGruer authored
This was resolved in https://github.com/web-platform-tests/wpt/pull/21641 Bug: 1049607 Change-Id: I20aace27d2637d62a3433140697fc7a8b5a4071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046714Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757551}
-
Wei-Yin Chen (陳威尹) authored
When needing to use waitForView() on the whole view hierarchy, the API of waitForView() requires more boilerplate code than ideal. This CL makes it possible to write shorter code. Bug: None Change-Id: Ic97f67df1e833a2c38a5a7e09133170e79910b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138964Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757550}
-
Rayan Kanso authored
Moves the generic web tests to the wpt folder. Minor changes were made to them (using wpt resources, not checking for specific error messages). The tests that were checking for specific chromium error messages were duplicated and kept. As were tests using testRunner functions. Change-Id: I79d1d3c5cf2092753ef7b0bfbbfa7b227395f8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142214Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757549}
-
Wez authored
Fuchsia's package cache not longer makes non-base-image packages available unless the device/VM is online, with connectivity to the package server. Keep the Target's Amber repository live while the test runs, to work around that limitation. Bug: fuchsia:49704, fuchsia:44527, fuchsia:44529 Change-Id: I9aadf6823634d04bc292c80fac86cc9b7da5e0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142412 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#757548}
-
Xianzhu Wang authored
Update canvas filter quality when recording the foreign layer. Change-Id: I7a5ae65eb45664718be6bf56ff80c6057b1bca28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141611 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757547}
-
Peter Kotwicz authored
BUG=1068692 R=hartmanng TBR=yfriedman (for trivial LaunchMetrics.java change) Change-Id: I747d76539830241f2175c83c458b439c9ab74065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141122 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757546}
-
Bo Liu authored
In-process GPU has lower stability guarantees as it cannot be restarted. It does not have a watchdog timer. Establish channel timeout is not useful as it's only waiting for a thread to start and do work. So it can really only trigger for false positives. So disable the timeout for in-process GPU. Bug: 1068670 Change-Id: I047e07c29d74e8b68a8bcf2ecdb333f066c377fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140818Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757545}
-
Xiaoqian Dai authored
In rtl, the user needs to swipe from the right side of the screen to go back. Bug: 1031766 Change-Id: I732992fa7f7546358c42e75deb2f5244ededb81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140997Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#757544}
-
Ayu Ishii authored
This change adds behavior for opaque origins specified here [1], and wpt to validate its behavior. [1] https://wicg.github.io/cookie-store/#CookieStore-get Change-Id: Id947c964910857ba85dffdc6d7c1e45ef8b49029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137926 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757543}
-
David Bokan authored
If we're at an offset that can't be represented at an int then the page probably isn't usable but it's better to saturate than overflow here. Bug: 1068200 Change-Id: I07afcf9b0486fac3311c0a128a1932b768b69d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137827 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757542}
-
Brian Geffon authored
This change allows core scheduling to be turned on when renderers start and before entering the sandbox. By doing it before entering the sandbox it cannot be disabled. There is a flag we can use to disable this if necessary via a finch kill switch should bugs in the kernel be encountered. BUG=b:152605392 Change-Id: I0f3b81a03eac2e3603bff8514e0c58e0d4e286c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140066Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#757541}
-
Wei-Yin Chen (陳威尹) authored
Reuse a single string literal for Finch parameter "thumbnail_aspect_ratio", so that it's easier to cross reference. Bug: None Change-Id: Iff9434ec4b3d759f40d40b799ec0a3c27f8c33c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139431 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757540}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a5187a88958..3150d88ba4ca git log 6a5187a88958..3150d88ba4ca --date=short --first-parent --format='%ad %ae %s' 2020-04-08 mtklein@google.com add Pixel CPU Test jobs 2020-04-08 egdaniel@google.com Update gpu flush semaphore contract. 2020-04-08 senorblanco@chromium.org Dawn: staging manager rewrite. 2020-04-08 fmalita@chromium.org [SVG] Fix spec links 2020-04-08 mtklein@google.com stifle leaks in terminator_CreateDevice() 2020-04-08 mtklein@google.com get skvm/llvm building again 2020-04-08 mtklein@google.com narrow use of fast_unwind_on_malloc=0 2020-04-08 mtklein@google.com shard ASAN bonusconfigs bot 2020-04-08 jvanverth@google.com Use fuzzier definition of zero-length segments in compute_intersection. Created with: gclient setdep -r src/third_party/skia@3150d88ba4ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Id362a0f080c0c8fa7965eba71e557cdfdd7875fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757539}
-
Nnamdi Theodore Johnson-Kanu authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/2128928 changed the route path name and route constant from kAccessibilitySubPage to kOsAccessibilitySubPage. This change caused the settings tray to not route to the appropriate location. This CL corrects that issue, updating the system_tray_client.cc to point to the right constant name. Bug: 1068971 Change-Id: Ia42ce2d197eb04a4a8a2076defdfd84c81485b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142142Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#757538}
-
Changwan Ryu authored
Currently <input type='password' inputmode='numeric'> shows normal password type virtual keyboard. With this change, it will show numeric password type keyboard. Bug: 1068182 Change-Id: I04f85ff240678b3f8854a84ad9227e1437b3300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139355 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757537}
-
Mei Liang authored
This CL update tab selection indicator to match the boundary of the card. Change-Id: I41ecdf19ddee921b4fcb85c2fa1d715bdd0860aa Bug: 1042890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140190Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757536}
-
Sinan Sahin authored
Bug: 1068346 Change-Id: Ied07d2d4b0e181a886ece94ad4a763c8ec9d7cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137855Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#757535}
-
Haiyang Pan authored
Bug: 922145 Change-Id: I08d3a9cc3dda9fe4673399c27d07a41d4eeadcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138791 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757534}
-
Aaron Leventhal authored
Bug: None Change-Id: Ie2c29aff27cf942fcbb240294c5baa305ce2577c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141143Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757533}
-
Oksana Zhuravlova authored
This change removes ContentBrowserClient::BindInterfaceRequestFromFrame since it's no longer used. Bug: 1062403 Change-Id: I010f7fedc22d95517c265140ba56d8dd98633694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134802Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757532}
-
Esmael El-Moslimany authored
Depending on what has focus, mousedown event may not be emitted when a user touches an element. Elements should handle the pointerdown event instead. Change-Id: I255812428698be93b547869f6b2674ad6f86047a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141201 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757531}
-
Pavel Yatsuk authored
Set animation duration to 0 to disable toolbar animations triggered by displaying tab modal dialogs. BUG=1026908 R=twellington@chromium.org Change-Id: Idcc1fe2fc85f8ccccc3dad72a65da886e89fe9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#757530}
-
Amr Aboelkher authored
Shell-encryption is a simple Homomorphic Encryption Library that uses Ring Learning with Errors (RLWE)-based encryption. This CL does the following: - Adds the required dependent files for the library, to be compiled successfully in chromium - Migrating the library to be compatible with C++14. That was needed as chromium only supports C++14, and the library was Compatible with C++17 - Overrides the include_rules section for SHELL - Adds SHELL lib as a client for abseil-cpp -- Locking the visibility of the library - Remove the possibility of adding SHELL directly from chromium - Adds the owners of the library - Adds README.chromium -- Include explanation about the library -- Include info about updating the library Change-Id: Ibe6117303bd77dfccb7320184960cbe6d9360c9c Bug: 1066937 TBR=thakis Change-Id: Ibe6117303bd77dfccb7320184960cbe6d9360c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106138Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#757529}
-
Gyuyoung Kim authored
This CL moves stretched-simplified-layout.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to abspos-descendent-001.html because it seems like it's a better naming for this test. Bug: 1063749 Change-Id: Ifa4a49ef007edfdd3c30cab3d176696e72b445e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132549 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757528}
-
John Smith authored
This cleans up the double mapping for kColorId_DialogBackground in the color pipeline as well as adds a new kColorId explicitly for button. The new colorid is hooked up as appropriate for button cases and returns the same colors as it did with DialogBackground. Having it be separate would be helpful for cases like high contrast where the button may need greater differentiation from the background and for any downstream consumers who use a different color even in regular modes. Bug: 1067359 Change-Id: I966bb0446c85ba08d8fe9d844544ccd06aff7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135385Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: John Smith <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757527}
-
danakj authored
This method is used in the renderer and doesn't need the hole punching to content-internal that web_test_support_renderer was designed for. Move it to web_test/blink_test_helpers.h. R=nasko@chromium.org Bug: 866140 Change-Id: I62f16e813b5eae8aa7b117c992f072b65ebf8be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142512Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757526}
-
Wei-Yin Chen (陳威尹) authored
The browser customization content provider package is required to be a system package for security. On local builds of Chrome Android, this requirement is lifted for easier debugging. This doesn't affect end users. Bug: None Change-Id: I7aa05fa9d71cbe1e15ae76adce9c579a41d876d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139078 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757525}
-
Reilly Grant authored
This change adds basic support for composite devices to the new Windows USB backend. The set of device paths for each function driver are collected into a map which can be used instead of the root device path when trying to open a WinUSB interface handle. As with the previous patch this still won't work for devices the are enumerated while Chrome is running because the device nodes for each USB function are not yet available. This will be addressed next. Bug: 637404 Change-Id: Ifbda29ef3cbe4dda2adb25fe8454dcc2a7c2036b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138260 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757524}
-
Anqing Zhao authored
Because of the re-org of Chrome OS Commercial team, the reviewers of DeviceLocalAccount have to be changed accordingly. Change-Id: I4702708d641172f4288e28785d6658fda12e7a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141978Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#757523}
-
Aran Gilman authored
This mostly entails the following: * Replace empty constructors & destructors with '= default'. * Replace deprecated DISALLOW_COPY_AND_ASSIGN() with explicit deletions. * Use for-each loops where appropriate. Change-Id: I379c6d4573a529264cc1541e8d157f0b556e5505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128093Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#757522}
-