GitLab

- Make UI.ToolbarInput control to not grab focus on text change.
- Make sure revealTreeNode always resolves.

BUG=825274

Change-Id: Ibb4439ecc131cc74d51546c0d2247c4579735f9f
Reviewed-on: https://chromium-review.googlesource.com/978858
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546139}

This removes SSLInfo in URLLoaderClient::OnReceiveResposne(),
since SSLInfo is now available as part of ResourceResponseHead
(AKA network.mojom.URLResponseHead) that this method already
receives.

TBR=dcheng@chromium.org
(for security review of url_loader.mojom, where a parameter is being removed)

See also: https://chromium-review.googlesource.com/c/chromium/src/+/978623

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I15d744b85fbb0055f70397527ab82421c61713bf
Reviewed-on: https://chromium-review.googlesource.com/979263
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546138}

Use the Origin class a bit more thoroughly. Basically after verifying
a CustomTabSession with an origin, a Trusted Web Activity would succeed
navigating to the origin but fail (fall back to a Custom Tab UI)
navigating to a subpath under the origin.

Bug: 800422
Change-Id: I1877477bcf307b00cf87386ed7787b217a734512
Reviewed-on: https://chromium-review.googlesource.com/978006
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546137}

Problem: Setting switches::kReportVp9AsAnUnsupportedMimeType command
line flag on the Main process has no affect, as it is not
white-listed to be propagated to the render process in:
RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer()

Solution: Add switches::kReportVp9AsAnUnsupportedMimeType to white-list

Bug: None
Change-Id: I037edfd0457d7ae87743854b8fd7d2d92e7f5107
Reviewed-on: https://chromium-review.googlesource.com/981392Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546136}

Adds bsheedy to chrome/browser/vr/OWNERS for the VR browser test-related
code in chrome/browser/vr/ and chrome/browser/vr/test.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9ac6b819f9551c40b37e559184ea9bf9dab85df8
Reviewed-on: https://chromium-review.googlesource.com/981513Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546135}

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I037a0c3e5f91b284700cddfd5c5253f01aa7fde2
Reviewed-on: https://chromium-review.googlesource.com/978623Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546134}

TBR=nodir@chromium.org

Bug: 731360, 826308
Change-Id: Ic083772c8e0ce8f5ff5fb441074d39836155b418
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/980926Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546133}

NotifyProxyServiceOfChange -> NotifyProxyResolutionService
ProxyServiceTest -> ProxyResolutionServiceTest
CreateProxyService and related functions -> CreateProxyResolutionService

This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/857421

TBR=stevenjb@chromium.org,sky@chromium.org,sdefresne@chromium.org,sdefresne@chromium.org,mmenke@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I25d80931839ba8c71e2863a0b275419ba9ec5368
Reviewed-on: https://chromium-review.googlesource.com/944005
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546132}

This reverts commit a28ac453.

Reason for revert: The bug is fixed, the original config should work again.

Original change's description:
> ios-simulator*: specify dimensions directly
> 
> This is to mitigate the immediate fire (see the bug).
> 
> PLEASE REVERT once the bug is fixed.
> 
> BUG=825843
> R=​justincohen@chromium.org,maruel@chromium.org
> 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I87f20f1eff838fa535970da1e2271c0dbffe939f
> Reviewed-on: https://chromium-review.googlesource.com/981448
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545883}

TBR=maruel@chromium.org,justincohen@chromium.org,sergeyberezin@chromium.org,martiniss@chromium.org

Change-Id: If51b71c56092c2685d7cce1e3cb12c633678f8d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825843
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/982105Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546131}

This makes migrating to FlushAsyncForTesting() clearer.

BUG=668707,749312

Change-Id: I074c71c21e2cbbc3fc2b1ea87d08ebd957b6c7f7
Reviewed-on: https://chromium-review.googlesource.com/978839Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546130}

This patch implements LayoutText::GetUpperLeftCorner for LayoutNG.

Spartial navigation, scroll to anchor, Inspector, and some others
use this function.

The existing code for legacy was incorrect for vertical flow as
callers expect physical with flipped block, and the code uses
LineTop (logical top) as physical Y. This patch includes the fix
and a unit test.

This is another step to port InlineBox code to LayoutNG, started
when Aleks hit a bug by unported code.

Bug: 636993
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I658a58fd8bd5582d51e973bf97e3a4e97107603e
Reviewed-on: https://chromium-review.googlesource.com/981332Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546129}

We plan to make --site-per-process mode the default mode on ToT for
//chrome layer.  To make this switch slightly easier, this CL inlines
the test expectations from //testing/buildbot/filters into the source
code of the tests - this should avoid having to keep passing the filter
files to the default test steps after making the switch.

Bug: 671734, 824962, 824966
Change-Id: I4ce397f5a7be18cc184f081058bf57f2e7c6239f
Reviewed-on: https://chromium-review.googlesource.com/976643Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546128}

This fixes the bug where grey placeholder image looks scrolled. This
CL accounts for contentInset set on web view proxy.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic6346a1cf5b0a637016be53bfde6e6a9df4ddca8
Reviewed-on: https://chromium-review.googlesource.com/979607Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546127}

This adds test coverage for correctly passing launch id from browser startup
to the notification system when Chrome is launched by the notification_helper
process.

Bug: 734095
Change-Id: If902781ab49368616857ab72a1fa02f4a9949e2f
Reviewed-on: https://chromium-review.googlesource.com/981198Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546126}

Bug: 800507
Change-Id: I6c519b8e83a8875eba17e80559e31817498ecd16
Reviewed-on: https://chromium-review.googlesource.com/982094
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546125}

This histogram is logged when the user closes Download Manager UI
without starting the download.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4e7912e312b1eccbb839207160ed82cbb3d95577
Reviewed-on: https://chromium-review.googlesource.com/981461Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546124}

It was possible for ProblematicProgram instance to have a null
BlacklistAction if multiple programs were associated to a single module.

This is because a unique_ptr outside a For Loop was moved inside the
body of the loop, resulting on a null unique_ptr on iterations beyond
the first one.

Bug: 825746
Change-Id: I12def4ec483b2c277f0c9e5dbac8e65766677d61
Reviewed-on: https://chromium-review.googlesource.com/980829
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546123}

This CL only turns the feature on by default and sets the default model.

A followup CL will be required to clean up the autoblacklist code completely.

Bug: 786245
Change-Id: I57cd84a8216064ea4f697debfb47c9d7de6ee830
Reviewed-on: https://chromium-review.googlesource.com/973809Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546122}

This is a follow-up to https://crrev.com/c/980335.
This CL migrates SigninActivity and SigninFragmentBase to support
library fragments (android.support.v4.app.Fragment instead of
android.app.Fragment).

Bug: 825789, 814728
Change-Id: I76d8a5eb329e9b418d1ae1c75a8d272d2b7c6009
Reviewed-on: https://chromium-review.googlesource.com/982054Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546121}

In preparation for a large upcoming DEX support CL |kInvalidOffset|
needs to change as the Dalvik standard uses 0xFFFFFFF*F*U as a sentinel
value. Instead use 0xFFFFFFF*E* to indicate |kInvalidOffset|.

Change-Id: I8ada5beb8e0f5bef28dadb8c6401f95665670b91
Reviewed-on: https://chromium-review.googlesource.com/978380Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Cr-Commit-Position: refs/heads/master@{#546120}

BUG=826225
NOTRY=true
TBR=caseq@chromium.org

Change-Id: I1020aac34ec1646e976b6e6688bebdecd70f8b10
Reviewed-on: https://chromium-review.googlesource.com/982152Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546119}

https://chromium.googlesource.com/catapult.git/+log/767f070f1df4..6b8f67cc144c

$ git log 767f070f1..6b8f67cc1 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 cjgrant VR: Remove UpdateTexturesAndSizes metric

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:806886


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I768834ced8cefa7496bef0b879a37c4fd30ed51e
Reviewed-on: https://chromium-review.googlesource.com/982003
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546118}

Bug: 779637
Change-Id: Ib41fb81f13e40465f5ae56f10c86426207c17702
Reviewed-on: https://chromium-review.googlesource.com/981118Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546117}

TBR=maruel@chromium.org

Bug: 731360
Change-Id: I189644631ee8781f8590bc3dce95abf6849b766f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/982099
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546116}

Currently, I'm
hardcoding values for Android and returning 0 for all other platforms.
In a subsequent CL I'll pick the right icon size from the list provided
by the developer, based on this size.

TBR=peter@chromium.org

Bug: 813564
Change-Id: If1d302a7439f7533d1c5649cce7eb2d0bf5583bc
Reviewed-on: https://chromium-review.googlesource.com/968865
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546115}

The root cause of this was that a copy of the toolbar was being created
in fullscreen mode. It seems like having separate NSThemeFrame subclasses
for fullscreen and non-fullscreen is unsupported.

This change causes a regression by making the toolbar too large in
fullscreen mode; https://crbug.com/825968 was filed to address this.

Bug: 824757
Change-Id: I9d63a1646f5dbfd0666f367d1dc859359e91552f
Reviewed-on: https://chromium-review.googlesource.com/980600Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546114}

GCC's analogous command-line argument is -Wno-unused-local-typedefs, with an
's' at the end, and //build/config/compiler/BUILD.gn already passes it to
the compiler unconditionally when clang is not being used.

This CL prevents warnings in the GCC build that look like this:

    cc1plus: warning: unrecognized command line option ‘-Wno-unused-local-typedef’

Change-Id: Icec95a6d1cf3a4bcd4f3a0acb7f002850aa9f7af
Reviewed-on: https://chromium-review.googlesource.com/980942Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#546113}

TBR=maruel@chromium.org

Bug: 807149
Change-Id: If98643d43b34edef6916eb6b669f4a98c2494018
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/982096Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546112}

Add "UsePdfCompositorServiceForTest" experiment to the field trial under
tests for all desktop platforms. It tests the new PDF generation service
which supports OOPIF printing.

BUG=824867

Change-Id: I808c8ed04509e5d6a6074d35b4d569f22c6c3e77
Reviewed-on: https://chromium-review.googlesource.com/981176Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546111}

Issue 824772 is a potential cause of issue 818214. Report whether
devtools is in use to investigate if there could be other causes.

Bug: 818214
Change-Id: Ia714353016a65473e5926ce7cbea9f65058bb39d
Reviewed-on: https://chromium-review.googlesource.com/980585Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546110}

Bug: 747349
Change-Id: Ied3abb6f93a391bf6581275efbd96b3763413de9
Reviewed-on: https://chromium-review.googlesource.com/976540Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546109}

Async Tracing (using TraceEvent.startAsync/finishAsync) used to be a
no-op if native has not loaded yet. Now they are deferred to
EarlyTraceEvent and stored on the java side until native is loaded then
are sent ala TraceEvent.begin/end

Bug: 822816
Change-Id: I612d03213b832cc6d381d98203bc5c9aca4ab12b
Reviewed-on: https://chromium-review.googlesource.com/971763Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546108}

https://skia.googlesource.com/skia.git/+log/2ef4525daf15..33f02edb14bb

$ git log 2ef4525da..33f02edb1 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 robertphillips Switch DDL rendering to be a Via in DM (take 2)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I5c06441073a15a91186cd2fd46d1e47967769eb6
Reviewed-on: https://chromium-review.googlesource.com/982000
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546107}

BUG=814587

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia607af378e66fa6c9b62dae780b51931dcef7184
Reviewed-on: https://chromium-review.googlesource.com/981894Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546106}

Embedded devices have limited storage capacity generally. But current default
hard coded value is 5MB per an origin in application cache storage. But embedders
often want to reduce the default hard coded value per an origin as well. So it would
be good if we give the power them to set the maximum cache size per an origin for
application cache through the command line.

Bug: 824619
Change-Id: I078365ec412834c024a92ff5ec4ad5d00452e2a7
Reviewed-on: https://chromium-review.googlesource.com/979877
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546105}

This is a reland of d260e9cf

It was reverted because of crbug.com/824716, these weren't new crashes
but known crashes mislabeled as a fallout of this change.
http://cl/190471699 fixes the crash backend to not rely on
"content::BrowserThreadImpl::IOThreadRun" being in the signature.

Only diff in this CL is to use base::debug::Alias() in methods that we
don't want optimized (i.e. IOThreadRun) out as CHECK_GT was seen as
optimized out in some of the reported crashes (even though the same
pattern as before was used by this CL..?)

Original change's description:
> Refactor BrowserThreadImpl, BrowserProcessSubThread, and BrowserMainLoop
>
> This brings back the invariant that BrowserThread::IO isn't available
> before BrowserMainLoop::CreateThreads(). This was broken to fix issue
> 729596 to bring up the thread earlier for ServiceManager but it is
> important that code that posts to BrowserThread::IO statically have an
> happens-after relationship to BrowserMainLoop::CreateThreads(). Exposing
> it statically earlier put that invariant at risk.
>
> Thankfully fixing issue 815225 resulted in finally reaching the long
> sought goal of only having BrowserThread::UI/IO. Now that the IO thread
> is also kicked off before it's named statically, BrowserThreadImpl no
> longer needs to be a base::Thread, hence this refactoring.
>
> Before this CL:
>  * BrowserThreadImpl was a base::Thread
>    (could be a fake thread if SetMessageLoop was used)
>  * BrowserProcessSubThread was a BrowserThreadImpl
>    (performed a bit more initialization)
>  * BrowserProcessSubThread was only used in production (in
>    BrowserMainLoop)
>  * BrowserThreadImpl was used for fake threads (BrowserMainLoop for
>    BrowserThread::UI) and for testing (TestBrowserThread(Impl)).
>  * BrowserThreadImpl overrode Init/Run/CleanUp() from base::Thread to
>    perform some sanity checks as well as drive IOThread's Delegate (ref.
>    BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread re-overrode Init/Run/CleanUp() to perform
>    per-thread //content initialization (tests missed out on that per
>    TestBrowserThread bypassing BrowserProcessSubThread by directly
>    subclassing BrowserThreadImpl).
>
> With this CL:
>  * BrowserThreadImpl is merely a scoped object that binds a provided
>    SingleThreadTaskRunner to a BrowserThread::ID.
>  * BrowserProcessSubThread is a base::Thread and performs all of the
>    initialization and cleanup specific to //content (this means it now
>    also manages BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread can be brought up early before being bound to
>    a BrowserThread::ID (BrowserMainLoop handles that through
>    BrowserProcessSubThread ::RegisterAsBrowserThread())
>
> Unfortunate exceptions required for this CL:
>  * IOThread::Init() (invoked through BrowserThreadDelegate) perfoms
>    blocking operations this was previously performed before installed
>    the ThreadRestrictions on BrowserThread::IO. But now that //content
>    is initialized after bringing up the thread, a
>    base::ScopedAllowBlocking is required in scope of IOThread::Init().
>  * TestBrowserThread previously bypassing BrowserProcessSubThread by
>    directly subclassing BrowserThreadImpl meant it wasn't subject to
>    ThreadRestrictions (unfortunate becomes it denies allowance
>    verification to product code running in unit tests). Adding it back
>    causes DCHECKs, as such
>    BrowserProcessSubThread::AllowBlockingForTesting was added to allow
>    this CL to pass CQ.
>
> Of note:
>  * BrowserProcessSubThread is still written as though it supports many
>    BrowserThread::IDs but in practice it's mostly always
>    BrowserThread::IO (except in ThreadWatcherTest I think). This change
>    was big enough that I didn't bother also breaking that
>    generalization.
>  * BrowserThreadImpl's constructor was made private to ensure only
>    BrowserProcessSubThread and a few select callers get to drive it (to
>    avoid previous missed initialization issues)
>  * Atomics to manage BrowserThread::SetIOThreadDelegate were removed.
>    Restriction was instead added that this only be called before
>    initialization and after shutdown (this was already the case).
>
> Follow-ups to this CL:
>  * //ios duplicates this logic and will need to undergo the same change
>    as a follow-up
>  * Fixing ios will allow removal of base::Thread::SetMessageLoop hack :)
>  * Removing BrowserThreadGlobals::lock_ to address crbug.com/821034 will
>    be much easier
>  * BrowserThread post APIs should DCHECK rather than no-op if using a
>    BrowserThread::ID before it's registered.
>
> Bug: 815225, 821034, 729596
> Change-Id: If1038f23079df72203b1e95c7d26647f8824a726
> Reviewed-on: https://chromium-review.googlesource.com/969104
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544440}

TBR=jam@chromium.org

Bug: 815225, 821034, 729596, 824716
Change-Id: I9a180975c69a008f8519d1d3d44663aa58a74a92
Reviewed-on: https://chromium-review.googlesource.com/980793Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546104}

Remove the WebMouseEvent dependency in MouseEvent
and all its subclasses like DragEvent and WheelEvent.

Bug: 820249
Change-Id: Icc62baea6862901cb91a531f7b649c6858ee94dd
Reviewed-on: https://chromium-review.googlesource.com/956543
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546103}

The fix is to reduce the scope of the |lock_| during track adapter
creation because Create[Local/Remote]TrackAdapter() may synchronize with
another thread that is busy waiting for the |lock_|. There is no reason
to hold the |lock_| while creating the adapter; we are ensured no other
adapters of the same kind (=local/remote) are created concurrently
because they may only be created on the appropriate thread (local =
main thread, remote = signaling thread) which is the thread currently
running the operation. In other words, at most 1
GetOrCreateLocalTrackAdapter() on the main thread and at most 1
GetOrCreateRemoteTrackAdapter() on the signaling thread can run at the
same time.

This is the equivalent of the WebRtcMediaStreamAdapterMap fix
(https://chromium-review.googlesource.com/c/868656/) but for the track
adapter map.

The deadlock is quite rare, but due to recent unrelated changes it has
become frequent enough that it is easily reproducible on some platforms
and applications, see bug.

Bug: 813574
Change-Id: I2e7ba605db973221f80443267fd099c5973ab818
Reviewed-on: https://chromium-review.googlesource.com/980949
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546102}

Mostly moving things around, refactoring...

1. Move GetRTCStatsCallback from rtc_peer_connection_handler.cc to
   rtc_stats.[h/cc] where other blink/webrtc stats-related content-glue
   is placed, and rename it RTCStatsCollectorCallbackImpl.

   This allows it to be used by content's RTCRtpSender and
   RTCRtpReceiver in follow-up CLs.

2. Remove unused content::RTCRtpSender-constructor.

3. Move WebRTCStatsReportCallbackResolver from RTCPeerConnection.cpp
   to its own file.

   This allows it to be used by blink's RTCRtpSender and RTCRtpReceiver
   in follow-up CLs.

4. Implement new PeerConnectionInterface::GetStats() functions in
   MockPeerConnectionImpl (need to wait for
   https://webrtc-review.googlesource.com/c/src/+/62900 to land and roll
   into chromium).

Bug: 680172
Change-Id: Ief18b2fb96ebc292149af606bd0edd87bac9e961
Reviewed-on: https://chromium-review.googlesource.com/973368
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546101}

 * Mac10.10 Tests
 * Mac10.11 Tests
 * Mac10.12 Tests
 * Mac10.13 Tests

No-Try: True
Bug: 790162, 790157, 790160, 818391, 790164
Change-Id: I9bc62e97f97012ca147f09e7ddb82b96169588ed
Reviewed-on: https://chromium-review.googlesource.com/982002Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546100}