- 19 Jan, 2021 40 commits
-
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I4a0a92a9c84c9ad08c6a2efe95c10b1bacbbbccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637303Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844730}
-
harrisonsean authored
Redesigned site settings page enabled/disabled strings. Bug: 1113642 Change-Id: I4b16629fdf0997fae00d0b5bfc9a541330de902a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461013 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#844729}
-
Owen Min authored
This matches the behavior of RemapRenamedPolices function in PolicyServiceImpl Change-Id: I7a38bb6f286c6ae873373454e379ec4103cbf58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636278 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844728}
-
Saurabh Nijhara authored
The C++ style guide suggests that enums should be named like constants, not like macros. This CL adapts the new style for ExtensionStatus enum in force_installed_tracker. Bug: 1167661 Change-Id: If74d7b647c9d484d510fdae04df722fda5b43cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633270Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#844727}
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: Ib2248ce249427ed4af1cc769416da28089c79c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637713 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844726}
-
Robbie Gibson authored
This test makes sure that the ViewRevealingVerticalPanHandler can handle two gestures at once. Specifically, if a second gesture is received while processing a first gesture, the second gesture is ignored. Bug: 1161209 Change-Id: I2b4f4ea1553e2cc11a51a6430485ecb900ac9d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632692Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844725}
-
Shik Chen authored
This reverts commit 6d262811. Reason for revert: https://crbug.com/1168057 Original change's description: > CCA enables multiple streams > > Chrome camera app enables multiple streams while recording. > > also pass type checking > > Bug: b:151047537 > Test: Manually test. preview is 640x360 and recording is 1280x720. > Change-Id: I8171b0061a94ca8653c044857da2598eece43e5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409683 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Inker Kuo <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844700} TBR=jcliang@chromium.org,shik@chromium.org,henryhsu@chromium.org,inker@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6fd3a938699b0a57f95554bd620e0dd5f4e9f6db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:151047537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637100Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844724}
-
Alice Wang authored
This CL moves the method called by native code launchSigninActivity() from SigninPromoUtil to SigninBridge. Bug: 1165772 Change-Id: Id684316cd759379235651511d34216fcbb74337d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632950Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844723}
-
Alice Wang authored
This CL cleans up the abstract method SigninFragmentBase#getSigninArgument(). It's simpler to use Fragment#setArgument() directly in code. Bug: 1045473 Change-Id: I40023d4b6c03db65aba29b7f8b596201aecdaa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633263 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844722}
-
Marc Treib authored
LocalSync means that Sync is not actually talking to the Sync server, but instead to a local server. There might not even be a signed-in account. In this situation, it makes no sense to offer the account-scoped storage - it's not going to work anyway. Bug: 1147165 Change-Id: Ib2a50c493e03756b9ee3948907ffabf974491ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637573Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#844721}
-
Rainhard Findling authored
The test is flaky. TBR=justinmiron@google.com Bug: 1168036 Change-Id: I51e479cc3f30953bc33143dd723db96ee1be2a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637634Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#844720}
-
Mathias Carlen authored
Before this patch AutofillAssistant flows would lose a non significant percentage of users that do not yet have the feature module installed. This patch adds two countries (US, GB) to the conditional install tag for the dynamic feature module so that this percentage will be lowered. Due to technical limitations around isolated splits this is only made available for Android O+ devices. Also note that this patch had to introduce a slightly different manifest for trichrome since those modules require min-sdk version 29. Bug: b/174305656 Change-Id: I49767dc9516e8e383f17c94697d44d3ad65305c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627372 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844719}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eddf4e758768..d1684427cdca 2021-01-19 dberris@chromium.org Revert "Reland "chromeperf: Anomaly configs in subscriptions"" 2021-01-19 dberris@chromium.org chromeperf: Remove broken logging 2021-01-19 dberris@chromium.org chromeperf: Use an empty dict for default config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I88b81ed738decf37449736dff7923a283910102d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637298Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/111e01a4ac13..ea4488d496b4 2021-01-19 sigurds@chromium.org Refactor ErrorWarningCounter to use a new CounterButton component 2021-01-19 wolfi@chromium.org Add sources_panel_icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140516 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e94f474f5f99d431c3312ad84b3477b96388f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637299Reviewed-by:
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ia7fe05b5c8f5038edc1d2f41a93d1ebd5c3b23ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632392Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844716}
-
Shik Chen authored
Some devices do not support the pointsOfInterest control and there is no standard Web API can query it without trying to apply it. This CL catches the exception from applyConstraints() and simply ignores it. Bug: b/172345418 Test: Manually Change-Id: Ied24770a1eddf8e6f3772287da6fd55c818b85e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637434 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#844715}
-
Robbie Gibson authored
When the thumb strip is open in peeked state, switching tabs should not close the thumb strip. This added EGTest checks that is the case. Bug: 1155211 Change-Id: Ifc530731b69e3572e0d3f6837cd68b857b1c08cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636393Reviewed-by:
-
Rainhard Findling authored
The test is flaky. TBR=lukasza@chromium.org Bug: 1163630 Change-Id: I63691605c11a1ab5cc0adafaa03544d6fb6a974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637494Reviewed-by:
-
Titouan Rigoudy authored
I have promised a few times that I would extract these tests once they reached a critical mass and I had a minute. That time has come. Bug: chromium:1167697 Change-Id: I5808dfa7bfac32190c39354895096c9e0679a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632681 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844712}
-
Jan Wilken Dörrie authored
This change fixes an issue inside IsContiguousIterator that would fail compilation if it was instantiated with an iterator to a container that has a non-trivial value_type. This was because `IsContiguousIterator<It>` instantiated `std::basic_string<iter_value_t<It>>` to determine whether `It` was an iterator for a `std::basic_string`. This would then trigger a static_assert inside basic_string if `iter_value_t<It>` was not a trivial type. Now IsContiguousIterator<It> only attempts to instantiate a std::basic_string if `iter_value_t<It>` is a trivial type, avoiding this issue. Bug: 828324 Change-Id: I1ab8d10b1847cca09041cc3f2fe623d2a04602fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632958 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844711}
-
Robbie Gibson authored
The cause of this DCHECK (and resulting broken UI) was that as part of closing the tab grid, the tab strip is snapshotted. As it has changed (new tab added), everything, including the tab grid has to be re-laid out. This causes the tab grid to scroll back to the recent tabs page, causing the bvc to be removed after it was added correctly earlier. This ends up with a broken UI and a black screen. The fix is that the tab grid coordinator should alert the tab grid that its content will disappear before changing the pan handler state. Bug: 1094335 Change-Id: Ie9062766952b6a5957046b472515223010b6c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632654Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844710}
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: I6cdcd2fb6a5813b453ef809011d6c09d9ee169a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637302Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
-
Victor-Gabriel Savu authored
Bug: None Change-Id: I07b8ff33ca484cbc88d369b6ff74fcdeb1e20c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635671 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1cb592d4efd1..cc7aa8e318bb 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 68635b431b3c to 81430e11c81e (12 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1d3066a6 to 00da91bb (227 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I5929eaba68d292c36e7d82879dc40a1353aceeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636995Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I493389752fdb93e9df006ee63a14eaebd5c650c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637414Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844706}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611024810-f8a51712b469a1b51b3e448822968fd32c8978ae.profdata to chrome-win64-master-1611035655-73de094cb5ff55b60927a0f5adde75a5bce05096.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I86acd36af6ff9f3b19cf62ae0cd2e71c41b2c141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637335Reviewed-by:
-
Kenichi Ishibashi authored
We have a hypothesis that ServiceWorkerRegistration could be destructed between ActivateWaitingVersion() and ContinueActivation(). This CL adds an instrumentation to confirm the hypothesis. Bug: 1159778 Change-Id: Id15e4832e6ce82cc5230dc3f907b3e90036e62de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636007Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844704}
-
Jérémie Boulic authored
Background.m.js replaces background.js and background_scripts.js. Update background.html to load the Image Loader as JS modules. Optimize_webui to run Image Loader as JS modules. Tests: Load image loader and check that there is no additional error in the console. Current integration tests pass. Bug: 1133186 Change-Id: I3cdf9fd2a59bca080b15c3efad51739a15fa93e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635384 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#844703}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: Icb4d7b9739b315e74cd9157dda932c1e3e2b02b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628771Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844702}
-
Ye Kuang authored
Bug: 1141780 Change-Id: Iec73a683433b599f8a226e1b035c01e2f4a7f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636744Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
-
Heng-Ruey Hsu authored
Chrome camera app enables multiple streams while recording. also pass type checking Bug: b:151047537 Test: Manually test. preview is 640x360 and recording is 1280x720. Change-Id: I8171b0061a94ca8653c044857da2598eece43e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409683 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by: -
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611013939-848f93cc4650c420e66bbec68de10e40d4656b36.profdata to chrome-mac-master-1611035655-254822a7c03cbefbcbdc34527b5136e1083ea204.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9bc425290d545bb217bd83697e265097345536aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637393Reviewed-by:
-
Glen Robertson authored
This allows other code to depend on profile.h (very common as it is a keyed service key) without depending on all of //c/b:browser. This improves modularization of the codebase and will help to break dependency cycles in GN. Bug: 1149277 Fixed: 1149277 Change-Id: Ib8a160dbcd29301490f9826278262980e34dbf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542933Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844698}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5eda7597b6b7..eddf4e758768 2021-01-19 dberris@chromium.org chromeperf: Support legacy test names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I73a164a8051a942473b4d061de008de106e4127b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637254Reviewed-by:
-
Jan Krcal authored
This CL adds WebContentsModalDialogManager to the sign-in flow web contents and implements its delegates. This is needed by the webauthn modal dialog which is in turn needed by the Gaia sign-in flow with security keys. Bug: 1167887 Change-Id: Ief107bf16056c5a8ceb3ed7b192b22497957e09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636399 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds two accelerators into the profile creation flow to improve accessibility and usability: - the back action for screens that actually show the back button - the reload action for the sign-in flow that happens over the internet and thus loading of the page can fail. Bug: 1126913, 1167675 Change-Id: I3c197dea2859c0136db62249064249e0569a93da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611013939-1c9af1927a800d0fae0bbc5808e1b1b28e5ab3fe.profdata to chrome-win32-master-1611024810-772a0a2d15ca5658988961a1c7ea3d1b91cdca35.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I04293ea11cd07dae3798b3b26e3b5ce815ab14a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636994Reviewed-by:
-
Eric Willigers authored
We add use counters for - close() - readable - writable - remoteAddress - remotePort Bug: 905818 Change-Id: I02539b29d3c1035642ba9200651ac15135eb58c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636634 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844693}
-
Tal Pressman authored
Following the discussions on platform-architecture-dev[1], this CL expands MojoBindingContext's responsibility to include context lifecycle notifications which were previously in ContextLifecycleNotifier. [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/_7Ybv_RLgic Change-Id: Icdcc2a59bf0580b919d1dbb015a45bfd184583b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596279 Commit-Queue: Tal Pressman <talp@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844692}
-
Luciano Pacheco authored
When running as JS module which is strict by default, the IF condition was raising an exception because the Polymer variable isn't defined. Fix by checking the variable explicitly in the global scope. Bug: 1133186 Change-Id: If62e8d5fd45a4453e67810c04a6bdf3cf2033fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637097 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844691}
-
