- 07 Mar, 2019 40 commits
-
-
John Budorick authored
Bug: 938487 No-Try: true Change-Id: I887735faee58cfe04e74359107ed4ab8d15a8ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507196 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638512}
-
Leo Zhang authored
These interfaces is used to load shared library and base classes dynamically into the IME Mojo service at runtime. Bug: 837156 Change-Id: I6da2aba6227ecb0ac91c552783ddf0c6c56e25c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478651 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638511}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2995dc2a67c7..952d27384a7e git log 2995dc2a67c7..952d27384a7e --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Fix windows build Created with: gclient setdep -r src/third_party/swiftshader@952d27384a7e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic130cdd215a1cbdb3c42eaefe788318b7ca166c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638510}
-
Hiroshige Hayashizaki authored
Bug: 829084 Change-Id: I699e5e8ac655f1b305fff5985a107d29f2200fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506825Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#638509}
-
Sylvain Defresne authored
Bug: 936211 Change-Id: If7bef8b0cd9256c961102773478a4afd6da7887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505510 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638508}
-
Anton Permyakov authored
For unknown key codes presenting in an accelerator 0 is added to the shortcut text. This results in unprintable character to be used on extensions shortcuts settings page. Bug: 936812 Change-Id: I5301660d8110defd908146862a230666af09a07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497072 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#638507}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/79d25ea0ce18..40c16ec0b3ad git log 79d25ea0ce18..40c16ec0b3ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1717 from jeffbolznv/getBufferReferenceAlignment 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1716 from jeffbolznv/buffer_reference_fold2 Created with: gclient setdep -r src/third_party/glslang/src@40c16ec0b3ad The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc2f1c00445188fe66ed46e4cf259dc9853ce850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506666Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/weborigin with the macros of Allocator. After some analyzes, it was concluded that for the case of ReportingServiceProxyPtrHolder, URLSchemesRegistry, and SecurityOrigin classes, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. Bug: 919389 Change-Id: Ibff778b830c479908df8ba454e289f8d604b365a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506057Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#638505}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::ReadAndReturnValueWithError that returns a base::JSONReader::ValueWithError. Bug: 925165 Change-Id: Ifdcc83a2612e4baed32d8c133dbb2f2b2c8640e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505632Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638504}
-
Ioana Pandele authored
This ensures that the feature check is performed only if all prerequisites for the feature are met. Bug: 903249 Change-Id: I0af5bbecff66e2c660b4d6b89cf64dc92fc8d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499517Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#638503}
-
Richard Knoll authored
This properly implements notification sync with the currently displayed notifications if supported by the platform. Bug: 891339 Change-Id: I467931abb54af94dc53f3981492487e5818a45f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505633 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638502}
-
Kazuki Takise authored
Android tells Chrome to activate windows through onTaskMovedToFront, which is called by ActivityStack#moveTaskToFront. For PIP tasks, we reparent them with reparent() and the function inserts them on top without using moveTaskToFront, so we seem to activate them explicitly. confirmed the browser was properly activated. Bug: b/123259430 Test: Exited PIP, pressed the shelf icon of the browser, and Test: atest android.server.am.ActivityManagerPinnedStackTests Change-Id: I7532e4b2c66a28b83168abcf3207266961c9a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485625 Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#638501}
-
Richard Knoll authored
This is required for the first version of Notification Triggers until we support scheduling notifications and storing the data in a more general way. Bug: 891339 Change-Id: I614c7279a3a065d6c261ea96d12b6d866f2db6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472695 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638500}
-
Jia authored
This cl contains the following changes 1. Use ModelConfigLoader to provide Adapter with some params. 2. Simplify params used by Adapter. The major changes are (i). We now change brightness as soon as average ambient light changes by more than a threshold. (ii). The ambient threshold is now an absolute value and not a ratio. It is also measured in the log space. 3. Log metrics explicitly for Atlas and Eve Bug: 881215 Change-Id: I45486e4e2cb12083c763a2f0db8b0efd077695af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501895 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#638499}
-
Andrew MacPherson authored
Optional sampleRate parameter to AudioContextOptions, if provided then the AudioContext will run at this sampleRate, otherwise it will run at the hardware rate. Running the AudioContext at a lower sample rate can allow running a heavier graph on low-end devices, for example if a given device is able to run with X nodes at a sample rate of 48k, it can support roughly 2X nodes at 24k or 4X nodes at 12k. Bug: 432248 Change-Id: I835f28b4625763bd6a6ddbee9b89636ef8a8a066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482957Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#638498}
-
danakj authored
WebViewHelper is a WebWidgetClient even though WebViewPlugin's WebView is not composited. So set it up as the WebWidgetClient after attaching the main frame. R=dcheng@chromium.org, tommycli@chromium.org Bug: 920952, 912193 Change-Id: I8391bde1d0452cf78d23a8b855a45497bac02d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504142 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#638497}
-
Andrew Moylan authored
These were added in http://crrev.com/c/1352824 (model_impl.h) but we didn't add them to enum.xml yet. Bug: 933200 Change-Id: If18be5107be2124797f72f0f290c0666e61a3c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496122Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638496}
-
vitaliii authored
Enable using Scrypt to derive the key when encrypting data with a new custom passphrase in Chrome Sync (starting from M74). I manually tested the functionality locally. We have a kill switch, which we can use if we decide not to launch in M73/M74. Bug: 875901 Change-Id: I37dee9a66e0f519e963a6b3a13887c3bf8b2e049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497141Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#638495}
-
Miyoung Shin authored
- unsigned long long / long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I24e97b5d2c3068e092d2f40a45920991468a06bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507294Reviewed-by:
-
Kamila Hasanbega authored
This reverts commit 99d553b3. Reason for revert: This has likely caused failing tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11228 Original change's description: > pdf: Switch to the threaded version of ink > > Updates the resource manager to not require a mime type when loading > a bundled resource. This is the same as the behavior in [1]. > > [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 > > Bug: 902646 > Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 > Commit-Queue: dstockwell <dstockwell@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638324} TBR=thestig@chromium.org,dstockwell@chromium.org,rdevlin.cronin@chromium.org Change-Id: I9ed4732eb289e9f8e0d1712ea7e03e46dbba032b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507712Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#638493}
-
Mohamed Amir Yosef authored
Enable Sync on clients one at a time in order to avoid race conditions. Bug: 919877 Change-Id: Ic8820cf33c9deb9cae3fbf24df0d2e1846d36cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506083 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638492}
-
Zhuoyu Qian authored
TouchEventDispatchResultType is unused, remove it. Change-Id: I9f3e49d5d9599dd5448bc54c2b9c71602b1cc325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506917Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#638491}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/text with the macros of Allocator. After some analyzes, it was concluded that for the case of LayoutLocale class, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. In WebEntities class, it makes sense to use DISALLOW_NEW because it's used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: Icf692c5541746e1b3d93662cdc951070d092b4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506677Reviewed-by:
-
Haojian Wu authored
The CDB for chromium is huge (~200MB), emitting into one line will make editors freezing when opening it. Change-Id: I85a09485104fd7c9c6c1b426178d9823bdfba543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505508Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/692122e3ef23..52e620ffd0bd git log 692122e3ef23..52e620ffd0bd --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@52e620ffd0bd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1e30b7b627af860b205dde01cb9b28746c773b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506645Reviewed-by:
-
Colin Blundell authored
The SigninManager unittest is the one test that uses FakeProfileOAuth2TokenService outside of either IdentityTestEnvironment or IdentityManager and friends. However, it doesn't need to, as it doesn't use any of the heavy functionality that FakePO2TS exposes. This CL changes it to use ProfileOAuth2TokenService, clarifying the actual usage of FakePO2TS in the codebase. Bug: 938823 Change-Id: I2fdea1b4c073be2488a9aae10fb7c2fb5b773766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505452Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638487}
-
Kazuki Takise authored
Currently, the backdrop window in AlwaysOnTopContainer is not set as always on top, which causes the window to be reparented to DefaultContainer when SetFullscreen is called for it (as OnPreWindowStateTypeChange is added to AOTController in [1].) This is causing the crash of the browser process when a window exits PIP. To prevent this, this CL sets a new property to backdrop windows so that they won't be reparented to another window. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1447991 Bug: b/124699190 Test: Confirmed exiting PIP didn't cause crash Change-Id: I4f2729e949bfcfd7bcb1b5e2ca623109ad5d7501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482100Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#638486}
-
Darwin Huang authored
- security bugs were for integer overflow and heap-buffer overflow. Bug: 925656, 932353, 925381 Change-Id: Ibda5a20302153b7ede3a5b89a7bcea622fded869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504333Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638485}
-
Dominic Mazzoni authored
TBR=nektar@chromium.org Bug: 905419 Change-Id: Iabcb0eff62369972c07aef952fa6345422b761ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507256Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638484}
-
Yuichiro Hanada authored
kLoginLayoutWhitelist has a list of xkb layout ids that are allowed to be used on login screen. However, the same information is already in //chromeos/ime/input_methods.txt. This CL removes the array and use the infomation in input_methods.txt instead. There is a slight diff between kLoginLayoutWhitelist and input_methods.txt. - 'fr' is only in kLoginLayoutWhitelist and xkb_manifest.json uses it. I updated xkb_manifest.json to use 'fr(oss)'. - 'ro(std)' and 'ga' is specified as login layouts in input_methods.txt, but not in kLoginLayoutWhitelist. They are considered as login layout after this CL. Bug: None Change-Id: Ic88846555310e3c534e64dd195bd47aa80befa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490986Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#638483}
-
Marc Treib authored
After https://crrev.com/c/1430089, this state is not meaningful anymore. Yay, one less! Semi-relatedly, this CL also moves some NotifyObservers() calls, to avoid notifying while we're in an intermediate (and thus potentially invalid) state. Bug: 839834, 935908 Change-Id: I6093ba3bd44452990ba9b0b8926b3c6e308c90ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481418Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638482}
-
Matt Falkenhagen authored
The non-servicified path is no longer supported. Bug: 926114 Change-Id: I0fa7058c73fb185f15bc00ff62d494cefb7ece45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506064 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638481}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/48f640f5365e..ffb1ffb82284 git log 48f640f5365e..ffb1ffb82284 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ffb1ffb82284 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic67fa50d7eb1c449dc5769cf94d27b181e432568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506207Reviewed-by:
-
Zinovy Nis authored
cc/paint/image_provider.cc:14:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:18:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)), destruction_callback_(std::move(callback)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:27:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(other.image_)), ^~~~~~~~~~ ~ cc/paint/image_provider.cc:37:12: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] image_ = std::move(other.image_); ^~~~~~~~~~ ~ Change-Id: I2c3d49f7833ea117ef1b6aec4cf9037d19cb7c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489751Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#638479}
-
Matt Falkenhagen authored
ServiceWorkerServicification is always enabled now, so loader interceptors are always enabled. Bug: 926114 Change-Id: I77855393a475da5636c7c855d6456b6819cd3e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506062Reviewed-by:
-
Yann Dago authored
Each section of the chrome://management page should look like each section of the settings page Visual of management page: http://screen/CQ335FkdT5a ChromeOS: http://screen/tZofcxLpJ6B Visual of settings page: http://screen/pYsjEZuRsVr Bug: 938995 Change-Id: I50f150081b1ca24d02be9aea2b2ee668965f53fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506499Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638477}
-
Hajime Hoshi authored
This CL refactors FrameMsg_JavaScriptExecuteRequest* and FrameHostMsg_JavaScriptExecuteResponse from being a legacy IPC message into a method on mojom::Frame and mojom::FrameHost. This is necessary for bfcache where JavaScript must not be executed on per-thread task runners. While legacy IPC processes messages on a per-thread (default) task runner, Mojo can dispatch on a per-frame task runner. Bug: 870606 Change-Id: Ie655dc6f594568f70efd3f030e9d49257c64cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488405 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9c4c2512141..45209e43f286 Created with: gclient setdep -r src-internal@45209e43f286 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:934623,chromium:790705 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I8eac98e38a3350282c1334764876a6a8fb4fab78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506643Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638475}
-
Maggie Cai authored
Currently we are not showing cookies in the site details page. It is confusing when we enter the site details page from the All Sites page, which shows the cookies for the origin. This CL shows the cookies in the site details page and also allow the user to clear the cookies from the site details page. In addition, if there are cookies on the etld+1 level and we only have one origin, we will show them as a grouped entry instead of collapsed to the top level entry. This is because otherwise the collapsed entry will look weird if we enter the site details page, which only shows the cookies number from the origin, not the etld+1. BUG=835712,935269 Change-Id: Id145657099f9d12fb9efd0200cb57c8e3ba8bb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493691 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638474}
-
Karandeep Bhatia authored
This CL fixes extraHeaders event listeners for webviews in network-service path. r611357 began requiring the 'extraHeaders' specifier for event listeners which wanted to intercept certain headers. However this doesn't work for webviews in the network service path. ExtensionWebRequestEventRouter::HasAnyExtraHeadersListenerImpl doesn't correctly handle web view event names, causing the WebRequestProxyingURLLoaderFactory to enter into an inconsitent state. Fix this by changing how HasAnyExtraHeadersListenerImpl is implemented. BUG=938095 Change-Id: I8ceb830fd16a2ec671d3b7f49f891ae4c30cb6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504817 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638473}
-
