- 07 Aug, 2020 40 commits
-
-
Marijn Kruisselbrink authored
This not only saves memory, but also makes the (blocking) BlobUrlStore.Registry mojom call faster by not having to set up the blob mojo binding context at that point. On the other hand this makes blob url resolution slightly less efficient, but this seems like the right trade-off. Bug: 1112410 Change-Id: Ic8e97fbcc313ae053f55166d1bad5479a856b8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335402 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#795821}
-
Viviane Yang authored
This CL renames the enum PushDeliveryStautus defined in push_messaging_status.mojom to PushEventStatus. The enum is no longer sorely used for push message delivery events (`push` events) but also for tracking the status of `pushsubscriptionchange` events, which is why a more general name PushEventStatus is more appropriate to report the event dispatch status. Please refer to CL:2332708 for more information. Change-Id: Icbb98dc66b680aa5f194c7dddbd51323918938f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339474Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#795820}
-
Jose Dapena Paz authored
GCC build fails because of missing include: ../../components/payments/core/error_message_util.h:20:16: error: ‘vector’ in namespace ‘std’ does not name a template type 20 | const std::vector<std::string>& skipped_apps); | ^~~~~~ Bug: 957519 Change-Id: Icb7c5b0e9b136d14eb088884f8d4f8ee312b9460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340967Reviewed-by:Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#795819}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/679763691656..ff9cb9b4ed1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: I4ed01705382e2d75a25fdccc961337662598bb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342081Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795818}
-
Jiewei Qian authored
Chromium browser grants some permissions to all websites by default. Most WebUIs will expect to have these permissions. However, users can block them if they are not registered with WebUIAllowlist for chrome-untrusted:// pages. This CL registers these permission to the chrome-untrusted:// part of sample system web app, as a reference for future chrome-untrusted:// WebUI implementations. Bug: 1101060 Change-Id: I66e84519ea4d8fc2b3cf759e8f147ad1111c752d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342490 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#795817}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/CUU63VsXItsrBlNDrRhMgCrIBW8n5Lch_BLHRTfvmNUC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008060800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I5a13fbd907624b64977c733eac49088ff5efc98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342427Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#795816}
-
Yves Arrouye authored
Since we only want a new name to run parameterized tests, and no new behavior, we can alias the type rather than create a new class. Bug: None Test: unit_tests --gtest_filter=*AutoEnrollmentClientImplFRETo* Change-Id: Id5c6d80a458baa2dfee382a201b5256d686da6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341171 Auto-Submit: Yves Arrouye <drcrash@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795815}
-
Cherie Cheung authored
This is a reland of 4702a75d Original change's description: > ARCVM SharePath() to use correct seneschal port > > During the processing of ARCVM SharePath() request, it was retrieving > the seneschal port via some Crostini functions. This was incorrect and > would trigger a Crostini restart. This change will properly fix this > by retrieving the correct seneschal port from ArcSessionManagerVmObserver. > > BUG=b:147618164 > TEST=tast run <DUT> arc.Drivefs.vm > > Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 > Commit-Queue: Cherie Cheung <cherieccy@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794973} Bug: b:147618164 Change-Id: I9570d8b18f05ea0ef629b19144b910dd4380cd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341086Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795814}
-
Fergus Dall authored
This gives the user much more ability to debug failures. Bug: 1110165 Change-Id: I5815a6cba3ac947b07a62fee1f1969118eb8b940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340352 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#795813}
-
My Nguyen authored
As we currently only needs autocorrect marker, we should only request suggestion types. Bug: 1109074 Change-Id: I81ed0fb146b1b37b4ec3159510405f1253a0f78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342328Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795812}
-
nancylingwang authored
When the scale is not 1.0, e.g. 2.0, the web apps generated icon can't apply the mask correctly, because the web apps icons use the scaled ImageSkiaReps, which don't match the mask imageskia loaded from the ResourceBundle, and CreateMaskedImage reports error due to mismatched scale and pixel size. Add a mask cache to cache the mask ImageSkiaReps for different scale, pixel size, and when loading the mask, check the current image's scale, pixel size to generate the mask imageskia to match the image. BUG=1083331 Change-Id: If16c3603db888e73bb272e6cbdd409ba8d0d4468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336387 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795811}
-
My Nguyen authored
Following UX writing review, update the relevant strings and layout. See go/cros-assistive-input-ux-writing-review. Current view: http://screen/9cXRfLiVR9M Add icon-secondary-color as specified in http://go/cros-ux-icon-color. Added a TODO to rename the rest of the files and strings in code. Bug: 1113612, 1113611 Change-Id: I4360a23addbc7e92bb6eca614e7dd543470f9792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341023Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795810}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a1495ff04c6..8221fb43a117 2020-08-07 nidhijaju@google.com Revert "Removing "other origins" UI from DevTools Service Worker tab" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112894 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia690cb80328807cea533de5659dfd901e9b57a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795809}
-
Matthew Mourgos authored
This CL creates a background circle of the proper size for standardized icons. Also, icons that should appear within a background circle are now scaled by using the distance of the farthest visible point from the center of the icon. This will ensure a constant spacing between the scaled down icons and the background circle. Bug: 1110496 Change-Id: I392b9a3738f2dac01dadea44b8a3e473402298eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342066Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795808}
-
Alice Wang authored
This CL changes AccountPickerDelegate.mAccountNames to a local variable to make this class simpler. Bug: 1093795 Change-Id: I92450414e13224bb3eb19afe10a392bdb6cbb276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339744 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795807}
-
Wei Lee authored
We should use TODO(crbug.com/{ID}) rather than TODO(crbug/{ID}) or TODO({ID}). Bug: None Test: None Change-Id: Ib6c89955e9c317f79e8870ddef579bf4aff6c155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342329 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#795806}
-
Kelvin Jiang authored
The structs were already functional by M85, but because the documentation was updated after the branch cut, the docserver listed ModifyheaderInfo as being available at M86. The availability is usually determined automatically by looking over API schemas over different versions/channels in chrome/common/extensions/docs/server2/availability_finder.py Bug: 947591 Change-Id: Iae71ac3c7b6bc9fb7e7d86815e855e31f588f36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340074Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795805}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e3988722bf9f..3831ac2043e4 2020-08-07 syoussefi@chromium.org Remove suppressions for passing tests 2020-08-07 geofflang@google.com Supress VVL error about multi-instance heaps. 2020-08-07 jmadill@chromium.org Vulkan: Rename CommandBuffer get method. 2020-08-07 jmadill@chromium.org Vulkan: Remove redundant vk prefixes in vk_helpers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ia601a7e9d5c613862a3d54b76ba93adf51f631be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342072Reviewed-by:
-
tby authored
This expired some time ago, so this CL removes it in-code. I'm keeping the associated Finch flag around for now, because it serves as a kill-switch for Drive suggestions. Bug: 1110737 Change-Id: Id863efd71c089bb8f9f91c4bb4afbbfa68a4d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342487Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#795803}
-
Ahmed Mehfooz authored
Bug: 1111904 Change-Id: I6cf412d09070419d52bce191dce7309aecdb00ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340934 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b35c3b8bcdf7..ea70694da8b1 2020-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from fa4b74d479aa to 2cf5a08cfc1b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I4f208be8c45abf476f5c1412e3b05553df07f52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342074Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcb0ad4d8c58..679763691656 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113265 Tbr: patricialor@google.com Change-Id: I168773269bd405e766efbf28ffcbaf440c6b7b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342071Reviewed-by:
-
Maggie Cai authored
Currently the intent picker launched the web app when user select the web app. This CL updates to reparent the web app instead of launch. BUG=1113969, 853604 Change-Id: Ie7a790999f68696a9c1d58bb1ef6e1e1cd8112b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341228Reviewed-by:
-
Kent Tamura authored
This CL ports LayoutButton::BaselinePosition() to ng_flex_layout_algorithm.cc. FlexNG's children don't have the last-line baseline values. So we set BaselineAlgorithmType in NGFlexLayoutAlgorithm::Layout() so that children provide the last-line baseline as well as the first-line baseline. PropagateBaselineFromChild() needs to call |NGBoxFragment:: FirstBaseline()| explicitly because button children's Baseline() is the last-line baselines. * text-overflow-ellipsis-button-expected.html Ellipsis processing in LayoutNG keeps the first letter. Bug: 1040826 Change-Id: I36402b4fc291d2989c45fb1764202f4fcea91fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300902 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#795798}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca50c1ef5f52..5a1495ff04c6 2020-08-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-07 nidhijaju@google.com Revert "Adding a link to SW internals page to view other origin SWs in DevTools" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112894 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87c3e12cad8f46f062ce9e9f2e8370bf772e38fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342073Reviewed-by:
-
Zufeng Wang authored
When the help app launches (or navigates), the main frame updates the src of the iframe with the main frame's pathname (but not search or hash params). The existing routing logic inside the iframe shows the subpage. Also changed the iframe to be created by js in browser_proxy.js, and add <head> and <body> tags so Chrome doesn't need to infer where to add them. Bug: b/147786001 Change-Id: Iddc2028a9f086d4caf5f18b93c148914578f31d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340503 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
-
Minggang Wang authored
As SplitCacheContentBrowserTestEnabled.SplitCacheDedicatedWorkersScripts becomes flaky recently, this patch disables it on Win10 and Linux ASAN. Bug: 1104847 Change-Id: I3ba6e017232f79cf78b127b8621e1aa17d03caa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342465Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29812a90. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Iccf4e22ef0e929da50967775c4a332c6e4fa83e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339939Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795794}
-
Ahmed Mehfooz authored
Bug: 1111484 Change-Id: I62e6916d4e535065dc968cf708c914f4bfa7321f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338003 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //android_webview. Bug: 1113033 Change-Id: I5dcc8599dc972c2631a7bd9d0e26d11e1fe68d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335659Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Auto-Submit: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#795792}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ee50b032e42a..c4d3ff474abe 2020-08-07 wvw@google.com Fix systrace cgroup data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1113545 Tbr: oysteine@google.com Test: Test: catapult/systrace/bin/systrace sched Change-Id: I29b79a556f226c8f2ce89cd916d0417c18fac3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342070Reviewed-by:
-
Makoto Shimazu authored
These tests are disabled: - RequestDesktopMobileSiteTestCase/testAppVersionJSAPIWithMobileUserAgent - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteKeptSessionRestoration - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteDoesNotPropagateToNewTab - RequestDesktopMobileSiteTestCase/testRequestMobileSitePropagatesToNextNavigations - RequestDesktopMobileSiteTestCase/testRequestDesktopSitePropagatesToNextNavigations - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteGoBackToMobilePurged Tbr: gambard@chromium.org No-Try: true Bug: 1111194 Change-Id: I3ac977790b4eef149cd8ccbecf955d416043319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331252Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795790}
-
sangwoo authored
Sometimes the first or the last dot of dotted line for text is too heavy and long. We should improve this. Bug: 807368 Change-Id: I2851c964892b145154514c6f38e8025a8c29a7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319501 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795789}
-
Josh Simmons authored
Add a Chromium feature flag to enable / disable Files.app running as a System Web Application (SWA). Bug: 1113981 Change-Id: Ib829df993294bef692b14aed8dab3749c5d227e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342227Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#795788}
-
Rakina Zata Amni authored
Turn off proactive BrowsingInstance swap for WebAppDataRetrieverTest.GetWebApplicationInfo_FrameNavigated The test does not expect a change of RenderFrames. Bug: 977562 Change-Id: Ib11cf533d413616fc9189103f44c0dc8dc327e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335850 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#795787}
-
Joe DeBlasio authored
This CL adds a list of 10k common english words to Chrome. Rather than include this list directly into the binary as a full list, its encoded as a DAFSA, which provides a space efficient set inclusion check. This CL is a necessary building block for implementing the policy in the referenced bug. This list isn't presently used anywhere, but the CL is large enough by itself that I didn't want to burden it further. It'll be used shortly after submit. Bug: 1106962 Change-Id: Ia03daca847e2eea42671b3d18348d5c706cc4904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340879 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795786}
-
Gavin Williams authored
This new destination will be used in the Print Preview dropdown to replace the existing Save to Drive destination. go/save-to-drive-cros-design-doc Bug: 1112416 Change-Id: If754c141adb66e070a3224343f034865e9ee0b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336019Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#795785}
-
Kang Minchul authored
Remove use of base/macro.h and use explicit deletion instead Bug: 1010217 Change-Id: I506af7085e0098351642a28b127965d16d103c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341022 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795784}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6e1d2d16082..ca50c1ef5f52 2020-08-07 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.2.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79f792ae159ba591d35385b1c14bfb9e80908ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341705Reviewed-by:
-
Alan Cutter authored
This CL ensures we re-install default installed Extension apps that were migrated to web apps if the migration flag is disabled. Previously we would not reinstall the old Extension because the uninstall for migration was recorded as a user uninstall. This CL updates AppService.Uninstall() to take an |uninstall_source| enum so the call site can indicate whether it is a user or migration uninstall. Bug: 1104696 Change-Id: I832e2d8f3c3769a45f147aafb1c4e15646c8fdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339294 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#795782}
-
