- 03 Apr, 2020 40 commits
-
-
Jeff Yoon authored
- chromium_trybot recipe set in ci.star for both bots - mb configs set in mb_config.pyl for both bots, exactly the same as the builders Bug: 1055164,912681 Change-Id: Ib2235e9803ddafddbd7fc44be493ab06fcb74c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121429 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#756442}
-
Dale Curtis authored
This reverts commit 6db10514. This did not work well so it's being reverted. R=tguilbert Bug: 1012063 Change-Id: Ia5faf1026921dab735ead8acaa8f4fdd80dc6fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135894 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756441}
-
Garrett Beaty authored
Consoles defined using ci.console_view instead of luci.console_view can specify a dictionary that controls how entries in that console are sorted. Calls to ci.builder can then specify the console_view_entry attribute with the category and/or short name for the builder and an entry for the builder will be added to the console corresponding to the builder's mastername. Bug: 1067057 Change-Id: Icbbb310bbf4434aeb2434ab930e8fb64fff85a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136107 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756440}
-
Alexander Cooper authored
Moves chrome/browser/vr/service and corresponding dependent metrics code into content. Also moves not-yet published statics into content/public. As a result of the move a few changes had to be made: * VRService needed to switch to PermissionControllerImpl * Swapped two "NULL"s to "nullptr" * Renamed usages of XRRuntimeManagerStatics to XRRuntimeManager * Deleted WebVRServiceProvider and directly hooked up VRServiceImpl in browser_interface_binders * Switched ChromeXrIntegrationClient::GetInstance usages to use ContentBrowserClient->GetXrIntegrationClient (and removed ChromeXrIntegrationClient::GetInstance) * Created GetXrDeviceServiceForTesting to manage dependencies for tests * ukm::GetSourceIdForWebContentsDocument replaced with WebContents::GetLastCommittedSourceId * XrRuntiemManagerUnitTest needed some singlethreaded task environments added due to changes in tests (requirements from using mojom) It seems like linking //device/vr into a source_set causes one of the static initializers from gvr_shim to get counted now (perhaps being optimized out when in a static library?) Bug: 1031622 Change-Id: Id856e6cb68471a9960f54c663ece417461067541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125016 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#756439}
-
Clark DuVall authored
This can now be shared between //chrome, //headless, and //weblayer. Bug: 1050722, 1049317 Change-Id: I3fdc6979926b7ba8d27a8543cace8909b5c3f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134691 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#756438}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/52ecbf88d69c..14215fbea0c8 git log 52ecbf88d69c..14215fbea0c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 jophba@chromium.org Add recipe engine servers to buildbucket cfg Created with: gclient setdep -r src/third_party/openscreen/src@14215fbea0c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I609f25078b3928b034c3e1e2dd54cc67368a3bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756437}
-
Tom Anderson authored
The bot's config will be moved into linux-ozone-rel, so this temporary bot can be removed. BUG=1029240 R=agable Change-Id: Iff366bf66bbf8d4a04e3d88970199908e8e0f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134692 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Peng Huang authored
glImportMemoryWin32HandleEXTFn and glImportSemaphoreWin32HandleEXTFn are added. It will be used for implementing Vulkan GL interop on Windows. Bug: 1067709 Change-Id: Ic6fa3e44ea5da64bd4f56491c97daee184e0f362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135420Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756435}
-
Arthur Eubanks authored
This reverts commit fd6e6ffb. Reason for revert: https://crbug.com/1067752 Original change's description: > Use urllib instead of curl > > Now that https://crbug.com/965937 is fixed. > Partial revert of https://crrev.com/c/1624331. > > Change-Id: I9e73fdff99984601182ec142723a9d3521a9eb6e > Bug: 897796 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134702 > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > Auto-Submit: Arthur Eubanks <aeubanks@google.com> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756285} TBR=hans@chromium.org,aeubanks@google.com Change-Id: Ia53d6e84a8e09d13d7935cfde3b9310d7bc06e93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136138Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756434}
-
Orin Jaworski authored
This CL takes another step toward having selection change logic consider full selection instead of updating line and state separately with assumed NORMAL state default. The API is preserved for now but behavior changes slightly in a way that should, long term, be more efficient than doing event handling in duplicate. In particular, the goal is to have result views only update on selection change once instead of once on line change and then again on state change. Bug: 1046523 Change-Id: I6c94db73d4997241275e4a1b62b75272611c166a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134917Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756433}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7803f6a504e3..d49a958f8fdf git log 7803f6a504e3..d49a958f8fdf --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rsavitski@google.com Merge "perfetto_cmd: if unique session is given, set comm to "p-session_name"" Created with: gclient setdep -r src/third_party/perfetto@d49a958f8fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id38cce4b2db2e6f76aab5656dc51a97b18121ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136133Reviewed-by:
-
Joey Arhar authored
This reverts commit ddcb2103. Reason for revert: The revert caused a compile error, so I am relanding it. I will then disable the test that was failing on msan instead. Original change's description: > Revert "media/video: Add SpatialLayer to VideoEncodeAccelerator::Config" > > This reverts commit ee98d31c. > > Reason for revert: > After the commit, SpatialLayerStructTraitTest.RoundTrip has been > consistently failing on msan. > > I was able to reproduce the failure locally on my linux machine by > building and running media_unittests with these gn args: > is_component_build = false > is_debug = false > is_msan = true > msan_track_origins = 2 > use_goma = true > > Original change's description: > > media/video: Add SpatialLayer to VideoEncodeAccelerator::Config > > > > This CL adds SpatialLayer to VideoEncodeAccelerator::Config so > > that a VEA client is able to configure a spatial layer encoding. > > The configuration is useful to configure temporal layer encoding > > too. Supporting temporal layer with vp9 hw encoder is a short > > term goal today. > > > > Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy > > > > Bug: 1030199 > > Test: media_unittests > > Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Dan Sanders <sandersd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756300} > > TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org > > Change-Id: I6a86cb5a8f7d5fd2d1b7dbd4b3d6d99d2298c5dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1030199,1067758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136113 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756427} TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org,jarhar@chromium.org Change-Id: If73b6e850248954c8709acc86b923d67dc11597a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030199, 1067758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136226Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756431}
-
Eric Roman authored
This reverts commit 89fd75a0. Original change's description: > Add quick check parameter to ConfiguredProxyResolutionService ctor > > Doing this cleans up an undesirable ConfiguredProxyResolutionService > usage pattern where code that primarily works with a > ProxyResolutionService must currently cast to the specialized class > before setting the right PAC quick check value. > > Bug: 1032820 > Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802 > Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753426} TBR=eroman@chromium.org,jam@chromium.org,mmenke@chromium.org,niarci@microsoft.com Bug: 1032820 Change-Id: I6c68ef6eca61e76ae35ba62665b0c9e880d9c833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135984Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756430}
-
Yusuf Sengul authored
This change is a follow up to a previous Chrome SSO change[1]. Currently, Chrome SSO through GCPW would only work if the profile is the initial profile dir. That wouldn't work if initial profile dir is deleted and/or another profile is being used. This change addresses signing into profile through GCPW regardless of profile being initial profile. Note that signing into profile doesn't work: If the same GCPW user is authenticated in any other profile. If any other profile was used to sign-in with GCPW before. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1984474 Bug: 1038368 Change-Id: I8719d1dbea59eb31206f9c897331fcd9674aae9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084721 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#756429}
-
Thomas Guilbert authored
One of the versions of GMS core had a bug, where seeks timing out would cause a crash, leading to crbug.com/914072. The fix at the time was to send manually-crafted 'seek' messages, instead of using the API. The issue was in a single version of GMS core, and the roll in crbug.com/958461 should have fixed it. This CL removes the temp fix, and switches back to using the normal API. Bug: 918644 Change-Id: I335493d535166f5154f8127f4001192ffbebff53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134399Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756428}
-
Joey Arhar authored
This reverts commit ee98d31c. Reason for revert: After the commit, SpatialLayerStructTraitTest.RoundTrip has been consistently failing on msan. I was able to reproduce the failure locally on my linux machine by building and running media_unittests with these gn args: is_component_build = false is_debug = false is_msan = true msan_track_origins = 2 use_goma = true Original change's description: > media/video: Add SpatialLayer to VideoEncodeAccelerator::Config > > This CL adds SpatialLayer to VideoEncodeAccelerator::Config so > that a VEA client is able to configure a spatial layer encoding. > The configuration is useful to configure temporal layer encoding > too. Supporting temporal layer with vp9 hw encoder is a short > term goal today. > > Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy > > Bug: 1030199 > Test: media_unittests > Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756300} TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org Change-Id: I6a86cb5a8f7d5fd2d1b7dbd4b3d6d99d2298c5dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030199,1067758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136113Reviewed-by:
-
Akihiro Ota authored
Before this change, ChromeVox compared locales using the language component. It treated zh-hant and zh-hans as the same, even though they are completely different. This change fixes this behavior; we now perform a strict comparison and alert the user if the locale has changed in any way. Bug: 1061222 Relnotes: N/A Change-Id: I1b1fe89c43d9fa9cec0a7b35a21798e937263754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101717Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#756426}
-
Alexandre Frechette authored
Bug: 1065431 Change-Id: Icd8d9dbb98b5408a2d3de383baa1d26c4134c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124737Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#756425}
-
dpapad authored
Need to double escape backslashes, since the JS parser parses the string before the Polymer bindings parser kicks in. Fixed: 1063530 Change-Id: I3a61824703cd5826920e347c82468d1ddf764cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117162Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756424}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3b734860c9926296a874b5d9f648fd6e2979a600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136056Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I458f85e0dbf767df4d858a116348be0de94618e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135649 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756422}
-
Eric Orth authored
Start a 2 second timer on SystemNetworkContextManager creation. On fire, checks for parental controls and updates the network service DNS config if DoH needs to be disabled. Should be more performant to check after the delay because the actual underlying API calls with performance issues are already triggered off-thread in Chrome main(), so the check is only a performance issue if called too soon after startup. On all config retrievals, skips checking parental controls if it hasn't been checked yet and the otherwise-configured mode is AUTOMATIC. In this mode, DoH activation probes don't even start until 5 seconds after NetworkService creation, so delaying 2 seconds before disabling DoH should have no practical effect. If the otherwise-configured mode is OFF, it doesn't ever need to be checked, and if SECURE, it's acceptable to take the performance hit to always wait for the check. For UI retrieval of config, set a flag to force checking parental controls immediately to ensure the UI shows the correct state. If the check hadn't been made yet, this triggers an update to NetworkService to ensure the UI state matches the service state. Made some simple changes to pull the service update calls into GetStubResolverConfig() to simplify its ability to perform the service update. Also converted the type for retrieving DoH servers from the mojo type to DnsOverHttpsServerConfig now that the mojo update is handled internally to GetStubResolverConfig(), and moved the type to doh_provider_list.h to be more widely shareable. Little bit of code churn, but nothing significant. Bug: 1064346 Change-Id: I6505bd363d6c1fb88b255dd8c1dd1973b721bf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130867Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#756421}
-
Owen Min authored
Disable the test on other platforms because the test is also timeout on them. Bug: 403325 Change-Id: I5e544c8392f69c251a9da6c327d6eadce9b53e76 Tbr: wjmaclean@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136030Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756420}
-
Anders Hartvoll Ruud authored
The properties defined by css-logical (and more generally surrogates) pose a hard problem for 'revert' in the StyleCascade, because declarations such as 'margin-bottom:revert' may actually need to revert to a different property in the previous origin (e.g. margin-block-end). An example is the h1 element, which is styled by html.css using css-logical properties. When the author then reverts using a corresponding physical property, we can't simply look up the cascaded value for that same physical property in the UA origin: we must be aware that the css-logical property won the cascade _at that level_. So when we we're applying an author declaration 'margin-bottom:revert', we have to find the *target property* for the revert, which is either margin-bottom (if that property won the cascade at the target origin), or the corresponding css-logical property. However, to find the target property, we need to know during the application of margin-bottom that a corresponding logical property (surrogate) needs to be taken into account. AutoSurrogateScope was created for this purpose, which sets (and resets) a "current surrogate" field on CascadeResolver. This current surrogate is used when resolving reverts, in order to find the correct target property. Also, we don't control the order in which physical/logical properties are applied. This means we could be applying the physical property first, which is unaware of any logical properties that should have been taken into account for revert. In other words, if we apply 'margin-bottom:revert' without the context of a "current surrogate" set, we'll fall back to unconditionally using margin-bottom as the target property, which may be incorrect if there also exists a logical property we'll get to later. This is why the force-reapply code exists: when both the physical and logical property exists in the cascade, the physical property must be applied (or re-applied) during AutoSurrogateScope, otherwise revert will not behave correctly. Bug: 579788 Change-Id: I864a4c9afdd94f130c42635d28d45c843d5fb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130850 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756419}
-
Mustafa Emre Acer authored
This CL introduces the ability to observe mouse clicks when a page with a delayed SafeBrowsing warning is loaded. If the feature parameter "mouse" is enabled, the warning is immediately shown on mouse click. Otherwise, a metric is recorded the first time user interacts with the page. Bug: 1057157 Change-Id: If81e9c5867b7e72703a284b8226e2987f5edf3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120428 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756418}
-
Lukasz Anforowicz authored
This CL is a step toward |request_initiator_site_lock| enforcement. This CL adds a call to mojo::ReportBadMessage when |request_initiator_site_lock| doesn't match |request_initiator|. OTOH, for now such request is not rejected as |!IsSane|. Hopefully the extra DwoC reports will help us make progress on https://crbug.com/1056949 (especially in presence of other mojo::ReportBadMessage fixes like https://crbug.com/987986). Bug: 920634 Change-Id: I454b67f2ad486c7cf65f4df1c9fa18bb3e5376eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112751Reviewed-by:
-
Gang Wu authored
TBR=tedchoc@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067719 Change-Id: Iececd4ad6ed0c016f12391148dd571623705e00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136088Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756416}
-
Mansi Awasthi authored
Bug: 1030242 Change-Id: I84a837b95eb48f05c144bf47d557bbcf303fa78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135101 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756415}
-
Michael Thiessen authored
This is just a precautionary change, as most launchFlags are not useful for launching apps from Chrome, and present an attack surface by allowing app launches to do interesting things like manipulate task stacks, prevent transition animations, etc. Bug: 1054826 Change-Id: I744e48476f7d2a88f7802cefc553b5c12748a470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128232Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#756414}
-
Xianzhu Wang authored
This fixes a regression caused by crrev.com/710881. The reason is that before that CL, we had an extra level in GraphicsLayer tree (which was the root GraphicsLayer created by VisualViewport), and the frame overlays were added in that level after the root layer of the contents. With the CL, frame overlays and the top-level contents GraphicsLayers started to have the same parent, so the frame overlays may be behind the contents layers after later compositing updates. The problem affected "persistent" frame overlays such as the DevTools overlay which lives when DevTools is running. Now in FrameOverlay::UpdatePrePaint(), always keep the GraphicsLayer the last child of the root layer to ensure it's the topmost. This will slightly impact performance when there are multiple frame overlays which is rare. The next step will be to refactor FrameOverlay not to create GraphicsLayers, and to combine code paths for pre-CompositeAfterPaint and CompositeAfterPaint. Bug: 1057071 Change-Id: I0fed6e69d4a90b38b7a636712f4349e0985ff100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135891Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756413}
-
Wenyu Fu authored
NightMode is not default enabled (supported) for Kitkat testers. Set static test Boolean for NightModeUtil to avoid test errors on Kitkat. Bug: 1067575 Change-Id: I4062b97279904e08b61c568c89a421308542485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135887 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756412}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c89ca0ba09ed..b6e7ef1092b7 git log c89ca0ba09ed..b6e7ef1092b7 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 reed@google.com Use skvm infix in gradients 2020-04-03 csmartdalton@google.com Revert "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding""" 2020-04-03 csmartdalton@google.com Revert "Disable baseInstance on SwiftShader" 2020-04-03 csmartdalton@google.com Add an option to GrMeshTest to save to png 2020-04-03 mtklein@google.com remove little-used bit_clear() and bytes() 2020-04-03 csmartdalton@google.com Disable baseInstance on SwiftShader 2020-04-03 brianosman@google.com Switch back to stack-based SkSL interpreter 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms bd0abcd0646a..60d5d65325e6 (1 commits) 2020-04-03 mtklein@google.com harmonize rewrite-includes and gn-format checks 2020-04-03 hcm@google.com Update release schedule, notes 2020-04-03 reed@google.com refactor colorspacexform for skvm infix 2020-04-03 csmartdalton@google.com Merge GrVkVertexBuffer and GrVkIndexBuffer into GrVkMeshBuffer 2020-04-03 csmartdalton@google.com gn format gn/gpu.gni 2020-04-03 westont@google.com Include fetch-gn in SKQP build recipe. 2020-04-03 bsalomon@google.com Don't require color type to make proxy copies. 2020-04-03 mtklein@google.com schedule() in place 2020-04-03 bsalomon@google.com Incorporate sample count into RTC fallback color type. 2020-04-03 brianosman@google.com In 3D sample, fix the matrix used for normal transformation 2020-04-03 mtklein@google.com eliminate use of Usage in finalize 2020-04-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 745e071241ab..1cc49bb2e230 (9 commits) 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src deeb0d54..d086f1bd (467 commits) 2020-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cb58662302c8..f99302c4efe6 (7 commits) 2020-04-02 bsalomon@google.com image_from_yuv_textures GM recreates YUVA image before each draw. 2020-04-02 csmartdalton@google.com Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"" Created with: gclient setdep -r src/third_party/skia@b6e7ef1092b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I849b0b88602b09e409ed5705928b5788012d56b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135979Reviewed-by:
-
Karandeep Bhatia authored
In certain specific and rare edge cases, we might end up setting ruleset prefs for an uninstalled extension. This can happen in: - RulesMonitorService::OnRulesetLoaded: This is dispatched when the extension rulesets are loaded. We reset the ruleset checksums if the extension was re-indexed due to a schema change. - RulesMonitorService::OnDynamicRulesUpdated: This is dispatched when the dynamic rules for an extension are updated on disk. Return early in both these cases to ensure we don't incorrectly modify extension prefs for an uninstalled extension. BUG=1067441 Change-Id: Ib2d1a94265ab73871b8ae791481fe0ec25234d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131222 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756410}
-
Matt Jones authored
This patch attempts to deflake more TabsTest tests by using the new TouchCommon infra and loading new tabs via the test rule. The test was run 100 times locally without flaking. Bug: 799728 Change-Id: Ic26b9fb5c25d911d13a0a6280357c91eef32985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134652Reviewed-by:
-
Lukasz Anforowicz authored
This CL fixes a NetworkService DCHECK failure/crash that is behind the layout test flakiness under wpt/fetch/cross-origin-resource-policy as pointed out in https://crbug.com/1067445#c17. Bug: 1067445 Change-Id: I3c516a09f68a722f6dad555f6467379e7d8fe2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136028Reviewed-by:
-
Danan S authored
Also improved some comments and renamed the following to clarify their purposes: section_container -> install_permissions_section_container ParentPermissionSecton -> ParentPermissionInputSection Finally, moved install_permissions_section_container and its enclosing scroll view into the scope of the code that adds extension permissions view. This removed dead space created by the scroll view in the case there were no permissions to display. Bug: 1052097 Change-Id: I1393d732504c82d586705257f1c1b125640db5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134911 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756407}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ce5fda2fea8..e06125cb520f git log 2ce5fda2fea8..e06125cb520f --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Fix Chromium and Android build 2020-04-03 bclayton@google.com Debug: Add missing include. 2020-04-03 bclayton@google.com Vulkan/Debug: Create a PhysicalFile if DebugSource has no content 2020-04-03 bclayton@google.com Vulkan/Debug: Always provide the dap::Source::path 2020-04-03 bclayton@google.com CMake: Don't always regenerate OpenCLDebugInfo100.h 2020-04-03 amaiorano@google.com CMake: use gtest and gmock targets 2020-04-03 amaiorano@google.com CMake: split out atsc-encoder into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: clean up cppdap usage 2020-04-03 amaiorano@google.com CMake: split out Reactor into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out boost into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out libbacktrace into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out subzero and llvm-subzero into their own CMakeLists Created with: gclient setdep -r src/third_party/swiftshader@e06125cb520f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I289bb442d8d930675c4e13f885935a416ded319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135421Reviewed-by:
-
Mario Bianucci authored
Currently, if you select a text on the page, hold down middle mouse button and start scrolling in either direction and leave the button, it deselects the text. This is due to incorrect position in widget information on an event. This CL fixes the bug by correctly populating the position in widget information on an event. As a side effect of populating the correct position, clicking in an OOPIF to end autoscrolling would result in the cursor not changing back to a pointer until the mouse was moved. This is because when auto- scrolling ends, a cursor update is scheduled, but the cursor update timer is tied to user interaction, and if user interaction doesn't occur after the click, the timer doesn't fire. This used to work because the cached value previously populated in the widget resulted in hit testing not reporting a remote frame, so the cursor was updated in EventHandler::HandleMouseMoveOrLeaveEvent. With this change, hit testing reports a remote frame, so it no longer updates in the same place. Therefore, in order to ensure that the cursor is correctly updated immediately after autoscrolling, CursorUpdate is called rather than just scheduling an update. Regressing change: crrev.com/c/1773540 Bug: 1054854 Change-Id: I6b5353529ab0b73c85c1dd0e0237d3e06c848a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116134Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756405}
-
Theresa Wellington authored
BUG=980567 Change-Id: I45dfeb4ef93b1d73d3ada19f11f524baec40334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135502 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2af328044cf7..2d6db0b9fdd5 git log 2af328044cf7..2d6db0b9fdd5 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 michael.liao@microsoft.com [Applications - Clear Storage]: Fix pie chart focus 2020-04-03 leese@chromium.org Reland "Show unbound breakpoints as disabled" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2d6db0b9fdd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066374 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf1cd31097affc4a0cdae74022b0e5497fe685ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135419Reviewed-by:
-
