Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 16 Jun, 2018 8 commits
    • Miguel Casas-Sanchez's avatar
      VaJDA: a bit of a cleanup · 2c1c1bd3
      Miguel Casas-Sanchez authored 
      A couple of cleanups I stumbled upon while reading the code:
- struct DecodeRequest can be made internal.
- unique_ptr<> doesn't need to be made const& (strange pattern).
- A few consts and initializing structs with = {} (ISO memset),
 using implicit initialization [1].
- Removed unnecessary |weak_this_|.

All in all, less lines of code :-)

TBR=dcastagna@chromium.org

[1] http://en.cppreference.com/w/c/language/struct_initialization

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If1a4e781abfa7ae96b85a6d621f5c96d4effb162
Reviewed-on: https://chromium-review.googlesource.com/1100001Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567839}
      2c1c1bd3
    • Paul Miller's avatar
      WebView: Add study for variations rollout · 074de24d
      Paul Miller authored 
      With https://crrev.com/c/1050931, variations is enabled 100% in m68. We want to
keep some small percentage disabled in order to compare metrics, but can't use
variations to do so. So hard-code the random group assignment instead, and add a
UMA histogram, Android.WebView.VariationsEnableState, with the result.

The logic about whether variations is enabled is now pretty complex, but we'll
remove most of it after 100% rollout. The current variables are:

- mEnabledByCmd
    Controlled by the --enable-webview-variations switch.
- mEnabledByExperiment
    Controlled by AGSA's experiment.
- sVariationsAlwaysEnabled
    Hard-coded to true in m68, intended for easy revert in case we decided to
    completely disable variations in m68.
- sEnableState
    The newly-added tri-state: default enabled, control-group enabled, and
    experiment-group enabled.

Before this change, variations would be enabled if any 1 of the first 3
variables were true. The new sEnableState can disable variations, overriding
sVariationsAlwaysEnabled.

This means that "sVariationsAlwaysEnabled" is no longer an accurate name, since
it can be overridden, but I'm keeping it as-is to allow easy reverts.

Bug: 851045
Change-Id: I5b96d5636d1a1d2b0d662a121cd8b285cdb37a48
Reviewed-on: https://chromium-review.googlesource.com/1094139
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567838}
      074de24d
    • Joel Hockey's avatar
      FileManagerUITest reenable tests · a6177b61
      Joel Hockey authored 
      Tests had failed on asan/lsan and debug.

Fix dispatchEvent to run on event queue by calling within setTimeout.

Bug: 852788
Change-Id: I01d0013be945014bcd54f923989a02f68f6687b8
Reviewed-on: https://chromium-review.googlesource.com/1101604
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567837}
      a6177b61
    • Dmitry Gozman's avatar
      Add more tests for NavigationPolicy decisions · 13cef1e7
      Dmitry Gozman authored 
      Bug: 849055
Change-Id: If18969f45020b6dfb559c73603724854661e8508
Reviewed-on: https://chromium-review.googlesource.com/1102559
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarNate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567836}
      13cef1e7
    • Chromium WPT Sync's avatar
      Import wpt@de3ae39cb59880a8245431e7f09817a2a4dad1a3 · 07269aba
      Chromium WPT Sync authored 
      Using wpt-import in Chromium 2cfc7aa7.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
1db32e09 "OffscreenCanvas Text rendering tests"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19692

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor
bajones@chromium.org:
  external/wpt/gamepad
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
bokan@chromium.org:
  external/wpt/visual-viewport
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-cascade
  external/wpt/css/css-conditional
  external/wpt/css/css-namespaces
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
chongz@chromium.org:
  external/wpt/pointerlock
  external/wpt/touch-events
chongz@chromium.org, yosin@chromium.org:
  external/wpt/input-events
cvazac@akamai.com, igrigorik@chromium.org:
  external/wpt/server-timing
dcheng@chromium.org, scottmg@chromium.org:
  external/wpt/domparsing
  external/wpt/domxpath
dgrogan@chromium.org:
  external/wpt/css/css-tables
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
dtapuska@chromium.org:
  external/wpt/uievents
eae@chromium.org, szager@chromium.org:
  external/wpt/intersection-observer
ecobos@igalia.com:
  external/wpt/css/css-display
ericwilligers@chromium.org:
  external/wpt/css/motion
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
fmeawad@chromium.org, panicker@chromium.org:
  external/wpt/device-memory
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
garykac@chromium.org:
  external/wpt/clipboard-apis
  external/wpt/keyboard-map
garykac@chromium.org, joedow@chromium.org:
  external/wpt/keyboard-lock
guidou@chromium.org:
  external/wpt/mediacapture-streams
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline
igrigorik@chromium.org, yoav@yoav.ws:
  external/wpt/preload
jfernandez@igalia.com:
  external/wpt/css/css-align
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/encoding
  external/wpt/resources
  external/wpt/service-workers/cache-storage
  external/wpt/storage
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
  external/wpt/webstorage
kojii@chromium.org:
  external/wpt/css/css-rhythm
  external/wpt/css/css-scoping
  external/wpt/css/css-text/i18n
  external/wpt/css/css-writing-modes
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2
kozyatinskiy@chromium.org:
  external/wpt/console
kpaulhamus@chromium.org:
  external/wpt/webauthn
ksakamoto@chromium.org:
  external/wpt/resource-timing
mcasas@chromium.org:
  external/wpt/geolocation-API
  external/wpt/mediacapture-record
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/cookies
  external/wpt/mixed-content
  external/wpt/secure-contexts
  external/wpt/trusted-types
  external/wpt/upgrade-insecure-requests
  external/wpt/x-frame-options
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mkwst@chromium.org, jochen@chromium.org:
  external/wpt/subresource-integrity
mlamouri@chromium.org:
  external/wpt/mediasession
  external/wpt/remote-playback
  external/wpt/screen-orientation
msisov@igalia.com:
  external/wpt/webvtt
msramek@chromium.org, mkwst@chromium.org:
  external/wpt/clear-site-data
mstensho@chromium.org:
  external/wpt/css/css-break
  external/wpt/css/css-multicol
mtrofin@chromium.org:
  external/wpt/wasm
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
ortuno@chromium.org:
  external/wpt/bluetooth
panicker@chromium.org:
  external/wpt/longtask-timing
  external/wpt/page-visibility
  external/wpt/user-timing
panicker@chromium.org, tdresser@chromium.org:
  external/wpt/paint-timing
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
rego@igalia.com:
  external/wpt/css/css-grid
  external/wpt/css/css-ui
  external/wpt/css/selectors
rijubrata.bhaumik@intel.com, mcasas@chromium.org:
  external/wpt/html-media-capture
rmcilroy@chromium.org:
  external/wpt/requestidlecallback
rob.buis@samsung.com:
  external/wpt/quirks
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-method-basic-card
  external/wpt/payment-method-id
  external/wpt/payment-request
skobes@chromium.org:
  external/wpt/css/css-scroll-anchoring
smcgruer@chromium.org:
  external/wpt/css/css-position
tdresser@chromium.org:
  external/wpt/hr-time
  external/wpt/navigation-timing
timvolodine@chromium.org:
  external/wpt/battery-status
timvolodine@chromium.org, reillyg@chromium.org:
  external/wpt/orientation-event
worker-dev@chromium.org:
  external/wpt/workers
  external/wpt/worklets
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=lukebjerring

No-Export: true
Change-Id: I1f8e43d19bce55cefdb489172df46d8ff4cbd888
Reviewed-on: https://chromium-review.googlesource.com/1103219
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567835}
      07269aba
    • Jiaquan He's avatar
      app_list: merges chrome's AppListControllerImpl into AppListClientImpl. · 3de5a64d
      Jiaquan He authored 
      Since AppListClientImpl and AppListControllerImpl depend on each other
tightly, we can merge them. All Chrome components talk to Ash via the
AppListControllerDelegate interface, and AppListClientImpl implements
it. That's similar to the Ash AppListControllerImpl implementing
AppListViewDelegate.

This commit also merges app_list_controller_browsertest.cc with
app_list_browsertest.cc and renames those tests into AppListClient*.

Bug: 733662
Change-Id: I570d46b540d8bf23198f34e8ea8810dc3f026ab1
Reviewed-on: https://chromium-review.googlesource.com/1100554Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#567834}
      3de5a64d
    • Steven Bennetts's avatar
      OOBE: Eliminate setMDMode and md-mode · 31bc2723
      Steven Bennetts authored 
      Also eliminates references to progress-dots which were removed
with the old UI.

Bug: 647411
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie7bc4ec3c5b506c637dbffa103e74ac8f133742d
Reviewed-on: https://chromium-review.googlesource.com/1080227
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567833}
      31bc2723
    • Tommy C. Li's avatar
      Omnibox UI Refresh: Fix search favicon if no default search provider · c50826d3
      Tommy C. Li authored 
      During unit tests, or if the default search provider is disabled by
policy, there may not be any default search provider.

Previously, when we went to fetch the favicon for the search provider,
we did not account for the defaults search provider being potentially
null, and this CL  fixes that.

Bug: 852630
Change-Id: I8637c684b1df286ac06506138b86b3237190ebb6
Reviewed-on: https://chromium-review.googlesource.com/1102882
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567832}
      c50826d3
  3. 15 Jun, 2018 32 commits