GitLab

This file references a file that doesn't even exist, so removing the
file.

Change-Id: I54ed1eae783a139ef14d495d41c4a6137d1f622e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522128
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#824932}

Also fixes string with "\n" as part of it.

Bug: 1138717
Change-Id: Id87562a1d2896d8cacceac5a3c95af8d7713e91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521295Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824931}

We clear the clipboard when entering LockedFullscreen.
LockedFullscreen is a state entered to start a secure test or poll.

We clear the clipboard in these cases to prevent cheating,
so it also makes sense to clear ClipboardHistory.

In the future we would like to create a new ClipboardHistory and
restore the old one  after leaving LockedFullscreen, but for now we
will just clear ClipboardHistory.

Bug: 1145651
Change-Id: Id5583567375384f2b2bc877f77acf6c054825977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521230
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#824930}

https://android.googlesource.com/platform/external/perfetto.git/+log/d57e268ce139..1e9cf1a8e1bd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I9893d05b5d7fec18020756150bae54fcc637450f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523055Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824929}

Change-Id: If3ed612970f6d576a30fd4a0cf783e7715d6d59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521939Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824928}

Required to support
https://chromium-review.googlesource.com/c/chromium/src/+/2510736

R=mpdenton@chromium.org

Test: on patched .so, and patched build of Chrome without any further modification, and a standard .so build using chromiumos toolchain, verify tts service works on arm32.
Change-Id: Idfefa22d2819ce819f3a265f4fa3e7169e6697ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518729
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Auto-Submit: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824927}

There are a series of messages that are sent to the LocalMainFrame
of the webview. This maps SetBackgroundColor onto one of those messages.
Other targeted messages will be converted in followup CLs.

BUG=993189

Change-Id: I221d0c9be378c731d0bb3a11e508bda8ba0dc849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518798
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824926}

This CL adds the ability for the subresource filter to index and
publish the ruleset from unindexed ruleset data stored as a resource in
the resource bundle. This functionality paves the way for WebLayer's
upcoming packaging of the in-repo unindexed ruleset data in the
resource bundle.

We also add a unittest of the new functionality. To facilitate adding
the unittest, we add the ability to mock out LoadDataResourceString()
to ui::ResourceBundle::Delegate and ui::MockResourceBundleDelegate.

TBR=spang@chromium.org

Bug: 1116095
Change-Id: Idb2c1b85465ab97e787c8191070f00acd571fadb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516519
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824925}

Updates imports in android_webview/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: Idaa01b0e842f4fa9ada7a2106764db0ac37e4463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518890
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824924}

Overrides button outline color to white as requested by UX. Currently
the outline is black under dark mode.

Bug: 1146259
Change-Id: I9d5a04bca5f094282b9e51d5f17aae08486b2b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522226Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824923}

Also add the marshmallow config & builder to the table,
and the doc for `--debug-tags` option

Change-Id: Ife316d632342025899faf4b921f83b9d009ed32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523358Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#824922}

This TODO was added to address cases where the web contents is destroyed
before explicitly closing the window. However, enforcing this would
violate encapsulation, e.g. the Java bottomsheet code shouldn't need
to worry about this nuance. See comment 20 on the bug for more detail.

Bug: 1099270
Change-Id: I66cc6fcbeefbdf16a9c9c6a1aa598ce0eb3f1b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521779Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824921}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d38e0064..5bce781f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I335561ec1b2d894b38f7cc14e3688eac87985e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523236Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824920}

Bug: 993189
Change-Id: I709dd4bf32e24e712efbaff8a5431f2297d05ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517922
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824919}

This reverts commit b944e5d8.

Reason for revert: Still failing

Original change's description:
> [Android] Remove force promo state update in BookmarkPromoRender tests
>
> Updating the promo state forcefully is not required for these tests.
> This cl does not change the behavior of the tests. It changes how the
> environment is set up.
>
> This cl also enables testPersonalizedSigninPromoInBookmarkPage test.
>
> Bug: 1123478, 1133426
> Change-Id: I4382f857ca1e91676404fce1a1c6e76c315e4493
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517684
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824830}

TBR=treib@chromium.org,triploblastic@chromium.org

Change-Id: I7100fb19e156f700ee1ec84149904287fd41aec1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1123478
Bug: 1133426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523360Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824918}

https://webrtc.googlesource.com/src.git/+log/42cafa5696f5..9c99b7964fab

2020-11-06 danilchap@webrtc.org Use SvcRateAllocator for av1
2020-11-05 steveanton@webrtc.org Add publicly visible mock for RtpTransceiverInterface
2020-11-05 steveanton@webrtc.org Add publicly visible mocks for AudioSourceInterface and AudioTrackInterface
2020-11-05 steveanton@webrtc.org Add publicly visible mock for DataChannelInterface
2020-11-05 roman.gaiu@ringcentral.com Add Presentation Mode Support for Capturing OpenOffice Impress document windows
2020-11-05 danilchap@webrtc.org Move SvcRateAllocator out of codecs/vp9 and make it not vp9 specific
2020-11-05 mbonadei@webrtc.org Fix -Wrange-loop-analysis.
2020-11-05 terelius@webrtc.org Add kill-switch to RTC event log factory.
2020-11-05 mbonadei@webrtc.org Add new try builder configs to mb_config.pyl.
2020-11-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fbd658a9..3f3e178f (824119:824219)
2020-11-04 mbonadei@webrtc.org Add new CI builder configs to mb_config.pyl.
2020-11-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0526cc47..fbd658a9 (823879:824119)
2020-11-04 natim@webrtc.org Enable continuous audio polling from ADM after StopPlay in VoIP API
2020-11-04 philipel@webrtc.org Remove remaining variables related to incomplete frames.
2020-11-04 nisse@webrtc.org Delete class RWLockWrapper, and its build target.
2020-11-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2357c735..0526cc47 (822514:823879)
2020-11-04 hta@webrtc.org Move "options" from ConnectionContext to PeerConnectionFactory
2020-11-04 philipp.hancke@googlemail.com uma_metrics: clean up and follow histogram recommendations
2020-11-04 nisse@webrtc.org Replace RWLockWrapper --> Mutex in DeviceInfoImpl
2020-11-04 alessiob@webrtc.org APM RuntimeSetting: record bool histogram when enqueuing a setting fails
2020-11-04 hta@webrtc.org tls_cert_verifier_ is now const and only network thread accessed
2020-11-04 ivoc@webrtc.org Initialize variables to measure preemptive expansion and acceleration
2020-11-04 nisse@webrtc.org Delete use of RWLockWrapper from SimulatedClock
2020-11-04 minyue@webrtc.org Revert "opus: take SILK vad result into account for voice detection"
2020-11-03 jakobi@webrtc.org Remove simulated neteq packet loss plot.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1140376
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I05844aa501fb606d19a0b2c047dc40c93ff9403a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824917}

https://swiftshader.googlesource.com/SwiftShader.git/+log/612ded0654a0..e8b6cf636df1

2020-11-06 jaebaek@google.com SpirvShaderDebugger: Correct member index for DebugValue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I902bced7c3895a588ef7c66acc31efec8699293d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523289Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824916}

TBR=govind@chromium.org

Change-Id: Ieca63e7dc3d3562ede6bad6cce3c9598fe519dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522893Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824915}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/db4f0a699e04..2cfcb1c1ee9a

2020-11-06 petermarshall@chromium.org [surveys] Add the UI for showing a survey link in IssueView
2020-11-06 tvanderlippe@chromium.org Add copy stacktrace contextmenu option for network initiator
2020-11-06 yiorsi@gmail.com Fix that the previous text will be selected when double-clicking the angle icon
2020-11-06 aerotwist@chromium.org [unit test] Add AccessibilityModel instantiation test
2020-11-06 aerotwist@chromium.org [unit test] Update runtime & env helpers
2020-11-06 alexrudenko@chromium.org Add icons for align-content and remove icons for start/end for now

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1112738,chromium:1139945,chromium:1146401
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I2669aac8b3dfcd4082af88d2b52e1de5d88ac5e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523353Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824914}

- The output doesn't seem useful. When data is missing the tool
segfaults rather than printing a message.

Bug: 1122182
Change-Id: I46842793e831b02d169f8d3acc4fa82de3f77951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521846
Commit-Queue: Nelson Billing <nbilling@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824913}

TBR=fernandex@chromium.org

Bug: 1146459
Change-Id: I4b8163481ee473e049cb54504698dc08fbc5a466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521707Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824912}

This CL add a feature flag kFullscreenAlertBubble to the feature
of Fullscreen Alert Bubble.

Bug: 1107185
Change-Id: I76c3ef33df6056f7a33f0a23294ce2ef169a2326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520323Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824911}

In preparation of moving all IDR_WEBUI_JS_* resources to
webui_generated_resources.h, a new header file needs to be
included in several places.

Bug: 1132403
Change-Id: Ibbdccde4177e916b63c736b98378576b930c2173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521931
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824910}

This allows chips to show a popup menu when tapped, instead of directly
invoking their callback. For now, this is only intended for trigger
scripts, specifically for the cancel popup.

A screenshot of the popup is in the linked bug.

Bug: b/172585820
Change-Id: Id32c529b7f32a11b2aaef18a9391e708795be38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521188
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Luca Hunkeler <hluca@google.com>
Cr-Commit-Position: refs/heads/master@{#824909}

The compiler cannot handle a type name the same as the a type name
from an outer scope and leads to errors like the following one:

GCC(8.4.0) says

error: declaration of ‘using AcceptedVote = class performance_manager::
    voting::AcceptedVote<VoteImpl>’ [-fpermissive]
using AcceptedVote = AcceptedVote<VoteImpl>;
error: changes meaning of ‘AcceptedVote’ from ‘class performance_manager::
    voting::AcceptedVote<VoteImpl>’ [-fpermissive]
class AcceptedVote;

Bug: 819294
Change-Id: If344be8eff75cb9c5ca99b814f589595ed3c8bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523201Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824908}

In older checkouts, the .javac.jar is in gen/ rather than obj/

Change-Id: I1a149fd02e463b1fabd2be87e584bb0f9c759c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518700Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824907}

Implements constants, trace member function, and member
variable definitions.

Bug: 839389
Change-Id: I53d3bbeace3bdd80f7bb4734d12e40dfc56bc252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512324
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824906}

Bug: 1136043
Change-Id: I2caa0b769cc08dd071d55336ca9202548f0dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521705
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824905}

https://chromium.googlesource.com/angle/angle.git/+log/0781b693fa2d..49d9785e4224

2020-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c2b2b5788575 to a61d07a72763 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ia25ed3e6ac64e844017f43e56e33e25e9c2d0dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521209Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824904}

In r824597 we have landed the new behavior of the NGLineBreaker class to
deal with trailing ideographic spaces, according to the last changes in
the CSS Text 3 specification.

These spaces are defined in the spec as 'other space separator' [1] and
as such, they should not be considered 'collapsible spaces' [2]. This
fact has some implications in the implementation of the Phase I [3] of
the White Space Processing algorithm.

Additionally, this CL implements also the required logic in the
BreakingContext class to deal with this kind of trailing spaces,
according to the value of the 'white-space' [4] CSS property. When its
allowed, these trailing spaces will be hang or even broken (in case of
break-space value), instead of selecting previous breaking opportunities
to avoid overflow, like it's described in the bug.

It's worth mentioning that even though this CL is about hanging trailing
spaces, we need to apply some changes in the TextBreakIterator. These
changes are needed to avoid ideographic spaces to be handled by ICU. The
problem is that ICU, following the UAX14 spec where ideographic spaces
are classified as BA, will return breaking opportunities 'after' the
trailing spaces character sequence. However, due to some performance
optimizations, we have decided to implement the BreakingContext logic
assuming that we always break before space (kBeforeEverySpace).

We have landed a patch in r807457 with an important refactoring to sync
TextBreakIterator behavior on the white-space handling with ICU, so that
we always break 'before space'. However, this change affects only to the
LayoutNG inline-layout logic, which was adapted accordingly to the new
behavior.

We have decided to avoid this approach for Legacy layout, since a big
refactoring like this could imply important regressions, difficult to
track and fix nowadays. The changes in the TextBreakIterator performed
by this CL try to handle ideographic spaces as if they were regular
white space character, avoiding ICU. The specific hanging behavior will
be implemented then by the BreakingContext class, assuming the old
'break before space' behavior.


[1] https://drafts.csswg.org/css-text-3/#other-space-separators
[2] https://drafts.csswg.org/css-text-3/#collapsible-white-space
[3] https://drafts.csswg.org/css-text-3/#white-space-phase-1
[4] https://drafts.csswg.org/css-text-3/#white-space-property

Bug: 972952
Change-Id: Ibc5a9d4c0b420320ef03f2a088685775b0034ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521614Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#824903}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d6242c0dc2d..639610df4433

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tinazwang@google.com,clamy@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: tinazwang@google.com,clamy@google.com
Change-Id: I7711e579b873b0576d3e6800863351d5eb1bcf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522648Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824902}

This is a reland of 6b7290b3

Compared to the original CL, the reland sticks more to the previous
behavior of AvatarMenu::GetImageForMenuButton(), it does not download
high res avatar. The only change in behavior is on Windows where it uses
2x built-in avatars instead of 1x avatars which is beneficial for the
large taskbar of Win10.

Original change's description:
> [Profiles] Use new colored default avatars for taskbar badges
>
> Recently, all logic around profile avatars has been integrated into
> ProfileAttributesEntry::GetAvatarIcon() incl. new features such as
> colored default avatars.
>
> This CL updates code that generates taskbar badges on Windows to
> delegate most of its logic to GetAvatarIcon(). Only the pieces needed
> for obtaining ImageLoadStatus remained in this code.
>
> The only behavioral change is for non-GAIA avatars: high-res /
> 2x windows old avatars are returned instead of low-res avatars. This
> means more downscaling is needed than before. This will be addressed
> by further CLs that will make GetAvatarIcon() respect preferred_size in
> more cases.
>
> Bug: 1122559
> Change-Id: I5eecc7c6647dc78f9ff92d74edb64214a48e8e63
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514153
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Auto-Submit: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824494}

Bug: 1122559
Change-Id: I5814c801165fde00bb20694561e5b94db0e12cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521735
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824901}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I01e0cb646b86a219deefb4751a4218672c5e8604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824900}

TBR=aboxhall@chromium.org

Bug: 1141280
Change-Id: I4682a0ed73e14bc8243bb57326334d0db752fa4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518625Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824899}

fx_logger_log_with_source() takes file and line as parameters
and lets the syslog library handle them.

Change-Id: I15b3b7948e8ad48781ac36afa6fa9df2145da5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521365
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824898}

Add the missing comment in
chromeos/components/telemetry_extension_ui/mojom/diagnostics_service.mojom.

This is to make the RunBatteryHealthRoutine() method documentation
consistent with
chromeos/services/cros_healthd/public/mojom/cros_healthd.mojom.

Bug: b:171327161
Change-Id: I49ee24348138b7505ede83d900c9f48d1d238fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523191Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#824897}

Bug: 1007807
Change-Id: I8c78ba00cd743dd62d8b96d853cf9a352239d911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520800Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824896}

Tests that tapping on "Close All" shows a confirmation dialog.
It also tests that tapping on "Close x Tab(s)" on the confirmation
dialog displays an empty grid and tapping on "Cancel" doesn't modify
the grid.

Bug: 1119319, 1124309
Change-Id: I65a8a70a867efe3643ebfde1c59f3fb186177c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450317
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824895}

This reverts commit b430ce77.

Reason for revert: This change causes linker errors in absl.dll on my Windows 10 workstation.

This was tested by checking out the CL before this one and confirming that the build completes successfully, then checking out this CL and confirming that it errors.

Please see the full error at the bottom of this description.

Original change's description:
> Generate absl .def file at build time.
>
> Instead of generating absl .def files at roll time, this CL switches
> the build config to generate the required .def file on the fly while
> building.
>
> The advantages are:
>
> 1. No need to re-generate .def files when something external to absl
> changes and affects .def files (e.g. when a new compiler optimization
> it enabled).
> 2. No need to hard-code supported build flavors in the .def generator
> script, resulting in multiple .def files checked-in.
>
> On the other hand, this makes the build slightly slower than it
> is today because reading all absl object files to generate the
> .def file can take a few seconds.
>
> Bug: 1046390
> Change-Id: If3a8fb3dca0ed75dbd85655cff1263853dcc146a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270094
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824844}

---
Full error:
PS C:\src\chromium\src> autoninja -C out/bug absl.dll
"C:\src\depot_tools\ninja.exe" -C out/bug absl.dll -j 1000 
ninja: Entering directory `out/bug'
[1/1] Regenerating ninja files
[3/3] LINK(DLL) absl.dll absl.dll.lib absl.dll.pdb
FAILED: absl.dll absl.dll.lib absl.dll.pdb
ninja -t msvc -e environment.x64 -- ..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /nologo -libpath:..\..\third_party\llvm-build\Release+Asserts\lib\clang\12.0.0\lib\windows -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\lib\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\um\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\Lib\10.0.19041.0\ucrt\x64 -libpath:..\..\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\VC\Tools\MSVC\14.26.28801\atlmfc\lib\x64 /IMPLIB:./absl.dll.lib /DLL /OUT:./absl.dll /PDB:./absl.dll.pdb @./absl.dll.rsp
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, 
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::unique_ptr<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct 
std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><1, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *>::__tuple_impl<struct std::__1::__tuple_indices<0>, struct absl::synchronization_internal::ThreadData *><0, struct absl::synchronization_internal::ThreadData *, struct absl::synchronization_internal::ThreadData *>(struct std::__1::__tuple_indices<0>, struct std::__1::__tuple_types<struct absl::synchronization_internal::ThreadData *>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>::__tuple_impl<struct std::__1::__tuple_indices<0, 1>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>><0, 
1, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, 
class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>(struct std::__1::__tuple_indices<0, 1>, struct std::__1::__tuple_types<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>> &&, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::__tuple_impl<struct std::__1::__tuple_indices<0, 1, 2>, class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><0, 1, 2, class absl::string_view, 
class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int, char const (&)[2], char const (&)[2], int>(struct std::__1::__tuple_indices<0, 1, 2>, struct std::__1::__tuple_types<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>, struct std::__1::__tuple_indices<>, struct std::__1::__tuple_types<>, char const (&)[2], char const (&)[2], int &&)        
lld-link: error: <root>: undefined symbol: public: __cdecl absl::AlphaNum::AlphaNum<16>(struct absl::strings_internal::AlphaNumBuffer<16> const &)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::thread::thread<void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&, void>(void (__cdecl &)(int, class absl::base_internal::SpinLock *), int &, class absl::base_internal::SpinLock *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__bind<void 
(__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *><void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *, void>(void (__cdecl &)(struct 
absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *&&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>>::__compressed_pair<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, struct std::__1::default_delete<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>>>><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, 1>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0>::__compressed_pair_elem<class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *, 0, 0><class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, 
struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&, void>(class std::__1::tuple<class std::__1::unique_ptr<class std::__1::__thread_struct, struct std::__1::default_delete<class std::__1::__thread_struct>>, class std::__1::__bind<void (__cdecl &)(struct absl::synchronization_internal::ThreadData *), struct absl::synchronization_internal::ThreadData *>> *&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::tuple<class 
absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int>::tuple<class absl::string_view, class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, int><char const (&)[2], char const (&)[2], int, 0, 0>(char const (&)[2], char const (&)[2], int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::__tuple_leaf<0, class absl::string_view, 0>::__tuple_leaf<0, class absl::string_view, 0><char const (&)[2], void>(char const (&)[2])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[5], char const (&)[4], 0>(char const (&)[5], char const (&)[4])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[6], char const (&)[7], 0>(char const (&)[6], char const (&)[7])
lld-link: error: <root>: undefined symbol: public: __cdecl std::__1::pair<class absl::string_view, class absl::string_view>::pair<class absl::string_view, class absl::string_view><char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>>, 0>(char const (&)[7], class std::__1::basic_string<char, struct std::__1::char_traits<char>, class std::__1::allocator<char>> &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int const>::optional<int const><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int volatile>::optional<int volatile><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: public: __cdecl absl::optional<int>::optional<int><int, 0>(int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int const, 1>::optional_data_dtor_base<int const, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int volatile, 1>::optional_data_dtor_base<int volatile, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: <root>: undefined symbol: protected: __cdecl absl::optional_internal::optional_data_dtor_base<int, 1>::optional_data_dtor_base<int, 1><int>(struct absl::in_place_t, int &&)
lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see 
all errors)
ninja: build stopped: subcommand failed.
---

TBR=brucedawson@chromium.org,mbonadei@chromium.org

Change-Id: Iaf681079a2c786a7e694538b9fddc68d96dd1a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523240Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#824894}

Dependency/include graph:

- frame_utils.h is included by frame_header.cc;
- frame_header.h is included by default_frame_header.h
- browser_non_client_frame_view_ash.cc includes default_frame_header.h.

So, in order to free browser_non_client_frame_view_ash.cc|h from
including //ash/ headers the items above will migrate step by step
to //chromeos/ui.

BUG=1113900
R=jamescook@chromium.org, sky@chromium.org

Change-Id: I573a053321b82825d80554c1a3c44079bf6d2a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521364
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824893}