- 05 Dec, 2017 40 commits
-
-
erikchen authored
This CL adds two histograms: * OutOfProcessHeapProfiling.UploadTrace.Size is emitted on each trace upload, and reflects the uncompressed size of the trace. * OutOfProcessHeapProfiling.RecordTrace.Success is recorded after each attempt to record a trace, and reflects whether a trace was successfully recorded. This CL makes two other small changes: * Increase the timeout for waiting for a trace to 30 seconds from 10 seconds. * Update the OutOfProcessHeapProfilingMode enum to reflect new profiling modes. Bug: Change-Id: I303349b8a61dd2d5e3d25930f8e4c59cac109795 Reviewed-on: https://chromium-review.googlesource.com/806325 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521600}
-
Donn Denman authored
Updates the flag for Chrome Smart Selection on Android to default enabled. BUG=770767 Change-Id: I39db673c4e37aa7919f5fd3edf4ee4e8a1f0d104 Reviewed-on: https://chromium-review.googlesource.com/807325Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521599}
-
Hiroshige Hayashizaki authored
Previously, Document::EnforceSandboxFlags() - Calls ApplySandboxFlags(), - Detects indirectly whether a new unique origin is set in ApplySandboxFlags(), and - Modifies Document's SecurityOrigin that is the new unique origin that was just set. This CL moves the modification to the new unique origin into ApplySandboxFlags(), before setting the origin to SecurityContext. |is_potentially_trustworthy| is plumbed to do this. No behavior changes are expected. Bug: 779730 Change-Id: Ia62a35c81bd4130e7a8119cc93e17c6b527f5e12 Reviewed-on: https://chromium-review.googlesource.com/762337Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521598}
-
dpapad authored
Bug: 787229 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I173e9c72b269c69a18f9c7909cfc60a0158f4707 Reviewed-on: https://chromium-review.googlesource.com/806930Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521597}
-
Alexander Timin authored
Rename FrameType which is used for reporting to FrameStatus. This removed unfortunate collision between said FrameType and WebFrameScheduler::FrameType which is used to distinguish main frame and subframes. This patch also moves FrameStatus from renderer_metrics_helper to a separate header. This is done to use FrameStatus in ResourceLoadScheduler for per-frame network metrics. The histograms are not changed and still have PerFrameType in their names. R=npm@chromium.org Bug: Change-Id: I1bca2f0ba556969da1fe33093b5b43dd3c8f16e0 Reviewed-on: https://chromium-review.googlesource.com/801674 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521596}
-
Emma Haruka Iwao authored
This patch adds updateViaCache to ServiceWorkerRegistrationOptions struct in mojom and ServiceWorkerContext. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RwjXGTAbuuA/7Q3NPlJ4BAAJ Split from the original patch: https://chromium-review.googlesource.com/c/chromium/src/+/618076 Bug: 675540 Change-Id: I199357745605ebf43a82adfd30b2fbfd5e18e4b4 Reviewed-on: https://chromium-review.googlesource.com/792810Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521595}
-
Joel Einbinder authored
This should make the color picker much faster Bug: none Change-Id: I487616d71e430cb6c8374473bc1d84d7810f10cf Reviewed-on: https://chromium-review.googlesource.com/807545 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521594}
-
Kurt Horimoto authored
Although this is only used by the new architecture, it is model code built on top of BrowserCoordinator, which also lives in ios/chrome. This CL also renames the test_helpers/ directory to test/ to match other cases in ios/chrome. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9b731c0805b36feb9cbced4688cb9899ac129ca8 Reviewed-on: https://chromium-review.googlesource.com/648076 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521593}
-
Devlin Cronin authored
JS can be suspended when the renderer receives the IPC to dispatch an event. In this case, the JS shouldn't immediately run, but rather respect the JS state. Currently, the EventEmitter does this by using JSRunner::RunJSFunction() (which does respect JS suspension) with each of the listeners for the event. This mostly works, but has a couple of problems. For one, it makes it difficult to catch exceptions thrown from a JS listener (since the listener isn't notified when we queue it up through the JSRunner). It also doesn't account for the possibility of listeners being removed between a event comes in, and when it is actually disptached. Finally, it makes creating a single result for the dispatch difficult, which is problematic for messaging bindings. Rework the way event dispatching works to instead use a v8::Function wrapper around the EventEmitter to trigger the event being dispatched to listeners. Once that function is triggered, it's safe to use synchronous JS execution, since JS is already running at that point. This addresses the concerns with the current approach. Also add a Suspension utility to the TestJSRunner to simulate JS being suspended in testing, and add unit tests for dispatching events while JS is suspended. Bug: 653596 Change-Id: I7899e1946e8fe750fa2a1f53d62a04e5bd075664 Reviewed-on: https://chromium-review.googlesource.com/792033 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521592}
-
edchin authored
A method (-controllerForUnhandledContent:) was in CRWWebDelegate when it belongs in CRWNativeContentProvider protocol. This helped pull the implementation out of tab.mm and into the BVC, which can provide a base view controller for presenting UI, instead of using rootViewController for presentation. Bug: 791206 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If82dcb4f16a64d5e1fef99e2805588e92f2ca4d9 Reviewed-on: https://chromium-review.googlesource.com/807306 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521591}
-
Tom Anderson authored
BUG=790683 TBR=creis@chromium.org Change-Id: I9ba4317841f6487795f1fb0676c9dde09f6fe500 Reviewed-on: https://chromium-review.googlesource.com/801264 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521590}
-
John Abd-El-Malek authored
Bug: 783981 Change-Id: I41afc98d8c9d60051cde53f3d17c28515ec9a8aa Reviewed-on: https://chromium-review.googlesource.com/807403Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521589}
-
Emil A Eklund authored
Change FontPlatformData::FontFamilyName to parse the font family name as UTF-8 instead of latin-1 as that is the encoding of the localized family name provided by the API. Verified on Linux, Windows 7/10, and Mac OS X. No test as I was unable to find a font with a localized non-latin family name under a suitable license. Bug: 667154 Change-Id: Iddb7932b68681824062cc2a7bf163459fc356cbb Reviewed-on: https://chromium-review.googlesource.com/807527Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#521588}
-
Alexey Kozyatinskiy authored
Without this CL we show only first line, sometimes other lines are important as well (see attached bug). With this CL we show message until first call frame. R=lushnikov@chromium.org Bug: chromium:780816 Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2 Reviewed-on: https://chromium-review.googlesource.com/802076Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521587}
-
Chris Harrelson authored
Full-width offscreen tiles become increasingly expensive on larger displays. Bug: 768799 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibb2423c6dc956a7ad81a85d12aefd9d58ee28872 Reviewed-on: https://chromium-review.googlesource.com/806994Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521586}
-
Robert Sesek authored
Bug: 598854, 626802 Change-Id: I89e8afa29d884a63b6db68b9618d87ea5863432c Reviewed-on: https://chromium-review.googlesource.com/807169 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521585}
-
Ovidio Henriquez authored
This change updates the gc-detach.html and detach-gc.html tests to use promise_test as opposed to async_test. This will help us migrate the tests to the wpt/ directory, since we use a wrapper around promise_test to dynamically load Chromium-specific modules. This change also updates gc-detach.html and detach-gc.html to use health-thermometer-iframe.html in order to use getHealthThermometerDevice rather than setBluetoothFakeAdapter. As a result, health-thermometer-iframe.html now contains a "RequestAndConnect" message case, and bluetooth-helpers.js does not rely on the "Ready" message from the health-thermometer-iframe.html anymore. Additionally, bluetooth-helpers.js now contains a function called setUpConnectableHealthThermometerDevice that sets up a fake_peripheral without requesting the device for tests that require the device to be requested outside of the main frame. BUG=769412 Change-Id: I310fd68569fb646e9e4e2ffde202b8f953a47e9b Reviewed-on: https://chromium-review.googlesource.com/777339 Commit-Queue: Ovidio Henriquez <odejesush@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#521584}
-
Pavel Yatsuk authored
SingleClientSessionsSyncTest.CookieJarMismatch test is flaky. It fails on the step when signed in account gets included in the list of accounts in cookie jar. In this case value of cookie_jar_mismatch should turn to false. I wasn't able to reproduce this bug, nor I was able to find scenario how this test could fail. I'm adding a check that ensures correct value of cookie_jar_mismatch is passed to sync engine. The next time this test fails it will be clear if failure caused by incorrect value or the value wasn't delivered to the server. R=pnoland@chromium.org BUG=789129 Change-Id: I508e5d37083e98b2c02e1bf3a35917dad3a9645f Reviewed-on: https://chromium-review.googlesource.com/804556 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#521583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7be49f33. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6909 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ibc166887ab9305cefdb751ea3855aaf3a0578828 Reviewed-on: https://chromium-review.googlesource.com/806366 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521582}
-
Rintaro Kuroiwa authored
- Instead set and remove keys one by one. Bug: 785563 Change-Id: Ib67694a5e38f927a9bb10477b359101c72b799e0 Reviewed-on: https://chromium-review.googlesource.com/804642 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521581}
-
Blake O'Hare authored
OnKeyboardBoundsChanging is being split into several more specific methods that have a stronger contract of how they are being used by the implementer. More information about why this is being done is in the associated bug. OnKeyboardWorkspaceOccludedBoundChanging is called when the keyboard's bounds change in a way that makes certain regions of the workspace unusable, as far as workspace layout is concerned. When the keyboard's bounds change in a way that is purely visual or the keyboard is in a mode where it shouldn't affect workspace layout (such as a floating keyboard), this method will not be called. Bug: 786290 Change-Id: I4237be051b1a4bb3cf6eeff5598079205b4e1292 Reviewed-on: https://chromium-review.googlesource.com/804626Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521580}
-
Jay Civelli authored
SafeXmlParser would DCHECK with CData containing non UTF8 strings. Now validating that the text is valid UTF8 and failing gracefully if it's not. Bug: 789832 Change-Id: I6cae6d1fad4297563627d2168c726160095be0d0 Reviewed-on: https://chromium-review.googlesource.com/805001 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#521579}
-
Thomas Guilbert authored
Currently, MediaSource and RemotingMediaSource have no common ancestor. This makes code reuse between CastMediaRouteProvider and RemotingMediaRouteProvider difficult. This CL renames MediaSource into CastMediaSource, adds a MediaSource interface, and updates RemotingMediaSource and CastMediaSources to both derive from this interface. This paves the way for the introduction of a BaseMediaRouteProvider. Bug: 790766 Change-Id: I3f8e46816a1e9f8f2f617a43b1099c8614204efc Reviewed-on: https://chromium-review.googlesource.com/783836 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521578}
-
Bruce Dawson authored
message_compiler.py checks to make sure its results match those generated by mc.exe, but these checks are only valid for a given version of mc.exe, because the output changes with every new Windows 10 SDK version. The checking is disabled for SDK versions other than 10.0.15063 but only for .man files. This change extends the disabling of checking for .mc files also, due to observed failures. Bug: 774669 Change-Id: I618f68d8926b73621192e7933aea5d264fedd214 Reviewed-on: https://chromium-review.googlesource.com/807205Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521577}
-
Aleks Totic authored
Part 2 of inline containing block patch. Stores inline-cb on NGOutOfFlowPositionedDescendant Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib3ed1dfe654f691f38a2ee0069177bc78fca51ce Reviewed-on: https://chromium-review.googlesource.com/804994 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521576}
-
Ken MacKay authored
Bug: Change-Id: I0c44d05c6b2c94f849621fb6d9073ad4d1faba62 Reviewed-on: https://chromium-review.googlesource.com/807587Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521575}
-
Shanmuga Pandi M authored
As per the spec[1], Constructing CSSURLImageValue should throw an error, if the URL is invalid. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssurlimagevalue-cssurlimagevalue Bug: 791434 Change-Id: I06ae5dad378ca91ce827f64ff56498a06c9963af Reviewed-on: https://chromium-review.googlesource.com/805635Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521574}
-
Theresa Wellington authored
BUG=778736 Change-Id: I44217534a8aba3c07d113b687c4065864d6303c0 Reviewed-on: https://chromium-review.googlesource.com/806978Reviewed-by:
-
Theresa Wellington authored
Start closing the bottom sheet before clearing URL focus on backpress to prevent "Search or type URL" from temporarily showing while the bottom sheet is closing. BUG=789775 Change-Id: I79bc1013b5dc91cc4ff94a8df86a7df7996b2d69 Reviewed-on: https://chromium-review.googlesource.com/807345Reviewed-by:
-
Emircan Uysaler authored
This CL adds a fallback for reading canvas content when async callback returns false. It looks like this ReadbackTextureAsync() is not supported for certain Intel CrOS devices, see below bug for more details. Bug: 788386 Change-Id: I691ce745b2703af8dab25b5c703427fe7b9b6f73 Reviewed-on: https://chromium-review.googlesource.com/804831 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521571}
-
Zhongyi Shi authored
Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iebb15655a503c33d674b1a1cb636ea788ffdecde Reviewed-on: https://chromium-review.googlesource.com/803632Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521570}
-
khmel authored
This fixes the issue when Linux implementation of the assigning app icon for the window does not request image representation and as result icon is not loaded. Bug: 779463 Test: Manually Change-Id: I33ac3733ad1a428c6a448bc3845d2589ff640d09 Reviewed-on: https://chromium-review.googlesource.com/807398Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#521569}
-
Tom Sepez authored
As the syscall_broker process becomes more capable, it is important not to expose all the new capabilities to old clients which do no require them. Introduce a set of flags to track allowed commands. Rename broker_common.{cc,h} to broker_command.{cc,h} since all the contents are related to commands issued to the broker. Consolidate client/host side checks in this new file. Parameterize some tests so we cover both client/host denials. Tidy, brace initialize some vectors for readability. Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.linux:linux_mojo Change-Id: I1ca23543f54e3eb5445bd476c24cf4a1bed06c37 Reviewed-on: https://chromium-review.googlesource.com/801936 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521568}
-
Yuwei Huang authored
This CL adds a blur view to the HostView when the app becomes inactive (transitioning to background, etc.) and removes it when the app becomes active again. Screenshot: https://drive.google.com/open?id=1UrWMUc-j0rRS-DQJ5zLLZ4_dTGgLohVr Bug: 791112 Change-Id: Ic66c57c939bb607ad7b740cb8112bd449cd20d45 Reviewed-on: https://chromium-review.googlesource.com/807402 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#521567}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/60b1b6e76e98..06ab3836f779 $ git log 60b1b6e76..06ab3836f --date=short --no-merges --format='%ad %ae %s' 2017-12-04 bsalomon Restore ability to dump SKSL in addition to GLSL 2017-12-04 kjlubick Add release_version as dimension for ChromeOS tasks 2017-12-04 reed add util to compare images 2017-12-04 csmartdalton Fix ANGLE build with extended clang warnings Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I266fb711815ff9e0be1d3414106e01913a345faf Reviewed-on: https://chromium-review.googlesource.com/807308Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521566}
-
Jay Civelli authored
If a test produced non valid UTF8 characters, the test runner would fail as it would provide invalid UTF8 to the JSON python library. We now sanitize the output. Bug: 791794 Change-Id: I635d1dbb9fdf2601112bed2953cae0e2c7e9ae92 Reviewed-on: https://chromium-review.googlesource.com/807386Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521565}
-
Ojan Vafai authored
This reverts commit 52dda118. Reason for revert: Broke compile on linux. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/54249 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/80407 https://uberchromegw.corp.google.com/i/chromium.gpu/builders/GPU%20Mac%20Builder/builds/108044 Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277,777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: I437f1c196351de49b83941a905a17a7add698abc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277, 777650 Reviewed-on: https://chromium-review.googlesource.com/807589Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521564}
-
Jay Civelli authored
Made RemovableStorageWriter a chrome service and changed ImageWriterUtilityClient to use the service instead of UtilityProcessMojoClient, which is being deprecated. ImageWriterUtilityClient now requires a service_manager::Connector when created. As a result, extensions::image_writer::Operation which creates an ImageWriterUtilityClient and all its derived classes now also take a connector. This patch was tested manually on Windows and Mac by using the Chrome OS recovery tool [1] and writing a recovery image on a USB stick. [1] http://bit.ly/2jFtsZZ Bug: 790024 Change-Id: Ie31c123e189ccd0134f9fc63a5dd7238011bebca Reviewed-on: https://chromium-review.googlesource.com/786257Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521563}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b278ddd93923..873be6fd45b7 $ git log b278ddd93..873be6fd4 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 agable Update depot_tools bleeding-edge win git to 2.15.1.2 Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I5ef3cdf1f7fc5dbc1a387cb1346095e6e80a7b62 Reviewed-on: https://chromium-review.googlesource.com/806649Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521562}
-
Thomas Anderson authored
This reverts commit 52dda118. Reason for revert: Breaks Linux x64 build: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277,777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: Id4d13f0b2097ccfe398b05ce239d21c5d3c2b626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277, 777650 Reviewed-on: https://chromium-review.googlesource.com/807588Reviewed-by:
-
