GitLab

variable for the 'OS=="win"' targets that use it, to work around
an apparent problem in the gyp variable expansion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17208 0039d316-1c4b-4281-b951-d872f2087c98

It also makes sure that engines which have been removed from Firefox
are not imported into Chrome.

BUG= http://crbug.com/12245
TEST= Install firefox, and do not change the default search engines.
Start Chrome, and import search engines from Firefox.  Default Firefox
engines should now be part of Chrome.


Review URL: http://codereview.chromium.org/115895

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17207 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/118015


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17204 0039d316-1c4b-4281-b951-d872f2087c98

TBR=finnur

Review URL: http://codereview.chromium.org/115940


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17203 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115936

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17201 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw

Review URL: http://codereview.chromium.org/118009


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17200 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17197 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115929

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17195 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/114063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17194 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115928

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17193 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115927

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17192 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17191 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115925

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17190 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113985

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17189 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115880

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115924

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17187 0039d316-1c4b-4281-b951-d872f2087c98

Implement Clear Browser Data for Mac as an app modal dialog. Uses the profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file.
BUG=none
TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance.
Review URL: http://codereview.chromium.org/112065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17186 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17185 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17184 0039d316-1c4b-4281-b951-d872f2087c98

The approach is borrowed from render_process_host's kMaxRenderersByRamTier.

The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.

Patch by Joel Stanley.

BUG=12028

Review URL: http://codereview.chromium.org/115452


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17183 0039d316-1c4b-4281-b951-d872f2087c98

In some cases this will avoid the implicit char* -> std::string conversion,
object creation, and string copying.  One of the biggest benefit is on Windows,
where we can save some conversions in FilePath::AppendASCII.

Review URL: http://codereview.chromium.org/113996


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17182 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a number of issue, and provides some additional support and fixes needed for the dev tools.
Review URL: http://codereview.chromium.org/115921

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17181 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none

Review URL: http://codereview.chromium.org/115870

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17178 0039d316-1c4b-4281-b951-d872f2087c98

- reduce header dependencies
- miscellanous cleanups (whitespace, explicit deps)

Review URL: http://codereview.chromium.org/113945

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17177 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: decouple class and method names from RPC message arguments. That would allow to select dispatcher wothout parsing the message argument.
Review URL: http://codereview.chromium.org/115862

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115915

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17175 0039d316-1c4b-4281-b951-d872f2087c98

and clean up some things:
* Make <(grit_out_dir) a top-level variable, used by multiple targets.
* Add precompiled.{cc,h} to various targets:  common and plugin.
* Add precompiled_wtl.{cc,h} to various targets:  renderer, unit_tests,
  and url_fetch_test.
* Add browser/net/test_url_fetcher_factory.cc to unit_tests.
* Add dependencies on net_resources and webkit_resources to unit_tests
  and interactive_ui_tests.
* Add a dependency on test_support_common to page_cycler_tests.
* Add a dependency on net to url_fetch_test.
* Pull in all of the installer/installer.gyp targets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17174 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115914

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17173 0039d316-1c4b-4281-b951-d872f2087c98

Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged calls the base class impl first.

Fix compile bustage by not compiling windows-specific code on other platforms.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115912

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17172 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17171 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17170 0039d316-1c4b-4281-b951-d872f2087c98

Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/114059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10911
TEST=net_unittests passes

Review URL: http://codereview.chromium.org/115700

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=visit about:crash, no dump file left over in /tmp.
Review URL: http://codereview.chromium.org/113984

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17161 0039d316-1c4b-4281-b951-d872f2087c98

The threads in our thread pool terminate after we have called
PR_Cleanup.  Unless we detach them from NSPR, if we use
CertVerifier, net_unittests dies with segfault on shutdown.

BUG=10911
TEST=net_unittests passes with code that uses CertVerifier.

Review URL: http://codereview.chromium.org/115856

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17160 0039d316-1c4b-4281-b951-d872f2087c98

unneeded methods from NativeTabContentsContainerWin.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115903

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17159 0039d316-1c4b-4281-b951-d872f2087c98

This is a quick hack, that will be replaced once we have the rest of prefs
implemented.

BUG=12736

Review URL: http://codereview.chromium.org/113977

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17158 0039d316-1c4b-4281-b951-d872f2087c98

accept the user's text.

Review URL: http://codereview.chromium.org/114058


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17157 0039d316-1c4b-4281-b951-d872f2087c98

vista without hebrew support
the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093)

the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least

BUG=12093
TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl".
Review URL: http://codereview.chromium.org/115849

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98