- 15 Mar, 2011 36 commits
- 
- 
rniwa@webkit.org authoredAnother Chromium rebaseline for r81095. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
laszlo.1.gombos@nokia.com authoredUnreviewed build fix. Buildfix when JIT is not enabled after r81079 https://bugs.webkit.org/show_bug.cgi?id=56361 * runtime/Executable.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81118 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
aroben@apple.com authored* TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81117 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
weinig@apple.com authored<rdar://problem/9108119> https://bugs.webkit.org/show_bug.cgi?id=56357 Source/WebCore: Reviewed by Adam Roben Test: AboutBlankLoad * platform/network/cf/ResourceResponse.h: * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Create a CFURLResponseRef if one does not exist yet as we do for NSURLResponses on the mac. Tools: Reviewed by Adam Roben. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added. (TestWebKitAPI::decidePolicyForResponse): (TestWebKitAPI::TEST): Add test that loads of about:blank have a response with a MIMEType of text/html. * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::MIMETypeForWKURLResponse): * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: (TestWebKitAPI::Util::MIMETypeForWKURLResponse): Add helper to get the MIMEType from a WKURLResponse. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: Add new files. git-svn-id: svn://svn.chromium.org/blink/trunk@81116 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
ap@apple.com authoredReviewed by Darin Adler. REGRESSION: Print preview is blank when selecting multiple pages per sheet https://bugs.webkit.org/show_bug.cgi?id=56341 <rdar://problem/8991382> * UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected callback number after receiving a different one. We only update preview after receiving the latest expected page data (and the assumption is that AppKit will ask for pages in natural order for N-up). git-svn-id: svn://svn.chromium.org/blink/trunk@81115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by Kenneth Rohde Christiansen. [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback. https://bugs.webkit.org/show_bug.cgi?id=56145 We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough. positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because of a bug in QtMultimedia. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::seek): (WebCore::MediaPlayerPrivateQt::stateChanged): (WebCore::MediaPlayerPrivateQt::positionChanged): * platform/graphics/qt/MediaPlayerPrivateQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by Kenneth Russell. Graphics Context is not properly recovered if the GPU process dies. https://bugs.webkit.org/show_bug.cgi?id=56148 Split context recreation into two steps. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): * src/WebViewImpl.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
morrita@google.com authoredUnreviewed, skipped tests that uses an unsupported DRT API. * platform/qt/Skipped: * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
ap@apple.com authoredReviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=44138 Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests. * platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that locally, becasue most WebSocket tests time out on my machine. 2011-03-14 Alexey Proskuryakov <ap@apple.com> Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=44138 Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html https://bugs.webkit.org/show_bug.cgi?id=55375 http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows https://bugs.webkit.org/show_bug.cgi?id=56185 http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows * platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that a pointer can be passed across threads when wrapped in a RefPtr. * platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists when executing a method on main thread by using RefPtr. git-svn-id: svn://svn.chromium.org/blink/trunk@81111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
rniwa@webkit.org authoredChromium rebaselines for r81095. * platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt: * platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: * platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed. * platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt: * platform/chromium-win/editing/deleting/smart-delete-001-expected.txt: * platform/chromium-win/editing/deleting/smart-delete-002-expected.txt: * platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt: * platform/chromium-win/editing/selection/after-line-break-expected.txt: * platform/chromium-win/editing/selection/expanding-selections-expected.txt: * platform/chromium-win/editing/selection/expanding-selections2-expected.txt: * platform/chromium-win/editing/selection/fake-drag-expected.txt: * platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt: * platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
rniwa@webkit.org authoredGTK and Qt rebaselines for r81095. * platform/gtk/editing/deleting/smart-delete-001-expected.txt: * platform/gtk/editing/deleting/smart-delete-002-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt: * platform/gtk/editing/selection/expanding-selections-expected.txt: * platform/gtk/editing/selection/expanding-selections2-expected.txt: * platform/gtk/editing/selection/fake-drag-expected.txt: * platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt: * platform/gtk/editing/selection/triple-click-in-pre-expected.txt: * platform/qt/editing/deleting/smart-delete-001-expected.txt: * platform/qt/editing/pasteboard/smart-paste-001-expected.txt: * platform/qt/editing/pasteboard/smart-paste-003-expected.txt: * platform/qt/editing/pasteboard/smart-paste-004-expected.txt: * platform/qt/editing/pasteboard/smart-paste-007-expected.txt: * platform/qt/editing/selection/expanding-selections-expected.txt: * platform/qt/editing/selection/expanding-selections2-expected.txt: * platform/qt/editing/selection/triple-click-in-pre-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by Kenneth Rohde Christiansen. [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=56006 * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): * QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): git-svn-id: svn://svn.chromium.org/blink/trunk@81108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
weinig@apple.com authored* WebCore.exp.in: git-svn-id: svn://svn.chromium.org/blink/trunk@81107 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
commit-queue@webkit.org authoredReviewed by Ojan Vafai. Add method to make BuildBot return test outputs https://bugs.webkit.org/show_bug.cgi?id=54374 The Builder.latest_cached_build will be used by the new rebaseline script to determine the build to use baselines from. * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: git-svn-id: svn://svn.chromium.org/blink/trunk@81106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
aroben@apple.com authoredReviewed by Sam Weinig. Source/WebKit2: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as empty documents, and defer to the platform for everything else. * WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformCanHandleRequest): * WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::platformCanHandleRequest): * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::platformCanHandleRequest): Renamed from canHandleRequest. Tools: Test that WKBundlePageCanHandleRequest returns true for empty document URLs * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test. (TestWebKitAPI::setInjectedBundleClient): Hook up our callback. (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to ensure the web process is initialized, then ask the bundle to run the test and assert that it succeeded. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added. (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class. (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to handle a given URL. (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown URL type cannot be handled). (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the result. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Added new files to the project. git-svn-id: svn://svn.chromium.org/blink/trunk@81105 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
joepeck@webkit.org authoredReviewed by Eric Carlson. Stalled media elements don't stop delaying the load event https://bugs.webkit.org/show_bug.cgi?id=56316 * http/tests/media/video-play-stall-before-meta-data-expected.txt: Added. * http/tests/media/video-play-stall-before-meta-data.html: Added. 2011-03-14 Joseph Pecoraro <joepeck@webkit.org> Reviewed by Eric Carlson. Stalled media elements don't stop delaying the load event https://bugs.webkit.org/show_bug.cgi?id=56316 We should stop delaying the load event when the load has stalled naturally, or if we require a user gesture to continue the load. Test: http/tests/media/video-play-stall-before-meta-data.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying. git-svn-id: svn://svn.chromium.org/blink/trunk@81104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
mrowe@apple.com authoredRoll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots. git-svn-id: svn://svn.chromium.org/blink/trunk@81103 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
commit-queue@webkit.org authoredReviewed by Martin Robinson. [GTK] Possible leaks after splitting TextCheckerClientEnchant. https://bugs.webkit.org/show_bug.cgi?id=55989 Convert gchar* to GOwnPtr<gchar> and refactor the code. * WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): git-svn-id: svn://svn.chromium.org/blink/trunk@81102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
morrita@google.com authoredReviewed by Tony Chang. Crash when dragging and dropping in a document with an invalid XHTML header https://bugs.webkit.org/show_bug.cgi?id=48799 * editing/pasteboard/drop-file-svg.html: Added. * editing/pasteboard/resources/drop-file-svg.svg: Added. 2011-03-13 MORITA Hajime <morrita@google.com> Reviewed by Tony Chang. Crash when dragging and dropping in a document with an invalid XHTML header https://bugs.webkit.org/show_bug.cgi?id=48799 DragController tried to dispatch textInput event even when the drag destination is not the editable area. This change skips the event dispatching on that case. Test: editing/pasteboard/drop-file-svg.html * page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): (WebCore::DragController::concludeEditDrag): git-svn-id: svn://svn.chromium.org/blink/trunk@81101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
ggaren@apple.com authoredReviewed by Oliver Hunt. Made the global object moving-GC-safe https://bugs.webkit.org/show_bug.cgi?id=56348 SunSpider reports no change. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Removed a dubious comment that suggested we do not need to visit all our references during GC, since that is not true in a moving GC. Re-sorted data members by type, removed one duplicate, and added back the one missing mark I found. * runtime/JSGlobalObject.h: Re-sorted data members by type. git-svn-id: svn://svn.chromium.org/blink/trunk@81100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
levin@chromium.org authoredhttp://trac.webkit.org/changeset/81094 https://bugs.webkit.org/show_bug.cgi?id=56355 Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-14 Broke the chromium DRT related build. (Requested by dave_levin on #webkit). Source/WebCore: * WebCore.exp.in: * WebCore.order: * page/Frame.cpp: (WebCore::Frame::layerTreeAsText): * page/Frame.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): * rendering/RenderLayerCompositor.h: Source/WebKit/chromium: * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText): * src/WebFrameImpl.h: Tools: * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump): * DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams): git-svn-id: svn://svn.chromium.org/blink/trunk@81099 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
abarth@webkit.org authoredApparently we need to exclude DefaultSharedWorkerRepository.cpp from the Chromium build, otherwise the objects visible in the global scope change. * WebCore.gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by David Hyatt. bug 56052: percentages are incorrectly rounded in WebKit https://bugs.webkit.org/show_bug.cgi?id=56052 * platform/mac/fast/css/percentage-non-integer-expected.txt: 2011-03-14 Rik Cabanier <cabanier@adobe.com> Reviewed by David Hyatt. bug 56052: percentages are incorrectly rounded in WebKit https://bugs.webkit.org/show_bug.cgi?id=56052 test: fast/css/percentage-non-integer.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): * platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout): * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows): * rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius): git-svn-id: svn://svn.chromium.org/blink/trunk@81097 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
abarth@webkit.org authoredAttempted Chromium build fix. Exclude AllInOne harder. * WebCore.gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
rniwa@webkit.org authoredReviewed by Darin Adler. EventHandler calls shouldChangeSelection needlessly https://bugs.webkit.org/show_bug.cgi?id=56324 Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and avoided calling shouldChangeSelection and setSelection when the existing selection is identical to that of new selection. * page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): Extracted. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto. 2011-03-14 Anton Muhin <antonm@chromium.org> Reviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * platform/chromium/test_expectations.txt: Temporary suppress text differences. git-svn-id: svn://svn.chromium.org/blink/trunk@81095 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * WebCore.exp.in: * WebCore.order: * page/Frame.cpp: (WebCore::Frame::layerTreeAsText): * page/Frame.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): * rendering/RenderLayerCompositor.h: 2011-03-14 Daniel Sievers <sievers@google.com> Reviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText): * src/WebFrameImpl.h: 2011-03-14 Daniel Sievers <sievers@google.com> Reviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump): * DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams): git-svn-id: svn://svn.chromium.org/blink/trunk@81094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
abarth@webkit.org authoredReviewed by Dimitri Glazkov. Add remaining files to WebCore.gypi https://bugs.webkit.org/show_bug.cgi?id=56351 Adding the remaining files to WebCore.gypi required updating the include/exclude lists in WebCore.gyp. These lists aren't overly elegant, but we can try to improve them in the future. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * bindings/v8/ScriptCachedFrameData.cpp: - Added ifdefs to this file to match the header. * platform/graphics/WOFFFileFormat.cpp: - Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER). git-svn-id: svn://svn.chromium.org/blink/trunk@81093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
antonm@chromium.org authoredReviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * platform/chromium/test_expectations.txt: Temporary suppress text differences. 2011-03-14 Anton Muhin <antonm@chromium.org> Reviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * bindings/scripts/CodeGeneratorV8.pm: * bindings/scripts/test/V8/V8TestInterface.cpp: * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: * bindings/scripts/test/V8/V8TestObj.cpp: * bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::calculateRootStyleSheet): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping): (WebCore::V8GCController::gcPrologue): * bindings/v8/WrapperTypeInfo.h: (WebCore::WrapperTypeInfo::isSubclass): * css/CSSRuleList.h: (WebCore::CSSRuleList::styleList): * css/StyleSheetList.h: (WebCore::StyleSheetList::document): git-svn-id: svn://svn.chromium.org/blink/trunk@81092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
luiz@webkit.org authoredSee https://bugs.webkit.org/show_bug.cgi?id=56347. * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81091 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
rniwa@webkit.org authoredMac Leopard rebaselines for r81053 (Grabbed off of Chromium bots). * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum: * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png: * platform/mac-leopard/editing/selection/drag-select-1-expected.checksum: * platform/mac-leopard/editing/selection/drag-select-1-expected.png: * platform/mac-leopard/editing/selection/fake-drag-expected.checksum: * platform/mac-leopard/editing/selection/fake-drag-expected.png: * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum: * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png: * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@81090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
cfleizach@apple.com authoredCrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248 https://bugs.webkit.org/show_bug.cgi?id=56336 Reviewed by Beth Dakin. Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view() pointers. * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: (-[AccessibilityWebPageObject accessibilityHitTest:]): git-svn-id: svn://svn.chromium.org/blink/trunk@81089 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
tkent@chromium.org authoredhttps://bugs.webkit.org/show_bug.cgi?id=55995 Reviewed by James Robinson. Source/WebCore: Test: fast/forms/interactive-validation-select-crash.html * rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock(). LayoutTests: * fast/forms/interactive-validation-select-crash-expected.txt: Added. * fast/forms/interactive-validation-select-crash.html: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81088 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
alice.liu@apple.com authoredhttps://bugs.webkit.org/show_bug.cgi?id=56159 Reviewed by Sam Weinig. Add function for creating a WKImage from CGImage data. * Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it. * Shared/API/c/cg/WKImageCG.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81087 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
ggaren@apple.com authoredReviewed by Oliver Hunt. Made JSWrapperObject and subclasses moving-GC-safe https://bugs.webkit.org/show_bug.cgi?id=56346 SunSpider reports no change. * runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject): * runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor. * runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren. * runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code. This doesn't cause any problems in our existing code since the base class never reads the anonymous slot it declares, but it caused crashes when I tried to start using the slot in an initial version of this patch. * runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue): Resolved a problem where our internal value was stored in two places: an anonymous slot, and a data member which was not always visited during GC. Now, we only use the data member, and we always visit it. (Instead of relying on certain subclasses to set the OverridesMarkChildren bit, we set it ourselves.) * runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor. * runtime/NumberObject.h: Removed meaningless declaration. * runtime/StringObject.cpp: (JSC::StringObject::StringObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor. * runtime/StringObject.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren. * runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code. git-svn-id: svn://svn.chromium.org/blink/trunk@81086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
msaboff@apple.com authoredReviewed by Gavin Barraclough. Look-ahead assertions with back references don’t work as expected https://bugs.webkit.org/show_bug.cgi?id=56082 Changed parentheses assertion processing to temporarily back out the number of known characters after the assertion while processing the assertion. This was done so that assertions don't fail due to checking the number of required characters as additional to the rest of the express since assertions don't "consume" input. Added a byte code to uncheck characters to support the change. * yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::uncheckInput): (JSC::Yarr::ByteCompiler::emitDisjunction): * yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::UncheckInput): 2011-03-14 Michael Saboff <msaboff@apple.com> Reviewed by Gavin Barraclough. Look-ahead assertions with back references don’t work as expected https://bugs.webkit.org/show_bug.cgi?id=56082 New tests to verify the corresponding changes. * fast/regex/assertion-expected.txt: Added. * fast/regex/assertion.html: Added. * fast/regex/script-tests/assertion.js: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
kbalazs@webkit.org authoredReviewed by Adam Roben. [Qt][WK2]Unbreak InjectedBundle on Qt https://bugs.webkit.org/show_bug.cgi?id=54109 No code changes so no new tests. Revert the changes that were needed to use KURL in WebKitTestRunner. * Configurations/WebCore.xcconfig: * WebCore.exp.in: 2011-03-14 Balazs Kelemen <kbalazs@webkit.org> Reviewed by Adam Roben. [Qt][WK2]Unbreak InjectedBundle on Qt https://bugs.webkit.org/show_bug.cgi?id=54109 Add API's to WKURL and WKString to satisfy WebKitTestRunner's needs. * Shared/API/c/WKString.cpp: (WKStringIsEqualToUTF8CStringIgnoringCase): * Shared/API/c/WKString.h: * Shared/API/c/WKURL.cpp: (WKURLCopyHostName): (WKURLCopyScheme): * Shared/API/c/WKURL.h: * Shared/WebString.h: (WebKit::WebString::equalToUTF8StringIgnoringCase): * Shared/WebURL.h: Added OwnPtr<KURL> member to be able to lazily parse the URL and store the result. (WebKit::WebURL::host): (WebKit::WebURL::protocol): (WebKit::WebURL::parseURLIfNecessary): * win/WebKit2.def: Revert the symbol exports that were needed to use KURL in WebKitTestRunner. 2011-03-14 Balazs Kelemen <kbalazs@webkit.org> Reviewed by Adam Roben. [Qt][WK2]Unbreak InjectedBundle on Qt https://bugs.webkit.org/show_bug.cgi?id=54109 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2 API's instead of KURL to analyze the URL. * WebKitTestRunner/StringFunctions.h: (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally in the WebKitTestRunner project. (WTR::toWK): Use adoptWK. (WTR::operator<<): Added helper for printing a WKURL. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link against WebCore. git-svn-id: svn://svn.chromium.org/blink/trunk@81084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
 
- 
- 14 Mar, 2011 4 commits
- 
- 
levin@chromium.org authored* platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81083 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
- 
jeffm@apple.com authoredReviewed by Adam Roben. Add WKViewSetScrollOffsetOnNextResize() to C API on Windows https://bugs.webkit.org/show_bug.cgi?id=56340 * UIProcess/API/C/win/WKView.cpp: (WKViewSetScrollOffsetOnNextResize): Added. * UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize(). * UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size. (WebKit::WebView::setScrollOffsetOnNextResize): Added. * UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize(). git-svn-id: svn://svn.chromium.org/blink/trunk@81082 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
commit-queue@webkit.org authoredReviewed by Laszlo Gombos. [Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian. https://bugs.webkit.org/show_bug.cgi?id=56133 Add condition to not compile webkit internal math round functions on RVCT compiler versions from 3.0.0 because they are already defined in compiler math library. * wtf/MathExtras.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81081 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- 
mrowe@apple.com authoredReviewed by Adam Roben. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned by JSStringCreateWithCFString. (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we allocate. git-svn-id: svn://svn.chromium.org/blink/trunk@81080 bbb929c8-8fbe-4397-9dbb-9b2b20218538 
 
-