GitLab

Getting size of full screen window now works correctly on all desktop
platforms. Re-enable Python-based ChromeDriverTest.testWindowFullScreen.

Bug: chromedriver:1945
Change-Id: I57a4b4003b37d174a8a9a5573453fd861845b948
Reviewed-on: https://chromium-review.googlesource.com/1249831Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594833}

Switch stability proto's renderer crash count to include all renderer
crashes that result in a minidump rather than just foreground.

Pros:
- Align renderer crash counting with GPU crash counting
- Closer alignment with crashes that are uploaded
  - Every crash resulting in a minidump is a candidate to be uploaded
- Background renderer crashes are real crashes and should be fixed

Cons:
- Foreground renderer crashes are certain to cause a bad user experience
  while background crashes do not necessarily do so.

We are testing this out and keeping the rest of the crash pipeline the
same so that we can continue to compare old vs new metrics. If it does
not result in poor prioritization, this change will stick.

Full context: http://g/clank-crash/hZJyq3PJC3g

Bug: 839017
Change-Id: Iab8d6bdae993fbe3d41932719b9cecc5a6c450b8
Reviewed-on: https://chromium-review.googlesource.com/1246462Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594832}

This CL adds logic to dismiss the heavy page capping InfoBar after 8
seconds of no requests being finished on the page. The actual time is
field trial configurable. This also adds a browser test to check this
behavior.

Bug: 888817
Change-Id: I7332918b4590f2f8cd70db365af8dce60f26956c
Reviewed-on: https://chromium-review.googlesource.com/1242173Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594831}

https://chromium.googlesource.com/catapult.git/+log/4e651334d46b..7a4e890f252c


git log 4e651334d46b..7a4e890f252c --date=short --no-merges --format='%ad %ae %s'
2018-09-27 simonhatch@chromium.org Re-enable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2


Created with:
  gclient setdep -r src/third_party/catapult@7a4e890f252c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:888947
TBR=sullivan@chromium.org

Change-Id: I122717fbc2aebcff1d1d190b2a75049b420c2d07
Reviewed-on: https://chromium-review.googlesource.com/1249634Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594830}

Change-Id: I6b5262ccf903b69dbf3e0a5c937e38a0c9b2e886
Reviewed-on: https://chromium-review.googlesource.com/1244879Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594829}

According to manual, it must be either NULL or pointer to an
extension-specific structure. Also GCC barks on skipping fields in
initialisers (8 times as 8 fields follow skipped pNext):

../../gpu/vulkan/vulkan_swap_chain.cc:94:3: sorry, unimplemented: non-trivial designated initializers not supported

Change-Id: I744b9dc84c24b927ec1172f4044f9ca7fbf64029
Reviewed-on: https://chromium-review.googlesource.com/1226600Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594828}

This is a source of webkit_layout_test flakiness on Windows.

Bug: 889608
Change-Id: Ib31cd068620d0c1917aaa85ce2ec7038ccd4236e
Reviewed-on: https://chromium-review.googlesource.com/1249385
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594827}

This CL introduces a few improvements to HttpCredentialCleaner:
(1) A fix in removing the protocol from signon_realm,
(2) refactoring the unittest to use parameters,
(3) minor style fixes.

More details about (1):
HttpCredentialCleaner removes the protocol (HTTP or HTTPS) form
the signon_realm in order to compare the signon_realm of HTTP
credentials with the signon_realm of HTTPS credentials. Until now,
a GURL was created from the signon_realm of the form and then the
protocol was extracted from that GURL, resulting the signon_realm
excluding protocol. This can cause problems when the auth realm contains
characters that are forbidden in an url. This will lead in creating an
invalid url, and the resulting signon_realm with protocol exluded will
be an empty string.
This CL will avoid conversion from the signon_realm string to the GURL
and use other way to remove the protocol from the signon_realm.

More details about (2):
Unitests for this class were changed from one single test into a
bunch of parametrised tests in order to make debug easier in case
of failing test in the future.

Bug: 871140
Change-Id: Ic606d250f50806ae3a3fa07a480fcb01f5551c97
Reviewed-on: https://chromium-review.googlesource.com/1249104
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594826}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74a2dc070e4e..b15eae0a955c


Created with:
  gclient setdep -r src-internal@b15eae0a955c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0df584d7e8c24ef676c34f8573b2bb6ff688eb65
Reviewed-on: https://chromium-review.googlesource.com/1249635Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594825}

Partial revert of https://codereview.chromium.org/1918183003
PointerWatcher is no longer needed with Ash hosting the Window Service.

Bug: 872450
Test: No regressions with clicks inside/outside system tray bubbles.
Change-Id: I987ee0aab77cd2c0efcd1106c7c30e0663349654
Reviewed-on: https://chromium-review.googlesource.com/1249902Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594824}

This CL renames the HostBrowserLauncherParams getter methods to have the
HostBrowserLauncherParams#getStartUrl() format instead of the
HostBrowserLauncherParams#startUrl() format.

BUG=None

Change-Id: I29f76346bfe80198711488a047e41833655595cf
Reviewed-on: https://chromium-review.googlesource.com/1244363
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594823}

Splitting this off from the implementation so we can submit strings
earlier.

Bug: 879548
Change-Id: I180391d203f1fcd98a04f42a89373eb42b33341f
Reviewed-on: https://chromium-review.googlesource.com/1246821
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594822}

https://skia.googlesource.com/skia.git/+log/227d4e10276c..dbdd151b1cb9


git log 227d4e10276c..dbdd151b1cb9 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 benjaminwagner@google.com Revert "bump NDK packages to r18"
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4241ad731a8a..40a6005e7a14 (3 commits)
2018-09-27 brianosman@google.com Remove redundant SkImage virtuals
2018-09-27 brianosman@google.com Revert "Reland "Implement an explicit binary search-based analytic gradient colorizer""
2018-09-27 bsalomon@google.com Revert "Change how GrTextureOp computes outset vertices."
2018-09-27 mtklein@google.com only build stats bar chart when it'll be printed
2018-09-27 fmalita@chromium.org [skottie] External font loader tweaks
2018-09-27 michaelludwig@google.com Reland "Implement an explicit binary search-based analytic gradient colorizer"
2018-09-27 mtklein@google.com bump NDK packages to r18
2018-09-27 mtklein@google.com add test that setLastPt() invalidates path bounds
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 115e8a2625f5..122919bddd98 (1 commits)
2018-09-27 mtklein@google.com invalidate pathref bounds when we attach an editor
2018-09-27 mtklein@google.com update SkPathRef bounds validation
2018-09-27 ethannicholas@google.com fixed SPIR-V interface variable declarations
2018-09-27 bsalomon@google.com Change how GrTextureOp computes outset vertices.


Created with:
  gclient setdep -r src/third_party/skia@dbdd151b1cb9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254,chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254
TBR=bsalomon@chromium.org

Change-Id: I01c18efde9921a36f3185d80d3950f46ff3e73ce
Reviewed-on: https://chromium-review.googlesource.com/1249507Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594821}

[about-omnibox] Performance refactoring of omnibox.js: split refresh method, extract inlined dom elements, and improved html output clearing.

1. Split `refresh` into `refreshAllResults` and `refreshNewResult` for performance reasons as explained in the comments (tldr, refreshing entire output is unnecessary when we only need to add to the output).
2. Extract variables for inlined expressions to retrieve document elements.
3. Use `Element.removeChild` instead of `Element.innerHTML = ` to clear output

Change-Id: Ia7085d97537c5f445c950ecb50f35e5880b6124a
Reviewed-on: https://chromium-review.googlesource.com/1246295
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594820}

The text of the accept button on the welcome page
is changed from "Sign in" to "Turn on sync...".

Screenshot:
https://drive.google.com/file/d/1dFMRqbKazetzouP8MzScMG_lTk5vrd2G/view?usp=sharing

Bug: 889949
Change-Id: I5053b940af365da5a59d434227fa54468919187e
Reviewed-on: https://chromium-review.googlesource.com/1249272Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594819}

Change-Id: Ie364d434a3b4976ba74251c453e117d1e65c3d98
Reviewed-on: https://chromium-review.googlesource.com/1246864Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594818}

https://chromium.googlesource.com/angle/angle.git/+log/122919bddd98..beb0c946de6d


git log 122919bddd98..beb0c946de6d --date=short --no-merges --format='%ad %ae %s'
2018-09-27 geofflang@chromium.org Vulkan: Make sure the default uniform info arrays match indices.


Created with:
  gclient setdep -r src/third_party/angle@beb0c946de6d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I8f18ddc41d556ba4f90e3cd7a4da02ed79445934
Reviewed-on: https://chromium-review.googlesource.com/1249508Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594817}

We can not replace it with our regular void (a = ...) here, so let's
just ignore it.

R=lushnikov@chromium.org

Bug: chromium:805249
Change-Id: I859ca107a15a0284a7c6a2ed0e32fe0c11d4734f
Reviewed-on: https://chromium-review.googlesource.com/1249539
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594816}

ChromeVox's expectations with regard to tab switch recovery have changed. Namely:
- selection events appear to be fired unexpectedly on tabs at various points
- ChromeVox range is no longer over the root web area when a hit test result comes back even when we do want to recover

This change adjusts accordingly to TOT and adds tests for both tab switching and refresh recovery to ensure we don't regress again.

Bug: 887185
Change-Id: I3081830457fb62c14456368a819b00765659a824
Reviewed-on: https://chromium-review.googlesource.com/1246366Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594815}

Bug: 872438
Change-Id: I72790fccc75bc4ac0bdf457cbb960a53019ab974
Reviewed-on: https://chromium-review.googlesource.com/1182614Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594814}

This change adds examples for
can_connect_to_other_services_with_any_instance_name and
can_create_other_service_instances options, as well as capability specs.

Bug: 866967
Change-Id: Iae17a8514a1a3be44b890a4c296a57085302174d
Reviewed-on: https://chromium-review.googlesource.com/1244823
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594813}

Context menu actions were added by https://chromium-review.googlesource.com/c/chromium/src/+/1242295

Bug: 867488
Change-Id: I2a83800e985dd7b62402f049cf9b0707c04e0b7a
Reviewed-on: https://chromium-review.googlesource.com/1248126
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594812}

Previously, WKWebView snapshots were defaulting to the size of the
web view, rather than the visible frame size. This caused the snapshot
to look out of place when animating.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I533f570c996320ab9ae1d33cffe05a63303f7f36
Reviewed-on: https://chromium-review.googlesource.com/1247881
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594811}

Allows https://skia-review.googlesource.com/c/skia/+/154501 to land.

Bug: skia:8262
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic1a9a6753814a5e6dbdfd057f6a96dbcb152e3b6
Reviewed-on: https://chromium-review.googlesource.com/1224660Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#594810}

This virtual method is not needed.  The derived classes don't all
support this method, and indeed it is invalid for an
OfflineAudioContext because the offline context requires a time
argument.

Bug: 889694
Test: internal change
Change-Id: I9ee9aa6279693f90b4a91bfa34f3f584e5f3654d
Reviewed-on: https://chromium-review.googlesource.com/1247683Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594809}

Before this patch, the client and server protos differed in the
precondition field numbering. This resulted in fields being empty.

This patch fixes that.

After this patch, preconditions have properly populated fields after
parsing.

R=rouslan@chromium.org

Bug: 806868
Change-Id: Iec4dcfe6ad9668394a9b16b11719f185dd259e47
Reviewed-on: https://chromium-review.googlesource.com/1249208Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594808}

Using wpt-import in Chromium eea0489c.
With Chromium commits locally applied on WPT:
16f78349 "Move target-in-different-window.html into wpt/"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25392

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I774d9e8d0121856b060462ed10c7966746e395f5
Reviewed-on: https://chromium-review.googlesource.com/1249525
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594807}

Change-Id: Ia6b77632aab5df842c8878fba6fc96bf405a28de
Reviewed-on: https://chromium-review.googlesource.com/1249488Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594806}

Bug: 827288
Change-Id: Ic500608906e7c7c428e3042c5ffcf29f31899beb
Reviewed-on: https://chromium-review.googlesource.com/1207576
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594805}

This avoids a heap allocation per task run.

Change-Id: Id26fe463b29160887d29cb165426101142728550
Reviewed-on: https://chromium-review.googlesource.com/1249311
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594804}

We shouldn't DCHECK-fail for conditions that depend on external
data, which in this case involves a reply from the sync server.
Instead, let's just ignore those updates.

Bug: None
Change-Id: I4e73d5bc68685399b74eb026af6cab344e530b3e
Reviewed-on: https://chromium-review.googlesource.com/1248628Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594803}

By limiting Assistant UI size not to exceed the usable work area:

-Fix Assistant UI goes offscreen if there is not enough screen space
 left when soft keyboard is present or rotate/zoom in the display.
-Fix Assistant UI disappears off the screen to the top during resizing
 animation with soft keyboard shows.
-Fix Assistant UI container resizes to the wrong size when dismissing
 soft keyboard.

Test: local compile and manually test.
Bug: b:111444849, b:112927824
Change-Id: I4a0c641386309f857ffd8ddc2b5a73187cc807c5
Reviewed-on: https://chromium-review.googlesource.com/1226369
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594802}

The test fails because of checking browser's root window with
Shell's root window -- this is actually checking the display
for the browser window. This CL applies the same fix for
TabDragController.

BUG=883523
TEST=interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: I8a53b15216c665c8c0f34ebfced0b22b97e93875
Reviewed-on: https://chromium-review.googlesource.com/1246064
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594801}

https://boringssl.googlesource.com/boringssl/+log/7f4f41fa81c03e0f8ef1ab5b3d1d566b5968f107..fb86b888ef1c1265719208fd6c27a53ceb4920f7

BUG=none

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5f9f8df83c33c9eb3787e4385c20e0f68a0d8335
Reviewed-on: https://chromium-review.googlesource.com/1246406
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594800}

With ChromeVox enabled, queries containing cards after the first
would result in a crash during clean up of the previous response's
cards. This occurred due to failure to detach the card's NativeViewHost
before removing from the view hierarchy and destroying.

Bug: b:116173111
Change-Id: Icb115ab1d3a5afad23a897b1f5a4dae9734210ff
Reviewed-on: https://chromium-review.googlesource.com/1237973
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594799}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99b1fae1..3ca11d72

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If56f10f8a5e8a03c71dd5e6624f6631b865c9ad6
Reviewed-on: https://chromium-review.googlesource.com/1249526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594798}

Add a new interface, content::mojom::NSViewBridgeFactory. This may be
used to create a content::mojo::RenderWidgetHostNSViewBridge in
another process, and initialize its client to a specified
content::mojo::RenderWidgetHostNSViewClient.
  * Note that the interface created by mojom::NSViewBridgeFactory is a
    stub interface, mojom::StubInterface, which is cast to a
    mojom::RenderWidgetHostNSViewBridge. This is because the latter
    has content-internal dependencies, and so cannot be included in
    any other module.

Add a content::NSViewBridgeFactoryHost class that will own such
a connection. There will exist one instance of this class for each
AppShimHost in the browser process.
  * Included in this a "host id". This will be set at initialization to
    match a views::BridgeFactoryHost.
  * When embedding web contents into a views::View, the
    views::BridgedNativeWidgetHostImpl will specify this id to the
    content::RenderWidgetHostViewMac, to ensure that all NSViews be
    created in the same process.

Add a content::NSViewBridgeFactoryImpl class that implements the
content::mojom::NSViewBridgeFactory interface. There will exist one
global instance of this class in each app shim process.

Add to content::RenderWidgetHostViewMac a MigrateNSViewBridge function,
which will move corresponding NSView to a different host.

Add to RenderWidgetHostNSViewBridgeLocal a constructor that takes
mojo interfaces. This constructor is called in the app shim process.
Clarify that the creator of the RenderWidgetHostNSViewBridgeLocal is
its owner, and is responsible for its destruction.

Note that all interfaces are associated. This is because call ordering
needs to be preserved amongst multiple NSViews (e.g, to add one as a
subview of another, but only once both have been put in an expected
state).

Bug: 859152
Change-Id: I69f64c57cf51189ca75e215346f3ef1cbab23094
Reviewed-on: https://chromium-review.googlesource.com/1239763Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594797}

Bug: 878390
Change-Id: I66e2329a2c94e3657b1685b6fb74f4bbc79d211e
Reviewed-on: https://chromium-review.googlesource.com/1222873
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594796}

This is consistent with how the frame rect is treated in other cases of
hit-testing (such as LayoutView::HitTestNoLifecycleUpdate). It also
eliminates the need for HitTestLocation::Intersects(const FloatRect&).
(The other "use" of this method is removed since it isn't used.)

Bug: 823796
Change-Id: I7532f0e685e9960d8afd16f9b41d699ae27bfd11
Reviewed-on: https://chromium-review.googlesource.com/1249142
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594795}

Bug: 847237
Change-Id: Ia95ec62d92a31bc5c71d53c355b6cb577acb4350
Reviewed-on: https://chromium-review.googlesource.com/1244099Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594794}