- 26 May, 2020 40 commits
-
-
Andreea Costinas authored
On slow networks, |SystemClockSyncWaiter| times-out before tlsdate syncs the system clock. This CL increases the time to wait for the system clock updated signal to 45 seconds, which allows tlsdate to try at least seven TCP retransmissions attempts. Note that RFC 1122, section 4.2.3.5 recommends at least 100 seconds for the TCP timeout. BUG=chromium:540686 TEST=none Change-Id: Ie0ff1f55ec2fc2c6d4a67f764af39464f411c4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214941 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771733}
-
Anqing Zhao authored
The class content::MessageLoopRunner class has been deprecated for a long time. Not 100% sure if this is related to the flaky tests, but nothing to lose replace them with the recommanded one - base::RunLoop. Bug: 1044417, 783450 Change-Id: I969f32550c7f1679c8dc398b9b1c17da97b4d137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214943Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#771732}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590465515-9ef099e12f3ab5051489e8b99894f13fb77c0985.profdata to chrome-win32-master-1590479866-bd3b364dec503175394de5d27879ac865b50ea38.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I36c2c37ec2e247f5bc9f4129f0ed990bac8a0522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771731}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590465515-790c6cf05617ff0779c93cfed8e1f71b6e306b53.profdata to chrome-mac-master-1590479866-02719b24a518e7640038fc4f4eebb5b489becebf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic631ccec5bf2820994c5956d9266a0f63baea9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215739Reviewed-by:
-
Alexey Baskakov authored
Apps in sync install are being installed and should be hidden for most subsystems. OnWebAppInstalled() notification will be send out later. Bug: 1086301 Change-Id: Ib02ad64eaf5a35053843bc32360091be1eb48a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215392 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#771729}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd6ecc479f9e..2863ba211be1 2020-05-26 beaufort.francois@gmail.com Show error if manifest icon src is empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie042291bfd6da7b7b09cf6c370d68ccac2c383ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215732Reviewed-by:
-
Guido Urdaneta authored
Also enable the GFD extension in tests so that all the metadata and type fields are reported correctly. Drive-by: test cleanups. Bug: 1069295 Change-Id: I9ffb5c9874c9f8556785a0664ee010d3912f866a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207162Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#771727}
-
Jana Grill authored
Bug: 924497 Change-Id: I5c3d74e0f7e92662dc7138f0f7739ded544fe38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207464Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
David Staessens authored
This CL adds usage documentation for the new video_encode_accelerator_tests, providing in-depth information on how to run the encoder tests. TEST=gitiles BUG=953114 Change-Id: Iaacaa2e6c79417e69eedced9c21b63ed9f483f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060437 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#771725}
-
Eric Willigers authored
The flag FeaturePolicyJavaScriptInterface has been stable since 2019-01. Bug: 703703 Change-Id: I261da132dbabf1d3f0a04931afa3deafb74b4867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206867Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#771724}
-
Benoit Lize authored
PartitionAlloc's alignement guarantees are not explicit anywhere, which is problematic to support aligned allocations properly. This in turn is required to broaden its use across the codebase. This CL doesn't change the behavior, but documents the existing one. Bug: 787153 Change-Id: Id3502081c5bf92f9f820ef1e992e56e1add92374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210422 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#771723}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5db4a28e..2bc8f192 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34b3c62a2ca4681537014cfe8127894a3d518f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215686Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771722}
-
Giovanni Ortuño Urquidi authored
Some apps, like Release Notes, are hidden from the app launcher, search, etc. This CL ensures this setting is correctly migrated to BMO. Fixed: 1086068 Change-Id: I47401753240da830f1f488dc6909e01912cec5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215385 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771721}
-
Jinsuk Kim authored
This CL injects EphemeralTabCoordinator object into the tab delegate factory instead of instantiating it directly. This fixes a problem of creating one coordinator per each tab. Bug: 1064207, 1084731 Change-Id: I78187e2476410a4fcfe3efa85b51884640e1c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214802Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#771720}
-
Yoshifumi Inoue authored
This patch changes "select-out-of-floated-contenteditable.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic2b7ebe39d80c00c5659db3110f53bed97314942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215767 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771719}
-
Rune Lillesveen authored
We incorrectly parse properties like background-image as page descriptors. This CL makes sure we at least don't trigger fetches for such urls. Bug: 1086264 Change-Id: I32f2262fae46cafdd57f1cf2baa825d6bef32389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215323Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771718}
-
Marina Ciocea authored
This reverts commit dbff1601. Reason for revert: Suspect for failures on Linux TSan starting with build https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/55141 Original change's description: > indexeddb: refactor special storage policy > > Special storage policy is a dynamic, complicated, browser-only data > structure that IndexedDB needs to query on shutdown to determine whether > or not to delete particular session-only directories (or not delete > protected directories). Because shutdown is time-sensitive, this > chooses to push updates to policies based on active origins (i.e. > origins that IDBFactories have been created for). > > This is the IndexedDB equivalent of this local storage change: > https://chromium-review.googlesource.com/c/chromium/src/+/1945940 > > Bug: 1015214 > Change-Id: I18f65a6416be508b298e8046d4d6c20c2e56b1f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203146 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771144} TBR=dmurph@chromium.org,enne@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015214, 1086138 Change-Id: I2dccf1105ca01971bfcade267e36191ff2f5c15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213529Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Forks TestLifetimeBrowserProxy into test_os_lifetime_browser_proxy.js - create new os_settings_v3_browsertest.js Bug: 1045266 Change-Id: I4500646fda8e8208d7bc63b405594592f9a7fce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190976 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#771716}
-
Colin Blundell authored
This ensures that the autofill framework won't kick off autofill in the URL bar. The user could still manually trigger autofill by long-pressing on the URL bar and selecting the autofill prompt that pops up. That seems not necessary to fix as that flow will not be possible in the WebLayer embedder. If it were to be fixed, it would need to be fixed at the level of the shared AutofillActionModeCallback. Bug: 1083479 Change-Id: I468b7e729139747479b0f5f6a641a3345fc007af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212125Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#771715}
-
Yutaka Hirano authored
Bug: 1086353 Change-Id: I4613a1271a985a9e01b6652c34dcb27cb6f83859 Tbr: ricea@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215654Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771714}
-
Alice Wang authored
This CL adds JNI code to open account picker bottom sheet in the web sign-in flow. Bug: 1041876 Change-Id: I3dcdeb0ae8ec9960362bae5ebcfbf2999d126bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204021 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771713}
-
Dominick Ng authored
Call TestWebAppProvider::Start() in the tests to stop the App Service waiting for web apps to be published. BUG=1082884 Change-Id: I051a43fa56e739e22e9b1a70e6edf58f0a49b600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214587Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771712}
-
Hitoshi Yoshida authored
This CL updates some IDLs to catch up each spec. There are no or tiny behavior changes. Bug: 839389 Change-Id: I7710fcb259e404608955545817fc38cb1f751d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213660Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#771711}
-
Kent Tamura authored
This CL ports TextAlignmentForLine() and AdjustInlineDirectionLineBounds() of LayoutRubyBase and LayoutRubyText to LayoutNG. This CL doesn't affect production because new behavior is behind a disabled runtime flag. Bug: 1069817 Change-Id: I5e09f0a46ff505f15daccea11f13c66444dc9876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214589 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c203f436263..17c11a2291ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I1e96e97b230500e5af0f1fb289ad7c1e7bedf062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e61a29bd9b4..bd6ecc479f9e 2020-05-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2280600f8cfe4b0779c6e64e0bd077c42a8108c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215728Reviewed-by:
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/7f483b5ee54c..8aff71f6f3e1 $ git log 7f483b5ee..8aff71f6f --date=short --no-merges --format='%ad %ae %s' 2020-05-21 renjietang In QUIC, when TLS 0-rtt is rejected, disable early data in all cached session tickets that are associated with that server. 2020-05-21 dschinazi Introduce QUIC version draft-28 2020-05-21 dschinazi Modernize comments in quic_versions.h 2020-05-21 fayang Notify quic crypto client handshaker about connection close. client side only, protected by existing gfe2_reloadable_flag_quic_notify_handshaker_on_connection_close. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iec5b9db5b157b376d40832036d2406ab9d7f9e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212937 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771707}
-
Phillis Tang authored
Fix WebAppBadgingBrowserTest to wait for service workers to be active before testing sending messages to sub app service worker. Bug: 1085547 Change-Id: Ie24b192b4d2f5654f300d935e11a50637df52ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213021 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#771706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a11b55fed243..b5479f2a80cf 2020-05-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 10bf4a61 to 9f39a47c (208 revisions) 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c746ac65e9d6 to 7ff01bb15d40 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1085627 Tbr: westont@google.com Change-Id: Iacf876570c6a44e577939ebe1b4f9ae29e1a8a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215726Reviewed-by:
-
Marja Hölttä authored
Bug: v8:7193 Change-Id: I67da5487192d4a9bc4aa7a24fd340a7ed6e231a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214882Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#771704}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34a30f39c0d1..f3393ea589ec 2020-05-26 dberris@chromium.org auto-bisect: Validate more input parameters If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086315 Tbr: eseckler@google.com Change-Id: I2040eb1880af53916bf23ba235dc77b7ed253b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215722Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f48f7c5. With Chromium commits locally applied on WPT: 9c36a269 "Reduce cross frame messages in feature-policy-nested-subframe-policy.https.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I03d7e41317c9fa6473383ce970e7dd144e107a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215499Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771702}
-
sandromaggi authored
This adds unit tests for * IsCompleteContact * IsCompleteShippingAddress * IsCompleteCreditCard This change rearranges the |IsCompleteCreditCard| checks to be more easily understandable without changing the behaviour of the function as a whole. Bug: none Change-Id: I0ed6bc657737b69e362e588156d8befbbadacfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214889 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#771701}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d2af84ffde20..79dcb2a5abbd 2020-05-26 capn@google.com Document helper invocations being considered active If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6026656fbaff9411ca9675ee095ea6244c5fea75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215571Reviewed-by:
-
Kinuko Yasuda authored
This inner class (URLLoaderRequestController) was introduced because the most of loading related code used to need to run on IO thread (while NavigationURLLoader itself needs to run on UI thread), while now everything can just run on UI thread. This change merges URLLoaderRequestController back to NavigationURLLoaderImpl. It looks like a lot more code cleanup can be made but leaving those TODOs in order to make the diff relatively cleaner. (The diff still looks a bit broken but no major changes are made in the existing code) Changed NavigationURLLoaderImpl's some method names too to avoid confusion (because now it also needs to have URLLoaderClient methods) * OnRequestStarted --> NotifyRequestStarted * OnReceiveResponse --> NotifyResponseStarted * OnReceiveRedirect --> NotifyRequestRedirected * OnComplete --> NotifyRequestFailed Bug: 1068896 Change-Id: I9d9dc5acf06816dc1bc73fd24a9b7ed4bb915dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212189 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771699}
-
Marc Treib authored
Also change the default value for its TTL parameter to 14 days (instead of 28), which is the value that's launching. Bug: 1034915 Change-Id: I0cef3d09878af50a4d465122f2ff8f84f4eccd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214387 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771698}
-
Adam Rice authored
This commit updates the renderer to use mojo datapipe to transfer WebSocket mesasge to the network service, which later sends out the message with appropriate framing. It adds new ProducePendingData() and ProduceData() functions to write pending messages to the datapipe. It also adds mojo SimpleWatcher and OnWritable callback function in case when the data pipe is unavailable at the moment. This also updates the unittests to stop testing the quota system, and start testing the new datapipe transfer. This commit is a follow-up CL from the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2071189 Design Doc: https://docs.google.com/document/d/1YWj1z9r8wxemGdod6S2tkchudhp6PvNaH3qSO0oucfY/ This is a rebase of https://chromium-review.googlesource.com/c/chromium/src/+/2089564, originally by Keita Suzuki. Bug: 1056030 Change-Id: Ic57abc92b95dad0765c55945439ced5adaf227b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206556Reviewed-by:
-
Toni Barzic authored
When moving accessibility focus to home button, instead of just tapping the button, also send a kHover accessibility event. The hover event is generally sent after tap, but with a delay. ChromeVox expects the kHover event to properly recognize home button as the currently selected node, and to properly handle Search + R command (if the hover event is not received in time, the command will fail, and ChromeVox will report that no elements are focused - just as is the case in the reported test failures). BUG=1085875 Change-Id: I89de078ce623ad4b03ed8c6b32465f633dd6a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214606 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771696}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e01c229a07aa..a11b55fed243 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cc5cda0f997d to 79dcb2a5abbd (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ie72c71347757e69c6f4dfb16628ea3a2ce9d58be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215573Reviewed-by:
-
Jit Yao Yap authored
Sync server-side changes from https://critique-ng.corp.google.com/cl/310015223, https://critique-ng.corp.google.com/cl/303392879, https://critique-ng.corp.google.com/cl/290992058, https://critique-ng.corp.google.com/cl/308723953, https://critique-ng.corp.google.com/cl/304090152, https://critique-ng.corp.google.com/cl/312266437 and https://critique-ng.corp.google.com/cl/313028916. Change-Id: I1faff600d862ddde984cc5c630ad5b6706102d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214522Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#771694}
-
