- 27 Feb, 2020 40 commits
-
-
Hongchan Choi authored
{IIR,Biquad}FilterNodes check the state of the filter and notify the main thread when it goes bad. In this process, the associated context can be collected when a posted task is performed sometime later in the task runner's queue. By using WeakPtr, the task runner will not perform a scheduled task in the queue when the target object is invalid anymore. Test: Locally confirmed that the repro case does not crash after 30 min. Bug: 1055788 Change-Id: Icdb3a7378d0345936b5b50e12ec2b187e58a611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074807 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#744936}
-
Rachel Carpenter authored
For M82. Launch bug: https://crbug.com/1042109 Bug: 1012578 Change-Id: I76e80ed1f8afc5a34f76fbad30ebef731fd84ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076738Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744935}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9931e7a88ec3..4112d4f0c61a git log 9931e7a88ec3..4112d4f0c61a --date=short --first-parent --format='%ad %ae %s' 2020-02-27 btolsch@chromium.org Remove platform/impl from cast/DEPS 2020-02-27 btolsch@chromium.org Add Cast app discovery mechanism Created with: gclient setdep -r src/third_party/openscreen/src@4112d4f0c61a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibdd3379caa76eb5e9fea7ca142451b8fdac7d660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744934}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/624dae6917b2..f0a0e26ccade git log 624dae6917b2..f0a0e26ccade --date=short --first-parent --format='%ad %ae %s' 2020-02-27 abennetts@google.com Override 'metric' property in ReadValue quest. 2020-02-27 phoglund@google.com Add method for setting summary options. 2020-02-27 fancl@chromium.org Sampling 20% uploaded tests querying sheriff-config for monitoring status 2020-02-27 dberris@chromium.org Run auto-recovery marking routine hourly 2020-02-26 jbudorick@chromium.org devil: restructure system app installation to facilitate retries. Created with: gclient setdep -r src/third_party/catapult@f0a0e26ccade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452,chromium:1052720,chromium:1056214,chromium:1056462 Tbr: sadrul@google.com Change-Id: I46b3be4043d9a9137588a3cee3725e3e290033e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076793Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9fd38e33cff73415aa59247a91bfeb163df5b956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076450Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744932}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/021c8b6784ea..d3db56259396 git log 021c8b6784ea..d3db56259396 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Roll build/ 1c4d2b193..64097b6e7 (62 commits) 2020-02-27 dschuff@chromium.org Sync the new mac toolchain in the DEPS hooks, and use -stdlib=libc++ explicitly Created with: gclient setdep -r src/native_client@d3db56259396 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056008 Tbr: mseaborn@chromium.org Change-Id: Iab0338b8f6e4d3fd2ec6b7ac8a9d86cf2a4b4561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077019Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e11b3351. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7bfdb3d56f92620b71654d37c25ffae50f4bf61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075640Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744930}
-
Alexander Surkov authored
Accessible name computation fails to pick up content of text level elements not listed elsewhere (refer to HTML-aam spec) when the elements are located in subtree of an element of name-from-content role R=dmazzoni@chromium.org Bug: 1053507 Change-Id: I702e04269ef298a16cb085b226709209a67517b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068755Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#744929}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I07b59f610b6928191bc65c8970a8661b2e467c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076669Reviewed-by:
-
Tal Pressman authored
Bug: 1049056 Change-Id: I0def4704acac88bdc29b31e8739488e8608f9831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071679 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744927}
-
Karan Bhatia authored
Wait for the fetch to complete before checking whether xhr request was seen by the browser. This should hopefully fix the flakiness since page load won't necessarily wait for the fetch to complete. BUG=1050536, 1056031 Change-Id: I9c043d69c4d619e00737303d2aaa3c15dc587ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076658 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744926}
-
edchin authored
crrev.com/c/2001849 broke snapshotCache in the tab grid mediator. The snapshotCache needs the browserState to be set before it is initialized. This CL fixes the order of setting the browserState then initializing the snapshotCache. Fixed: 1046349 Change-Id: Ie257b18c862e071a90dc67b12e4d39ebc429e28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076446Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744925}
-
garzonou authored
When window.open() is called, we need to use the exact WKWebViewConfiguration provided by WebKit's delegate method in crw_wk_ui_handler to initialize the WKWebView inside CWVWebView. This CL makes the WKWebView inside CWVWebView to be initialized lazily. Bug: 1054276 Change-Id: I5e26c393bbaa667b43b43ba5f78a24b2cacaaede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061984 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#744924}
-
Sylvain Defresne authored
Showcase should not depend on //ios/chrome/app (except for the hooks). The dependencies were unnecessary and can be safely removed (after the removal of one stale #include). After this CL, there is no dependency on //ios/chrome/app:app_internal: $ gn path out/Debug-iphonesimulator --all \ //ios/showcase:ios_showcase_egtests \ //ios/chrome/app:app_internal No non-data paths found between these two targets. Bug: 870935 Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: -
Makoto Shimazu authored
This CL adds tests to initiate requests from a service worker with `require-corp` policy. This currently fails but it'll be fixed once a new service worker starts to respect the COEP value. Bug: 1039613 Change-Id: Ic610cbe8ceb9c5c0d407507918fcdf2c69eb93b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065257 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744922}
-
Tal Pressman authored
Change-Id: If2fe13456a656c531e3426bad2a7d307b43aaa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076221 Auto-Submit: Tal Pressman <talp@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Alex Keng authored
This CL addresses the issue where when the timeline slider is focused while the media is playing, Narrator will announce 'Elapsed time, Elapsed time, ..." repeatedly. (NVDA will repeat the whole sentence which is also not ideal) With this change, the behavior is now changed to announce the current/elapsed time only once when the slider gets focused. Note 1. only Aria updates triggered by the timer are suppressed, so user interactions that would move timeline slider, ex mouse clicks, left/right keys etc, would still trigger current/elapsed time utterance. 2. we can't use aria-live:off to suppress aria since according to the spec [1], aria-live:off doesn't apply to areas that are being focused. [1] https://www.w3.org/TR/wai-aria-1.1/#aria-live Bug: 1054885 Change-Id: I5519793a3d53f1982733f49fd4db882326f5c2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067381 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744920}
-
Yuly Novikov authored
In order to force linking with libc++ as a shared library, resulting in just one instance of libc++ per process. Previously, libc++ was linked statically into each of around 6 libraries involved in ANGLE tests and these libc++ instances conflicted. This CL turns on dEQP EGL tests on SwANGLE bots, which now pass. TBR=kbr Bug: angleproject:4396 Change-Id: Ief399919701df962914cbb83f1ff9bae94d65ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071913Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#744919}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I837036ea6e9d0e0fb52abb6d6c56d3f41947a06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074997Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Haiyang Pan authored
Bug: 922145 Change-Id: I2b4f35ba16e63598c5f7e8dbfcfa89d24f70f61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076522Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#744917}
-
Alexander Alekseev authored
Implementation: http://crrev.com/c/chromiumos/platform2/+/2073263 Bug: 1052268 Change-Id: I4fb10b2868f4d4296837c23f0da632857711a285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072855 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744916}
-
Tomasz Wiszkowski authored
This change is part of Adaptive Suggestions Count feature that aims at presenting as many suggestions on screen as would fit between the Omnibox and soft keyboard. The change introduces no new logic and simply installs a callback that monitors and responds to suggestion list size changes. Bug: 1050813 Change-Id: I8fe777c83241cdb47e9cf238fe246b25cdbf78cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067659 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#744915}
-
jonross authored
The bug blocking them has been fixed. This re-enables the tests while also introducing baselines, which account for some minor anti-aliasing at the borders. There is no longer the background bleeding through TBR=backer@chromium.org TEST=blink_web_tests css3/filters/backdrop-filter-transform.html Bug: 1044032 Change-Id: I2d787df9d7cb311aab42addda0833e64830b74f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072309Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#744914}
-
Jiaxun Yang authored
Add support to generate rpm for MIPS and ARM. To prevent confusion, we also removed build_script_arch and use the deb/rpm arch directly as the build script argument. Change-Id: Ifb44e4831e67a256e13bd02a1bfae09279448484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053783Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Jiaxun Yang <jiaxun.yang@flygoat.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#744913}
-
Chris Cunningham authored
Will fix the assert just as soon as we now which one to fix. Bug: 931533 Change-Id: If10eb70acc5b9d616f6a5dc22fb8f49e666f09de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076340 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#744912}
-
Yusuf Sengul authored
Bug: 1055977 Change-Id: I1ae0c0bb08dd7ca7e995ab0190f52b019e7c6c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073005Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#744911}
-
Takashi Sakamoto authored
This reverts commit 8d889479. Reason for revert: suspect causing ash_unittests failure on linux-chromeos-dbg - TabletModeDesksTest.DesksCreationRemovalCycle - TabletModeDesksTest.RemoveDeskWithMaximizedWindowAndMergeWithSnapped - TabletModeDesksTest.RemovingDesksWithSplitView Sample build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17282 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887345963796360720/+/steps/ash_unittests/0/logs/Deterministic_failure:_TabletModeDesksTest.DesksCreationRemovalCycle__status_CRASH_/0 Original change's description: > Desks: Fix MRU and stacking order of windows of removed desks > > The windows of removed desks should be demoted to be LRU across > all desks. That's why they're appended at the end of the overview > grid list. However, their relative order should be maintained. > > This CL makes sure the MRU order is updated to match the above > expectation, as well as the windows' stacking order (that is > windows of the removed desk should be stacked at the bottom > of the target desk's container's children). > > BUG=1048271 > TEST=Expanded existing tests. > > Change-Id: I06bc69e068e3ffc29bccf7a5983ed6d56fc04830 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073366 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744856} TBR=jamescook@chromium.org,afakhry@chromium.org Change-Id: I28c5e412f0b7b44b6dfa8f5219f3eb7f514237cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076040Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#744910}
-
Takashi Sakamoto authored
This reverts commit 12dc6d4e. Reason for revert: suspect causing compile failure on fuchsia-x64-dbg Sample build: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/7443 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887344967367021984/+/steps/compile/0/stdout?format=raw --- ld.lld: error: undefined symbol: sys::ComponentContext::ComponentContext(std::__Cr::shared_ptr<sys::ServiceDirectory>, zx::channel, async_dispatcher*) >>> referenced by test_component_context_for_process.cc >>> test_support/test_component_context_for_process.o:(std::__Cr::__unique_if<sys::ComponentContext>::__unique_single std::__Cr::make_unique<sys::ComponentContext, std::__Cr::shared_ptr<sys::ServiceDirectory>, zx::channel>(std::__Cr::shared_ptr<sys::ServiceDirectory>&&, zx::channel&&)) in archive obj/base/test/libtest_support.a ld.lld: error: undefined symbol: sys::ServiceDirectory::ServiceDirectory(fidl::InterfaceHandle<fuchsia::io::Directory>) >>> referenced by test_component_context_for_process.cc >>> test_support/test_component_context_for_process.o:(std::__Cr::__unique_if<sys::ServiceDirectory>::__unique_single std::__Cr::make_unique<sys::ServiceDirectory, fidl::InterfaceHandle<fuchsia::io::Directory> >(fidl::InterfaceHandle<fuchsia::io::Directory>&&)) in archive obj/base/test/libtest_support.a >>> referenced by test_component_context_for_process.cc >>> test_support/test_component_context_for_process.o:(std::__Cr::__compressed_pair_elem<sys::ServiceDirectory, 1, false>::__compressed_pair_elem<fidl::InterfaceHandle<fuchsia::io::Directory>&&, 0ul>(std::__Cr::piecewise_construct_t, std::__Cr::tuple<fidl::InterfaceHandle<fuchsia::io::Directory>&&>, std::__Cr::__tuple_indices<0ul>)) in archive obj/base/test/libtest_support.a ld.lld: error: undefined symbol: sys::ComponentContext::~ComponentContext() >>> referenced by test_component_context_for_process.cc ... --- Original change's description: > [fuchsia] Allow the process' ComponentContext to be overridden by tests. > > ComponentContextForCurrentProcess() returns a sys::ComponentContext > connected to the process' incoming service directory, outgoing directory > for services & debugging APIs, etc. > > Provide a TestComponentContextForProcess, which overrides the process' > ComponentContext with one which by default has no services available, > and which allows services to be provided by the test itself, and for > services available in the test process environment to be exposed to the > test. > > Bug: 1038786 > Change-Id: I0d754a1629ab25527dce377d6ffaa039791ef3e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064908 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744858} TBR=wez@chromium.org,kpozin@google.com,sergeyu@chromium.org,anmittal@google.com,geb@google.com Change-Id: Ieb24627ff5605b72ce3c6ca8dca7c1979dc77102 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076741Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 7767aa96. Reason for revert: suspect causing compile failure on android-archive-rel Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw ---- ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true); ^ symbol: method setGridTabSwitcherEnabledForTesting(boolean) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true); ^ symbol: method setTabGroupsAndroidEnabledForTesting(boolean) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null); ^ symbol: method setGridTabSwitcherEnabledForTesting(<null>) location: class CachedFeatureFlags ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null); ^ symbol: method setTabGroupsAndroidEnabledForTesting(<null>) location: class CachedFeatureFlags 4 errors ---- Original change's description: > Make tab strip auto scroll to position of the selected tab > > Currently, when a tab in group is selected or a new tab is created > within group, the tab strip doesn't scroll to the position of the > currently selected tab. This could lead to a state where user needs to > scroll by themselves to find their selected tab in strip. This CL fixes > this issue by making following changes: > * Always scroll the strip to the last position when new tab is added > in group. > * When selected a tab in group (through tab grid dialog etc), try to > scroll to a state where the selected tab is in the middle of the > strip, if possible, > > Bug: 1054079 > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744892} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8918f99..60a026a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76ba5100a4dfd5b9eb9e47bff8e1366f9bfd9226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076357Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744907}
-
Zhenyao Mo authored
The DevicePerfInfo is mostly collected in the info collection GPU process, but recorded in the browser process, once per UMA ping. BUG=1039792 TEST=manual R=magchen@chromium.org,isherman@chromium.org Change-Id: I1b197e14b050bd370aa7a48d0a92237d007fe42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068867 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744906}
-
Julie Jeongeun Kim authored
This change introduces a mechanism to enable accessibility (on auralinux) by creating the kApplication node and waiting until there is a API query to enable accessibility fully. This is done to ensure chromium will avoid performance overhead for users who don't need accessibility, by not creating ATKObjects when they are not being used. Accessibility is enabled when one of two conditions are met: 1. A client queries an ATKObject API. 2. An AXMode is set on AccessibilityNotificationWaiter (used during testing). This is implemented by using AXMode set on the AXPlatformNode, when this is set it will allow for all ATK objects to be created. This change does not remove the need to specify environmental variables and the commandline flag. The original author of this patch is Jessica Tallon<jtallon@igalia.com> Bug: 977112 Change-Id: Ie5e46347296507d214df345320d3d58c9921c84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060359Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
John Lee authored
Fixed: 1056293 Change-Id: I988cd0d273bd8d5a2e771181f3da7f186b013acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075545 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744904}
-
Fergal Daly authored
Capture the URLs involved. Also: - fix the crash key string so that the labels match the values - add GetRenderFrameProxyHost(instance) - change the crash key string name to have no spaces in the hope that it will show up in the crash dashboard - use DEBUG_ALIAS_FOR_CSTR to capture it so that it definitely shows up in the minidump Bug: 1006814 Change-Id: I1528408203ff789436abb50bcd15f06a03a9b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072523 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744903}
-
Nick Diego Yamane authored
Recent changes in LinuxInputMethodContextFactory initialization (see crrev.com/c/2062974) broke ozone/x11. After it, browser crashes at startup. This fixes it as well as adds DCHECK to make sure LinuxInputMethodContextFactory is correctly set just after LinuxUI initialization. Bug: 1055061 Change-Id: Iefe5acc48ec9047b90042b398159e9b260a753f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069229 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#744902}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f0cc231dab7d..9931e7a88ec3 git log f0cc231dab7d..9931e7a88ec3 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 btolsch@chromium.org Add CastPlatformClient for handling sender requests 2020-02-27 miu@chromium.org Add IPEndpoint::Parse(). Created with: gclient setdep -r src/third_party/openscreen/src@9931e7a88ec3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3b9795f4f510655751ffc3af80f7713934f8ba76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075419Reviewed-by:
-
Eric Willigers authored
With a flaky network connection, ExternalWebAppManager may request an app whose manifest cannot currently be retrieved. We emulate this scenario in a browser test by specifying a manifest known not to exist. Note that when the requested user display mode is 'standalone', the effective display mode will be 'minimal-ui' as the app display mode defaults to 'browser' in the absence of a manifest. Bug: 1055523 Change-Id: Ie7ebf42f95891f7e3eb65d3328d85104585f749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076739 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744900}
-
Rachel Carpenter authored
This means that searching for "Help" will suggest the app, even if that string is not in the app name. Bug: b/138968583 Change-Id: Iaee7168c4f6c897b62bc24cd74072b1045ae946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071462 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#744899}
-
Jeremie Boulic authored
The objective is the keep the StorageHandler simple, getting requests from the UI side and returning the requested numbers. The logic for the calculation of the storage items is moved outside of the StorageHandler. The StorageHandler is observing storage size changes and sending the numbers back to the UI side. For each storage item, a test api is defined as a friend class, allowing access to private methods in tests. size_calcualtor_test_api.h is only linked in the unit_tests target. Bug: 1051364 Change-Id: I1eacf84f80b649fed1e63c92fca8e03b821c2f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051785 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#744898}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b847c567e717..005269a51304 git log b847c567e717..005269a51304 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@005269a51304 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4c0977648b01db5b3cb9e716cadebdff84f29c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076327Reviewed-by:
-
