- 12 Jul, 2019 40 commits
-
-
Colin Blundell authored
As part of finalizing the code structure of IdentityManager in the codebase, this CL moves //components/signin/core/browser/webdata/ to //components/signin/public/webdata/. This change follows the structure proposed here: https://docs.google.com/document/d/1p_kahITGFgv7PehQ61-thRVR3Hrdaf3tLryMytTRPYs/edit# This change was entirely scripted. Using NOPRESUBMIT=true because an overly-aggressive check for the presence of NULL detects its presence in a string in a moved file; I don't want to change the string as part of this code move. NOPRESUBMIT=true TBR=eugenebut@chromium.org Bug: 952788 Change-Id: Id86b0248f31ebfa8efddbbebbddb7f4fda933566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688848 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676902}
-
Chris Lu authored
For iOS 13, the scroll position for iPad is slightly larger. This shouldn't make the test significantly more unreliable since it is just bumping it up 0.5. Bug: 983149 Change-Id: I588f9a7566959c15ea3fae492fa864a44c5e205e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697533Reviewed-by:
-
Gyuyoung Kim authored
Some files of //chrome/browser/signin have been including account_consistency_method.h even though they don't use AccountConsistencyMethod or DiceMethodGreaterOrEqual(). This CL removes all unnecessary account_consistency_method.h includes in //chorme/browser/signin. Bug: 970268 Change-Id: I5d511ca7d57ab913b770a8e87d4b1eb153abaab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699802Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#676900}
-
Daniel Bratell authored
In some non-default, extreme, jumbo builds, the kSeparator in content_index and the kSeparator in push_messaging ended up in the same translation unit which then prevented compilation. To avoid that, this patch renames them kSWRIdDescriptionSeparator and kOriginSWRIdSeparator. Bug: 973844 Change-Id: I6d29c3b1f1826613e30577870ed02612e30a368c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698521 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#676899}
-
arthursonzogni authored
Clank Official Build Failure: ~~~ File "../../build/android/gyp/apkbuilder.py", line 383, in <module> main(sys.argv[1:]) File "../../build/android/gyp/apkbuilder.py", line 307, in main with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: File "/usr/lib/python2.7/zipfile.py", line 770, in __init__ self._RealGetContents() File "/usr/lib/python2.7/zipfile.py", line 857, in _RealGetContents x._decodeExtra() File "/usr/lib/python2.7/zipfile.py", line 388, in _decodeExtra tp, ln = unpack('<HH', extra[:4]) struct.error: unpack requires a string argument of length 4 ~~~ This CL speculatively revert the CLs that seems to be linked with build failure. The bug happens while trying to zip dex file: ~~~ with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: ~~~ and the following branch of CL deals with zip + dex files: Revert "dex.py: Remove obsolete flags, code clean-up." commit 35fc212e. https://chromium-review.googlesource.com/c/chromium/src/+/1694090/4 Revert "Android: Zipalign library dex files for incremental install" commit 209eac23. https://chromium-review.googlesource.com/c/chromium/src/+/1692492/6 TBR=agrieve@chromium.org Bug: 983519 Change-Id: Ia90b7f5d16b09ae29cf0617a09a80e5312ed858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700064 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#676898}
-
Mathias Carlen authored
We are seeing quite a few precondition failed errors in the autofill action. In order to help debug this further we are introducing two new fields in the unexpected error info proto. One field is the address map keys when the error occurred (i.e. a client memory addresses snapshot of the keys only, not their values which contain PII). A second field is what key was actually requested by the autofill action. Bug: b/136788056 Change-Id: I679456eecb81afba70b8a329823d82bd5c1fcb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699604 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#676897}
-
Francois Doray authored
I suspect that this was caused by PageMsg being frozen. This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1690052. Bug: 918701, 981886 Change-Id: Ie1419b0436c932be8e41a6c735dacbf8338f21ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697137 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676896}
-
Fernando Serboncini authored
TBR=juanmihd Bug: 983454 Change-Id: I2f0c8fac9e917ac509aa17d3d71b62e26dd8ec01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700103Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676895}
-
Saman Sami authored
This reverts commit 6a44a630. Reason for revert: these tests are still failing on Android FYI bots. https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%205%29/19007 Original change's description: > Add viewport metadata tag to pixel video tests. > > 1. Add viewport metadata tag to the pixel video tests since they are run on > mobile devices(android). Without this tag, the webpages are not scaled > as expected according to device pixel ratio and hence was failing to match > color expectations. > > 2. This CL fixed 3 tests - Pixel_Video_MP4, > Pixel_Video_MP4_FourColors_Aspect_4x3 and Pixel_Video_MP4_FourColors_Rot_180. > > Bug: 925744 > Change-Id: I5dac913b158146f69c6b539d99fb386c3162eb8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698981 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676650} TBR=zmo@chromium.org,kbr@chromium.org,vikassoni@chromium.org Change-Id: I73c25b707513ecd73e007a6942d82eb343d2fbd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700162Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#676894}
-
Robbie Gibson authored
Bug: 976643 Change-Id: I13e7f454112ddfa9eed2779290fefd8dcaeee8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691920Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#676893}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80bb3116391c..25378d6a29ce git log 80bb3116391c..25378d6a29ce --date=short --no-merges --format='%ad %ae %s' 2019-07-12 ianelliott@google.com Vulkan: Split some SKIP expecations and put with correct bugs Created with: gclient setdep -r src/third_party/angle@25378d6a29ce The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ia3045c84739a8016d4f53618eb0ffc2357f325f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699994Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676892}
-
Saman Sami authored
This reverts commit b9aec252. Reason for revert: GpuSwitchingToForegroundHang fails on Android FYI bots. Original change's description: > Added three more GPU watchdog tests > > These new tests covers OnBackgrounded, OnForegrounded and WillProcessTask > functions. > > Bug: 949839 > > Change-Id: I07ff5dfc168b584d26ca8f4fabc7a30b19f6e5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696543 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676669} TBR=zmo@chromium.org,piman@chromium.org,magchen@chromium.org Change-Id: I4867be61c29f12c574e4df8d8414a3a69174e172 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949839,983543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699196Reviewed-by:
-
Mario Sanchez Prada authored
The implementation of blink.mojom.AppCacheHost, which is also the client for blink.mojom.AppCacheFrontend, lives in content::AppCacheHost. Likewise, the implementation of blink.mojom.AppCacheFrontend, which is also the client for blink.mojom.AppCacheHost, lives in blink::ApplicationCacheHost. Finally, the blink.mojom.AppCacheBackend is implemented in content::AppCacheServiceImpl and used remotely from blink::ApplicationCacheHost. Last, all these three mojo interfaces are defined in the appcache.mojom file and currently bound to their remote implementations via RegisterAppCacheHost method of the DocumentInterfaceBroker mojo interface, which gets called from the ApplicationCacheHost::BindBackend() method, in the renderer process. Since these interfaces are tightly related to each other, this CL migrates references to the three of them at the same time across the browser and the renderer process, updating callsites and tests as required. Bug: 955171, 978694 Change-Id: I2a8779cfd52792d5f3485099b1500551bcba1440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692573Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#676890}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8590026dbf0d..bc525d65a1f8 git log 8590026dbf0d..bc525d65a1f8 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 fmalita@chromium.org Revert "reimpl parts of arctTo using doubles to handle shallow angles" Created with: gclient setdep -r src/third_party/skia@bc525d65a1f8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:982968 TBR=fmalita@google.com Change-Id: I82a8f4f57373aadc60619cf0d806fe32bbca3369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699992Reviewed-by:
-
Allen Robinson authored
This brings the installation of OT enabled and context enabled features closer to the installation of runtime enabled features. Change-Id: I1c95d6fd20466feb6b8accc4f89756eb86455c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696910Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Allen Robinson <arobins@chromium.org> Cr-Commit-Position: refs/heads/master@{#676888}
-
Suman Nelson Kancherla authored
This reverts commit 29f357a0. Reason for revert: Observed a crash Original change's description: > Moved ArCore's module install to ArConsentDialog. > > This is a no-op. All that is done is to separate DFM and ArCore install > into a separate class and call the install API from consent dialog instead > of from ArCoreDevice. > > Bug: 907591 > Change-Id: I742db94cf896a4955d4de1938d7323d19a04664e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694401 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676543} Bug: 907591 Change-Id: Id0368e1533e1109ff89f05e40b6c8261ae670d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699730 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#676887}
-
François Beaufort authored
See https://github.com/gpuweb/gpuweb/pull/342 Bug: 877147 Change-Id: Idef876c3c6cf496367e7d045382ec740d4dcda09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699807Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#676886}
-
Robert Ma authored
This test hits a DCHECK on CQ. TBR=foolip No-Try: True Bug: 829028 Change-Id: I7192e67e6be546afc96092e379e7d5759df4e2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699737Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#676885}
-
Mounir Lamouri authored
Bug: 980780 Change-Id: I9a1219df8b67a52fc0caf16595009997d4086390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698630Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#676884}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/12e4307dc7b4..b110acba9e6f git log 12e4307dc7b4..b110acba9e6f --date=short --no-merges --format='%ad %ae %s' 2019-07-12 wl@gnu.org [sfnt, winfonts] Avoid memory leaks in case of error (#56587). Created with: gclient setdep -r src/third_party/freetype/src@b110acba9e6f The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Iae202152f30e55b855ec4970b1662a1661a78f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699986Reviewed-by:
-
Camille Lamy authored
Following https://chromium-review.googlesource.com/c/chromium/src/+/1609783, this function has a slightly modified behavior. Renamed it DetachDocument to make it clearer what it is now doing. Bug: 855189 Change-Id: I1c40f1019160529fdeaa10f04c71cdff456b1d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685381 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Alex Clarke authored
The generic problem seems to be startActivity(true) creates a NTP which is a problem if ChromeTabbedActivity.setupCompositorContent runs before that NTP is created because that creates a SimpleAnimationLayout which tries to hide the page resulting in a MainIntentActionType.SWITCH_TABS. Bug: 982081, 980587 Change-Id: I5324e63f1d115f3df4c819f4ec88857d10eff2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698536 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#676881}
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Change-Id: I6fefa72e30af31205eb9657a2ed932b8eec90c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698637Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676880}
-
Saman Sami authored
This reverts commit 771db245. Reason for revert: breaks vulkan_content_browsertests on Linux FYI bots Original change's description: > canvas2d: Use correct buffer format for shared images. > > R=sunnyps@chromium.org > > Bug: 980122 > Change-Id: Id45d60eb7cea1682badf1a02cc18dae572f24e32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694246 > Auto-Submit: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676521} TBR=sunnyps@chromium.org,fserb@chromium.org,khushalsagar@chromium.org Change-Id: I4531a80f01d60bc4beb8e8d4538e7f3779e43c7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 980122,983538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699734Reviewed-by:
-
Eugene But authored
WKWebView has undefined behavior regarding start the navigation on iOS 13. It's not a bug, just a difference in behavior from iOS 11 and 12, where navigation always starts on simulator but never starts on device. The test is disabled for iOS 13, because it's not possible (and unnecessary) to test undefined behavior. Bug: 983150 Change-Id: I69f5b503bc994bebd803fda4021cb88d4ba0c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698779Reviewed-by:
-
Aga Wronska authored
This reverts commit b026d472. Reason for revert: Kiosk Next not needed any more Original change's description: > Fix status area color when immersive app is opened > > Status area background color was incorrect when switching from > KioskNext home to immersive app, because shelf turns to auto-hide > mode then and both shelf and status area are not visible. > > Bug: 949289 > Change-Id: I28213355ea0f65d7638bd59714e50fbaceef3371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577944 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653016} TBR=jamescook@chromium.org,agawronska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949289 Change-Id: Ic83ce3aae5e93f0c4a138786f24b17e5e7e3ac1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700041Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676877}
-
Aga Wronska authored
This reverts commit 71bbd6d8. Reason for revert: Kiosk Next not needed any more Original change's description: > Fix shelf being visible on kiosk next home screen > > Shelf should not be visible on Kiosk Next home screen. Starting drag > gesture during transition to home screen can cause shelf remaining stuck > and visible. To prevent that cancel drag gesture when home screen > animation is finished. > > Bug: 968635 > Change-Id: I89cfaebbfc9eed0e8ef916b382fdb88f470399f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638917 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665561} TBR=xiyuan@chromium.org,michaelpg@chromium.org,agawronska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968635 Change-Id: I9b6ebf663ffbc76e2fd39a2aa185833908516528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698531Reviewed-by:
-
Ivana Zuzic authored
The icon is going to lead to a password editing activity which doesn't exist yet and will be created in the next CL. The icon is flag-guarded since the feature of editing passwords is still in the making. Bug: 377410 Change-Id: Ibd7d702b884d1a9ab0228e6f8b8c7be424a04946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695353 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676875}
-
Alex Clarke authored
USER_VISIBLE tasks on the UI thread are now run at a lower priority than default / USER_BLOCKING tasks. This caused the test to become flaky because it runs 100 USER_VISIBLE tasks to call OnProgress but the QuitClocure task is run at USER_BLOCKING priority so occasionally it can run too soon. This patch fixes that by running the Quit at USER_VISIBLE priority. Change-Id: I93bc93c9c583b160aa1ff4326a021c432eab525a BUG: 863341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697204 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676874}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/11820502b840..01d04fac7548 git log 11820502b840..01d04fac7548 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 artit@webrtc.org Revert "Add wrapper to normalize flags." 2019-07-12 philipel@webrtc.org Add VideoEncoderFactory::GetImplementations function. 2019-07-12 mbonadei@webrtc.org Revert "Optimize PacketRouter/RTPSender interactions." 2019-07-12 mbonadei@webrtc.org Revert "Pass RtpRtcp::Configuration to RtcpReceiver ctor and initialize ssrcs" Created with: gclient setdep -r src/third_party/webrtc@01d04fac7548 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4d5bdf515b540e024487e27245c974de0fc821e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699990Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7938579ef96f..93193c0ebf2f Created with: gclient setdep -r src-internal@93193c0ebf2f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Idaf5bc1b4c9161541815c594e890f89e6c65110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676872}
-
Camille Lamy authored
This CL allows FrameLoader::CommitDocumentLoader to commit a specified DocumentLoader instead of the provisional DocumentLoader. This is part of a series of CLs that aim at removing the provisional loader (step 8k in the linked doc in the bug). Bug: 855189 Change-Id: Ic59f1793c1db01d4a6f05546a67ce42ec5f70cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611818 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Ilya Bizyaev authored
This adds a feature flag that will be used in the near future to test experimental access control features related to Crostini (restricting VM CLI tools access, restricting Crostini root access). Test: compile Change-Id: Ia60944e2af4bbe9109f31737f2657ba176c16dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698203 Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676870}
-
Fernando Serboncini authored
Bug: 959357 Change-Id: I3ec12e7cbbf42a5cb1d113264ec6a39405933eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697109 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676869}
-
kylechar authored
Graphics code was updated to use OnceCallbacks which support move only types without base::Passed(). Finish cleaning up unnecessary base::Passed() usage and replace with std::move(). Bug: 714018 Change-Id: I5bb3c3fdd3c195fbdb5cca33c2eb0de378e8aeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699207Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676868}
-
Camille Lamy authored
This CL re-organizes FrameLoader::CommitNavigation and DocumentLoader::StartLoading, so that PrepareForCommit is called directly from the FrameLoader. This is step 8i of the doc linked in the bug. Bug: 855189 Change-Id: I74d16740136edab0a248368543cf11ba982830e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609783 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da391939c524..cba4ff0049c8 git log da391939c524..cba4ff0049c8 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 eseckler@google.com Merge "Revert "build: Attempt to use system includes for gtest/mock in chromium"" 2019-07-12 lalitm@google.com Merge "Revert "Update jsoncpp version"" 2019-07-12 khokhlov@google.com Merge "Trace_processor: export instant and async events in json format" 2019-07-12 khokhlov@google.com Merge "Update jsoncpp version" 2019-07-12 eseckler@google.com Merge "build: Attempt to use system includes for gtest/mock in chromium" Created with: gclient setdep -r src/third_party/perfetto@cba4ff0049c8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifa1c9109e3d404a4f354cec3a828d35ac22b6ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699987Reviewed-by:
-
Egor Pasko authored
Bug: None Change-Id: I50ef287f7a31c10735e9c2f2dbe749cbc2bfbab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695413Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676865}
-
Peter Beverloo authored
Otherwise their own members wouldn't be properly destroyed. Also address some tiny style nits. Change-Id: Ia0f08d5d5b972022025e8ca0cc031482fde77b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697207 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Alex Oldemeier authored
This test fails consistently on Mac10.10, Mac10.11, Mac10.12, and Mac10.13 builders. I can reproduce flakiness on my Linux machine, so I am disabling this test for now. TBR=blundell@chromium.org Bug: 983061 Change-Id: Icb65b137d6b5c80d2c0bb798dc7aa763147cffb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698371 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
-
