GitLab

Review URL: https://codereview.chromium.org/170743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251911 0039d316-1c4b-4281-b951-d872f2087c98

If ANDROID_SDK_ROOT is set, it's still added to the path for now, but it's
no longer passed to gyp. If you want to set a custom sdk root, call gyp like
"build/gyp_chromium -Dandroid_sdk_root=path".

If ANDROID_SDK_ROOT is not set, it's still getting exported with a default
value that's identical to the default value of gyp's android_sdk_root variable.

ANDROID_SDK_TOOLS and ANDROID_SDK_BUILD_TOOLS_VERSION are now
completely ignored. Set the android_sdk_tools or android_sdk_build_tools_version
gyp defines instead if you need to change either. If they are not set,
envsetup no longer sets them.

(Dependent on an internal that changes a bot to set these gyp defines in
addition to the env vars.)

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/164193010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251904 0039d316-1c4b-4281-b951-d872f2087c98

that --v=1 is functional.

Review URL: https://codereview.chromium.org/170743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251903 0039d316-1c4b-4281-b951-d872f2087c98

Resubmission of https://codereview.chromium.org/130263007/ with the binary resources added with dcommit.

BUG=334309, 161119
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/170843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/162943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251900 0039d316-1c4b-4281-b951-d872f2087c98

The test seems to pass fine when I run it manually on Windows Ash (including with high values of --gtest_repeat)
This CL:
- Makes ToplevelWindowEventHandlerTest.RunMoveLoopFailsDuringInProgressDrag look more like ToplevelWindowEventHandlerTest.Caption which I don't think is flaky on Windows Ash.
- Adds an extra check which will help better understand the source of the flakiness should it occur again

BUG=343167
TEST=None

Review URL: https://codereview.chromium.org/168793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251899 0039d316-1c4b-4281-b951-d872f2087c98

R=piman
BUG=

Review URL: https://codereview.chromium.org/167953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/167703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251897 0039d316-1c4b-4281-b951-d872f2087c98

We're not planning to enable this on any new platforms, so we can just
hardcode it off when not on ChromeOS. Leaving the disable flag for
ChromeOS for now, as we're working on disabling that code path there.

R=piman
BUG=

Review URL: https://codereview.chromium.org/167973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251896 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> cd src/ui
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235
R=arv@chromium.org, joi@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/161313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251895 0039d316-1c4b-4281-b951-d872f2087c98

One common coding patern is to define an enum as in:
  enum Color { RED, GREEN, BLUE, COLOR_LAST=BLUE };
but this is fragile when someone adds a new constant and forgets
to update the COLOR_LAST constant.

This change looks for enums that have a xxx_LAST or xxxLast member,
and warns if there are any higher-valued constants present.

Review URL: https://codereview.chromium.org/150943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344704
NOTRY=true
TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/171673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251893 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the embedder to change the autofill authentication based on
whether the functionality is available but has been turned off.

BUG=341492
R=gcasto@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/170783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251892 0039d316-1c4b-4281-b951-d872f2087c98

These files are automatically generated for the PDF extension. The long term
solution is not to check in vulcanize-generated files. These files may not
be needed once HTMLImports are fully implemented in chrome.

BUG=303491
R=arv@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/154223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254545
R=cpu@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/165353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251889 0039d316-1c4b-4281-b951-d872f2087c98

Begin blacklisting datamngr.dl, lmrn.dll and hk.dll from the browser
process.

BUG=329023

Review URL: https://codereview.chromium.org/171153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251886 0039d316-1c4b-4281-b951-d872f2087c98

When opening a bubble on linux aura, we send a message to our anchor
Widget telling it to not render as if it was disabled. We never reenable
this when we go away.

BUG=342008

Review URL: https://codereview.chromium.org/171253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251883 0039d316-1c4b-4281-b951-d872f2087c98

R=ericde@chromium.org
TBR=engedy@chromium.org
BUG=344643

Review URL: https://codereview.chromium.org/171483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/164983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251878 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up CL of r251277

Now we invalidate the weak pointers during Decrypting*::Stop(), so all callbacks
are canceled. We don't need to manually cancel the NewKeyCB anymore.

TEST=Media unittests updated.

Review URL: https://codereview.chromium.org/167333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251876 0039d316-1c4b-4281-b951-d872f2087c98

r251624 mistakenly removed this GetSystemColor call.

BUG=344593
TEST=New Profile Management UI buttons have the expected blue background on hover; otherwise look as expected.
TBR=sky@chromium.org,noms@chromium.org

Review URL: https://codereview.chromium.org/166273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341969
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/169993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251871 0039d316-1c4b-4281-b951-d872f2087c98

Only affects SDK build, not Chrome.

NOTRY=true
BUG=344575
TEST=build_sdk.py --bionic

see also parent issue:
  https://code.google.com/p/chromium/issues/detail?id=344574

Review URL: https://codereview.chromium.org/170973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251870 0039d316-1c4b-4281-b951-d872f2087c98

Right now source fortification isn't supported by Clang (http://llvm.org/bugs/show_bug.cgi?id=16821)
It may also prevent the sanitizer tools from catching some bugs.

BUG=162783,341809
R=hans@chromium.org

Review URL: https://codereview.chromium.org/138913015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332228

Review URL: https://codereview.chromium.org/148113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251867 0039d316-1c4b-4281-b951-d872f2087c98

This is a change similar to https://codereview.chromium.org/153273002/
but for the component updater.

BUG=336614

Review URL: https://codereview.chromium.org/165393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338952
R=weitaosu@chromium.org

Review URL: https://codereview.chromium.org/168213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251864 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251863 0039d316-1c4b-4281-b951-d872f2087c98

Instead of tracking ANGLE revisions manually, we've switched to
automatically embedding a commit id header. The ANGLE roll means
we need to update Chrome to the new version tracking.

BUG=343676

Review URL: https://codereview.chromium.org/164913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251862 0039d316-1c4b-4281-b951-d872f2087c98

Some settings make sense, even for Guest, but the profile management section should not be available.

BUG=285347

Review URL: https://codereview.chromium.org/167723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344533
R=rdsmith@chromium.org

Review URL: https://codereview.chromium.org/167793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251860 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251859 0039d316-1c4b-4281-b951-d872f2087c98

Includes VP9 external frame buffers.

Roll details:
https://codereview.chromium.org/168343002

Keep casting away warning:
https://codereview.chromium.org/167973004

Update README.chromium::
https://codereview.chromium.org/171343002

BUG=339889
R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/168363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251858 0039d316-1c4b-4281-b951-d872f2087c98

The |formats| Java Array is sent to native where is pushed into
the C++ |formats| array. This is easier than to pass data types
to and from Java.

VideoCapture.CaptureCapability modified to match C++ equivalent
VideoCaptureFormat [1]. Added mPixelFormat to it. Internal logic
adapted to keep capture format in that class too. Some internal
allocate() logic is passed from iterator to Java foreach loop.



[1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/video_capture_types.h&sq=package:chromium&l=37&type=cs

BUG=309554

Review URL: https://codereview.chromium.org/135213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251857 0039d316-1c4b-4281-b951-d872f2087c98

This is the same basic fix we made in article.js to correct the handling of expand/collapse sections -- basically, instead of testing the media query once, test in the click event handlers, so we correctly handle devices that switch between wide & narrow modes.

Renato, can you review this? We'll need Ben for the official LGTM.

NOTRY=true

BUG=343400

Review URL: https://codereview.chromium.org/156553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true
TBR=rnk

Review URL: https://codereview.chromium.org/171363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251854 0039d316-1c4b-4281-b951-d872f2087c98

Also update caps on ReleaseGL. The updated RendererCapabilities
are posted back to the main thread. Main thread layers will
receive OnOutputSurfaceCreated (should be renamed to
OnRendererCapabilitiesChanged) when this happens. Note this
is also called on first renderer initialization.

BUG=332616

Review URL: https://codereview.chromium.org/151093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251853 0039d316-1c4b-4281-b951-d872f2087c98

ReverseInterface::Log was removed from native_client, since it was 
never used. Now we can remove this implementation as well.

BUG=239656

Review URL: https://codereview.chromium.org/170663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251852 0039d316-1c4b-4281-b951-d872f2087c98

Removes two callback-based about:sync functions and replaces them with
alternatives that are more event-based.

Replaces getAboutInfo and the onServiceStatusChanged event with
requestUpdatedAboutInfo and an onAboutInfoUpdated event. Unlike its
predecessor, the requestUpdatedAboutInfo function does not take a
callback. Instead, it requests that the message handler issue an
onAboutInfoUpdated event. It is assumed that the caller of this
function is already subscribed to receive a callback for this event.
The onAboutInfoUpdated event differs from its predecessor in that
it provides a 'details' member that contains the updated aboutInfo.

This CL also makes the SyncInternalsMessageHandler observe
ProfileSyncService events directly, rather than having these events
routed through the JsEventHandler.

Replaces getListOfTypes with requestListOfTypes. The new function
does not take a callback. The response will arrive in the form of
an onReceivedListOfTypes event.

BUG=334431, 328606

Review URL: https://codereview.chromium.org/162283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251851 0039d316-1c4b-4281-b951-d872f2087c98

The reporting feature should work via the tab modal dialog / settings. Removing the old download feedback string from the context menu.

BUG=312533

Review URL: https://codereview.chromium.org/166223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251848 0039d316-1c4b-4281-b951-d872f2087c98