- 06 Aug, 2018 40 commits
-
-
Nico Weber authored
Bug: 549140 Change-Id: Ie0dfb2c1983fe1d587e9c959eff72b1c46506a68 Reviewed-on: https://chromium-review.googlesource.com/1163314Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581043}
-
Theresa authored
Use the old dark action bar color and status bar color for the ManageSpaceActivity. On some versions of Android, a white icon is shown in the ManageSpaceActivity task in Android recents. When the primary activity color is white, this causes the icon to disappear. BUG=871193 Change-Id: I6e5bd0c2fe59b64d20367b22254683a8998744c7 Reviewed-on: https://chromium-review.googlesource.com/1163830Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581042}
-
Matt Wolenetz authored
Adds a UseCounter for tracking usage of SourceBuffer.changeType(), retains gating that method's visibility to those in chrome://flags/#enable-experimental-web-platform-features, and lets origin trial framework also enable visibility of the method using feature name "MediaSourceChangeType" for increased experimentation. BUG=605134 Change-Id: Iaf6e1ca58b579cd09b7c07573fb817ec1e69ad82 Reviewed-on: https://chromium-review.googlesource.com/1162583Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581041}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iafcb5b0a0671f1f73fcd52f7c7f7b34fa98045b1 Reviewed-on: https://chromium-review.googlesource.com/1164396Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#581040}
-
Weidong Guo authored
Bug: 871448 Change-Id: I3f8b2c4c9e22065c6615db7d3fab8c8c6b1a7e20 Reviewed-on: https://chromium-review.googlesource.com/1164245Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581039}
-
Daniel Erat authored
Remove power_prefs.h and power_prefs_unittest.cc files that I think were accidentally missed when r549765 moved code from //chrome to //ash. Bug: 812504 Change-Id: Ic83f1d400742321756b09f9f2cc9cc738883f2bd Reviewed-on: https://chromium-review.googlesource.com/1164410Reviewed-by:
-
Joel Hockey authored
The absolute path for the mount point of Linux files is long and not user friendly. We should replace the path with the "Linux files" label, which we use in Files app UI. Moved all existing code for sanitizing path display names into file_manager/path_util.cc where it can reuse the existing path naming for consistency. Bug: 863616 Change-Id: Ie4dd57937840760e8468d37182efe64cd3059438 Reviewed-on: https://chromium-review.googlesource.com/1160831Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#581037}
-
David Black authored
Previously, the SuggestionContainerView was the footer of the AssistantMainStage. Now, I've added AssistantFooterView which is the new footer of AssistantMainStage. AssistantFooterView will have two children: - SuggestionContainerView - AssistantOptInView When the user is opted out, SuggestionContainerView will be hidden and the AssistantOptInView will be visible. This CL adds the AssistantFooterView but not the AssistantOptInView. That will be added in a follow up CL. See bug for mock. Bug: b:112236931 Change-Id: Ie95a78639777f6cc009ce59ebffe4acc2e1d09dc Reviewed-on: https://chromium-review.googlesource.com/1163216 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581036}
-
Lukasz Anforowicz authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8e39681139d273c16bc93cd58506bae2314fadd6 Bug: 846839 Reviewed-on: https://chromium-review.googlesource.com/1072645 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581035}
-
Takuto Ikuta authored
build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic. This is a part of effort to utilize cache of test execution on swarming. Bug: 870611 Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be Reviewed-on: https://chromium-review.googlesource.com/1163349 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#581034}
-
Johannes Henkel authored
There's just one enabled_ field here, a bool. Bug: 851762 Change-Id: I25247dc0d0333ea48ce2cf06c3fdf633ef2c1662 Reviewed-on: https://chromium-review.googlesource.com/1163998Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#581033}
-
Takuto Ikuta authored
This fixes exception happening on Windows deterministic builder like below. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic/9666 Change-Id: Iff309dabe5753fa1633366d6bc6716505aaf18c5 Reviewed-on: https://chromium-review.googlesource.com/1164144 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Ben Pastene authored
And add a few test suites that need that arg to run. Bug: 840967 Change-Id: I9954a08cc22f7237b0e0d2093214b544b6f3d897 Reviewed-on: https://chromium-review.googlesource.com/1162863Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#581031}
-
Alex Newcomer authored
There is a bug where users can keep their clamshell mode context menu open by detaching the keyboard. This allows users to have a side shelf in tablet mode, and they may get stuck in this state. This CL prevents this from happening by ignoring the clamshell options if they are somehow executed in tablet mode. Bug: 870469 Change-Id: Ifb9638c3ae705bd58a2e785edc5ca84d698651d2 Reviewed-on: https://chromium-review.googlesource.com/1161387Reviewed-by:
-
Manas Verma authored
This change fixes the Manage Cards button, in the Manage Cards prompt, to link to chrome://settings/payments instead of chrome://settings/autofill bug: 855186 Change-Id: I3d274367deae5d04c7a3029db8e5eec3aa852cc1 Reviewed-on: https://chromium-review.googlesource.com/1163743 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581029}
-
Jun Cai authored
This CL updates the currently disabled browser tests for setting x-frame-options headers to web store requests. Bug: 852877 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8e131848a37a8fbf5b9f4bdb53bcbb225440330d Reviewed-on: https://chromium-review.googlesource.com/1155931Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581028}
-
Weidong Guo authored
Background: When screen is rotated to portrait, only half of the background shield is shown because mask layer bounds is incorrectly updated. 1. Remove mask layer used to create corner radius for background shield and, instead, draw rounded corner background on Canvas. 2. As a side effect, this improves dragging smoothness. Bug: 869622 Change-Id: Ia3b8ce30e0f76f27cdc90ab674504915a79cfb99 Reviewed-on: https://chromium-review.googlesource.com/1164178 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Paul Miller authored
Change-Id: I68ee67d5c0f498e04ca3a892043557b6ce0289f5 Reviewed-on: https://chromium-review.googlesource.com/1164068 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#581026}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/58bf2845eb4d..e19516b87bb1 git log 58bf2845eb4d..e19516b87bb1 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 eakuefner@chromium.org [Dashboard] Halve max concurrent histogram tasks Created with: gclient setdep -r src/third_party/catapult@e19516b87bb1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867379 TBR=sullivan@chromium.org Change-Id: Ie7b7d0e7b92b17e8cbae75271929f2e05e0f982b Reviewed-on: https://chromium-review.googlesource.com/1164282Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581025}
-
Ross Wang authored
Garnet no longer produces an SDK manifest; switch to topaz. Bug: None Change-Id: I43ef7d7d1cc64a57ec546c046379af381c4dcdb5 Reviewed-on: https://chromium-review.googlesource.com/1164397 Commit-Queue: Ross Wang <rosswang@google.com> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581024}
-
Charlie Reis authored
Data URLs are usually put into the process that created them, but this info is not tracked after a tab restore. Ensure that they do not end up in the parent frame's process (or each other's process), in case they are malicious. BUG=863069 Change-Id: Ib391f90c7bdf28a0a9c057c5cc7918c10aed968b Reviewed-on: https://chromium-review.googlesource.com/1150767Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581023}
-
Peter Kasting authored
We can't compute contrast ratios on transparent colors. This prevents DCHECKs with Orin's soon-to-be-landed code, and prevents theme authors from setting colors that lead to drawing artifacts. Bug: 856893 Change-Id: I2994cd44b04ea363b20f087295f6b085325f8ec5 Reviewed-on: https://chromium-review.googlesource.com/1164170 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#581022}
-
Peter Boström authored
Force-enables MaterialDesignController::IsSecondaryMaterialUi() and removes the experiment kSecondaryUiMd as a first step of cleanup. Follow-up changes will remove code that only gets called when IsSecondaryMaterialUi() is false. Finally all traces of IsSecondaryMaterialUi will be removed. Bug: chromium:630357, chromium:867557 Change-Id: If1b7f96c100673a8d3861fee712b4f0d7b8ef726 Reviewed-on: https://chromium-review.googlesource.com/1162901Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Dominick Ng authored
This is a speculative fix for crashes caused by native methods being called after this object is destroyed. BUG=871129 Change-Id: Id620402711979e6e380dd8e307cca098619e962d Reviewed-on: https://chromium-review.googlesource.com/1163407Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#581020}
-
Siddhartha authored
BUG=855037 Change-Id: Ifb2d3298db6cc368ceb5f7ed4de7cf01f412be81 Reviewed-on: https://chromium-review.googlesource.com/1161381Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Make virtual/mouseevent_fractional/fast/events/touch/touch-latched-scroll-node-removed.html flaky in Mac TBR=sahel@chromium.org Bug: 869726 Change-Id: Ie6610d7bd9b18dedac07444dc65904d30192e945 Reviewed-on: https://chromium-review.googlesource.com/1164143Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581018}
-
Xiangjun Zhang authored
This CL adds the implementation to create an audio loopback stream through Audio Service as requested. Bug: 734672 Change-Id: Ifd78a1848c7979438401586c03f41758d996978e Reviewed-on: https://chromium-review.googlesource.com/1141284 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581017}
-
Fady Samuel authored
OnSurfaceDiscarded cosists of two operations: 1. Drop tracking of dependencies of the discarded surface. 2. Unblock surfaces blocked ont he discarded surface. 1. is equivalent to listing all activation dependencies as 'removed_dependencies' and calling OnSurfaceDependenciesChanged. This CL does just that, reducing the number of lines of code in SurfaceDependencyTracker further. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8191f1be81d04cce0c2181ac4fc341ebb8e3cf3f Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1163632 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581016}
-
Daniel Zhang authored
Fixing a bug that involves SearchResult tile text being cut off on the second line of text. Standardized text style between SearchResults and SearchResultTileItems. Bug: 869632 Change-Id: Ifbcc68c29c17b78a5d2323aa59dc98a759b81b34 Reviewed-on: https://chromium-review.googlesource.com/1162742Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#581015}
-
David Roger authored
The order of the enum in enums.xml did not match the order from the code, resulting in wrong labels on the histograms. In the code, the type is TokenRevocationRequestProgress, defined in mutable_profile_oauth2_token_service_delegate.cc This CL fixes the label of the histogram. Bug: 834720 Change-Id: I30b039a8f5c9c2181bc1a77d807123eab53272fb Reviewed-on: https://chromium-review.googlesource.com/1163680Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581014}
-
Scott Violet authored
BUG=842365 TEST=none Change-Id: I3f29c66f1d82c88eaff7da4c8b99ee6aed4902cc Reviewed-on: https://chromium-review.googlesource.com/1164075Reviewed-by:
-
Xiaoqian Dai authored
1) If the overview ends because a window (either from overview or not) just got snapped, we should not do animation when exiting overview. 2) If the overview ends because of releasing a dragged window, we also should not do animation when exiting overview. Bug: 823769 Test: SplitViewControllerTest.OverviewExitAnimationTest, SplitViewTabDraggingTest.OverviewExitAnimationTest Change-Id: I506120348f55ac7c86ec581ede08473c14f6e128 Reviewed-on: https://chromium-review.googlesource.com/1162587 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581012}
-
Jared Saul authored
Bug: 868552 Change-Id: I6a796cdcc0d4aa27750caa8a93581f205d4e8409 Reviewed-on: https://chromium-review.googlesource.com/1161569Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#581011}
-
gogerald authored
Bug: 806868 Change-Id: I9290cc5830308134e14b23be0d87eb5b11dd0d6e Reviewed-on: https://chromium-review.googlesource.com/1156480 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581010}
-
Clark DuVall authored
This reverts commit c9cbab07. Reason for revert: Breaking linux dbg bots: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/73603 Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: I56a28f0f2ebd8f3ec57aa0af0a94e317d7cffcaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164208Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581009}
-
Chris Harrelson authored
Previously we unconditionally invalidated both on any style change. Most of the changes in this patch are updates of code that looks like: SetNeedsPaintPropertyUpdate(); to: SetNeedsPaintPropertyUpdate(); if (Layer()) Layer()->SetNeedsCompositingInputsUpdate(); in cases where the LayoutObject in question might have a PaintLayer. The call to SetNeedsCompositingInputsUpdate() cannot be pushed down into SetNeedsPaintPropertyUpdate() because SetNeedsPaintPropertyUpdate() is called from SPv1 compositing code post-inputs, and it's illegal to set lifecycle bits for that phase after it has already completed. Bug: 814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c2aa3d451ad24e6feb0b14858bdba09d42f4ef5 Reviewed-on: https://chromium-review.googlesource.com/1157651 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Yue Li authored
Also update icon for assistant server notifications. Bug: b/111936939 Test: Manual Test Change-Id: I91d013daba51174d9532b6806484f1ed42809f14 Reviewed-on: https://chromium-review.googlesource.com/1162976 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Robbie McElrath authored
Currently NetworkConnectionTracker is in //content/public/browser, but it needs to be used by some //components that get used by ios, which can't depend on //content. Bug: 821009 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id47eda058f5be58492f510771b3ed6e5bbbaffac Reviewed-on: https://chromium-review.googlesource.com/1162747 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#581006}
-
Jérôme Lebel authored
metrics::prefs::kMetricsReportingEnabled and prefs::kMetricsReportingWifiOnly are local prefs, and not user prefs. prefs: :kMetricsReportingWifiOnly is part of the local pref service. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a5bfc6d4b7c34e59d911996329b6515190c164c Reviewed-on: https://chromium-review.googlesource.com/1163714Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581005}
-
Azeem Arshad authored
This CL exposes three additional methods: OnVersionActivated, OnVersionRedundant and OnNoControllees. These methods are required for ChromeOS integration for Android Web Messages. Bug: 850823 Change-Id: I2d38e46e28c1f4b2c76fb6410a57fb74c1a3b850 Reviewed-on: https://chromium-review.googlesource.com/1145621Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#581004}
-
