- 08 Apr, 2020 40 commits
-
-
Frank Liberato authored
Allow video decoders to attach HDR metadata in addition to color space information to a VideoFrame. This will help us to defer tone mapping until later in the display pipeline. Bug: 1068321 Change-Id: I686159905657979d5b6c9fe280c2991e37feeeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137918 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757520}
-
Anqing Zhao authored
This extension needn't trigger the full-screen warning notification in MGS session. Bug: 1063236 Change-Id: I3cd1f5973d5d265e5aff02627dbc921534f4423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138412Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#757519}
-
Thomas Tellier authored
Bug: 993653 Change-Id: Icf3cdb322223487a6780a5f20a3c22f9ed22ca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133972 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#757518}
-
Ben Pastene authored
Due to emergency server maintenance in crbug.com/1069091, we need all tests to not be deduplicated into tests that ran prior to the maintenance. Adding a trivial change to //testing/test_env.py will prevent any task deduplication since most every test includes this file in its inputs. TBR=johnchen No-Try: true No-Tree-Checks: true Bug: 1069091 Change-Id: If99af96b6bce7b00cd982de0234b39dbb9a9ec89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142619 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#757517}
-
sreejakshetty@chromium.org authored
This CL converts UsbTabHelper to use RenderDocumentHostUserData and replaces existing manual tracking of frame lifetime in a map. Currently a map from render_frame_host to the FrameUsbServices is maintained to get the associated FrameUsbServices object instead we use RDHUD to do the same set of operations. BUG = 1068546 TBR=fdoray@chromium.org,reillyg@chromium.org,altimin@chromium.org, haraken@chromium.org Change-Id: I05dc172e511f6b4752a1c138ee3d0cecbb6858ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139814Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#757516}
-
Nathaniel Steinbock authored
Merge-with: eureka-internal/384313 Bug: internal/153204109 Change-Id: Ia56c4c148470fc0f76b73f30a843bdc8bdb39506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135832Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Nate Steinbock <steinbock@google.com> Cr-Commit-Position: refs/heads/master@{#757515}
-
David Van Cleve authored
As part of accommodating requests with Trust Tokens [*] parameters present, a previous CL (https://crrev.com/c/2062869) added a trust token helper argument to URLLoader. Whenever URLLoader was provided a trust token helper, it would call out to the helper before sending its request and after receiving response headers. The previous CL did not include a mechanism for actually giving URLLoader a trust token helper outside of tests. This CL adds logic to construct trust token helpers for requests bearing Trust Tokens parameters, by: - implementing a new factory class, TrustTokenRequestHelperFactory, responsible for making a decision of which TrustTokenRequestHelper to vend (or whether to fail with an error); - modifying URLLoader to take one of these factories instead of a TrustTokenRequestHelper proper, and to use the factory to create a helper when given a request bearing trust token parameters (still calling the helper's Begin/Finalize methods at the same time as before); and - having URLLoaderFactory give created loaders a TrustTokenRequestHelperFactory, when requests bear trust token params. (For now, the helper factory will always return an error, because the underlying Trust Tokens operations are not yet fully implemented.) [*]: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit Bug: 1042962 Change-Id: I53743999ff301a832e6a929292d0fb8f0e7df424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097057 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#757514}
-
Ryan Harrison authored
Roll src/third_party/shaderc/src/ 4e3bbd9c5..802636496 (1 commit) https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/4e3bbd9c5f1a..8026364968ac $ git log 4e3bbd9c5..802636496 --date=short --no-merges --format='%ad %ae %s' 2020-04-07 rharrison Add concept of comparison sampler to API (#1036) Roll src/third_party/spirv-cross/spirv-cross/ e58e8d5db..a1d9b474b (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e58e8d5dbe03..a1d9b474b5ca $ git log e58e8d5db..a1d9b474b --date=short --no-merges --format='%ad %ae %s' 2020-04-07 post MSL: Do not use base expression with PhysicalTypeID OpCompositeExtract. 2020-04-03 post Expose a query if samplers or images are comparison resources. 2020-04-03 post Do not add NonWritable/NonReadable decorations for regular images. 2020-04-03 post MSL: Deal with cases where builtin is implicitly needed, declared, but unused. 2020-04-03 post HLSL: Add support for treating NonWritable UAV texture as SRV instead. 2020-04-03 troughton MSL: mark BuiltInFragCoord as implicitly used for subpass reads Created with: roll-dep src/third_party/shaderc/src src/third_party/spirv-cross/spirv-cross BUG=dawn:367 Change-Id: I02882bc2910b5b8f396af72605813ee20ddaff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141206 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757513}
-
Darwin Huang authored
Mark PointerLockBrowserTest.PointerLockEventRouting as flaky on Linux. TBR=lfg@chromium.org, gab@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766450 Change-Id: I1932e553b3ae1644241a4e8c8676b121e5710b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142330Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757512}
-
Wei-Yin Chen (陳威尹) authored
Move Finch parameter "tab_switcher_on_return_time_ms" to a more suitable class. Bug: None Change-Id: I1b7b7dba72d2a2d646ba6c1f89e6dc8107c65538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139374 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#757511}
-
Chris Sharp authored
TBR=sebmarchand@chromium.org Bug: 1069043 Change-Id: Icc0aec1af963580139869c86f1d9ff886d387087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142038Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757510}
-
Dominique Fauteux-Chapleau authored
Bug: 1065880 Change-Id: Ieb3264606cb1188c08e085328ab4e69bd64f3840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132030Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757509}
-
Ted Meyer authored
And, as a use case, logs failure reason for decoders when they can't be initialized. This currently just dumps the status as JSON into the media log. I've not implemented a frontend for this in devtools yet. Change-Id: I3aea5f027078e3f2979eaeeebc08549aa8a393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141622Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#757508}
-
inglorion authored
tools/clang/scripts/goma_link_tests.py was originally written to work with both Python 2 and Python 3. I intend to add some unit tests that will use unittest.mock, which is not part of Python < 3.3. Instead of complicated workarounds, let's just a modern Python version for the tests. Bug: 877722 Change-Id: I475091b005e1f2e4b804e1c884d255ff60669847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140598Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#757507}
-
Nasko Oskov authored
This test has been disabled on Windows as flaky. Running locally 100 iterations of the test passed successfully, so this CL enables it. Bug: 662160 Change-Id: I21d192e02b157c35cb95e9aa6f5ad40425d16ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141135 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#757506}
-
Corentin Wallez authored
The GN targets have moved in Dawn and the former names are groups that proxy to the name path. Change the paths in Chromium so that the proxy groups can be removed in Dawn. Bug: chromium:1064305 Change-Id: I75abda829d8677699bc0165d2fd27c4466a815cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142213Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757505}
-
David Bokan authored
This is now all dead code, from the ill-fated "touchless" project. This CL is a manual revert of the following CLs: https://crrev.com/c/1490195: Add feature flag for Fallback Cursor Mode https://crrev.com/c/1504845: Add event handler for cursor fallback mode https://crrev.com/c/1517155: Pumping Android cursor visibility state https://crrev.com/c/1515636: Add Tab observer for TouchlessEventHandler https://crrev.com/c/1525468: Mouse event handling for fallback cursor mode https://crrev.com/c/1525353: Call platform API for fallback cursor mode. https://crrev.com/c/1533259: Pumping Fallback Cursor Mode state to render https://crrev.com/c/1532538: Add spatnav back key event handling Bug: 1062457 Change-Id: I3feb32ded7ffcf4ef01bb226873c24a57152967c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108183Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757504}
-
Katie D authored
When a user bookmarks a Reader Mode page, we want to bookmark the original instead. Add page title to Reader Mode URLs so that the bookmark_utils::GetURLAndTitleToBookmark can determine it. This makes page title a required parameter to build a Reader Mode URL. Bug: 1066165 Change-Id: Iff8e0eb421946a36516262425da79190c2dbe037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128930Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#757503}
-
Greg Thompson authored
The multi-install support was deactivated in 2017 but there were still many remnants remaining in the Chromium code base. These remnants have been a source of friction for changes being made in the install and update infrastructure. Some additional house-keeping is included by reviewer request. TBR=rsesek@chromium.org NOTRY=TRUE Bug: 1067489 Change-Id: I75d6f633a5ec2132470e3c88fd64c9d080e5c58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135203Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757502}
-
Daniel Libby authored
We've seen a number of bug reports in Edge of the mouse cursor not showing. There doesn't seem to be much tracing in the area, so adding a few trace events to try and help narrow this down.s Change-Id: I18c01a3847ae1d4cc16c36c9be3a5b9216b65e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140600Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757501}
-
Rohit Rao authored
Breakpad has a 255-byte limit on the size of a single value, but will internally split values up to 10 ways to stay under that limit. Breadcrumbs has similar, redundant functionality, so this CL disables it by increasing the maximum allowed value size. BUG=1068802 Change-Id: Ibb668f7270d6f48fb62844de88789f528b323bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139996Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757500}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: I9d984924273755bf0b13a03642af117b99dbbd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142037 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#757499}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 6e35691a. Reason for revert: errorprone failure https://ci.chromium.org/p/chromium/builders/try/android_compile_dbg/515354 Original change's description: > Reland "[PlayBilling] Support app-store billing in AndroidPaymentAppFinder" > > Original patch: https://crrev.com/2135152 > Revert: https://crrev.com/2141209 > Reason for revert: > Test failure - > AndroidPaymentAppFinderTest#testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps > Reason for reland: > The test get fixed. > Before: the test expectation assumed a fixed order in Set elements. > After: the test doesn't assume it, compare set with set instead. > > Original change's description: > > Revert "[PlayBilling] Support app-store billing in AndroidPaymentAppFinder" > > > > This reverts commit cc5487e9. > > > > Reason for revert: testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps is failing consistently on KitKat: > > https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 > > > > Original change's description: > > > [PlayBilling] Support app-store billing in AndroidPaymentAppFinder > > > > > > After: > > > When a merchant page runs in a Trusted Web Activity that's installed > > > from an app store (e.g., Google Play) and the PaymentRequest is not > > > requesting shipping or payer contact, if it satisfies the following > > > conditions, the TWA itself would be included: > > > - the PaymentRequest supports the (TWA installer) app store's > > > billing method in the payment request. > > > - the TWA can handle pay intents. > > > - the TWA can handle the app store billing method. > > > > > > Before: > > > AndroidPaymentAppFinder could not include a TWA for an app store > > > billing method. > > > > > > Change: > > > * In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the > > > merchant page is a TWA installed from app store and if the > > > PaymentRequest is requesting shipping or payer contact. If it is, > > > add the TWA itself as a payment app if it's eligible. > > > * remove mIgnoredMethods. > > > > > > Note: > > > * Counterintuitively, the merchant page would send the pay intent to > > > the TWA instead of the Play Store, because it would be the TWA who > > > is responsible to interact with the app stores. > > > > > > Bug: 1064740 > > > > > > Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152 > > > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > > > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#757128} > > > > TBR=rouslan@chromium.org,maxlg@chromium.org > > > > Change-Id: I954a5d5589704b2c8ad13400fcb487eac00bc677 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1064740 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141209 > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Commit-Queue: Patrick Noland <pnoland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757427} > > TBR=rouslan@chromium.org,pnoland@chromium.org,maxlg@chromium.org > > Change-Id: Id55022716d27a12c46d1cf4d0166d7bdb7a9ffcf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1064740 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142334 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757456} TBR=rouslan@chromium.org,pnoland@chromium.org,maxlg@chromium.org Change-Id: I3470242894219da445ed70238eb21b7e572c027f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142396Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757498}
-
Dominique Fauteux-Chapleau authored
Change-Id: I86fb26961667fb08b6c35a87682198c02cf5b769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137519 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#757497}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I12b4ceab21c9d0e69847768716e8027224bc726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139821Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#757496}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I2dc1737f17186f434ebe0b98c88c16efba911bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141208 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#757495}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/36cd17488a63..7119a0278da3 git log 36cd17488a63..7119a0278da3 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 cwallez@chromium.org BUILD.gn: enable additional warnings. 2020-04-08 cwallez@chromium.org Roll third_party/swiftshader/ 51b2800bb..63ed0e445 (131 commits) 2020-04-08 cwallez@chromium.org Fix wgpu::WholeSize to count until the end of the buffer. Created with: gclient setdep -r src/third_party/dawn@7119a0278da3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I72d21fa25a77fecb0736d56b0743d25bec4400c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757494}
-
Monica Basta authored
Bug: 1059818 Change-Id: Ie6857e0e78ad0c299fa6ae7cf41e364f3e0394ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141101Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#757493}
-
Miguel Casas authored
crrev.com/c/2070820 moved the buffer allocation in the BufferQueue from using CreateGpuMemoryBuffer() to letting the SharedImageBackingFactory decide if it's OK; this broke HDR playback on ChromeOS, where we import GMBs as 1010102 formats when high bitdepth is needed. This CL fixes that by adding support for {RGBA,BGRA}_1010102 where appropriate. Bug: 1064385 Change-Id: Ia0ca81db2619bc0c000c698e15ba49fbca3266fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131029 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757492}
-
Philip Rogers authored
This is now set via PaintArtifactCompositor::Update. This is possible because will-change: transform is a compositing trigger, so we do not need to inspect the properties of paint chunks within the layer. Change-Id: I9c62e1d85575eb23512d1098763e7b8e3f18c07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142391Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757491}
-
Dominic Battre authored
Bug: 1066190,736415 Change-Id: I3803471b302988ac7354350698ff9a007c8d4b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142254 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#757490}
-
Jonah Ryan-Davis authored
conformance/misc/type-conversion-test.html started flaking recently on Win10 opengl passthrough. Suppress this failure until the issue is fixed. TBR=kbr@chromium.org Bug: angleproject:4555 Change-Id: I9d37627b2b75028c069e3bc6cfef2382ef513ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142314Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#757489}
-
John Chen authored
Add documentation on objects used by ChromeDriver to keep track of connection to Chrome. NOTRY: true Change-Id: I61d629923b9ef6e311792e64ff3f78a8c33d2aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138507Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757488}
-
David Van Cleve authored
This CL adds a new method to Document, hasTrustToken(<issuer>), returning whether the user has any trust tokens (https://github.com/wicg/trust-token-api) for the token issuer origin given by |issuer|. This works by querying a new Mojo interface provided by the network context via BrowserInterfaceBinders. More specifically, the method first checks if it can associate the calling top-level context (in the sense of TrustTokenStore::SetAssociation) with |issuer| and, if not, fails. For this reason, the Mojo handle is bound by trusted code to the document's top-level context. New code: - //content, NetworkContext: boilerplate to bind the Mojo interface - blink::Document: add a new mojo remote and bind it; pack API calls into mojom::HasTrustTokenAnswerer requests and unpack responses - Blink scheduling: boilerplate to add a new TaskType (necessary in order to use HeapMojoRemote) correctly; WPTs exercise the interface end to end. Test: unit tests check that the logic in the network service behaves Bug: 1061116 Change-Id: I0f7835cac15b5af3582bb560e116511c601f3b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103082 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757487}
-
Dominik Röttsches authored
Testing in [1] shows that Mac OS 10.13 is unable to retrieve variable font underline metrics correctly, thus for issue 1068559 we need to move to the hybrid approach where we use FreeType for variable fonts already on Mac OS 10.13. Test will be added in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2134018/ Bug: 1068559 Change-Id: I218d57dad8a788533890dc139d11dc2034430b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141917Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#757486}
-
Elly Fong-Jones authored
This is always the empty rect these days, which is the default anchor anyway, so just remove it. Bug: 1064663 Change-Id: I37b901c2f9e907a0339c66555f42482fd2e73b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140175Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#757485}
-
Wei-Yin Chen (陳威尹) authored
TabListDelegate::getLastDirtyTimeForTesting is used in prod code as well, so rename it to reflect the real usage. Bug: 971802 Change-Id: I226987bd70356b35ec64343d6556dd63f2a790dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138778Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757484}
-
Dominic Battre authored
TLSDeprecationConfigTest.NoProto is currently in the top 10 flakes on the Flake Portal. The test is so flaky because it relies on global state of a singleton but the test on trybots are executed in random order. The test expects that the singleton is uninitialized but observes the state left by other tests. This CL resets the state before performing any validation of the behavior. Bug: 1069016 Change-Id: If3f78c5809490166e233f67e60d0b9551b85c6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141099 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#757483}
-
Ahmed Fakhry authored
This system was added in 2015 in the hopes that it will deliver actionable results to detect and fix performance and memory consumption regression. The rappor metrics (which this system is using) was deprecated, and the system failed to give us any useful stats. Therefore the decision was made to remove it. BUG=976423 TEST=Should compile, and tests should pass. Change-Id: Ib57283ae6b8eda6d46ca1f3d67c68648de8c02c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140594Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#757482}
-
Xi Han authored
In this CL, TabContentManager will return the fetched jpeg file to the caller if it finds the file. This makes TabContentManager can fetch cached jpeg on the device before native initialization. Bug: 1041865 Change-Id: Ic4570ff7132dfd5477a1a2b4a0933113ff188438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134957Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757481}
-