GitLab

The flakes are common and we have seen it on Windows and ChromeOS
already. Interestingly, it times out often on Linux Tests (dbg) [1] and
causes several retries ASan but still works on msan and rel builds. I'll
disable it Linux to calm the bots down.

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebRtcGetDisplayMediaBrowserTestWithPicker.GetDisplayMediaVideoAndAudio

TBR=guidou@chromium.org

Bug: 986033
Change-Id: I6dc8c8febdeede7c394475c731cf10f56a275540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718950
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681250}

Test is a Flakey CRASH in DEBUG builds.

No-try: true
No-presubmit: true
Bug: 835943
Change-Id: Ic8dc0a56d6409344db076948fa1dcaf97cad87e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720242Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681249}

https://chromium.googlesource.com/angle/angle.git/+log/fab397e5acde..f002a637743f


git log fab397e5acde..f002a637743f --date=short --no-merges --format='%ad %ae %s'
2019-07-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 9f2236e58ed0..42f813401bdf (6 commits)
2019-07-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3855447d93eb..f54b8653dd9d (9 commits)


Created with:
  gclient setdep -r src/third_party/angle@f002a637743f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=jmadill@chromium.org,jmadill@google.com

Bug: chromium:None,chromium:None
Change-Id: I20ac515e931b60b6fbabdf047c10a56dc1ae38e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720302Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681248}

nacl is using an old toolchain and it seem there are constructs
in the current code it cannot handle. Rather than chasing those
down, just disable jumbo for everything built with the nacl
toolchain.

Example error:

In file included from newlib_pnacl_nonsfi/gen/ipc/ipc_jumbo_1.cc:7:
In file included from ./../../ipc/ipc_channel_common.cc:6:
In file included from ../../ipc/ipc_channel.h:14:
In file included from ../../base/bind.h:10:
In file included from ../../base/bind_internal.h:17:
../../base/memory/raw_scoped_refptr_mismatch_checker.h:30:61: error: 'AddRef' is a private member of 'scoped_refptr<IPC::ChannelProxy::Context>'
                        void_t<decltype(std::declval<T*>()->AddRef()),
                                                            ^
../../base/bind_internal.h:905:11: note: in instantiation of template class 'base::internal::IsRefCountedType<IPC::SyncChannel::ReceivedSyncMsgQueue, void>' requested here
          IsRefCountedType<std::remove_pointer_t<DecayedReceiver>>::value,
          ^
../../base/bind_internal.h:922:1: note: in instantiation of template class 'base::internal::MakeBindStateTypeImpl<true, void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
using MakeBindStateType =
^
../../base/bind.h:247:31: note: in instantiation of template type alias 'MakeBindStateType' requested here
  using BindState = internal::MakeBindStateType<Functor, Args...>;
                              ^
../../base/bind.h:270:16: note: in instantiation of function template specialization 'base::BindRepeating<void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
  return base::BindRepeating(std::forward<Functor>(functor),
               ^
./../../ipc/ipc_sync_channel.cc:175:28: note: in instantiation of function template specialization 'base::Bind<void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
          FROM_HERE, base::Bind(&ReceivedSyncMsgQueue::DispatchMessagesTask,
                           ^
../../base/memory/scoped_refptr.h:277:15: note: declared private here
  static void AddRef(T* ptr);
              ^

Change-Id: I82a13431a74c743cc3ad20c6d4308e2986d88a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474947
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681247}

This reverts commit a2cb14b2.

Reason for revert: Apparently breaks CrOS builds, see comments on review.

Original change's description:
> Fix android generate_linker_map check.
> 
> This change fixes gn refusing to build when `generate_linker_map` is
> true for android targets from a linux host.
> 
> Bug: 986842
> Change-Id: Ieb5e4d236ca54c87cf5f09fe26ce82a9bfe3191f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715024
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681105}

TBR=dpranke@chromium.org,nsatragno@chromium.org

Change-Id: I9b0a81fe63a79fe5be29cfb1a08be953ce704c7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720125Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681246}

Whenever possible, we replace use of EXPECT_CALL macro with use of
ON_CALL in the constructor of the fixture to make the expectations
of each test clearer.

Change-Id: I86a509898e3e2d9893166e46114d94d79274e207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660865Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#681245}

The migration has been completed and the feature is no longer used.

Bug: 950269
Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681244}

This reverts commit 506aea91.

Reason for revert: It's possible that this patch has caused the renderer
process to crash on Android so let's revert it for now and I will investigate
a better patch if needed once I'm back from OoO, in August 5th. 

Original change's description:
> Move implementation of Mojo method GetTextSurroundingSelection() to Blink
> 
> Move this method from the content.mojom.Frame Mojo interface into Blink,
> as part of a new blink.mojom.SurroundingText Mojo interface, and add a new
> class there to implement such interface (i.e. blink::SurroundingTextImpl),
> to replace usages of content.mojom.Frame's GetTextSurroundingSelection()
> from the browser process.
> 
> Note that this SurroundingTextImpl class still relies on WebSurroundingText
> and WebLocalFrame to keep the change smaller, but this is a temporary step
> that will be corrected once WebSurroundingText has been moved out of the
> public API and into renderer/core, which will happen on a follow-up CL.
> 
> Bug: 980151
> Change-Id: I62fb2d5b24a98773c1acddbe1c58217c1a2d53e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696968
> Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679981}

TBR=dcheng@chromium.org,kenrb@chromium.org,haraken@chromium.org,dominickn@chromium.org,mkwst@chromium.org,mario@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 980151
Change-Id: Ic3869e4d6fad9ca06d8d730d5202112b01cc47e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719489Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681243}

Original CL: https://crrev.com/c/1692414

I've disabled the culprit flaky test LoadingSubframeDoesNotPreventCaching.
Flakiness can be investigated separately from this CL (tracking bug:
https://crbug.com/986742).

This reverts commit 381033f4.

Bug: 986742,976697
Change-Id: I6ea4b9543e6bc1d732be704a824c129b6044d329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718244Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681242}

This is a reland of 129650cb with
fixing the reverted reason that CCA video playback couldn't work
after 2nd video recording on ChromeOS.

The original CL removed WeakPtrFactory in MediaRecorderHandler class
and the encoding callback was fired consistently even after
MediaRecorderHandler::Stop was called, so this CL calls Pause function
in MediaRecorderHandler::Stop to stop the encoding callback.

Original change's description:
> Remove WeakPtrFactory from MediaRecorderHandler
>
> This CL removes WeakPtrFactory from MediaRecorderHandler class that
> is garbage collected and replaces the weak pointer with
> WeakPersistent references.
>
> Bug: 981572
> Change-Id: I5dbfc268177cac290b85246ec029833e6baf64ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688966
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#675183}

Bug: 981572
Change-Id: I81938a2751564a6c38301b918f5ed72f6db4a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718474Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681241}

Using the newly added parameter to chrome://favicon2, we now plumb the
icon url associated with a remote history entry to the FaviconSource
level, so that it can be used by HistoryUiFaviconRequestHandler to
collect more reliable grouping metrics for chrome://history/*. The data
plumbed comes from Footprints for chrome://history and from Sessions
Sync for chrome://history/syncedTabs.

Bug: 973192
Change-Id: I81b47cd96d96392f99fb1c0357a5976d1489b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702408
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681240}

To ensure that <details open> fires the toggle event in case of setting
the open attribute from either HTML parser or XML parser.

We introduce a UseCounter for 'toggle' event handler execution. Also we
define and capture whether toggle is happening during parsing or not in
Document.h and DispatchPendingEvent(). We count the new UseCounter if
the event is toggle and happens during parsing.

Bug: 960252
Change-Id: Iefa0d79a5a8866bfd830ecea0bc053350b04b537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717571
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681239}

Using wpt-import in Chromium dabc0b61.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
f050694a "Restrict Shape Detection API to Secure Contexts"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: If55046d84679c465b8c8227cffcfd58d9c285885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718601Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681238}

Change-Id: I8060d8f89c65bb45552c9f5f2da8d67c1414174d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718372
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#681237}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a6f61256488..f86d0ece2ee1


git log 3a6f61256488..f86d0ece2ee1 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 linben@google.com Land Android Variant determine code for bertha for workspace.
2019-07-26 jwerner@chromium.org image_signing: Update kern_b_hash logic to support SHA256


Created with:
  gclient setdep -r src/third_party/chromite@f86d0ece2ee1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9645e453af12eae9c4d16a165d8f67366f3227d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720001Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681236}

https://webrtc.googlesource.com/src.git/+log/2bac7da1349c..67f88a0d305e


git log 2bac7da1349c..67f88a0d305e --date=short --no-merges --format='%ad %ae %s'
2019-07-26 mbonadei@webrtc.org Use print() instead of print in rtc_tools/ python scripts.
2019-07-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 96a23698..b6340b51 (680738:681123)
2019-07-25 sukhanov@webrtc.org Add option to remove transport sequence number from FEC packet calculation


Created with:
  gclient setdep -r src/third_party/webrtc@67f88a0d305e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: Ie02b3fd8107e87a57290392b581d34fbfff4ddb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720291Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681235}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c9190a54da56..f54b8653dd9d


git log c9190a54da56..f54b8653dd9d --date=short --no-merges --format='%ad %ae %s'
2019-07-25 afdx@google.com Limit fuzzer tests so that they take less time to run (#2763)
2019-07-25 stevenperron@google.com Fix check for unreachable blocks in merge-return (#2762)
2019-07-25 afdx@google.com Transformation and fuzzer pass to add dead continues (#2758)
2019-07-24 zoddicus@users.noreply.github.com Remove unneeded future imports (#2739)
2019-07-24 stevenperron@google.com Process OpDecorateId in ADCE (#2761)
2019-07-24 stevenperron@google.com Record correct dominators in merge return (#2760)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@f54b8653dd9d

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng

TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com

Bug: None
Change-Id: Ief89fac3b85b9f77979122a8941c7014066b0802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720293Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681234}

Split dialog classes and webuis into two different files.
Added a new little class BasePasswordDialog that has the code common to all 3 dialogs.

Bug: 930109
Change-Id: I7c6d407a1eec2fdd297f9943d0119b2b0bc85b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718805
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681233}

https://chromium.googlesource.com/catapult.git/+log/572296c6382d..ce4a26a406d3


git log 572296c6382d..ce4a26a406d3 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 perezju@chromium.org [Telemetry] Provide options_for_unittests.GetRunOptions
2019-07-26 simonhatch@chromium.org Pinpoint - Add startedTime property to job.
2019-07-26 simonhatch@chromium.org Pinpoint - Make autocomplete boxes scrollable.


Created with:
  gclient setdep -r src/third_party/catapult@ce4a26a406d3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=oysteine@google.com

Bug: chromium:985712,chromium:987371,chromium:986807
Change-Id: I7e4708e02a955fa59f5af69a2105f27fc58adce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720297Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681232}

On iOS 13, we use overrideUserInterfaceStyle to force incognito pages
into dark mode, thus using dark colors. On iOS 12, this doesn't exist,
so any color that is a dynamic color on iOS 13 must be set to the
correct dark color on iOS 12. This code happens a lot and has a lot of
boilerplate, so the util function speeds things up.

Bug: 974255
Change-Id: I7823f58534d66623a31ac7ccb135c369fee4c6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718028
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681231}

If the ExecutionContext has been shutdown, ScriptPromiseResolver returns
a nullptr. This used to work in the GetNotifications call as we never
used that value. However, in https://crrev.com/c/1475553 we introduced a
TaskRunnerTimer and now call ExecutionContext::GetTaskRunner which
causes a NPE if it has been shutdown already.
This fix simply returns from NotificationManager::DidGetNotifications as
any calls to ScriptPromiseResolver::Resolve or ::Reject would be ignored
anyway.

Bug: 983029
Change-Id: I87726eb04fa10b9cfef468ad31a50c0b0c97cb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719004
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681230}

This prevents attacks where a malicious renderer tries to guess a
session ID to gain access to a capture stream.

To realize this change, this CL also:
* Changes video capture controller IDs to UnguessableToken, since
  session IDs are sometimes used to initialize these values.
* Several, though not all, constants with special session ID values
  representing "No Session" or similar, have been removed as explicit
  values.Empty UnguessableTokens are used instead.
* A CHECK has been added to VideoCaptureImpl (the mojo client on the
  renderer process) to ensure that session IDs are not empty. This
  ensures a renderer crash instead of a hang in case a code path
  mistakenly tries to send empty session IDs.
* A DCHECK stating that session IDs are not zero in AudioInputIPCFactory
  (which sets up IPC on the renderer process) has been updated to
  CHECK for the same reason.
* A DCHECK was added to MediaStreamVideoCapturerSource to ensure its
  session IDs are not empty. This is an already existing assumption that
  was not stated as a DCHECK.

Bug: 775511
Change-Id: I87bb5645744c690df9d6b8e9d5db1a44260ebe96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710547Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681229}

Separate qr_scanner_view into 2 more files - preview_overlay_view & video_preview_view

Bug:986716

Change-Id: I1f7554630d07af27b365e78fadb3ae7c53cb8d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713189
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681228}

https://chromium.googlesource.com/angle/angle.git/+log/c327370e72d3..fab397e5acde


git log c327370e72d3..fab397e5acde --date=short --no-merges --format='%ad %ae %s'
2019-07-26 ianelliott@google.com Vulkan: Enforce an error when initializing a global with a non-const


Created with:
  gclient setdep -r src/third_party/angle@fab397e5acde

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=jmadill@chromium.org,jmadill@google.com

Bug: None
Change-Id: Ia69908a04c782b2c6d04c8f117f07d537382810a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719982Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681227}

This reverts commit 81209323.

Reason for revert: It's possible that the first patch of this chain of
three
patches has caused the renderer process to crash on Android, so we need to
revert this CL now in order to revert that first patch afterwards, so check
whether the crashes go away after that.

Original change's description:
> Move blink::WebSurroundingText out of the public API
> 
> This class is now only used from blink::SurroundingTextImpl, so we can
> move it down into renderer/core/editing and remove it from the public API.
> 
> Also, make the most of this move to make the new blink::SurroundingText
> class use internal Blink types (i.e. WTF::String, LocalFrame) instead of
> the public Web* types (i.e. WebString, WebLocalFrame), which will allow
> migrating blink::EditingImpl away from WebLocalFrame on a follow-up CL.
> 
> Bug: 980151, 919392
> Change-Id: I2a6ba1aa9e00603d40b4ccb9acb69f46baf5931b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699608
> Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680007}

TBR=dcheng@chromium.org,haraken@chromium.org,mario@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 980151, 919392
Change-Id: I978b040d7d9ee68d515cb7226f39edef942e61d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719349Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681226}

This CL renames mojo to mojom and *_struct_traits.* to
*_mojom_traits.* in //ui/events.

*_struct_traits.* => *_mojom_traits.*
ui/events/mojo => ui/events/mojom

Bug: 806965
Change-Id: I9dc89fe005833039b8b27cb029abdfb1255f3e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715781Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681225}

This reverts commit 58051e42.

Reason for revert: Most suspicious CL for failing paint-related test
failures as mentioned in the linked bug.

Bug: 987915

Original change's description:
> [LargestContentfulPaint] Set startTime
> 
> Currently startTime is 0, which is a problem because getEntries()
> methods all sort by startTime. To help with this problem, we set the
> startTime to renderTime, if available, or to loadTime, if renderTime is
> nt available.
> 
> Bug: 965505
> Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681147}

TBR=npm@chromium.org,yoavweiss@chromium.org

Change-Id: Ie810b8a3ac88369ab73a66670865f462f590e1ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719351Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681224}

There are several files in platform/ containing implementations of
public/platform interfaces. It'd be better to keep them all under
platform/exported for the time being. This involves moving the following
files:
- web_gesture_event.cc
- web_icon_sizes_fuzzer.cc
- web_icon_sizes_parser.cc
- web_icon_sizes_parser_test.cc
- web_mouse_event.cc
- web_mouse_wheel_event.cc
- web_pointer_event.cc
- web_screen_info_test.cc
- web_text_input_info.cc
- web_thread_type.cc
- web_touch_event.cc
- web_vector_test.cc

Bug: 919385
Change-Id: I5428aadc8ae0aaa025daf9e87a25f326772fbb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713548
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681223}

The function sent a round-trip message to the browser process in order to
synchronize shared worker startup with service worker controller info that were
sent via different mojo messages. This is no longer necessary thanks to
PlzSharedWorker because the controller info is passed via the same message with
shared worker startup (see mojom::SharedWorkerFactory::CreateSharedWorker()).

Bug: 983031
Change-Id: I37e5c412615f9b9d298e675c0d96695ce8d20687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719854Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681222}

This reverts commit 58756aea.

Reason for revert: suspected to a cause Linux Tsan failures see
crbug.com/985799

Builders failed on:
- Linux TSan Tests:
  https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests
- Linux TSan Tests:
  https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests
- Linux TSan Tests:
  https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests

Original change's description:
> Removed ProcessLifetimeObserver from TestLauncher.
>
> The goal of this cl is to move all child process logic to TestLauncher.
> This should simplify the gtest launcher structure and clarify
> each class responsibilities.
>
> TestRunner controls running test processes across sequence runners.
>
> TestLauncherDelegate is now limited to provide test specific needs.
> Command line for tests, timeout, result processing, etc.
>
> This allows us to remove the ProcessLifetimeObserver and its extending
> classes
>
> Bug: 936248
> Change-Id: I2165d9f5a295f153bd87e0155aabf9316acabfc6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677241
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Ilia Samsonov <isamsonov@google.com>
> Cr-Commit-Position: refs/heads/master@{#677409}

TBR=sky@chromium.org,erikchen@chromium.org,isamsonov@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 936248, 985799
Change-Id: I169c720169564182e3eae8dcd391ef2eeb33c225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719485Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681221}

Add StorageMonitorDummy for this case.

Bug: 760678
Change-Id: If591d891a09ccd3785a2b2255b5f02694bbe6961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711033Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681220}

When a click on a password is performed, the opened fragment loads the
data about the saved password by its ID through PasswordManagerHandlerProvider.

Bug: 377410
Change-Id: If3612580645c71701bc574ac723b35a397fb6726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709321
Commit-Queue: Ivana Zuzic <izuzic@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681219}

This reverts commit a2103b51.

Reason for revert: Only Fido Cl before failures in
FidoGetAssertionHandlerTest.* started: 
https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55166

Log: 
[ RUN      ] FidoGetAssertionHandlerTest.SuccessWithOnlyInternalTransportAllowed
=================================================================
==86183==ERROR: AddressSanitizer: requested allocation size 0xbebebe00bebebe00 (0xbebebe00bebece00 after adjustments for alignment, red zones etc.) exceeds maximum supported size of 0x10000000000 (thread T0)
    #0 0x113961c0d in __sanitizer_mz_malloc ??:0:0
    #1 0x7fff63b001bc in malloc_zone_malloc ??:0:0
    #2 0x7fff3ba12b7b in __CFStringDecodeByteStream3 ??:0:0
    #3 0x7fff3b9ee8a5 in __CFStringCreateImmutableFunnel3 ??:0:0
    #4 0x7fff3b9fc50c in CFStringCreateWithBytes ??:0:0
    #5 0x10a49f7ee in base::SysUTF8ToNSString(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) ??:0:0
    #6 0x10ab34881 in device::fido::mac::FindCredentialsImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0
    #7 0x10ab34496 in device::fido::mac::FindCredentialsInKeychain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0
    #8 0x10ab1988a in device::fido::mac::TouchIdAuthenticator::HasCredentialForGetAssertionRequest(device::CtapGetAssertionRequest const&) ??:0:0
    #9 0x10aa6c35b in device::GetAssertionRequestHandler::AuthenticatorAdded(device::FidoDiscoveryBase*, device::FidoAuthenticator*) ??:0:0
    #10 0x10aa57795 in device::FidoDeviceDiscovery::AddDevice(std::__1::unique_ptr<device::FidoDevice, std::__1::default_delete<device::FidoDevice> >) ??:0:0
    #11 0x103f5dd56 in device::FidoGetAssertionHandlerTest_SuccessWithOnlyInternalTransportAllowed_Test::TestBody() ??:0:0
    #12 0x10438ec30 in testing::Test::Run() ??:0:0
    #13 0x10439139a in testing::TestInfo::Run() ??:0:0
    #14 0x104392a26 in testing::TestSuite::Run() ??:0:0
    #15 0x1043c0236 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0
    #16 0x1043bee1c in testing::UnitTest::Run() ??:0:0
    #17 0x10a6fc90a in base::TestSuite::Run() ??:0:0
    #18 0x10a738fa1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ??:0:0
    #19 0x10a738b48 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ??:0:0
    #20 0x1040af3cc in main ??:0:0
    #21 0x7fff63957014 in start ??:0:0

==86183==HINT: if you don't care about these errors you may set allocator_may_return_null=1
SUMMARY: AddressSanitizer: allocation-size-too-big (/b/s/w/ir/out/Release/libclang_rt.asan_osx_dynamic.dylib:x86_64+0x43c0d)
==86183==ABORTING

Original change's description:
> [webauthn] Refactor Platform Discovery
> 
> This change moves the platform discovery logic from AuthenticatorCommon
> into TouchIdDiscovery, which is injected directly into
> FidoRequestHandlerBase. This streamlines the device discovery process
> for platform authenticators and allows testing them through the virtual
> authenticator environment.
> 
> Additionally, this change uncovered a bug on BLE device tests: they
> were relying on FidoRequestHandlerBase::notify_observer_callback
> never being called because SetPlatformAuthenticator wasn't called.
> 
> Bug: 981399
> Change-Id: Ic0b508c701447fb6228fd2fb8a44b4132370f330
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699947
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> Cr-Commit-Position: refs/heads/master@{#680857}

TBR=avi@chromium.org,nsatragno@chromium.org,martinkr@google.com

Change-Id: If6a20f444449936aa0fe24f7e0bd1536f9cc3989
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 981399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720237Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681218}

This reverts commit c5667854.

Reason for revert: Most likely candidate to have started the failing
TextFragmentAnchorBrowserTest.EnabledOnUserNavigation/0 tests.

Bug: 987895

Original change's description:
> Kitkat build test
> 
> Disable input for some browser and content Android tests.
> 
> 
> Disable input until we present something to the user
> 
> When a document loads, there is a significant period between when
> the frame is created and when the user sees content. During this time,
> the document is not processing lifecycle updates but Javascript is
> scheduled and the RenderWidget exists to handle input.
> 
> A major concern is that users might click on some place where there is
> something reactive laid-out and available for hit testing and processing
> (an ad, a link, start a video) before they have actually seen anything to
> click on. Think of something like a last ditch attempt to click on
> something on the page you're navigating away from only to hit something
> on the page you're navigating to.
> 
> It seems safer to avoid this rather than have unexpected and potentially
> very nasty behavior. In theory this situation was possible before with
> deferred lifecycle updates though it apparently never warranted concern.
> But we're preparing to enable the flag that defers the first compositor
> commit until we have some content ready to raster (or a timeout), in
> which case document lifecycles are running and there is content there
> to hit-test against and send events to, but the user hasn't seen it yet
> (for half a second at most, right now).
> 
> This patch adds a flag to suppress all input from the time when
> RenderWidget navigates to a frame to the time we are notified of the
> first compositor commit and paint, which is the best estimate we have
> for the user seeing something.
> 
> This patch may affect the FirstInputDelay (FID) web platform metric.
> FID may improve because dropped input won't be measured at all, and
> the delay for the first event we actually process will be smaller because
> it will come when the system is less stressed. i.e. after initial layout
> and paint. Regardless, the impact on FID will be monitored when this
> patch lands.
> 
> Tests disable this feature, with an open bug crbug.com/987626 to fix
> the tests and enable the feature.
> 
> Bug: 958424
> 
> Change-Id: I9d288b6861f88e7101d9957d1a21b6bebb38bca8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590415
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681157}

TBR=avi@chromium.org,dcheng@chromium.org,bokan@chromium.org,torne@chromium.org,schenney@chromium.org

Change-Id: If18cd4c9ae4b9d21e578e2ce46f9f9aa20f8650a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719487Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681217}

Also remove treib (who hasn't worked on this in years) and pam (who
also hasn't worked on this in years, and who isn't even working on
chromium anymore).

Bug: none
Change-Id: Icb33f4f47d8863bfbfce0720cc348d64924f1bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715499
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681216}

Bug: 927324
Change-Id: I710f718f18410cc69391f1456b0ba7f02ea9e66d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710652
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681215}

Default-installed external web apps is a 1st class subsystem in WebAppProvider.

WebAppProvider should not be a proxy between ExternalWebAppManager and
PendingAppManager: they should be connected directly.

This CL just wraps the function into a class and moves the code.
No behavior changes.

Bug: 877898
Change-Id: I95871207d9548c65a915d7b9ebe2590fa2f9d089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715515
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681214}

This reverts commit de2996a4.

Reason for revert: Causing issues with blink unit tests.

Original change's description:
> LazyLoad: Mark automatic lazyloading as experimental
> 
> This CL marks "loading" attribute support as experimental, so that WPT
> tests run with this attribute supported.
> 
> Bug: 937986
> Change-Id: I797a6e467e784c1740bdd77750f7b6a3460ca58b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700651
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680556}

TBR=kinuko@chromium.org,rajendrant@chromium.org,yoavweiss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 937986
Change-Id: Id341a39814c93140deb95447368081549a011788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719863
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681213}

This CL refactors DesktopScreenX11 to re-use ui::XDisplayManager so that
ozone and non-ozone |display::Screen| implementations share the same
core code that interacts with Xlib/XRandR.

Bug: 891175
Test: views_unittests (DesktopScreenX11Test.*)
Change-Id: I67a622f2573de2b073b6b6ab403bb068e0ec7581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715901Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681212}

Before this CL, a GN wrapper "blink_python_runner" assumed its invoker
to have inputs, outputs, and deps.

This CL makes it more flexible, i.e. to assume invoker's sources, data,
and data_deps.
This change resolves the confusing situation, for example, having |data| in
an invoker does not affect on any actions.


Bug: 839389
Change-Id: Ieecb8d07adc7f020df7de869fd15789d76c81621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718065
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681211}