GitLab

Flatten DocumentThreadableLoader into the base class, ThreadableLoader.
Same for DocumentThreadbleLoaderClient and DocumentThreadableLoaderTest.

Bug: 706331
Change-Id: Ib15340f83bc38e6c0427d829cb0490f7b3ecd2c5
Reviewed-on: https://chromium-review.googlesource.com/1045522
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577914}

This is a reland of 6ec9b32f

Mac Retina bots were down when rebaselined last time, and
they started failing when back.

Original change's description:
> [LayoutNG] Remove spaces before <br> to avoid crbug.com/40634
>
> This patch removes spaces before <br> because the images do
> not match due to crbug.com/40634, which LayoutNG does not
> have the problem.
>
> TBR=eae@chromium.org
>
> Bug: 591099
> Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49
> Reviewed-on: https://chromium-review.googlesource.com/1142050
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576333}

TBR=eae@chromium.org

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2243c930a20a1b2404854df09fbdeec4a33c9807
Reviewed-on: https://chromium-review.googlesource.com/1149640Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577913}

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug: 773382, 866540, 867027
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577912}

If the triggering element is no longer valid, update it, before
checking if a triggering a refill is necessary. While updating the
old element, check for nameless forms and unowned elements as well.
Also, if the triggering element is not filled, triggering a refill
is necessary.
Tests added.

Fixes (Desktop): etsy, staple and ysl.

Bug: 863575
Change-Id: Id9a775a31a345c5c722687df5958c55b662ebbfd
Reviewed-on: https://chromium-review.googlesource.com/1145486Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#577911}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/09f0990a2db0..cb29fbd231d6


git log 09f0990a2db0..cb29fbd231d6 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 mikenichols@chromium.org cbuildbot_launch: Wrap duration with per instance timing metric.


Created with:
  gclient setdep -r src/third_party/chromite@cb29fbd231d6

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7e5fb32ce11a19647fa35aac7ca1c89814d7604b
Reviewed-on: https://chromium-review.googlesource.com/1150046Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577910}

This is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1136730

I appear to have missed a few sites in the previous CL.

Bug: 843745
Change-Id: I541f0db2e9cf8e419a3303b7ab2a08a1df0c0372
Reviewed-on: https://chromium-review.googlesource.com/1148982
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577909}

Latest revisions from UX in comment 17 on the linked bug:

Text items reduced from 32 to 28
Container items reduced from 48 to 40 (not specced, but not doing this made
them look very weird)
Separator spacing reduced from 8pt to 4pt

Bug: 860673
Change-Id: Iad700a22eb9aad43f2c328314a6bffa885843194
Reviewed-on: https://chromium-review.googlesource.com/1148467
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577908}

A race condition exists between Account Manager's JS components'
initialization and AccountTrackerService callbacks.

Bug: 833797
Change-Id: I8eaf0d134aef4c08e089494b3ddd7d1bf7d0b2ae
Reviewed-on: https://chromium-review.googlesource.com/1150171Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577907}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I13d873174d8167e70fb45f49a415de60addfbcb9
Reviewed-on: https://chromium-review.googlesource.com/1149996
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577906}

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/common

Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /chrome/common

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: Ic8ec1308146f68a7c1bf82f850361adb3b4b63f8
Reviewed-on: https://chromium-review.googlesource.com/1150025Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577905}

https://chromium.googlesource.com/angle/angle.git/+log/096c5296c3b0..2160821e16db


git log 096c5296c3b0..2160821e16db --date=short --no-merges --format='%ad %ae %s'
2018-07-25 jmadill@chromium.org Add gl::TexLevelArray.


Created with:
  gclient setdep -r src/third_party/angle@2160821e16db

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I89a9cff4a950c4c40b323bff638a2b934313df1d
Reviewed-on: https://chromium-review.googlesource.com/1150045Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577904}

When a Background Fetch registration is created, a BGFetchJobContoller
is created immediately after committing it to storage even if the job
can't be started just yet -- this should be the scheduler's decision.

This CL is the first step in removing the assumption that each existing
Background Fetch registration is represented by a BGFetchJobController.
Acknowledging creation of the registration is separated from indicating
that a new registration is available, by adding an OnRegistrationCreated
method to the BackgroundFetchDataManagerObserver.

As part of this refactoring, in an effort to avoid passing around unique
pointers to BackgroundFetchRegistration objects, these are now passed by
const& where the receiver makes a copy when necessary. This enabled
reducing knowledge of the protobufs throughout our system, which is a
nice clean-up on its own.

TBR=avi for BUILD.gn

Bug: 850512
Change-Id: I8d3c42a11ab89f7b7c3573a6f9a21e096493b838
Reviewed-on: https://chromium-review.googlesource.com/1149871
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577903}

https://skia.googlesource.com/skia.git/+log/c062b6be5a01..42c1c03334c7


git log c062b6be5a01..42c1c03334c7 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms dad22fe0e646..4642d9fe69e1 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@42c1c03334c7

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Idf6d4304c03a18a301aa70e7cbd41e069c294be6
Reviewed-on: https://chromium-review.googlesource.com/1150042Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577902}

Change-Id: I229ea7ee210aa1a7abe3d7449294d2dcd24ce499
Reviewed-on: https://chromium-review.googlesource.com/1149921Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577901}

Change-Id: I56db43cb851f267b50664702943614bcc9b25e0d
Reviewed-on: https://chromium-review.googlesource.com/1145957Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577900}

This reverts commit e459c6e9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "fast/events/touch/gesture/* layouttests are using gpu benchmarking."
> 
> This reverts commit cb66764a.
> 
> Reason for revert: I re-wrote the flaky test.
> 
> Original change's description:
> > Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking."
> > 
> > This reverts commit 8faf0805.
> > 
> > Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103
> > 
> > Original change's description:
> > > fast/events/touch/gesture/* layouttests are using gpu benchmarking.
> > > 
> > > Bug: 846424
> > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2
> > > Reviewed-on: https://chromium-review.googlesource.com/1144230
> > > Commit-Queue: Sahel Sharify <sahel@chromium.org>
> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#577727}
> > 
> > TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org
> > 
> > Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 846424
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Reviewed-on: https://chromium-review.googlesource.com/1150180
> > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577856}
> 
> TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org
> 
> Change-Id: I3b9fcc55c7449028646d5d83958c73ed8f878312
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 846424
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1150240
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577897}

TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org

Change-Id: I41e015730a5df25f74d991f011aa15376bfd70d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846424
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1150123Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577899}

- Turns out these tests were failing because notification permissions
were switched from info bars to modals a while ago and these tests were
never updated.

Bug: 853405
Change-Id: Ia663240507a7fa674f96170c4fdcbfdc9c028ec9
Reviewed-on: https://chromium-review.googlesource.com/1145309
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577898}

This reverts commit cb66764a.

Reason for revert: I re-wrote the flaky test.

Original change's description:
> Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking."
> 
> This reverts commit 8faf0805.
> 
> Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103
> 
> Original change's description:
> > fast/events/touch/gesture/* layouttests are using gpu benchmarking.
> > 
> > Bug: 846424
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2
> > Reviewed-on: https://chromium-review.googlesource.com/1144230
> > Commit-Queue: Sahel Sharify <sahel@chromium.org>
> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577727}
> 
> TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org
> 
> Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 846424
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1150180
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577856}

TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org

Change-Id: I3b9fcc55c7449028646d5d83958c73ed8f878312
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846424
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1150240Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577897}

https://webrtc.googlesource.com/src.git/+log/b732b81e5520..e095b819400f


git log b732b81e5520..e095b819400f --date=short --no-merges --format='%ad %ae %s'
2018-07-25 titovartem@webrtc.org Move g711 to proper third_party directory


Created with:
  gclient setdep -r src/third_party/webrtc@e095b819400f

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I138d9ee7e1f891ff0feb8cbd7eb1cce64dc3b7b6
Reviewed-on: https://chromium-review.googlesource.com/1150043Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577896}

We were changing to a bold weight font in
collectionView:cellForRowAtIndexPath:.  This was causing the text to
reflow onto three lines instead of two, but the collection view didn't
know that it needed to recompute cell heights, causing a rendering
issue.  This CL works around the issue by leaving the font at a normal
weight, so that no text reflow occurs.

BUG=864495

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3ec847752dbddad8460d27f4d051952bc46fa54f
Reviewed-on: https://chromium-review.googlesource.com/1147144Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577895}

It is possible for HTMLMarqueeElement::GetAnimationParameters to return
a negative duration - this occurs when the <marquee> has no size but its
'mover' does. In this case we should not attempt to animate as this will
just throw in TimingInput::Update (as a negative duration is invalid).

Bug: 866289
Change-Id: Ifa0c2d2e8c717284670f7bddf8d350c174094f57
Reviewed-on: https://chromium-review.googlesource.com/1148887Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577894}

The following CL contains a small fix required to ensure
that it is possible to build app bundle for official Chrome
builds, which require placeholders native libraries for
older Android releases.

BUG=820459
R=benmason@chromium.org,tiborg@chromium.org
TBR=agrieve@chromium.org

Change-Id: I1fa5999c808b11c248c854f6c5131c54996d9959
Reviewed-on: https://chromium-review.googlesource.com/1150173Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577893}

These checks are not run automatically as many targets fail, but VR
shouldn't fail.

BUG=
R=vollick

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0db508b58f9c02c85559fad4c32fd45659ee736d
Reviewed-on: https://chromium-review.googlesource.com/1148980Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577892}

This change removes the now useless copied reference that is
retained by HTMLCanvas.  This was useful back when the code used
SkBitmap, which did not have copy-on-write semantics.

BUG=753483
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibc047653cbe39f1a13f99f2f2fa16743ba1d3c05
Reviewed-on: https://chromium-review.googlesource.com/1148893
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577891}

Continuation of work in bug 646094.
Preparing to activate an errorprone check to flag
context#getApplicationContext calls. The goal is to prevent storing the
resulting context as a class property, and instead use ContextUtils.

Bug: 846456
Change-Id: I0739a803ff80c38df73632f62298f83bb90d28f8
Reviewed-on: https://chromium-review.googlesource.com/1095974Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#577890}

When pointer is locked, we still need to check ShouldGenerateAppCommand
and set event handled so that won't generate unnecessary navigate
appcommand when kExtendedMouseButtons is enabled. This causes unable
to preventDefault on mouse back/forward buttons to prevent navigation
while pointer is locked.

Bug: 852709
Change-Id: I5f75a68e36037210c38310f8d83825c5efdf311e
Reviewed-on: https://chromium-review.googlesource.com/1148886
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577889}

The response format has changed. The CL implements the
change on the client.
* renaming "private_topic_name" property to "privateTopicName"

Bug: 863816, 801985
Change-Id: I7e65b095c3764f73e928a0fa0a2fb5da461eb223
Reviewed-on: https://chromium-review.googlesource.com/1146725Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577888}

LayerTreeHostImpl::ScrollLayerTo and
LayerTreeHostImpl::GetScrollOffsetForLayer looked up the cc::LayerImpl
from the active tree by layer_id, however the caller knows the element
id and this allows us to more directly look up the scroll node and ask
the scroll tree directly. This moves us towards not needing layer ids in
cc.

Bug: 865973
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic279a95592071bbd93cd4c239a5a738b6041d292
Reviewed-on: https://chromium-review.googlesource.com/1145130Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577887}

Tab helpers are attached to prerender web contents, and as a result
TabLoadTracker counts these web contentses as tabs. This CL adds
additional tracking of non-UI tabs and adds Get*TabUiCount() methods
that exclude non-UI tabs from counts.

This CL also modifies CoreTabHelperDelegates to notify TabLoadTracker
when tab contents are swapped. In that case, non-UI tabs are promoted to
UI tabs.

Bug: 861800
Change-Id: I3666b17634efd1445cd24cade8514fee06ad2c92
Reviewed-on: https://chromium-review.googlesource.com/1134504Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#577886}

This is an updated version of this previously-reverted patch:

https://codereview.chromium.org/150733002/

... along with some fixes to the treatment of left-hand scrollbars in the layout code (the need for
which was revealed by test failures).

BUG=250514
R=skobes@chromium.org,eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icd2aa1b4d40aad1272c392366fdbde81a6830478
Reviewed-on: https://chromium-review.googlesource.com/1141332Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577885}

Bug: 858944, 835983
Change-Id: Ia7908a1a199a1e537bf7ba7668116e018cbd4e61
Reviewed-on: https://chromium-review.googlesource.com/1144138Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577884}

Any SharedBitmapIds registered with a CompositorFrameSink should be
considered as destroyed by the renderer when the CompositorFrameSink
is lost, as the renderer will treat them as so and will not report when
they are deleted, and will re-register anything it wishes to reuse.

This makes RenderWidgetHostImpl::RequestCompositorFrameSink() report
all |owned_bitmaps_| as being deleted to the ServerSharedBitmapManager
so that the same bitmaps are not re-registered, and bitmaps that are
not reused are not leaked.

R=piman@chromium.org

Bug: 862584
Change-Id: I39fcbe49559f9d32eab3a52310b136f65a5f92ab
Reviewed-on: https://chromium-review.googlesource.com/1148812Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577883}

The test:
virtual/paint-touchaction-rects/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html
was marked flaky yesterday and a new bug was filed. There was actually
an existing bug for this flaky test.

This CL changes the bug number. No behavior change should be introduced.

TBR=imcheng@chromium.org

Bug: None
Change-Id: Id37d6c075cda4a50a8b49d3dc71d78caeee65506
Reviewed-on: https://chromium-review.googlesource.com/1149988Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577882}

Bug: 866927
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I25d41139da731ae998ac82e1643c8b261cf7b886
Reviewed-on: https://chromium-review.googlesource.com/1149700Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577881}

Provides support for fencing and throttling.

Change-Id: I44d9e027fbf7e78deef1b8205c918a0eebfab503
Reviewed-on: https://chromium-review.googlesource.com/1146802Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577880}

The number of settings-toggle-button elements on the
personalization_options.html page changed with
https://chromium-review.googlesource.com/c/chromium/src/+/1145315.

This CL updates the test that checks this number.

Bug: 867410
Change-Id: Ie4cca8a3305b1c8677a4e9a599ec531ff6fcab78
Reviewed-on: https://chromium-review.googlesource.com/1150157Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577879}

This patch only removes unused includes and DEPS entries.

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1c3c1456fbc6263ec7a93608fd7675a2a20eccb1
Reviewed-on: https://chromium-review.googlesource.com/1149417Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577878}

Adds a default leading image to the omnibox to be used when
it's being focused (before the first update of the leading image).
There are two images: for the empty textfield (magnifying glass)
and the non-empty textfield (default favicon).

Bug: 865000
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib9869c3b87f81041ec8a13b0ac220a3b93aa521e
Reviewed-on: https://chromium-review.googlesource.com/1146926Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577877}

This CL adds an image view to all usernames in the passwords accessory
sheet which separates username/password groups visually.
It also indicates the origin of the credentials.

The icons are loaded by origin on the native side. If icons are
requested multiple times, they will be grouped by origin and result
in only one request to the FaviconService.
Already requested icons are cached - when one of these is requested,
the callback will return synchronously instead of async.

Bug: 853748
Change-Id: Ia97c5c62710daf709d7ee19d732d2e226ac7634f
Reviewed-on: https://chromium-review.googlesource.com/1138319Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577876}

This CL delays the execution of update() for an increasing amount
of time if the calling worker doesn't control a client. The delay
is reset every time a controller is added to the worker, or an
event is dispatched. postMessage from service workers,
|install| and |activate| don't reset the delay.

Bug: 805496
Change-Id: I9c25ba4315ce6a915634ecdf6405db8774c40929
Reviewed-on: https://chromium-review.googlesource.com/900763
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577875}