GitLab

WebContentsObserver.NavigationEntryChanged is required for Tab.
The plumbing was done not through WebContentsObserver->Proxy but
from Tab native to Java directly via native WCO. This CL does it
properly.

Bug: 925242
Change-Id: I59989f3257f9249a6a07fe57ee7b6a5a07fc920e
Reviewed-on: https://chromium-review.googlesource.com/c/1481177Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636211}

No change to code, only docs.

This adds device/emulator setup instructions. This recommends the
emulator, as it's publicly available and easy to setup. For physical
devices, this points to an Android site hosting publicly available
images (and directs Googlers to internal instructions).

This also documents how to build AOSP, but recommends against doing so.
The intent is to update
https://www.chromium.org/developers/how-tos/build-instructions-android-webview
to point to this page, so I've included this for completeness.

R=ctzsm@chromium.org

Bug: 918221
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I668171e9ed76a3af36429fc9218e4b236b4dd085
Reviewed-on: https://chromium-review.googlesource.com/c/1490407Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636210}

This allows both implementations of the feature to reuse the same tests,
since only the command line flags differ between them.

Bug: 908491
Change-Id: Idd02aba393a57c8e1457b1f5f83b0cb4bcea383a
Reviewed-on: https://chromium-review.googlesource.com/c/1492891
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636209}

Allows wayland clients to register and listen for vsync events.

Bug: b/125859117
Test: Ran on device to verify vsync events are received
Change-Id: I1effc27d504f8f02922facff78648fbe4c9a7499
Reviewed-on: https://chromium-review.googlesource.com/c/1493033Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636208}

- interception-take-stream.js is only supposed to work with the network service,
    old expectations were for errors reported when it doesn't;
- xhr-interception-auth-fail.js change is due to actually changed semantics -- we
    do not prompt for auth when sending XHRs in general, but if worked before
    because we used to intercept at the lower level (URLRequestJob vs. URLLoader).

Bug: 933880
Change-Id: I3d0a1cae30b11af3ca50bd64d4123b294e42b59b
Reviewed-on: https://chromium-review.googlesource.com/c/1492046
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636207}

There was a pref name collision such that setting
kAccessibilityImageLabelsEnabled caused kAccessibilityImageLabelsOptInAccepted
to be reset. This meant that if you selected the "always" submenu option, it
would no longer remember if you'd already accepted the dialog during the
"just this once".

Bug: 905419
Change-Id: I94089366a92d76189581199c6bc1fd736b0686af
Reviewed-on: https://chromium-review.googlesource.com/c/1492043
Commit-Queue: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636206}

This fixes a Mac bug where an inactive window would be brought to front when hovering from an inactive tab to the active tab in the inactive window.

Bug: 910739
Change-Id: I186848c122b5df85b1e924d3e7dead819acb20ef
Reviewed-on: https://chromium-review.googlesource.com/c/1490445Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636205}

This patch reduces tree traversals in NGBoxFragmentPainter
when there are floating objects.

When a PaintLayer has floating objects, PaintPhase::kFloat
runs tree traversals twice, once for regular children and
another for floating children.

This patch adds HasFloatingDescendants() to
NGPhysicalContainerFragment to optimize the traversal. With
this change, we will no longer traverse normal children when
PaintPhase::kFloat, and skip traversing descendants that
don't have floating objects.

Bug: 936024
Change-Id: I1df35b788501dd39660e781b03ed76af1190e7f0
Reviewed-on: https://chromium-review.googlesource.com/c/1490355
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636204}

The |cr_fuchsia::test| namespace was added before a final decision was
reached regarding the namespace name to use for shared code under the
//fuchsia directory. For consistency, this changes usage of the
|cr_fuchsia::test| namespace to |cr_fuchsia|.

Bug: 922635
Change-Id: I731856a61745c95e45af178a08cfc1b76e75ce2a
Reviewed-on: https://chromium-review.googlesource.com/c/1488579
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636203}

kForeignFetchInterception and kRespondToSameOriginRequestWithCrossOriginResponse are no longer used.

Remove them from web_feature.mojom

Change-Id: Ifd127d46a28ea696661bece08266a2c0e933fa2b
Reviewed-on: https://chromium-review.googlesource.com/c/1491236Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636202}

Bug: 936602, 936500
Change-Id: I9265a2950c185c90da7ee07210ab7ff63f4eb5f6
Reviewed-on: https://chromium-review.googlesource.com/c/1493081
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636201}

This CL moves oom_intervention.mojom to public/mojom/oom_intervention
in order to organize mojom files at mojom folder.

TBR=avi@chromium.org

Bug: 919393
Change-Id: I0b79de25d325ff2f933e9fe7d9332ff1ac1264b8
Reviewed-on: https://chromium-review.googlesource.com/c/1482438Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#636200}

Bug: 933400
Change-Id: I2675fd4acfdd50ec76597f89b4412f9fda85cccb
Reviewed-on: https://chromium-review.googlesource.com/c/1478097
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636199}

Stops using ScreenExitCode enums reported by enrollment screens (which
is part of a larger effort to deprecate ScreenExitCode enum all together).
Instead, defines result enums per screen when needed (i.e. if the screen
can report multiple values).

Updates how screens relay the exit code to WizardController - instead of
using BaseScreenDelegate::OnExit (indirectly though
BaseScreen::Finish), the screens now take a callback that is run when
the screen exits.

Affected screens:
  * EnrollmentScreen
  * AutoEnrollmentCheckScreen

Deprecated exit codes:
  * ENTERPRISE_ENROLLMENT_COMPLETED
  * ENTERPRISE_ENROLLMENT_BACK
  * ENTERPRISE_AUTO_ENROLLMENT_CHECK_COMPLETED

  BUG=930267

Change-Id: I2ade27b1a8d8a3b1e2a0993d76d3056c63feb61a
Reviewed-on: https://chromium-review.googlesource.com/c/1484079Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636198}

Tear down all sub-components of the OzonePlatformScenic implementation
on MessageLoop destruction, to prevent components which set FIDL error-
handlers from observing ZX_ERR_CANCELED events.

MessagePumpFuchsia is also updated to print out the base::Location at
which the {ZxHandle|Fd}WatchController was created, to help in
diagnosing issues with failing asynchronous watch operations.

Bug: 927400
Change-Id: I91ad15b5a5f83c9e45b602a0647745813c55aef9
Reviewed-on: https://chromium-review.googlesource.com/c/1490953Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636197}

Histogram LevelDB.Destroy.* is currently unused as it doesn't appear in
histograms.xml, this CL removes it from leveldb_database

ProtoDB.DestroySuccess.* is currently active and captures a similar
metric

Bug: 870813
Change-Id: I9999249574de582bba3d709f06a36e35543fbba0
Reviewed-on: https://chromium-review.googlesource.com/c/1490748
Commit-Queue: Salvador Guerrero <salg@google.com>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636196}

Bug: 677338
Change-Id: I38b6632c5c57540046c93084141ba437fef80136
Reviewed-on: https://chromium-review.googlesource.com/c/1490852Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636195}

git grep -l 'NFCPushMessage' | xargs sed -i 's/NFCPushMessage/NDEFMessageSource/g'

Corresponding Spec changes:
https://github.com/w3c/web-nfc/commit/bf85df9e534da7351fc4c870228857dddef37e0e

Bug: 520391
Change-Id: I07980bfa1e68fc8959541442ddf4c83db968a52f
Reviewed-on: https://chromium-review.googlesource.com/c/1483028Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#636194}

Bug: 929840
Change-Id: I2b1d6e28105fb29db92ed94727a445e8edac3f7f
Reviewed-on: https://chromium-review.googlesource.com/c/1492292
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636193}

No sandbox isolation policies are being applied, but the default
process mitigations will now be in place when the sandbox is
enabled. The sandbox will be enabled by feature flag.

Before:

DEP (permanent)
ASLR (high entropy)
CF Guard

After (when enabled):

DEP (permanent)
ASLR (high entropy)
Dynamic code prohibited
Strict handle checks
Extension points disabled
CF Guard
Signatures restricted (Microsoft only)
Non-system fonts disabled
Images restricted (remote images, low mandatory label images)

This also adds 4Gb job process limit.

BUG=841001,920727

Change-Id: I9dc1213615e621a321b3da42772fa68d5bea3394
Reviewed-on: https://chromium-review.googlesource.com/c/1481658
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636192}

* Add a script for building symbol tarballs from ids.txt files.
* Create symbol tarballs for all packages currently deployed to CIPD.
* Adds a CIPD recipe for archiving symbol tarballs to CIPD.

Bug: 772252
Change-Id: I71fc222570ba61b832ce5c7a9a08777c8d71e120
Reviewed-on: https://chromium-review.googlesource.com/c/1478171
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636191}

NetworkStateHandler::GetNetworkStateFromGuid() can return nullptr if the
guid is not found.

BUG=887131

Change-Id: I81c948ea57197e62c5341f1291a4201060ecd374
Reviewed-on: https://chromium-review.googlesource.com/c/1491153Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636190}

The suite is not properly reporting which suites are expected to fail
to the recipe and appears to be responsible for a significant increase
in cycle time on linux-rel.

Tbr: kyleju@chromium.org
No-Try: true
Bug: 929689, 936557
Change-Id: Ibcb5959bc87cbbf76396e840f8c94fc1360e4d94
Reviewed-on: https://chromium-review.googlesource.com/c/1492775Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636189}

If SmbShareFinder::OnSharesFound early-outs on a share discovery
failure and the pending hosts count becomes 0, the final share discovery
callback won't get run and no discovered shares will be shown to the
user.

BUG=935865

Change-Id: I15e2a102b6208eb0222b706d8984175eb8d265a8
Reviewed-on: https://chromium-review.googlesource.com/c/1490356Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636188}

TBR: domenic@chromium.org
No-Try: true
Bug: 936615
Change-Id: Icb90779e1626651a20a06ca73b7c42af739528e6
Reviewed-on: https://chromium-review.googlesource.com/c/1493080Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636187}

TBR: joedow@chromium.org
Bug: 936583
Change-Id: Ic93d3c059b4e29a812256e52df49b4b942e0e650
Reviewed-on: https://chromium-review.googlesource.com/c/1492755Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636186}

This CL adds glue interfaces and setup unimplemented classes for
notification scheduler system to use platform background task scheduler
API.

TBR=peter@chromium.org

Bug: 930968
Change-Id: I01abc4edc15f4d2569ec7fb0abf012341cfa4ee5
Reviewed-on: https://chromium-review.googlesource.com/c/1470718Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636185}

Bug was due to inconsistency between the calculations in
BrowserActionsContainer::GetWidthForIconCount() and
BrowserActionsContainer::WidthToIconCount().

This does not resolve the inconsistency but instead accounts for it. We
can return to fix the inconsistency but the general feeling is that we
may end up moving away from the current BrowserActionsContainer solution
and there's a lot of other code tangled with those two functions, so a
spot fix is preferred in this case.

Bug: 935216
Change-Id: Ie38a72292dbc8975dd382bb6b23bc824dfabf677
Reviewed-on: https://chromium-review.googlesource.com/c/1491141
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636184}

Rewrite chrome://newtab to about://newtab, but don't rewrite
about://newtab twice.

Also adds unit tests.

Change-Id: I4744e84d0855c39b50076a9550aefe75812c4bf9
Reviewed-on: https://chromium-review.googlesource.com/c/1490959
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636183}

While mash was in early development we supported a number of different
inititialization paths. That has since been simplified, we should now
explicitly initialize dbus from the correct places.

Bug: 647367
Change-Id: If5ec193ffe2a8db03bf1ddfe756815fb806d8b06
Reviewed-on: https://chromium-review.googlesource.com/c/1490400Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636182}

With Mice, account consistency is enabled even when the user is not Syncing.
The X-Chrome-Connected header should always be sent.

Change-Id: I7337f41afc4273674cca75c5b34d9d66c3f18a5b
Reviewed-on: https://chromium-review.googlesource.com/c/1491615Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636181}

Currently, the page has an "Import JSON" button. Clicking it opens a
file selector; it also accepts dragged texts and files. Copying text
is arguably easier than dragging text, avoids issues with editors which
don't support dragging text, and avoids issues caused by dragged texts
containing formatting characters. The additional "Import JSON from
clipboard" buttons imports the clipboard when clicked and also supports
dragged text and files.

Bug: 891303
Change-Id: I386a8935adffe3bc33421d2c5153ff0ae0130499
Reviewed-on: https://chromium-review.googlesource.com/c/1492000
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636180}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7f6f891204d0..105fd0f651d1


git log 7f6f891204d0..105fd0f651d1 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 headlessclayton@gmail.com VkDebug.hpp: Call abort() after assert(false)
2019-02-27 headlessclayton@gmail.com CMake: Add DCHECK_ALWAYS_ON flag
2019-02-27 headlessclayton@gmail.com Fix warnings raised during release builds
2019-02-27 headlessclayton@gmail.com Suppress LLVM warnings raised during release builds.
2019-02-27 chrisforbes@google.com Return newly-created value from SpirvRoutine::createIntermediate
2019-02-27 chrisforbes@google.com Implement indexed draws
2019-02-27 sugoi@google.com Descriptor sets binding
2019-02-27 sugoi@google.com Simple PipelineBarrier implementation
2019-02-27 loganchien@google.com Fix REACTOR_USE_SUBZERO flag
2019-02-26 headlessclayton@gmail.com Add Print helpers to reactor


Created with:
  gclient setdep -r src/third_party/swiftshader@105fd0f651d1

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/126329018,chromium:b/126329018,chromium:b/123933266,chromium:b/123933266,chromium:b/126475489,chromium:b/118619338,chromium:b/115344057
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I42ec6021cf0cad3376cfb5bf178f2dbc6b1f98d9
Reviewed-on: https://chromium-review.googlesource.com/c/1492611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636179}

Currently, only headers for boolean fields have their name included in
their tooltip. On small browser windows, the displayed header names can
become truncated. To avoid confusion when interpreting "Ass..." or
"Provider & ...", this CL adds the full header names to their tooltips,
followed by a new line.

Additionally, this CL expands the tooltip for the header "URL &
URLStripped" to describe both fields; previously, it only described URL.

Bug: 891303
Change-Id: I13fedc0679aeb68c7baeab4ebd7eed227a93d889
Reviewed-on: https://chromium-review.googlesource.com/c/1491797
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636178}

Adding an newly installed extension to the ExtensionIdsMap is considered
part of the installation process and should therefore be in
BookmarkAppInstallationTask rather than in PendingAppManager.

This is the first in a series of patches to remove usage of ExtensionIdsMap
from PendingBookmarkAppManager and make PendingBookmarkAppManager a simple queue
of install/uninstall tasks. Performing pre-installation checks should be either
moved into BookmarkAppInstallationTask or into a separate class.

Bug: 877898
Change-Id: I30469f2682a3028e71390afc116d2785bb1ae2e9
Reviewed-on: https://chromium-review.googlesource.com/c/1484879Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636177}

Add switches to file_manager_uitest.cc browser_test
to disable 'ShadowDOMV0', 'CustomElementsV0', 'HTMLImports'.

The UI tests do not support loading chrome://resource URLs
and the html-imports polyfill silently fails for everything
if it encounters a resource that it can't load.

html-imports also requires polymer2.

So in order to make html-imports run with polymer2, and
without failing, all
//third_party/polymer/v1_0/components-chromium/ polymer
elements, and others in file_manager are copied
into the file_manager/test/gen directory and modified to
refer to a valid file path.

The polymer1 dir is removed, and the polymer2 directory
is renamed to polymer so that all elements now refer
to the correct path for polymer2.

Update create_test_main.py generation script to do this copying
and update paths correctly.

Deleted chrome/test/data/chromeos/file_manager/html-imports.js
There was an earlier plan to use this file with modifications,
but this file is now not needed.

Bug: 924873
Change-Id: Ie0dfdd660c26e9f8c6e4ed843dc4e35fcaa1b34f
Reviewed-on: https://chromium-review.googlesource.com/c/1488484
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636176}

This interface was used to receive the results of a call to
StartPhishingDetection on the PhishingDetector interface. It's more
flexible to pass a callback as part of StartPhishingDetection, and
removes a mojo interface.

Bug: 925464
Change-Id: I20a02e7bf8951d77fdc71d1baeb81f5afb601558
Reviewed-on: https://chromium-review.googlesource.com/c/1477940Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636175}

This will avoid missing CLs where True is used instead of true
(eg: https://chromium-review.googlesource.com/c/chromium/src/+/1459922
which is currently breaking import/export).

Change-Id: I87cfd936545506fd536e382f908391237a6e6b77
Reviewed-on: https://chromium-review.googlesource.com/c/1492671
Commit-Queue: Luke Z <lpz@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636174}

TBR: jorgelo@chromium.org
Bug: 936576
Change-Id: I83cada3c08e3cf1ba46d915d090071670f7de4bb
Reviewed-on: https://chromium-review.googlesource.com/c/1492427Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636173}

Some of the trailingButton related code wasn't being used. This CL
removes that and updates the comments to be more specific to the
trailing button.

Bug: N/A
Change-Id: I1d07dd57647f6020d76a134afb8a753174cb2eef
Reviewed-on: https://chromium-review.googlesource.com/c/1489425
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636172}