- 23 Jun, 2020 40 commits
-
-
shrekshao authored
Remove suppression for [win nvidia passthrough] conformance/buffers/buffer-data-dynamic-delay.html Tbr: kbr@chromium.org Bug: 1082826 Change-Id: I9ec1ba97527a35fbd0f29601494cb8a98a433228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255223Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#781153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9aba625ec30a..b444943db27d 2020-06-22 johnstiles@google.com Update SkString::resize to preserve string contents efficiently. 2020-06-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-06-22 jvanverth@google.com Reland "Fill in GrD3DGpu::onUpdateBackendTexture" 2020-06-22 fmalita@chromium.org [skottie] skottie_tool updates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I55d88fe51e4d3cfb05435b0f2723bd36149af54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781152}
-
Li Lin authored
Based on UI review feedback, we want to expand the scope of related info setting toggle and remove the Quick Answers sub toggle. We are going to proceed with two steps: 1. Gate the sub toggle with feature flag that is disabled by default in case we want to turn it on. 2. Clean up the sub toggle code after launch and confirmed that it doesn't significantly impact related info opt in rate. This CL is the first step. Bug: b/159166868 Test: unit tests Change-Id: Ia0e87112c69251914b3bae9ae3f3a0c0d1bc96ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250475 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781151}
-
Reilly Grant authored
This change removes the uninclusive term "master" from the name of this class. This is a better name anyways due to the symmetry with the DeclarativeUserScriptManager class. Bug: 1097189 Change-Id: Ie7bd46087103b30d52a32b397eda2a1097d99316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258357 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#781150}
-
Ian Kilpatrick authored
As per: https://github.com/w3c/csswg-drafts/issues/4645 This adds two different use-counters: 1) Determine how often we query a non-zero scroll offset. 2) Determine how often a dialog is larger than the viewport. Change-Id: I2a3532512ad29ad22e997073ae9eed80612bf4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258213 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781149}
-
David Jean authored
Change-Id: I86625fa583c7b21b665bc2e19fc0b9e4b18a282c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253745Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781148}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I7c64c8eef59adcc5906cbebc30e5c8035d07e1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259572Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781147}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592852054-fc80552e8cd021ac422e9a90f3c3c2d4420e412e.profdata to chrome-win32-master-1592866776-599fc29ec545e33b0a3ff20f5395d165563a3711.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7eee758f08144a94e29a4ce6c803b98febf2fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258671Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d09e31e. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Iea22c870455c36129b772ca7846e5b8ad4eb2951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257727Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781145}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cfbf769d5f63..7db2dceccdad 2020-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04f0b691eb4c to 74ed6cfd05c1 (20 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib2c0d1e3775b7e69b1638d3273602f22db2a20f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258377Reviewed-by:
-
Moe Ahmadi authored
Given the increase in the suggestion row heights of the Realbox in the WebUI NTP to match the Omnibox, suggestion header row height and font size should also be increased to match that of the Omnibox. Bug: 1098097 Change-Id: I31c5ccf6a98619dcbe867ef43dabaf643682087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258858Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781143}
-
Liviu Tinta authored
Bug: 1092550 Change-Id: Ib45946e26ec15d7f341c31d232cf9065dd64ac3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255426 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781142}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ac199dc2390d8240508c04d09ce838e134ec4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258952Reviewed-by:
-
Kenneth Russell authored
These are converted to RGBA16F format, which WebGLImageConversion didn't handle, and the calling code didn't detect that failure. In WebGLImageConversion, handle unpacking half-float data to 32-bit floating-point, as well as all packing conversions to the supported texture upload formats. Expand comments describing the needed conversions and remove old incorrect FIXMEs. Tested thoroughly with the enhanced image_bitmap_from_blob WebGL conformance tests in https://github.com/KhronosGroup/WebGL/pull/3100 . All versions of the test (2D/3D, all texture upload formats) pass in Chromium with this fix. Bug: 1058160 Change-Id: I6bf4e5b9370cbd471e02030858ca1e93c7b88af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253372 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781140}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3b5a5e5b9d33a8e360c0160a9d42a5806c412eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258962Reviewed-by:
-
Takashi Toyoshima authored
This change removes the last TODO in the cors-and-webview-api.md. file:///android_asset/ and file:///android_res/ are almost same with other usual file:// URLs, but still can be accessible even if AllowFileAccess is set to false. Test cases mentioned in the doc are also added to ensure legacy and current CORS behaviors. TEST=./out/a/bin/run_webview_instrumentation_test_apk -A Feature=CORS Bug: 1035366 Change-Id: I5bdb7c54e261136d099944ed3690e6892fe72c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253262 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781138}
-
Brian Sheedy authored
Deduplicates the Skia Gold code used by the Android instrumentation tests and the GPU Telemetry-based pixel tests, as they were effectively identical with only a few differences. This is accomplished by moving the majority of the code to //testing/skia_gold_common and having each test harness extend the abstract classes as necessary. Bug: 1093994 Change-Id: Icef9f22d896a82672f3c64a26d38c026bf6bd02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253147Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781137}
-
danielng authored
Updating the port forwarding UI to guidelines suggested by UX. This includes updating the port forwarding dialog in regards to error handling, adding a toast when activating a port fails and also includes adding tests for the updated features and revamping some of the older tests to be async functions. Screenshots: https://drive.google.com/drive/folders/19BU8axWIax1f-8axva5L48jR0TRbgyXb?usp=sharing Some of the mocks: go/crostini-ports-design Test: Added browser tests, revamped others, and ran tests Bug: 848127 Change-Id: I4639df00a2e37b18a93a4436cc6636cee182c165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251617Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#781136}
-
Harry Cutts authored
This is a USB wireless gamepad in the PlayStation style, which seems to be mostly available in Japan. (Amazon: https://amzn.com/B01MXY05W0) It complies with XInput. Bug: b:159368181, chromium:1096754 Test: Connect the gamepad in "X" mode, load gamepadviewer.com, and check that pressing buttons and moving axes is correctly reflected on-screen. Change-Id: Ie0758fceb09ed6b3c701672e27a4c045a231dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252469Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#781135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716bc4468192..3231e4267bf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025606,chromium:1057553,chromium:1059455,chromium:1080747,chromium:1095642,chromium:1096666 Tbr: caseq@google.com,hayato@google.com Change-Id: Ia52a3ed86e405d730315f3459faa205bd4225290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781134}
-
David Bokan authored
The text fragment highlighting can be distracting for many users and the click/tap to dismiss isn't very discoverable. To make this easier on the eyes, dismiss the highlight as soon as the user starts scrolling. Bug: 1096575 Change-Id: I42f0b12e50275e7325a3647ee7a2100527602507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255780 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#781133}
-
Xiaocheng Hu authored
The function currently uses the LayoutObject of the documentElement as the layout invalidation root, which is incorrect because there can be objects not in its subtree. For example, a modal dialog. This patch fixes it by using the LayoutView, the root of the layout tree, as the layout invalidation root. Bug: 1092411 Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738Reviewed-by:
-
Hiroki Sato authored
CL:2222068 modified ARC++ focusability and accessibility name computation so that focusable views gets name from its non-focusable descendants. We should not apply this to virtual nodes like WebView. AX-Relnotes: n/a. Bug: b:152930082 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open Gmail app. WebView nodes (leaf nodes) correctly gets focus from ChromeVox. Change-Id: I8bc7b46f1b557aa13b4953243ebbd53425f0052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256922 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781131}
-
Moe Ahmadi authored
Previously, the realbox input text would remain unchanged when the suggestion group header was being focused (say by tabbing into it) despite the selection being reset. This CL makes those behaviors consistent by clearing the realbox input in addition to resetting selection when the suggestion group header geet focused. Bug: 1095719 Change-Id: I5bcabb4c455731b0002357639555d3d1452697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258466Reviewed-by:
-
Ian Kilpatrick authored
TBR=kojii@chromium.org Bug: 974666 Change-Id: If7e93264db3afdbeddcf4f39c427bd378bf83bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258471Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#781129}
-
Sadrul Habib Chowdhury authored
Create a trace-event at the point when UMA is reported, so that it is easier to associate the UMA with the associated frames. BUG=1095186 Change-Id: Id78695d21f3178e69c6025f580c2db49a67e3360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251300 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#781128}
-
Alexandre Courbot authored
When the decoder is reset, the frame splitter should be reset as well. BUG=b:158800859 TEST=VDAtest passes on Hana-kernelnext. Change-Id: I90cd638a4240a4f85b412f4046d8b92fd5241bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257121Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#781127}
-
John Z Wu authored
This is a prerequisite to implementing post submission leak checking for passwords. Bug: 1096281 Change-Id: I7722298bf2d32e1f83afc8a61b5068fc2469e286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250932Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781126}
-
Chris Thompson authored
Bug: 1089465,1089466 Change-Id: Id5ad8fcf304a378de236ca999baa671a571ca395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258425 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781125}
-
Adam Langley authored
The PRF extension will need a new structure to hold values that |GetAssertionTask| needs, but which aren't part of the getAssertion request itself. This structure will be a second argument, but RunTask doesn't currently support more than one such argument. This CL addresses that. Change-Id: I1aad401d14ab4b7d50e98cf05a63884fa590cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255209 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781124}
-
charleszhao authored
(1)The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2235485 (2) The handwriting_recognizer.mojom related javascript files also added to the machine_learning_internals.html. Tested: unit tests passed. Bug: 1054621 Change-Id: I1332d763ba2a84e275b9d30e27fa316561e821c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237437Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781123}
-
edchin authored
TBR=thegreenfrog@chromium.org Bug: 1098117 Change-Id: I97907ef407f106292f7da22e35ea345344c54133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258860Reviewed-by:
-
Curt Clemens authored
A wrapper for OauthApiCallFlow that provides convenience methods StartPostRequest, StartPatchRequest, StartGetRequest. Change-Id: Ib44cb33dbefdd5cbe4f65821aa704c4b1431b606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227862Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#781121}
-
Sam Fortiner authored
Enabling the feature MaxOverlapBoundsForFixed and update relevant test expectations. This feature is generating good performance wins on metrics (see bug for details). Bug: 1058987 Change-Id: Id753cace6795aab715c1fe52ff301705ad5d8fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256366Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
chrome://media-appTrent Apted authored
Language has the region code stripped out, so it can obtain improper strings. A similar approach was used for chrome://help-app in r772523. chrome://media-app needs some basic scaffolding to obtain strings in the first place, which wasn't needed in r772523. Note only the untrusted frame needs updating (there are no translated strings in the host webui). Bug: b/156549136 Change-Id: I162bff0822e282b92406c48d2bd4e3f62656f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257458Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#781119}
-
Kevin Babbitt authored
Refactoring in preparation for making system color keywords compute to themselves. Remove the one-off flag for storing "is current color" and store StyleColor values directly - these will be flexible enough to retain system color keywords (and in the future, color-mix) through computed-value time. Adjust size assert for BorderValue. Net impact on the structure size is +4 bytes, and from what I can tell we don't store many of these. Bug: 1081945 Change-Id: I70b8868f49d1ea6647b57929f94e9d0bad5ad864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252577 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781118}
-
Christian Biesinger authored
In the short term, we will keep this as an internal value to implement the desired aspect-ratio behavior, where min-content will take the aspect ratio into account but we still need to be able to access the "real" min-content size to implement min-block-size: auto. In the longer term, CSS may add this as a length keyword with the same semantics and this prepares us for that. See also https://github.com/w3c/csswg-drafts/issues/5032 Bug: 1045668 Change-Id: I76a290748e186b900bdbc2c4f5db8db55f6ce04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255564 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
David Munro authored
Test: Unit tests, manual (check in logs that Cicerone was called with StartLxd) Bug: chromium:1064512 Change-Id: I97fa328acc40cc059e79ced2ea668f2eae1d53bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154640 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#781116}
-
Sophey Dong authored
Bug: 1079467, 1098052, 1098053 Change-Id: Iaf75a4b46278746572bb6212403e1efce93628be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255739Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781115}
-
Anastasia Helfinstein authored
Migrate FocusRingManager to the paradigm of global instances, rather than being managed by the NavigationManager. Stop listening for changes to the current group's position unless it is currently displayed (i.e. for the back button). AX-Relnotes: n/a. Bug: None. Change-Id: Iba6fec2590dbec3c868f79fdbe867106f08c06bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254822 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#781114}
-
