GitLab

Add histogram definition for Network.Shill.WiFi.HiddenSSIDNetworkCount.

BUG=b:163168922

Change-Id: I9d4bfed4e7ca69b50276cad2ff473d6452372579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351969
Auto-Submit: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798313}

For same-process iframes, propagate the Document-level IsXrOverlay flag,
and use the correct element as the overlay layer.

This moves the document->SetIsXrOverlay setters from xr_system to
fullscreen to ensure it gets applied consistently. There are multiple
documents that need updating when iframes are being used. (Handling
out-of-process iframes needs additional logic that's being added
in a followup CL.)

Bug: 1101193
Change-Id: Icf80e65e1b927888c6140acbc998ed90d469b5e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283823
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798312}

Passing a non-boolean type Item to a boolean type feature in
DocumentPolicyParser will cause DCHECK failure in structured
header implementation.

This CL fixes this issue.

Change-Id: I6db4a4bee4181631b2ee209895176e44faa9d23d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357512
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798311}

The testAddressIconIsNotVisibleWhenAddressStoreEmpty test case is flaky.

Bug: 1116043
Change-Id: Ibe1603dc8b11ff28558991fbc14193151df5895b
Tbr: javierrobles@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358030Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798310}

This change adds support for the new Print Preview destination
SAVE_TO_DRIVE_CROS in PDFPrinterHandler. When the user chooses
Save to Drive, PDFPrinterHandler opens the file picker
defaulted to the user's Drive directory.

Bug: 1112416
Change-Id: I0f00b95c0ca48d9c50f64052cc099791d9c07b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340516Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798309}

Bug: skia:10613
Change-Id: I41d5955848a2f0023052531147868cec92f3edd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356973
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#798308}

Fix a bug where an existing user could auto-update to M85, get
randomized into the SplitSettingsSync field trial, but end up
with OS sync disabled. This results in apps, OS preferences,
Wi-Fi configs and wallpaper not syncing.

The root cause is that when we migrate their per-data-type sync
prefs (e.g. apps -> OS apps, preferences -> OS preferences) we
were not enabling the global OS sync feature pref. That pref
has a "safe" default value of false, so OS sync was never enabled.

This does not affect new users, because they see the OOBE sync
consent dialog, which enables OS sync if the user opts in.

This CL also fixes migration of the OS wallpaper sync pref, which
should be set if the user was previously syncing both apps and
themes.

Some of the regression came from this CL, though migration wasn't
quite right before either:
https://chromium-review.googlesource.com/c/chromium/src/+/2197489

We noticed this in M85 because that's the first milestone that
contains the SplitSettingsSync trial.

Bug: 1116046
Test: added to unit_tests

Change-Id: Ie40fc2b4bdc194a16b7b756c82f1e2bc258c60ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354724
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798307}

This change is no-op as we are always creating the autofill suggestion
setting the itemTag to an empty string which'd result in the itemTag
text view's visibility to be set to GONE.

In a follow-up CL, we'll add the itemTag parameter to the
AutofillPopupBridge and populate the autofill suggestion with it. This
will be used to display the offer text in the autofill dropdown.

Bug: 1112095
Change-Id: Idbbc08565a4911d76264f3fc33e688228601e5b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350147Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798306}

that voiceover does not use them.

Bug: 1049320
Change-Id: Ic7059a1c1f2a9800afca5a711994a5e485163564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357629Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#798305}

Sets the sorting order of the tests to --order=natural, so this will
always run first (instead of being randomized).

Bug: 953991
Change-Id: If0dad58a192c7ef2c99bd3c273f1f19fe69b7575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357255Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798304}

The CL also changes the indent size of variants.pyl from 4 spaces to
2 spaces. This is so that it's format will match test_suites.pyl's
format.

Bug: 1041619
Change-Id: Ibe24a42462910f8e85cef42c8e144e102cfb3869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347322Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#798303}

This change expands the network-stack logic implementing the Trust
Tokens request signing operation to accommodate taking multiple Trust
Tokens issuers and providing one signature per issuer over the request's
canonical signing data.

The Sec-Signed-Redemption-Record header becomes a Structured Headers
list where each element's value is an issuer and its associated
parameters (basically, a dictionary associated with the list element) is
a single key-value pair { "redemption-record": <SRR> }.

The Sec-Signature header remains a Structured Headers dictionary and
gets the new logical structure
	{ "sign-request-data": <sign-request-data value>,
          "signatures": [
	    (issuer1, { "sig": <signature> "public-key": <key> }),
	    ...
	    (issuerN, { "sig": <signature> "public-key": <key> })
	    ]
        }
where the "signatures" value is a Structured Headers "parameterized
member" with an "inner" list whose elements are issuers and each of
which has "parameters" (essentially a dictionary) storing the
corresponding signature and public key. This seems to be how one
implements a nested dictionary with Structured Headers.

More background:
https://docs.google.com/document/d/1L7OPuLt9CE5VhT_bGGwp3xej3mehGF-mS1ZZOVX8yp4/edit#

Test: Expand unit tests for multiple issuers, including error handling.
Bug: 1105230
Change-Id: I559d65c94e3b815897018d1ebee36b1e038a3e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315641
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798302}

The test is flaky on Linux.

Bug: 1114038
Change-Id: I107dc2c2d8d78f10e03eae2c517766225eb1b575
Tbr: rajendrant@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357455Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798301}

This creates an end-to-end connection from the navigation stack into the
new third-party JS lib which will handle the highlighting/scrolling in
the page.

Change-Id: I95d2a0e89387708d573bfab4617fa5ff34f516c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354605
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798300}

Bug: 1115755
Change-Id: I77d48a7d14e11e5a84dd4305011adbcaf4359873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354808
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798299}

Two new classes IncognitoNotificationPresenceController and
IncognitoProfileDestroyer now bind the TabModelSelector to the
.incognito package, controlling respectively the incognito notification
and the incognito Profile destruction.

Since TabModelSelectorBase creates the TabModels only after native load,
it acts as a relay for the events. It is changed to recognize that there
are two TabModels, one normal and one incognito, so it can observe the
incognito one.

Splitting IncognitoTabModel into interface and impl keeps tests from
having to depend on IncognitoTabModelImpl.

Bug: 1109013
Change-Id: I697f8422777ec42b44ddf19af8abb82702e136a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343790
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798298}

Change-Id: I67a0f21df7e3becd2e76e4971d040e9c1c4138ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354725
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798297}

Increase offset to fit ~2 cards before triggering infinite feed. Compute
initial NTP scroll height in layout to only trigger infinite feed if the
feed has loaded.

Bug: 1085419
Change-Id: I9fccd5f135382d5574ccb6a7ce562339455c7564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355294
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798296}

This is only logged if we have a navigation to tie the event to and if
there is actually a tuning version associated with the allowed
optimization.

Privacy doc: https://docs.google.com/document/d/1XnnJrIt6Uy81_H8FBclTRS5AI7XeZcHzZNshO-DMtrU/edit

Bug: 1113287
Change-Id: If6570b62cce07b285d1129921b4e56838d0c3503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350799
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798295}

The fourth (and final) CL in implementing origin-/site-keying of
SiteInstances. https://crbug.com/1085275/#c2 lists the sequence of CLs
and what each will accomplish.

This CL adds the keying bit to SiteInfo, and updates MakeTie() and
ComputeSiteInfo() to use it. It removes the prior hack in GetSiteForURL
regarding isolated base origins, and adds/updates tests that involve
isolated base origins.

This CL also changes the order in which we check isolated origins, so
that opt-in isolation requests take precedence over command-line
isolation.

Bug: 1067389, 1085275
Change-Id: I3f91fe94a1a61a7ef272d83232a6ff4e6e3bff3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269516
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798294}

Screenshots:

Before:
• http://shortn/_z0AhPafkbB

After:
• http://shortn/_GmWk2Ou5Gb

BUG=1066273
TEST=manual inspection

Change-Id: Ic1a47ff8f02b3c30f4800040c6f176ae41d79915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356670Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/master@{#798293}

To create the dimming visual effect when showing a sheet in Big Sur,
AppKit installs a new child window of the window with the sheet,
which breaks NativeWidgetMacTest.WindowModalSheet.

Bug: 1114245
Change-Id: Ib7185441e1c52e0990caa1c92f5f773431d66775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357633
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798292}

https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..a3fcf2574157

2020-08-14 gijosh@google.com Add windows commandline to heapprofd api.
2020-08-14 fmayer@google.com Merge "Use libunwindstack warnings."
2020-08-14 lalitm@google.com Merge "Fix view-based annotation tracks in the UI."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:160400319
Tbr: perfetto-bugs@google.com
Change-Id: Ie06ebb744780cdd643af9cf9b23a94d269a471ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356566Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798291}

A Cast Streaming Session can have subsequent offer messages following
the initial offer. This CL ignores subsequent offer messages to
prevent a browser crash.

Bug: 1116185
Change-Id: Id41b7012d5669996ba81ed9e416ceaf7d1f60b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357675
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798290}

Run all the system_web_app_manager browser tests in a mode that installs
by WebApplicationInfo in addition to the old manifest install.
Also fix a missing feature where finalization misses the ChromeOSData
when installing from a WebAppInfo

Change-Id: I20a87982438d4713a0a458ba73a036288557219f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330814
Commit-Queue: Dominic Schulz <dominicschulz@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jiewei Qian  <qjw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798289}

Fix a crash caused by posting a callback to the UI thread with a pointer
to a member variable without checking that the originating object is still
alive.

Bug: 1115364
Change-Id: Idf1594e8072d6269d3a0d2e04c17a583400e71c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353396Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/master@{#798288}

Despite some attempts to fix it, the test is still a bit flaky.

Bug: 1078828
Change-Id: I16d6f8efc7aaa8c042f1f15f5887d25ffc78ea62
Tbr: olivierli@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357600Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798287}

In order to promote browser_tests to CI to be shariffed to prevent
regressions.

Bug: 1111979
Change-Id: Ia01e3a124adc5acfbbceb763fb871d845309519a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356564
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Auto-Submit: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798286}

The test was disabled due to flakiness, but it looks fine on try bots.

Bug: 1109131
Change-Id: I9f113a468e5b415344b70510918ef07e791bfd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354947
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798285}

This reverts commit 98a0a1d3.

Reason for revert: Seems this should be fixed by crrev.com/c/2354124.

Original change's description:
> Disable DownloadCallbackTest.testBasic on Android
> 
> org.chromium.weblayer.test.DownloadCallbackTest.testBasic fails on
> Android,
> https://analysis.chromium.org/p/chromium/flake-portal/flakes/
> occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUB3ZWJs
> YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl
> c3QuRG93bmxvYWRDYWxsYmFja1Rlc3QjdGVzdEJhc2ljDA,
> disable it for now until it is fixed.
> 
> TBR=jam@chromium.org
> 
> Bug: 1116248
> Change-Id: I24f0ab8414f4b17ff3689f3686e3f58682c48b37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354162
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797990}

TBR=jam@chromium.org,lanwei@chromium.org

Change-Id: I0c18d0e319ee49770b5e453af435d22a5a0a182f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116248, 1116311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357637Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798284}

Bug: 1112795
Change-Id: I2bd6282c859c93ea2a193759713d2da08d2be5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340003Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798283}

This removes the existing uptime histogram and replaces it with multiple
new histograms that are categorized by the exit cause.

Format

Bug: 1109991
Change-Id: I3d50585b860dafc55764929bd17bfa6c3fbb8241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349921Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798282}

Click the open with button at the browser url bar, then shutdown the
system, it crashes due to access the null pointer. So add the null
pointer checking to avoid the system crash.

BUG=1116344

Change-Id: I4c45983f8d626eabd98a8e0f188c32255ffbe0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353779
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798281}

We intend to make a wider rollout/experiment of the feature to discard
the code cache. No changes are expected in the lab. Update the config to
confirm no effect on bots.

Bug: 1045052
Change-Id: I5c0a6443f9cefac93391d957a1fcefffc72adea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356709Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798280}

Bug: 1111824
Change-Id: I1b95c1c1c9f1b823e9b077cc9937d0a01f302f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332317
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798279}

Bug: 1109373
Change-Id: I012f3bc8021a7c2f7fc8a2f6349db1607aa82752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354556Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#798278}

xrEndSession should only be called in the XR_ERROR_SESSION_NOT_STOPPING
per the OpenXr spec, so checking for the running state isn't necessary.

Bug: 1116111
Change-Id: I089846d868441d8cd2d6d9bd82534859966d8772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357511Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798277}

This CL fills in more impl of the capture session:
- Paints the capture region according to the current selected
  source.
- Add support for event handling.
- Pressing ESC dismisses the session, while ENTER performs
  the capture and dismisses the session.

BUG=1116137
TEST=Manual

Change-Id: Ic86fd1230dea04d8d59ed19cbf7455e70d0a7795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354567Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798276}

This test asserts that closing a parent NSWindow deallocates the child
NSWindow if the parent held the last reference. This is all well and
good, but needs to account for AppKit's habit of autoreleasing refs
to things while operating on them (eg, https://crbug.com/998773). Do this
by allowing the autorelease pool to drain before checking for dealloc.

Bug: 1114245
Change-Id: I46426f163b5fbdc3822ec4c4019c722cac787c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356910
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798275}

Before this, sometimes the standardized icons are not given a white
background circle when they appear within the shelf or launcher
suggestion chips because the icons were incorrectly being detected as
already circular shaped.

This CL changes some of constants used for circle detection so that
icons of smaller sizes are correctly detected as being non-circular.

Bug: 1115812, 1113576
Change-Id: I51e04c63457bb48bb12a1898edc4e94467169362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355493Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798274}