- 04 Mar, 2020 40 commits
-
-
Annie Sullivan authored
The UKM were removed in crrev.com/c/1988594, and I think the intention was also to remove the UMA, because LargestContentfulPaint is the metric we are exposing to users. Change-Id: Ief74c8760dfc254892d251b5a4a07160e0eeb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080815 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746809}
-
Justin Cohen authored
Change-Id: Id5ee6a44dff07e10295f997a68e982c6fefa471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085291 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746808}
-
Anna Malova authored
SetRequestHeadersCallback expects RequestHeadersCallback which is RepeatingCallback. Bug: 1007815 Change-Id: Ib0061cbff30193c1533989bc51142666cd8c073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087221 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746807}
-
Samuel Huang authored
Running an ASan build of Clank requires a one-time device set up instructions. However, the 1-line instruction in asan.md is improperly wrapped to 2 separate lines. This CL remedies the above. Bug: 978698 Change-Id: Ie0f5b403cb20a3f4e7bcbe18d56ec339f15f9059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082327Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746806}
-
Rafael Cintron authored
GetNumericHelper and DoGetFramebufferAttachmentParameter were previously allocating a std::vector of bufsize size and using it as scratch space before copying the result to the output parameter. With this change, GetNumericHelper and DoGetFramebufferAttachmentParameter are modified to write directly into the output parameter. Bug: 1057747 Change-Id: If19d353a9f7d0bc9aa513deede15afad5c05b67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084111Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746805}
-
Alice Wang authored
This CL removes the boolean FirstRunActivity.SHOW_WELCOME_PAGE since after removing the Android EDU support it is always true. Bug: 1056132 Change-Id: I8e7891d22d537364899a8a22f423cd4363e22982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074479Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746804}
-
Stepan Khapugin authored
Breaks startUpBrowserForegroundInitialization into three methods: * Code to run before any scene is created * Code to run to build up a scene/window * Code to run after at least one scene/window is created Currently these are broken down simply by the order in which they appeared in the original method. A follow-up CL will reshuffle code between these as necessary. Bug: 1045658 Change-Id: I0c40be3a88d082018a47f13bf3a0876de8cac179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087751 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746803}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4518a20e14ec..420ad1af1ef1 git log 4518a20e14ec..420ad1af1ef1 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 eshr@google.com Fix video_loopback crash when selecting all streams Created with: gclient setdep -r src/third_party/webrtc@420ad1af1ef1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I515a58750ce9138c9cb7f101a12e98d0accf2616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746802}
-
Danil Chapovalov authored
Bug: None Change-Id: Iecf24e69967e57307ec1aa8bd475c9f410dc6611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087340Reviewed-by:
-
Fergal Daly authored
Also link to debugging_with_crash_keys.md from crash_key.h. Bug: 1056426 Change-Id: I8652eae061868e0ec220a89071e738fc2fef7ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086388Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746800}
-
arthursonzogni authored
(mechanical change) Plumb the full COEP struct to several content/browser components: - EmbeddedWorkerInstance - ServiceWorkerDatabase - ServiceWorkerNewScriptLoader - ServiceWorkerUpdateChecker - ServiceWorkerVersion This is helping implementing the COEP reporting API. It fixes one TODO from: https://crbug.com/1056122. Maybe it is fixing the issue completely? I am personnally interested, because the CacheStorage is currently taking the full COEP struct, but without this patch, I only have access to the COEP.value. I need this patch to make progress on: https://crbug.com/1031542 Bug: 1056122, 1031542 Change-Id: I98e6e5e2034d6f83df7939681b661ee2fe5c1362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084996 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#746799}
-
arthursonzogni authored
Test CacheStorage responses entering in a COEP ServiceWorker are enforced against CORP/CORS. Bug: 1031542 Change-Id: Iadae43549cfca5e2b7e47676fc447b5b6104e43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084811 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Andy Paicu authored
...request. Bug: 1057981 Change-Id: I08617ef32dd46d68773e84ac5484abe10bb1b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087717 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#746797}
-
Roman Sorokin authored
* Do not wipe anchors from the uToS as it's already an embedded version * Put links from the additional tos in a plain text. Fixed: 1057957 Change-Id: Id7ae1c3a1f738017057c404f6986fadcb2158679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084552 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746796}
-
Alice Wang authored
This CL fixes the ConfirmManagedSyncDataDialogIntegrationTest by replacing the bundle null check by listener check during the recreation, since the bundle can have null value when activity gets recreated on oreo phones, this made the test flaky. Bug: 1054855 Change-Id: Id3e2d265be0c78c8415b9ed891f4d4fea8d63b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083186 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Nazerke authored
This CL modernizes the SelectorCoordinator to use |browser| in the initializer. Bug: 1029346, 1048675 Change-Id: Id337cb6313adf9ba58cbb7080a45f3cb23458e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087217Reviewed-by:
-
Greg Thompson authored
This CL adds installed_browser_version to BrowserReport and includes the pending browser version when an update is awaiting a browser restart. BUG=1043624 R=zmin@chromium.org Change-Id: I6e86c5e5641a6bda7a7eb36267d527afd347aa44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087715 Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746793}
-
Fredrik Söderquist authored
Currently there are three different methods - SubtreeChildWasAdded, SubtreeChildWillBeRemoved and SubtreeTextDidChange - that are almost identical. Most callsites call them by first getting a LayoutSVGText from LocateLayoutSVGTextAncestor and then calling the method if an appropriate ancestor is found. Instead add a static LayoutSVGText::NotifySubtreeStructureChanged which find an ancestor and calls a new merged version of the above methods, SubtreeStructureChanged. Also fold InvalidatePositioningValues() into the new method since it is it's only caller. Change-Id: I797d350acf76f6a3372d0833566313d304d16fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087400Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746792}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ie2f1535a6dd84e6fae4a106d2868ee465fe5c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085255 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's run from a loop: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=fd1f7cd492a3db415e007ab24b6ff266fddb43d8&l=773 However, most likely this parameter is not used at all: * https://crbug.com/1057572 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007805 Change-Id: I5b5d4818ebdfbcad7356f801e2e656b3116494f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083014 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746790}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ifee769d9f78a813e0540ffe007329a2246274e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085212Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: I0cbc5c04efb6e11e734c0528f330c10157fee083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083150 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746788}
-
Rainhard Findling authored
* Adds the safety check safe browsing child element * On an update state change, adapts the child icon, icon color, secondary label, and user action UI components accordingly Bug: 1015841 Change-Id: Ia7991665feb034700b7736f93d8ddbea26d641c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072224 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746787}
-
Yoichi Osato authored
This CL changes Resource to have ResourceRequestHead instead of ResourceRequest in redirect chain. That's because we don't copy request body in Resource after crrev.com/c/2059889. Change-Id: Ib85c81d82b2318e8b2f25448f32f97d9182b05f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072342Reviewed-by:
-
sandromaggi authored
This adds integration tests for Showcast actions on elements in an iFrame. The helper has been rewritten to support selecting elements in iFrames. Bug: b/143942385 Change-Id: Ida4045364de9bbbcfd27057d9ecb8cb5e8dc8284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082564 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#746785}
-
Nazerke authored
This CL modernizes the DownloadManagerCoordinator - to use the superclass -initWithBaseViewController:browser: initializer. - to remove the public property for dispatcher, webstatelist. - to use self.browser to get dispatcher, webstatelist values. Bug: 1029346, 1048402 Change-Id: Ib2efa46f23e166d7d47bdc42b0b07e6febcd840e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036101Reviewed-by:
-
Monica Basta authored
Change-Id: I9a6cf4355d7a1af684fc3cfd7f409403a44652db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087339Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#746783}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b5ecdf536e0..35645a601a73 git log 9b5ecdf536e0..35645a601a73 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 cwallez@chromium.org Roll Dawn's copy of the Vulkan headers. Created with: gclient setdep -r src/third_party/dawn@35645a601a73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I472373be677d437e18d0a833425c35108eeda77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087836Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d62881ce79c8..3f283eb209ad git log d62881ce79c8..3f283eb209ad --date=short --first-parent --format='%ad %ae %s' 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src a553ed74b7fe..1af57a3ec414 (1 commits) Created with: gclient setdep -r src/third_party/angle@3f283eb209ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Iaff143173ad37d51504cb8801e57f2bad6f70e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087838Reviewed-by:
-
Andrew Shulaev authored
Corresponding proto messages have been added in aosp/1215194, aosp/1229899, and aosp/1234331. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective event(s) only. Bug: 148777631 Change-Id: I77184a5ee9bbefad57aff9e4c5addd4d1321adcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049974Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#746780}
-
Sigurd Schneider authored
The error reporting was landed recently here: https://chromium-review.googlesource.com/c/chromium/src/+/2070409 This CL adds a layout test that checks that the new errors are actually reported via the Chrome DevTools Protocol (CDP). Note that this test relies on the --cross-origin-isolation flag to be turned on, which it is for layout tests, and we don't expect it to be turned off. If the flag gets turned off, this test will fail and needs to be disabled. Bug: chromium:1051473 Change-Id: Iaccb843923ae1b2654ea11f3eec3f5b04bd1d551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087913 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746779}
-
Stepan Khapugin authored
* Moves -createInitialUI method to SceneController * Reparents TabSwitcher * Moves the call to CustomizeUIAppearance() outside of per-window code section * Removes a DCHECK(!_mainCoordinator) that relies on an ivar in MainController (vs a lazy getter). This can be re-added when we move mainCoordinator. Bug: 1045657, 1045658 Change-Id: Ia8b91bdb9c0116b71b253b88c89d948aefe3a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084674 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL updates the comment for WebContents::ImageDownloadCallback to specify that if the image fails to download the callback will receive an empty |bitmaps| vector. This detail is necessary for: https://chromium-review.googlesource.com/c/chromium/src/+/2072344/ At the same time this CL reformats the parameter comment to match the general style used in Chromium. Bug: 926083 Change-Id: Ide1d38ff21be467085373e366423a8a27390cec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086363 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL removes some unused methods in AccountManagerFacade and cleaned FirstRunUtilsTest. Bug: 1057040 Change-Id: Ie1f8103182053d528d48b3f2a5a27ef151f3b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083452Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3aaac47e569451565acc6844a354fab50d8cab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087842Reviewed-by:
-
arthursonzogni authored
According to CSP, nonce are handled the same way for both HTMLElement and SVGElement. Both are setting the nonce when the Element is inserted, but only the HTMLElement was supporting "modifying" a nonce. It looks like a bug in Chrome found by annevk@: https://github.com/web-platform-tests/wpt/pull/21853 This patch fixes the issue. It was meant to fix the WPT test: - content-security-policy/nonce-hiding/nonces.html But it turns out it is also fixing two more tests - content-security-policy/nonce-hiding/svgscript-nonces-hidden.html - content-security-policy/nonce-hiding/svgscript-nonces-hidden-meta-sub.html Bug: 1053496 Change-Id: I872cae74817bff2f5f910dcd7864fc97426c49cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075340Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746774}
-
Vidhan authored
This CL attempts to do the following:- - Move methods unused for password generation from AutofillPopupViewDelegate to AutofillPopupController - Remove elided values from AutofillPopupBaseView and its subclasses Bug: 1045401 Change-Id: I1200513085c72d75c0fbe63a1d08d82f3e257929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071937 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746773}
-
Mohamed Amir Yosef authored
Removal of PSL matched is now supported by the LoginDatabase [1]. We can safely update the comment! [1] https://chromium-review.googlesource.com/c/chromium/src/+/2087397 Bug: 1032992 Change-Id: I4d2c2ae06a34d3206c6cccf0db93732a397c3008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083179Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#746772}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/579edae5..e1861849 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic5c7e1e308d7fc55488e28e89af2aa7b4bd00a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087112Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746771}
-
Mohamed Amir Yosef authored
Before this patch: The removal of PSL matched credentials wasn't allowed by the LoginDatabase. However, |is_public_suffix_match| isn't something the database should care about. The flag is set for convenience of the caller. After this patch: Removal of PSL matched credentials isn't blocked anymore. Change-Id: Ifaac8f5a2fb62b1d30898c2d952442fd4d6f3d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087397Reviewed-by:
-
