- 09 Jul, 2018 40 commits
-
-
Emily Hanley authored
This enables deletion of the telemetry_perf_tests isolate and the recipe code that supports it. Bug: 757933 Change-Id: I82198ff98e3d7dc189761f1468bc88b591f2a5b1 Reviewed-on: https://chromium-review.googlesource.com/1129364Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#573456}
-
Mounir Lamouri authored
Bug: None Change-Id: Idafa3fbc6214dbb15bad5c28d177296bed1926b8 Reviewed-on: https://chromium-review.googlesource.com/1129828Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#573455}
-
Kevin McNee authored
While it's still not clear why this is happening, this DumpWithoutCrashing is not providing any further information. Bug: 851958 Change-Id: Ib8066c525c94b8503caf35251c12cc804af20dc6 Reviewed-on: https://chromium-review.googlesource.com/1129858Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#573454}
-
Ryan Daum authored
- Adds a new event rewriter which (when enabled) intercepts press and release events and detects triple-tap type events. Bug: internal b/110532350 Test: unit test and manual Change-Id: I29eacc2e2402f304b534c94799d0f67f1cbc01f6 Reviewed-on: https://chromium-review.googlesource.com/1124865 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573453}
-
Daniel Murphy authored
There has been a bunch of memory-corruption-smelling crashes around this area. Changing the container to a std::map should give us more information about where this is happening, and maybe cause it to crash somewhere else. R=mek@chromium.org Bug: 845400,821371,857464 Change-Id: Ife8cb10336a4f0752db89e2bca836ed873f7c711 Reviewed-on: https://chromium-review.googlesource.com/1129849Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573452}
-
Becca Hughes authored
Do not create DisplayCutoutHostImpl automatically in WebContentsImpl BUG=859241 Change-Id: I1dff20d653d1712f529f595c3fb9d0ce08eaceeb Reviewed-on: https://chromium-review.googlesource.com/1129557Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#573451}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/916c76140064..5f2d58f235b1 git log 916c76140064..5f2d58f235b1 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 treehugger-gerrit@google.com Merge "Remove manual reference to exe_and_shlib_deps" 2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps Created with: gclient setdep -r src/third_party/perfetto@5f2d58f235b1 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845700 TBR=perfetto-bugs@google.com Change-Id: Iaf9846fbb79fc0c82c07cbf875147fef14f36374 Reviewed-on: https://chromium-review.googlesource.com/1129880 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573450}
-
Wez authored
Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky, potentially causing unexpected early-exits if run under a different RunLoop to the one intended. Bug: 844016, 859151 Change-Id: Ib38310c0feeec09dbaac6cb74ffd061476e30cf3 Reviewed-on: https://chromium-review.googlesource.com/1123763 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573449}
-
bsheedy authored
Re-adds the former VR controller deadzone as a test-only option. This should allow the tests to avoid failures due to controller noise while preventing the grid-like movement from applying the deadzone all the time. Bug: 861667 Change-Id: Ic5badf59374fa236e8b462379bf53b214328d80d Reviewed-on: https://chromium-review.googlesource.com/1129386Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573448}
-
Ran Ji authored
The message loop has to be started to post tasks on Android. Previously the message loop is started on PreEarlyInitialization(). Now we need to post tasks earlier than that. This change starts the message loop when it being created on Android. For files: android_webview/browser/aw_browser_main_parts.cc, chrome/browser/chrome_browser_main_android.cc, chromecast/browser/cast_browser_main_parts.cc, components/cronet/android/cronet_library_loader.cc, content/shell/browser/shell_browser_main_parts.cc, remoting/client/chromoting_client_runtime.cc TBR=boliu@chromium.org,yfriedman@chromium.org,halliwell@chromium.org,kapishnikov@chromium.org,mkwst@chromium.org,garykac@chromium.org Bug: 848615, 729596 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b2a2afb570096cc56339978ef8e4ba3f3f9ecc7 Reviewed-on: https://chromium-review.googlesource.com/1112958 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Ran Ji <ranj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573447}
-
David Black authored
Screen context requests are initiated and sent to the server when: - UI is shown (when not using stylus input modality). - Metalayer session is complete (when using stylus input modality). Still TODO: - Initially inactivate widget and activate after request callback runs. - Cache/show server response. Bug: b:111008970 Change-Id: Ibc2934be60bccc62e63a523384c2739a4ecfdabd Reviewed-on: https://chromium-review.googlesource.com/1129390 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#573446}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1208cbb3ec07..7219d053d56a git log 1208cbb3ec07..7219d053d56a --date=short --no-merges --format='%ad %ae %s' 2018-07-09 saza@webrtc.org Split aec and aecm into separate build targets 2018-07-09 mbonadei@webrtc.org Removing /wd4703 from rtc_base:rtc_base_generic. 2018-07-09 brandtr@webrtc.org Add unit test for JavaToNativeVideoCodecInfo. 2018-07-09 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before RTCRtpTranceiver in ObjC 2018-07-09 brandtr@webrtc.org Support injecting custom native codecs from Java. 2018-07-09 sakal@webrtc.org Change test VideoProcessor kMaxBufferedInputFrames from 10 to 20. Created with: gclient setdep -r src/third_party/webrtc@7219d053d56a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e2b918edc020c2484e1dce31855a51cd601dd24 Reviewed-on: https://chromium-review.googlesource.com/1129339Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573445}
-
Michael Thiessen authored
Looks like some code that was commented as being for autopresentation wasn't actually for autopresentation :) Code was erroneously removed in https://chromium-review.googlesource.com/c/chromium/src/+/1127850 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieb871d92ed97f6df814d51f0a508f9b7d5b1456c Reviewed-on: https://chromium-review.googlesource.com/1129855Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#573444}
-
Erik Luo authored
Stepping multiple times within 1000ms while paused can result in multiple setTimeouts scheduled to clear the inline value previews. This may result in disappearing value previews. Also, we need to clear stale value widgets after generating new ones, to ensure that values are shown for the current scope only. This CL ensures there is only one 'clear' setTimeout at any time, and that we properly clear old ones before rendering new ones. Screenshot: https://imgur.com/a/rDnzGiv Bug: 844665 Change-Id: I86178a0d825ebae2820170d666b85f3b6d09a745 Reviewed-on: https://chromium-review.googlesource.com/1066708Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#573443}
-
Nicolas Pena authored
This CL makes PerformanceEntry::entryType() a pure virtual method instead of storing |entry_type_|. It also changes the usage from String to AtomicString. Only PerformanceEventTiming keeps |entry_type_| since it can be 'event' or 'firstInput'. Since the entry type is no longer available from the PerformanceEntry constructor, we change EntryTypeEnum() to pure virtual too. Bug: 852050 Change-Id: Ie02040b52cf17c7563667ef440bbb78ae97e64c7 Reviewed-on: https://chromium-review.googlesource.com/1113671 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#573442}
-
Fredrik Söderquist authored
This flag should be a copy of the same flag in an associated HitTestLocation. In all cases where it is used we have said HitTestLocation and can use the flag from there instead. The most complicated case - HitTestResult::ResolveRectBasedTest - will return a HitTestLocation with the flag cleared, which should mean that the state invariant is maintained. EventHandlingUtil::HitTestResultInFrame as changed to take a HitTestLocation to be able to maintain this invariant a little easier. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8b8d17a4fabca725ec089f18550523a19b677c75 Reviewed-on: https://chromium-review.googlesource.com/1127939 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573441}
-
Wenzhao Zang authored
Bug: 859232 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7a2e298b8c2bab9f8e67cfd3ae6f10f0b5768963 Reviewed-on: https://chromium-review.googlesource.com/1121422Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#573440}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee7c8c3f3769..245c7310a74e git log ee7c8c3f3769..245c7310a74e --date=short --no-merges --format='%ad %ae %s' 2018-07-09 thestig@chromium.org Roll third_party/freetype/src/ 125b84800..b532d7ce7 (64 commits) Created with: gclient setdep -r src/third_party/pdfium@245c7310a74e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78acf3fd21e79b2380262aff4a87d4755e35d54d Reviewed-on: https://chromium-review.googlesource.com/1129559Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573439}
-
Kenneth Russell authored
Allow jobs to run on both 10.12.6 and 10.13.5. Bug: 856799 Tbr: ynovikov@chromium.org Change-Id: Iaec9bd5229af369aec58ae44b9bef036210ba163 Reviewed-on: https://chromium-review.googlesource.com/1129539 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573438}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7788c48..27f6e148 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7385db185a6ab7449daa7c64711dad6695fe4ee2 Reviewed-on: https://chromium-review.googlesource.com/1129383Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573437}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8fbd9d96e68b..d7890bca9b35 git log 8fbd9d96e68b..d7890bca9b35 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 tobine@google.com Skip noop draws in the frontend 2018-07-09 lucferron@chromium.org Vulkan: Flip on Y, fix for MaxTextureSizeTests 2018-07-09 lucferron@chromium.org Vulkan: Fix how the viewport is calculated with Y flip 2018-07-09 jmadill@chromium.org Allow constexpr initialization of PackedEnumMap. Created with: gclient setdep -r src/third_party/angle@d7890bca9b35 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie71e721c2cfdaa544a441e4d82fb42e7ce46851d Reviewed-on: https://chromium-review.googlesource.com/1129639Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573436}
-
Jeremy Roman authored
It has no callers and is therefore dead code. Change-Id: Id7888a8898607ac844460bf429cc81f682b56a5f Reviewed-on: https://chromium-review.googlesource.com/1126520Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573435}
-
Lei Zhang authored
Use base::debug::Alias() to prevent ICF from combining Chromium's port of sk_abort_no_print() with similar functions. BUG=860850 Change-Id: I3c45d7aa567c2bdd2098a355cbf2e56a8e82bb34 Reviewed-on: https://chromium-review.googlesource.com/1128459Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#573434}
-
Min Qin authored
When Creating a download item from history db, the item might have already imported from the in-progress db. So this DCHECK is no longer correct BUG=842245 Change-Id: Iff0c7f77f33bd910ba42602a526c914d0e12bcd7 Reviewed-on: https://chromium-review.googlesource.com/1129366Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573433}
-
Dmitry Gozman authored
There was a single BackgroundTaskRunner::PostOnBackgroundThread function in platform/threading, which makes sense to be in scheduler. Change-Id: Ibe0a53d6875c43cda0915bf8de5c15085fda12c5 Reviewed-on: https://chromium-review.googlesource.com/1128543 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573432}
-
Martin Kreichgauer authored
This adds the DeleteWebAuthnCredentials method which deletes WebAuthn credentials that have been created under a given browser profile and in a given time interval. Bug: 678128 Change-Id: I7f7b54b099c8d5cd622c70d16a510cf16f8948e6 Reviewed-on: https://chromium-review.googlesource.com/1123627 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#573431}
-
Theresa authored
* Updates EnabledStateMonitor to use a new unified consent helper method that determines whether URL-keyed anonymized data collection is enabled * Updates the EoC settings screen to open the new sync and personalization screen when unified consent is enabled. * Updates EoC settings screen text when toolbar button is enabled. BUG=829457,859564 Change-Id: I727043abeaed33d68b179e9bef8d40b1f074a0a5 Reviewed-on: https://chromium-review.googlesource.com/1124970 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#573430}
-
Alex Newcomer authored
This reverts commit 1c822163. Reason for revert: Linker failures: obj/ash/app_menu/app_menu/notification_menu_view.o:notification_menu_view.cc:function ash::NotificationMenuView::NotificationMenuView(ash::NotificationItemView::Delegate*, message_center::SlideOutController::Delegate*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function Bug: 861885 Original change's description: > cros: Add a double separator above context menu notifications > > Add and remove a double separator with NOTIFICATION_CONTAINER. > > Bug: 843761 > Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d > Reviewed-on: https://chromium-review.googlesource.com/1121243 > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573418} TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org Change-Id: I10ce18a75e80116fa8d7a530d18e979a2dfbb395 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843761 Reviewed-on: https://chromium-review.googlesource.com/1129661Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573429}
-
Khushal authored
This reverts commit 2200b6d9. The change inadvertantly disabled an optimization for low-end Android devices that releases all GPU memory when the application has been backgrounded. The optimization works by releasing all non-WebGL GpuChannels. Since this change moved the GrContext ownership to a shared object cached in the GpuChannelManager instead of per GpuChannel, it is necessary to explicitly destroy it in the channel manager during cleanup. R=ericrk@chromium.org, piman@chromium.org Bug: 860506, 854416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3f6754ce939c3f815b13a3f96cd4414f5c8a3449 Reviewed-on: https://chromium-review.googlesource.com/1129548Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573428}
-
Devlin Cronin authored
The PermissionsUpdater is responsible for updating permissions for both granted optional permissions and runtime-granted permissions (and for revoking permissions from each set). However, there are some subtle distinctions between these sets - optional permissions affect both granted and runtime-granted permission sets in preferences, whereas runtime-granted permissions only affect runtime-granted permissions. This is intentional in order to help isolate the experimental behavior for runtime host permissions. In order to properly isolate (and better document) these sets, introduce separate methods for granting/revoking optional permissions and granting/revoking runtime permissions. Update callers and tests to use the new methods, and add more test coverage to ensure that adding optional permissions affects both runtime-granted and granted permissions, whereas granting/revoking withheld permissions only affects runtime-granted permissions. Bug: 848448 TBR=atwilson@chromium.org (simple method rename in c/b/background) Change-Id: I05ac756ca87eb60cbb1a461f6d5384bcec7da15a Reviewed-on: https://chromium-review.googlesource.com/1124876Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573427}
-
Jamie Madill authored
These tests are quite flaky. Unsure of the root cause. Disable them until we can triage the failures. This should help clear up flakiness on the ANGLE CQ. Bug: 861814 Change-Id: I69c405731ee0cfe9bcb176a6ff82e0ce4ab4c1ae Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1129388Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#573426}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bea867a76a73..f6618d3f745e git log bea867a76a73..f6618d3f745e --date=short --no-merges --format='%ad %ae %s' 2018-07-09 simonhatch@chromium.org Dashboard - Add Ben as an owner 2018-07-09 chiniforooshan@chromium.org Telemetry: frame times in TBMv2 2018-07-09 cphlipot0@gmail.com Android systrace: Fix printf/scanf format compiler warnings Created with: gclient setdep -r src/third_party/catapult@f6618d3f745e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: If76b6d155d063591fee6621b5d9fd8d42a13d163 Reviewed-on: https://chromium-review.googlesource.com/1129381Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573425}
-
Jeremy Roman authored
Part of reducing the differences between the AudioNode connect/disconnect variants. Bug: 856641 Change-Id: I51cab0acd1b6ae8463dedd3b02b30e3b80dabbc7 Reviewed-on: https://chromium-review.googlesource.com/1126411Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573424}
-
Kevin McNee authored
The current logic for reusing the zoom bubble for extensions 1) prevents an extension initiated zoom change from reusing the zoom bubble even when the bubble is showing for a previous zoom change by the same extension, and 2) attributes a user initiated zoom to an extension if the extension recently initiated a zoom change. The logic for reuse is now essentially, allow reuse if the attribution hasn't changed. Bug: 849704 Change-Id: Ia4935fa84e30ab263772500f7ca566c0f5fc29be Reviewed-on: https://chromium-review.googlesource.com/1124945 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573423}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: If313108d6055ac2bf1eb0933abacaad3996c9724 Reviewed-on: https://chromium-review.googlesource.com/1127367Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#573422}
-
Koji Ishii authored
Following bot results are included. 7655 7656 7659 7664 7671 7680 7683 7687 7697 12 lines were removed and 10 lines were deflaked by consecutive results since 7649. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I59805929c4f94d914f833f3386131a4c27464092 Reviewed-on: https://chromium-review.googlesource.com/1127905 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573421}
-
Andrew Grieve authored
Change-Id: I461eccdec572979b00e076422a3589f6dbcff760 Reviewed-on: https://chromium-review.googlesource.com/1129840Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#573420}
-
Peter Mayo authored
This new test fails when using enable-blink-gen-property trees. This is the intersection of two newly launching features and may block the second one, whichever that happens to be. Bug=861824 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib632eaa5377a7a5040597e8837dfa99e06883da0 Reviewed-on: https://chromium-review.googlesource.com/1129396Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573419}
-
Alex Newcomer authored
Add and remove a double separator with NOTIFICATION_CONTAINER. Bug: 843761 Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d Reviewed-on: https://chromium-review.googlesource.com/1121243 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#573418}
-
Wez authored
Similar to the OS_POSIX && !OS_FUCHSIA sites that need cleaning up, we have a few sites which still use OS_POSIX || OS_FUCHSIA incorrectly, in this case the ProcessUtilTests concerned with kill() / signals. Bug: 854721 Change-Id: Id7896b1ca3ff3da3db6e6444eabc49bf9218de4b Reviewed-on: https://chromium-review.googlesource.com/1129632 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573417}
-