GitLab

Review URL: https://chromiumcodereview.appspot.com/10831089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149236 0039d316-1c4b-4281-b951-d872f2087c98

The last reference to the class was deleted in https://chromiumcodereview.appspot.com/10539045


BUG=138614

Review URL: https://chromiumcodereview.appspot.com/10831058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149235 0039d316-1c4b-4281-b951-d872f2087c98

Regression started by (http://crrev.com/148492).

The FilePath.BaseName().value() is a local temp object and it is not safe to
assign it to a const string reference. Use the display_name instead.

BUG=139736
TEST=lumpy

Review URL: https://chromiumcodereview.appspot.com/10828086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149234 0039d316-1c4b-4281-b951-d872f2087c98

Write whether or not the kernel supports seccomp BPF on stdout
when running unit tests.


Review URL: https://chromiumcodereview.appspot.com/10834075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149233 0039d316-1c4b-4281-b951-d872f2087c98

Used for android WebView.postUrl

HasPostData in NavigationEntry is used to indicate to the renderer that the
navigation is a http post request. The usage here is slightly overloaded.
HasPostData is set when from the renderer side for a http post request. This
change also uses it to indicate a browser initiated http post request from
PostURL. is_post is added to ViewMsg_Navigate_Params.

A BrowserInitiatedPostData field is added to NavigationEntry in order to pass
the post data to the renderer. Similar field added to ViewMsg_Navigate_Params.
This field is only used for temporarily storing and passing post data to the
renderer. Since the post data is also saved in ContentState after loading the
it is cleared when ContentState is set.

BUG=
TEST=New tests passed

Review URL: https://chromiumcodereview.appspot.com/10829044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139700

Review URL: https://chromiumcodereview.appspot.com/10823084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149231 0039d316-1c4b-4281-b951-d872f2087c98

The WebKit prefs were renamed in issue 123812. This CL fixes three
references to WebKit prefs missed in that rename.

BUG=139787


Review URL: https://chromiumcodereview.appspot.com/10826081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149230 0039d316-1c4b-4281-b951-d872f2087c98

FAILED: C:\Users\binji\dev\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 link.exe /nologo /IMPLIB:_pyautolib.pyd.lib /DLL /OUT:_pyautolib.pyd /PDB:_pyautolib.pyd.pdb @_pyautolib.pyd.rsp
LINK : fatal error LNK1104: cannot open file '../third_party/python_26/libs/python26.lib'

It seems 'libraries' aren't fixed with gyp relative path, so changed it as tools/gyp/test/win/linker-flags/library-directories.gyp does.

BUG=134540
TEST=win trybot and ninja -C out\Release _pyautolib.pyd

Review URL: https://chromiumcodereview.appspot.com/10824100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149229 0039d316-1c4b-4281-b951-d872f2087c98

When using Pepper Flash chrome://media-internals displays NaN for volume.

Volume may never be set by plugins like Pepper Flash. Fix is to only display volume information if it exists.

(Also fixed presubmit errors.)

BUG=64215
TEST=Ran on youtube and verified that volume wasn't displayed. Ran on music.google.com and verified that volume was displayed.

Review URL: https://chromiumcodereview.appspot.com/10821058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139835
NOTRY=TRUE
TBR=simonjam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10834090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149227 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149226 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149225 0039d316-1c4b-4281-b951-d872f2087c98

Uber tray UI Polish: Adjust uber tray bubble and arrow so that the uber tray bubble and app list bubble will line up at the bottom for bottom launcher, and line up at inner edge of the launcher for vertical launcher.


BUG=132772


Review URL: https://chromiumcodereview.appspot.com/10830078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149224 0039d316-1c4b-4281-b951-d872f2087c98

These headers now match the regex used in the presubmit check.

This will simplify adding a tool to check license compatibility for the Android
WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10835019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149222 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10832086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149221 0039d316-1c4b-4281-b951-d872f2087c98

Replace uses of GDataDirectory::AddEntry() with the new function in tests.
Along the way, make GDataEntry::AddEntry() private.

BUG=137725
TEST=out/Release/unit_tests --gtest_filter=GData*  && out/Release/browser_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10828083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138001
TEST=manually


Review URL: https://chromiumcodereview.appspot.com/10802028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149219 0039d316-1c4b-4281-b951-d872f2087c98

whether they are set to float across all workspaces.

BUG=133577
TEST=covered by tests
R=oshima@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139835
NOTRY=TRUE
TBR=simonjam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10834089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10827080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149216 0039d316-1c4b-4281-b951-d872f2087c98

On Windows XP and Vista, new windows don't indicate activation on the taskbar.
(the window buttons should look "pressed" on launch and new window)
This regression was introduced by http://crrev.com/104051

Limit the original fix for http://crbug.com/90386 to Windows > Vista.

BUG=90386,123473
TEST=New Chrome window appear "pressed" on the taskbar on Vista and XP. No regressions (especially not of crbug.com/90386)

Review URL: https://chromiumcodereview.appspot.com/10826058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/10807038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149214 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149213 0039d316-1c4b-4281-b951-d872f2087c98

This picks up support for None entries, which is needed for iOS.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10824109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149212 0039d316-1c4b-4281-b951-d872f2087c98

This is to make 'git clean' a no-op.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10837024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149211 0039d316-1c4b-4281-b951-d872f2087c98

Add RPH use for said notification to clear the setting affordance from the location bar.

R=bauerb@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10821059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139680
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10824110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149209 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the test case to compare SkPMColor between SkPMColor, rather than SkColor.

BUG=138933
TEST=ui_unittests --gtest_filter=PNGCodec.EncodeBGRASkBitmapDiscardTransparency

Review URL: https://chromiumcodereview.appspot.com/10831031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139819
Review URL: https://chromiumcodereview.appspot.com/10823066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149207 0039d316-1c4b-4281-b951-d872f2087c98

In FileManager when clicking on the current root while viewing the top directory, do nothing (instead of rescanning the directory).


BUG=137985


Review URL: https://chromiumcodereview.appspot.com/10834087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/chromeos_login.py
R=nirnimesh@chromium.org
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10824096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149205 0039d316-1c4b-4281-b951-d872f2087c98

1. Add option to suppress logging to omit sensitive information.
2. Change debug output to longMsg to aid debugging.

BUG=137853


Review URL: https://chromiumcodereview.appspot.com/10823093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=happier dominic


Review URL: https://chromiumcodereview.appspot.com/10824111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149203 0039d316-1c4b-4281-b951-d872f2087c98

R=gavinp


Review URL: https://chromiumcodereview.appspot.com/10829090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10816040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149198 0039d316-1c4b-4281-b951-d872f2087c98

BasicStartupComplete is not invoked for browser tests

BUG=none
TEST=no complaints about MainMenu not found when running content_browsertests on mac


Review URL: https://chromiumcodereview.appspot.com/10843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688


Review URL: https://chromiumcodereview.appspot.com/10836029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149196 0039d316-1c4b-4281-b951-d872f2087c98

This is a barebones implementation of the skia target in skia.gyp.  iOS will not
use a full skia implementation, but it will use an occasional header here and
there.  Those headers require an implementation of SkDebugf_FileLine(), so this
CL adds a barebones skia target that simply compiles skia/ext/google_logging.cc.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149193 0039d316-1c4b-4281-b951-d872f2087c98

extension from the webstore. Without that, webstore-specific permissions
checking doesn't happen, notably, whitelisted extensions requesting the
"experimental" permission (e.g. Accessibility Developer Tools) can't be
installed without enabling experimental APIs in about:flags.


Review URL: https://chromiumcodereview.appspot.com/10834082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149190 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10835027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149189 0039d316-1c4b-4281-b951-d872f2087c98