- 31 Jul, 2017 16 commits
-
-
Matt Giuca authored
The ImageLoader now std::moves the ImageFamily into the callback, rather than holding onto a reference throughout the duration of the callback. Fixes a data race in ScheduleCreatePlatformShortcut where the ImageFamily could not be safely handed off to the other thread (because the ImageLoader was still holding onto a reference). Bug: 749342 Change-Id: I1452e47c892660e5fd06e27e3a0582240a5cbcec Reviewed-on: https://chromium-review.googlesource.com/590338Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#490708}
-
Qiang Xu authored
context: In crbug.com/490597, 2x image is used for HiDPI blur issue. Then there is a CL "Migrate LauncherSearchResult to use SetBadgeIcon", https://codereview.chromium.org/1200543003, which I think it removes the proper handling of the size of this 2x loading. changes: When custom icon is loaded, resize it to proper size. HiDPI screenshot: https://screenshot.googleplex.com/2rWk8akUx99 Test: tested that it works fine now, screenshot: https://screenshot.googleplex.com/u9BapUpenhu Bug: 723021 Change-Id: If18a59e7aaeed48e9a0e88409f8672d057eb986a Reviewed-on: https://chromium-review.googlesource.com/592415Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#490707}
-
Matt Menke authored
Bug: 715695 Change-Id: I093262cfefeca6b70eb09c9d94764f4ed4f786c2 Reviewed-on: https://chromium-review.googlesource.com/583632 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#490706}
-
Kent Tamura authored
According to the specification, relative URL of base[href] should be resolved with document's fallback base URL, not document's URL. Bug: 739504 Change-Id: I811e8b14d7130873a4ffa6d45a094407f9e8a098 Reviewed-on: https://chromium-review.googlesource.com/590632Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490705}
-
Matt Giuca authored
Image: - Adds move constructor/assignment. Not technically required as Image is cheaply copyable, but this allows more efficient moving without incrementing/decrementing the refcount. Also safer for multi-threaded usage. - Removes SwapRepresentations. Was unused, and superseded by std::move. ImageFamily: - Removes copy constructor/assignment. ImageFamily can be fairly heavyweight, so it's best to move it rather than copying. Also it is heavily used across threads and accidental ImageFamily copying is responsible for data races (https://crbug.com/749342). - Adds Clone method, an explicit copy operator for use if necessary. - Adds move constructor/assignment. This should be used where possible. BUG=600237,749342 Change-Id: I00482c8440d62edb8d9fb216c3de65bf4102d153 Reviewed-on: https://chromium-review.googlesource.com/588033Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#490704}
-
Kinuko Yasuda authored
Bug: 739603 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I4ea6792a6412df74225da50db214889bb1d02a26 Reviewed-on: https://chromium-review.googlesource.com/588875Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490703}
-
Nico Weber authored
Bug: 554717 Change-Id: I5f597f879b4cca5a2ce1702b635d7c81c5e620a9 Reviewed-on: https://chromium-review.googlesource.com/593154Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490702}
-
Kunihiko Sakamoto authored
This will be used to understand the effect of YieldBetweenContentScriptRuns experiment on page load time. Bug: 636655 Change-Id: I7978daa7361c73ba5b835dbc21402b8cb7d73ae3 Reviewed-on: https://chromium-review.googlesource.com/571246Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#490701}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: Idd978a50f79ec051645fa20fc4d45164487d7d0c Reviewed-on: https://chromium-review.googlesource.com/593215Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490700}
-
meade_UTC10 authored
This reverts commit fc83d355. Reason for revert: Seems to have broken various tests on content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) webkit_tests failing on chromium.webkit/WebKit Win10 webkit_tests failing on chromium.webkit/WebKit Win7 (dbg) See http://crbug.com/750540 for more details Original change's description: > Using SwiftShader for Layout Tests on Windows > > Turing on SwiftShader for Layout Tests on Windows. > Added expectations for tests which will require rebaselining. > > Bug: 726075 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ida42b4f47061436d512230059f0ffd9240658b80 > Reviewed-on: https://chromium-review.googlesource.com/514443 > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490686} TBR=sugoi@chromium.org,kbr@chromium.org,capn@chromium.org Change-Id: Ie1c01eabb2b92cbe5cf988a7b67f0b3a76afcdf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726075, 750540 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/593068Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490699}
-
Jinsuk Kim authored
The reported crash indicates that WebContents object is null when WebContentsAccessibility object gets instantiated. This may happen if AccessibilityNodeProvider is requested after WebContents/CVC get destroyed. In which case we should not proceed to creating one but return null instead. BUG=749761 Change-Id: If74945442fd6d05f2f2090c6e0a6aca375fb04f2 Reviewed-on: https://chromium-review.googlesource.com/590887Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#490698}
-
Hiroki Nakagawa authored
This CL removes the RunningWorkerInstances set that was introduced for terminating all service workers for the leak detector[1], but no longer used. [1] https://codereview.chromium.org/413993002 Bug: 507224 Change-Id: Idcaee369cf5f4fc5c9221a0600ba8ec825369b44 Reviewed-on: https://chromium-review.googlesource.com/592995Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#490697}
-
Stuart Langley authored
I'm starting with the simplest of changes, which includes. - just changing the header file over and transitively including WebLocalFrameBase temporarily. - places where WebLocalFrameBase was being used as a local variable. I'll split this into multiple CL's to help it go through the CQ. Bug: 731490 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I40a62619be3ef4034c048f8d17e52404eccd74ab Reviewed-on: https://chromium-review.googlesource.com/590591Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#490696}
-
Matt Falkenhagen authored
Update expectation from timeout to failure after r490666. TBR=ananta NOTRY=true Bug: 715632 Change-Id: Ie7932b83bbd0e409da1ffc5d3acfad26c28f3efb Reviewed-on: https://chromium-review.googlesource.com/592999Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#490695}
-
Trent Apted authored
Arabic text rendering got fancy, so the test strings would no longer create text runs with a matching number of glyphs. Use a simpler string that just repeats the same character. Bug: 748512 Change-Id: Ia1b61d3cf564ffdc9ff22f8406e4072e06e323a4 Reviewed-on: https://chromium-review.googlesource.com/590345Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490694}
-
Trent Apted authored
One of the characters in the test got fancy causing a wild glyph to appear. Use a less fancy character. Bug: 748512 Change-Id: I22dfcf22f28326b0d9aaeea141d99704c91a8c84 Reviewed-on: https://chromium-review.googlesource.com/590339Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490693}
-
- 30 Jul, 2017 15 commits
-
-
Koji Ishii authored
The :first-letter pseudo element may not be a child of the element in style/box tree. For example: <div><span>text</span></div> creates: <div> <span> <div:first-letter>t</div:first-letter> ext </span> </div> FirstLetterPseudoElement computes this correctly on creation, but inherited from <div> on RecalcStyle(). This patch fixes the inheritance on RecalcStyle() too. Inline layout code assumes that a text box has the same style as its parent inline box. The incorrect style on FirstLetterPseudoElement breaks this assumption. Bug: 450002, 507757, 739800 Change-Id: Icda675f5ffbb705c4b87f9d23cca34f24c4763ee Reviewed-on: https://chromium-review.googlesource.com/593067Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490692}
-
Bugs Nash authored
This patch - Changed CSSParserContext argument from * to & for null safety and readability in the remaining utils files in core/css/properties - Changed the CSSPropertyParserHelpers::ConsumeCommaSeparatedList parameter pack argument to a universal reference with perfect forwarding so that reference arguments can be passed through it. Bug: 668012 Change-Id: I5e607c9a1f8e26d7848092468d666f9879711941 Reviewed-on: https://chromium-review.googlesource.com/590910Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#490691}
-
Robert Hogan authored
Bug: 714862 Change-Id: Ic584853df872456a788b3ef45a06d8c346f50516 Reviewed-on: https://chromium-review.googlesource.com/593307Reviewed-by:
Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490690}
-
Zijie He authored
This is a reland of 62d23080 Original change's description: > Implement EvaluateCapability and its tests > > This change adds --type=evaluate_capability command line parameter to execute > host binary in "evaluate capability" mode. Meanwhile a helper function > int EvaluateCapabilityForkedly() has been added to execute the host binary to > evaluate certain functionality, and retrieves its output. > > Return value is too simple for the evaluation, e.g. for DirectX capturer, both > initialization result and DirectX version are required. To make it simple, in a > coming change, we can directly output the host attributes regarding to the > DirectX capturer into console, so the network process needs not to execute any > DirectX related logic. > > Bug: 741926 > Change-Id: Ief06bed7b9297318bd387106108eccd02180e066 > Reviewed-on: https://chromium-review.googlesource.com/575730 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490121} Bug: 741926 Change-Id: I9b882afbc415613ecc3308e7e1b95806d0ae8051 TBR: joedow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/592009 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#490689}
-
Kenneth Russell authored
On current Android versions there is a race condition while sending the application to the background. The browser attempts to drain its graphics pipeline and cease rendering, but in the meantime one call to eglSwapBuffers fails. This causes the compositor's context to be lost, and since this is treated as a severe failure, it causes all active WebGL content to be blocked. To work around this problem but maintain strictness on other platforms, add a time-expiring driver bug workaround that applies to the current and next Android release. BUG=744678 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4eb1344f17b6b12cabf8964856e0645473797a8e Reviewed-on: https://chromium-review.googlesource.com/584037Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490688}
-
Jialiu Lin authored
Add function to handle warning on shown events, and warning completed events. These event handling covers UMA recording, updating security state, update cached verdicts, and etc. Bug: 741138 Change-Id: I5945a7d28244672e52bd00be67e17165b680a122 Reviewed-on: https://chromium-review.googlesource.com/585780 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#490687}
-
Alexis Hetu authored
Turing on SwiftShader for Layout Tests on Windows. Added expectations for tests which will require rebaselining. Bug: 726075 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ida42b4f47061436d512230059f0ffd9240658b80 Reviewed-on: https://chromium-review.googlesource.com/514443 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490686}
-
Nico Weber authored
This reverts commit 1d8d254c. Reason for revert: Fails on win7: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933 Original change's description: > Plumb URLs through memory_instrumentation UKMs. > > The URLs are obtained by creating a new interface CoordinationUnitIntrospector > on the resource_coordinator service. The implementation of this interface crawls > all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by > looking at associated FrameCoordinationUnits. > > The interface for memory_instrumentation is modified slightly to include pid in > ProcessMemoryDump to allow correlation between the memory dump and the URLs > obtained from resource_coordinator. In a hypothetical future world where > memory_instrumentation and resource_coordinator live in the same service, this > can be removed. > > Bug:730783 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 > Reviewed-on: https://chromium-review.googlesource.com/578482 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490668} TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org Change-Id: I0120cea65f8e95f787d15579e427b9b3bab86187 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730783 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/593213Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490685}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c25437da5c6a..50b2084bd15e $ git log c25437da5..50b2084bd --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Gradient stages cleanup Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I00a4ca54d2310622544c2d46bebf0c7607eaae9e Reviewed-on: https://chromium-review.googlesource.com/593094Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490684}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/77c6866668ac..c25437da5c6a $ git log 77c686666..c25437da5 --date=short --no-merges --format='%ad %ae %s' 2017-07-30 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: If097fa1c144652f2771683358781be930aeeb608 Reviewed-on: https://chromium-review.googlesource.com/592853Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490683}
-
meade_UTC10 authored
This reverts commit 1d8d254c. Reason for revert: Broke ProcessMemoryMetricsEmitterTest.FetchDuringTrace ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics ProcessMemoryMetricsEmitterTest.FetchThreeTimes on chromium.win/Win7 Tests (dbg)(1) First broken run: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933 Original change's description: > Plumb URLs through memory_instrumentation UKMs. > > The URLs are obtained by creating a new interface CoordinationUnitIntrospector > on the resource_coordinator service. The implementation of this interface crawls > all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by > looking at associated FrameCoordinationUnits. > > The interface for memory_instrumentation is modified slightly to include pid in > ProcessMemoryDump to allow correlation between the memory dump and the URLs > obtained from resource_coordinator. In a hypothetical future world where > memory_instrumentation and resource_coordinator live in the same service, this > can be removed. > > Bug:730783 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 > Reviewed-on: https://chromium-review.googlesource.com/578482 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490668} TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org Change-Id: I07a942b89aa22dcddd924fdcaeda025b6484b4eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730783,750476 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/593267Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490682}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: If5f382894c71980166de8f73a82a763c03e7c31f Reviewed-on: https://chromium-review.googlesource.com/593210Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490681}
-
Florin Malita authored
BUG=630695 TBR= Change-Id: I98783ed2a818cdf744c9d1652094648e79d06417 Reviewed-on: https://chromium-review.googlesource.com/593149Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#490680}
-
weili authored
Add a return status code to avoid aborting the service upon any error. Mojo verifies the validity of returned handle, will exit it is not valid. Also add unit test for this service. BUG=chromium:455764 Review-Url: https://codereview.chromium.org/2919823004 Cr-Commit-Position: refs/heads/master@{#490679}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/28a586966d58..77c6866668ac $ git log 28a586966..77c686666 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Remove stale SkTwoPointConicalGradient assert 2017-07-29 fmalita Don't instantiate degenerate 2pt gradients Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ie246fb31808c2bc4dd00bc713457e4c16c6c6e98 Reviewed-on: https://chromium-review.googlesource.com/593189Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490678}
-
- 29 Jul, 2017 9 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/93fe0ccd240c..28a586966d58 $ git log 93fe0ccd2..28a586966 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Remove now-dead SK_SUPPORT_LEGACY_GRADIENT_MATRIX_MATH code Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I7295cb3046712f64273a5b07d6685f9bea97a955 Reviewed-on: https://chromium-review.googlesource.com/592533Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490677}
-
Nico Weber authored
The major blockers for this were that gcc+libc++ (android) and clang+libstdc++4.8 (linux) didn't compile in this mode. We've since switched android from gcc to clang, and linux from libstdc++ to libc++, so this works fine everywhere now. Off-waterfall bots setting `enable_custom_libcxx` to false need to make sure that they use a libstdc++ newer than 4.8 (like the simplechrome chromeos bots), else they'll get build errors -- see the blocker bugs of the linked bug below. We'll use the same process for C++14 that we used for C++11, we'll list new features at http://chromium-cpp.appspot.com/, disallow everything at first, and then allow things over time. So don't use any C++14 stuff for now. This doesn't affect the Windows bots; cl.exe (and clang-cl.exe) have implicitly always allowed C++14. Bug: 554717 Change-Id: Ibf2a19168a35b5aad2449af9abdc44a56997aeef Reviewed-on: https://chromium-review.googlesource.com/583635Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490676}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5f9b59b52db2..93fe0ccd240c $ git log 5f9b59b52..93fe0ccd2 --date=short --no-merges --format='%ad %ae %s' 2017-07-29 liyuqian Enable delta AA by default Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I15c28e1c4d86b9380d80cff8c8b406cd0410b6e2 Reviewed-on: https://chromium-review.googlesource.com/592703Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490675}
-
Wei Li authored
PrintWebFrameHelp will be a better name since this class is associated with render frame, not web view anymore. This CL changes the class name. BUG=chromium:666548 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4843fa611509d5def25a838f555a9ab47f37203d Reviewed-on: https://chromium-review.googlesource.com/583583 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#490674}
-
Wenzhao Zang authored
As a follow-up of CL 572144, some redundant dependency needs to be removed. Please see the bug and the error log for more details. Bug: 750260 Change-Id: I00ef044160cd90aac8e39b23144eef21f29a7d31 Reviewed-on: https://chromium-review.googlesource.com/592328Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#490673}
-
Biao She authored
Remove usage of SequencedWorkerPool::GetNamedSequenceToken from WallpaperApi and WallpaperPrivateApi SequencedWorkerPool is being deprecated in favor of TaskScheduler. Bug: 667892 Change-Id: Id4b1bdfba4b5f004bea8985925f23d5211016280 Reviewed-on: https://chromium-review.googlesource.com/561657 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#490672}
-
wutao authored
Force use of render surface and cache it when there is no damage from contributing contents. This will allow us to create a caching mechanism that is simple to maintain and provides the benefits needed to make the Chrome OS UI fast. BUG=708513 TEST=manual && new damage_tracker_unittests && surface_aggregator_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2873593002 Cr-Commit-Position: refs/heads/master@{#490671}
-
Florin Malita authored
(SK_SUPPORT_LEGACY_GRADIENT_MATRIX_MATH) Change-Id: I99305d8dc64a7e4c90baaa6c3b64d907c0469284 Reviewed-on: https://chromium-review.googlesource.com/586633 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#490670}
-
Aaron Leventhal authored
We need to look for extra enums in automation.idl that are not reflected in ax_enums.idl. Bug: None Change-Id: I7cf93697f5c09fc48606b787f6ff8b3cb71081f2 Reviewed-on: https://chromium-review.googlesource.com/592054 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#490669}
-