GitLab

BUG=122913
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10854236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152386 0039d316-1c4b-4281-b951-d872f2087c98

We weren't checking the UUID in the returned service records list, so we
would always connect to the first device in the list.

BUG=none
TEST=manually


Review URL: https://chromiumcodereview.appspot.com/10829391

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152385 0039d316-1c4b-4281-b951-d872f2087c98

Buildbots (not trybots) were giving grief on past iteration of this CL:
http://codereview.chromium.org/10832345/
... so I am splitting it into smaller pieces to help identify what piece was the cause.

http://crbug.com/142962
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828395

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143272
TEST=Sign out, see policy disappear.


Review URL: https://chromiumcodereview.appspot.com/10854213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152383 0039d316-1c4b-4281-b951-d872f2087c98

This changes the color of the version label on the login
screen (shown only for dev builds, I believe) so it uses
light text with a dark outline instead of light-gray text
with a white shadow, which just looks blurry to me.

BUG=139360
TEST=version text is more readable with light and dark backgrounds

Review URL: https://chromiumcodereview.appspot.com/10837263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152382 0039d316-1c4b-4281-b951-d872f2087c98

This is a refactor and shouldn't have any visible behavioral change.

BUG=crbug.com/142945
TEST=browser_tests --single_process --gtest_filter=FullscreenControllerTest.FullscreenFileURL

Review URL: https://chromiumcodereview.appspot.com/10700117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152381 0039d316-1c4b-4281-b951-d872f2087c98

I think exiting with no error is counted as a GPU process crash for crash stats purposes.

Review URL: https://chromiumcodereview.appspot.com/10823375

TBR=apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152380 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829370

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122861
TEST=gpu bots
Review URL: https://chromiumcodereview.appspot.com/10829432

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152378 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152377 0039d316-1c4b-4281-b951-d872f2087c98

- Roll DEPS to NDK r8b
- Use 64-bit toolchain
- Use gold linker

BUG=


Review URL: https://chromiumcodereview.appspot.com/10837226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152376 0039d316-1c4b-4281-b951-d872f2087c98

Use the new BubbleDelegateView::set_anchor_insets() instead.
Remove redundant DCHECK, fix indent, revise comments.

BUG=none
TEST=No noticable changes (placement or otherwise).

Review URL: https://chromiumcodereview.appspot.com/10830366

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98

Buildbots (not trybots) were giving grief on past iteration of this CL:
http://codereview.chromium.org/10832345/
... so I am splitting it into smaller pieces to help identify what piece was the cause.

http://crbug.com/142962
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831394

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140919,143637
Review URL: https://chromiumcodereview.appspot.com/10828378

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152373 0039d316-1c4b-4281-b951-d872f2087c98

This adds the constant for the Chrome Shell package which we're
bringing up downstream at the moment.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10823410

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152371 0039d316-1c4b-4281-b951-d872f2087c98

Buildbots (not trybots) were giving grief on past iteration of this CL:
http://codereview.chromium.org/10832345/
... so I am splitting it into smaller pieces to help identify what piece was the cause.

http://crbug.com/142962
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827422

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143244

Review URL: https://chromiumcodereview.appspot.com/10837329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152369 0039d316-1c4b-4281-b951-d872f2087c98

Revert to the old behavior of WaitUntil such that it returns True when the
callable succeeds (default). Provide a way for it to return the last return
value of the callable if required.

TBR=stanleyw@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/10854229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152368 0039d316-1c4b-4281-b951-d872f2087c98

This moves the favicon bitmap data to a new table: favicon_frames.
The favicon_frame table contains columns:
icon_id
bitmap_data
last_updated
width
height

For favicons of type .ico, a single entry in the favicons table will have multiple associated frames.
For favicons of other image types, there should be a single frame for each favicon id.

Bug=138553
Test=ThumbnailDatabaseTest.*, HistoryBackendTest.* pass

Review URL: https://chromiumcodereview.appspot.com/10815068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152367 0039d316-1c4b-4281-b951-d872f2087c98

Each test only gets 3 chances to pass when running in run_test_case.py. If it fails those 3 it no longer gets to be retried running alone.


BUG=


Review URL: https://chromiumcodereview.appspot.com/10825448

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152366 0039d316-1c4b-4281-b951-d872f2087c98

This cl is intended for the beta channel.

BUG=143743
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837341

TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10854230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152364 0039d316-1c4b-4281-b951-d872f2087c98

This cl is intended for the beta channel.

BUG=143743
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837341

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152360 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834412

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152359 0039d316-1c4b-4281-b951-d872f2087c98

Intended for the beta channel.

BUG=143505
TEST=none
TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857064

TBR=rvargas@google.com

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152354 0039d316-1c4b-4281-b951-d872f2087c98

This was causing Linux ChromiumOS (dbg) browser_tests to fail with timeouts on several tests, identified with a local bisect.

- Pulse app list button while LauncherModel has STATUS_LOADING;
- Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed;
- ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and
  watch for sync finish and pending extension install. It sets
  LauncherModel::STATUS_NORMAL when sync is finished and there is no pending
  extension install from sync, or when a maximum 60 seconds timeout since
  turning on loading status;

BUG=129236
TEST=Verify sync animation after OOBE.

Review URL: https://chromiumcodereview.appspot.com/10829268

TBR=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827420

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152352 0039d316-1c4b-4281-b951-d872f2087c98

r152328 seems to cause the memorybot failure. See http://crbug.com/143715.

BUG=128088
TEST=manual
TBR=ben@chromium.org
# for chrome/chrome_browser.gypi (adding stale_cache_files_remover.[cc|h])

Review URL: https://chromiumcodereview.appspot.com/10832241

TBR=yoshiki@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152349 0039d316-1c4b-4281-b951-d872f2087c98

See the bug link for details on the crash that this CL is attempting to fix.
Although I haven't been able to reproduce the crash locally, my intuition is
that, when we call window->ShowInstant(), sometimes it tries to paint, and
since the RenderWidgetHostView hasn't yet been told that it's being shown, it
fails the DCHECK(). So, reorder the calls so that WasShown() is always called
before any change to the Instant overlay layout (ShowInstant/HideInstant).

BUG=143207
R=sky@chromium.org
TEST=Watch try bots/waterfall; Instant shouldn't fire this DCHECK().

Review URL: https://chromiumcodereview.appspot.com/10828374

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152348 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10831337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152347 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127845
TBR=thakis@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829430

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143699
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10829427

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152342 0039d316-1c4b-4281-b951-d872f2087c98

For cursors that don't have an aura-image asset, the corresponding
X11 cursor is displayed. However, in high-dpi, the default X11 cursors
are small. So always use the high-dpi default-cursor for these cases.

BUG=143268

Review URL: https://chromiumcodereview.appspot.com/10854211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152341 0039d316-1c4b-4281-b951-d872f2087c98

Don't rely on the Android toolchain being exported in the PATH for the {CC,CXX,LINK,AR}_target defines.

The make build has start using these environment variables since gyp revision
1470[1]. This works in the Chromium repository as the Android toolchain is being
exported in the PATH, which is something WebKit doesn't do, and we shouldn't
be relying on in general. Instead, use the paths to the toolchain and prefix
them with Android's goma wrapper, which yields the same effect.

[1] https://code.google.com/p/gyp/source/detail?r=1470

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10827419

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141192
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10827392

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152339 0039d316-1c4b-4281-b951-d872f2087c98

The new interface extracts the API bits from InfoBarTabHelper.  This
change switches files under chrome/browser/autofill and
chrome/browser/api to use the API and remove the temporarily-allowed
dependency on InfoBarTabHelper.

TBRing other owners as the changes are just to match the updated API and include paths.
TBR=ben@chromium.org
BUG=140037


Review URL: https://chromiumcodereview.appspot.com/10830353

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143218

Review URL: https://chromiumcodereview.appspot.com/10823394

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141008


Review URL: https://chromiumcodereview.appspot.com/10855242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152336 0039d316-1c4b-4281-b951-d872f2087c98

The mac_build.gypi will build the iossim executable using ninja.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10827200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152335 0039d316-1c4b-4281-b951-d872f2087c98

*) Set autoExpands=true for UserImagesGrid so that added items are actually created (regression after ).
*) Typo fix for old UI, which prevented it from working.

TBR=ygorshenin1
BUG=None
TEST=Manual: chrome://chrome/settings/changePicture should display the image grid properly

Review URL: https://chromiumcodereview.appspot.com/10829428

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141723
TEST=Make sure the Win8 privacy warning is shown in the advances settings UI, but ONLY when running on Win8.


Review URL: https://chromiumcodereview.appspot.com/10854126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152333 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140102
TEST=none
R=ben@chromium.org,msw@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823380

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152331 0039d316-1c4b-4281-b951-d872f2087c98