- 28 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..1170250afce4 git log a9da772f0587..1170250afce4 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 bclayton@google.com Device/Renderer: Fix uninitialized field. 2019-08-28 capn@google.com Make round-robin task enqueue index thread safe 2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn 2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count. 2019-08-27 bclayton@google.com Some minor code tidying. 2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded. 2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue. 2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers 2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct() Created with: gclient setdep -r src/third_party/swiftshader@1170250afce4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139010488,chromium:998457,chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453 Change-Id: I90209a57d73a7304378594a81314b6af3a09e184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691151}
-
Vasiliy Telezhnikov authored
This CL removes unused code from SkiaOutputDeviceGL. Bug: none Change-Id: I2fa12d13e3127c260e788af3bd1ef5a49ef0c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772692Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#691150}
-
Marc Treib authored
The reason for marking them experimental was resolved months ago. Bug: 933356 Change-Id: Ie02ea8fb15ec4f82a234640dbcc122a58c0506b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771958Reviewed-by:
smut <smut@google.com> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691149}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This CL makes background_fetch aware of the core thread instead of assuming the IO thread. This makes external/wpt/background-fetch web tests and related browser_tests pass when the feature is enabled. The conversion is fairly straightforward but some IO thread work is still required because blob building must be on the IO thread. Change-Id: I19aa33b12dec85498bc741d934a1f803bbf89474 Bug: 824858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771488 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#691148}
-
Lowell Manners authored
Disable BackForwardCache for the following tests in RenderFrameHostManagerUnloadBrowserTest: SubframeProcessGoesAwayAfterUnloadTimeout SubframeTerminationPing_Image SubframeTerminationPing_SendBeacon These tests involve unload handlers. Unload handlers are never be invoked for documents that are cached in the BackForwardCache, so the BackForwardCache must be disabled for this test to make sense. Change-Id: Ib4a0cdedcdcf069ee0e0b27ad241521ad4211777 Bug: 990354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768767Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#691147}
-
Mark Pearson authored
1. Extend Expiration for Settings.StartupPageLoadSettings 2. Remove Settings.StartupPageLoadURLs Bug: 986512 Change-Id: I0a1a6893cb6594756537d6ed73380b69ee86d16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772424Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#691146}
-
Christian Dullweber authored
The blocked badge doesn't fit well with the shield icon, so a separate icon is added to indicate when cookies were blocked. https://screenshot.googleplex.com/XeT9kWgEYqw.png Also fix an issue where the UI is not updated correctly from initial state. Bug: 967668 Change-Id: I1bfdfe8eea764c0e364c62c6db20a0c698ccf370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768467 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#691145}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I50718e83c691bd3351f7d881aeabc5be1475f1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773198Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691144}
-
Nicolas Ouellet-payeur authored
Change-Id: Ia6df2f18131b7be7c7f258612438abb646218d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773748Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#691143}
-
Mike West authored
https://chromium-review.googlesource.com/c/chromium/src/+/1765469 deflaked `fast/frames/frame-name-reset.html` but neglected to remove it from the `TestExpectations` file. This patch remedies that oversight. Bug: 993238 Change-Id: I512ad6b3feb075031088839c5b0c76c953e5856c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774438 Auto-Submit: Mike West <mkwst@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691142}
-
Edvard Thörnros authored
Changed SMILTimeContainer to step through all times where an animation stops or ends when just playing it normally. Currently it will only add slowdowns but also makes the animations more "correct". The "repeatn-remove-add-animation.html" test has been changed to work more reliably with the new stepping. This commit also fixes issue 688742 Bug: 688742, 986219, 997279 Change-Id: I7f1a68c42994eb5b080a87bd2df53cb80316ecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768765Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#691141}
-
Vadym Doroshenko authored
This CL replaces PasswordFormManager->NewPasswordFormManager. The main difference is that a constructor of form managers are different: PasswordFormManager takes PasswordForm NewPasswordFormManager takes FormData (which is converted to PasswordForm inside NewPasswordFormManager during parsing). Bug: 949519 Change-Id: Ibf4dc4bcd2d1d05ad9baa5f5568fb96c71ffea9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771959Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#691140}
-
Oskar Sundbom authored
Tbr: nator@chromium.org Bug: chromium:998466 Change-Id: I2ea87bbb861ec4ab77aa5a48905b6f8f0971c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774442Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691139}
-
Kevin Ellis authored
The test had a strict inequality test for current time based on the fact that the ready promise is typically received in the next frame after the compositor has paused the animation. However, the test is validating that the updated playback rate does not take effect too early, which would result in a big change to current time. Changing the assert from > to >= still validates what the test was designed for and accommodates some variability in the delivery time of the ready promise. The spec does not state that the time must advance before the ready promise is delivered, just that the animation client must acknowledge that it is ready. Bug: 997149 Change-Id: I1a0a5d889d6f8270560c9d4ec8e9de94b429e855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773718Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#691138}
-
Bill Budge authored
- Create an isolated copy of the response URL to avoid a crash. - Reworks code caching to avoid parsing KURL until necessary. BUG: v8:9659 Change-Id: I93bac35a4780a8da45ad615263395f5f57ee4be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773533Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#691137}
-
Javier Ernesto Flores Robles authored
To avoid maintaning dupe code, the logic to find the keyboard is consolidated in the helper. The keyboard view and its best constraining view can now be accessed as class properties. Bug: 996669 Change-Id: I4da6883539375cf99a8edf82bbf9b8fec2ba82c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765470Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#691136}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d190ff4e..d1b0195e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide0657b235b4c6dd0e699a39dd7177b89595c1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772213Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691135}
-
Antonio Gomes authored
This is phase 1.6 of the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Both .cc and .h files were moved to renderer/platform/peerconnection, and a factory method was added to [2], so its functionality keep exposed to content/. [2] //t_p/blink/public/platform/modules/peerconnection/web_rtc_video_frame_adapter_factory.h A blink::Platform method was added, namely IsWebRtcHWH264DecodingEnabled(), to support an Win7 specific quirk, related to HW decoding. Last, the switch over from base::Bind to WTF::Bind et al is left off for a follow up CL. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Iaefebd7f279a82aab8ebdf82ec53e0a9d0e4db7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771664 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#691134}
-
Andrew Luo authored
This is caused by crbug/994324. We actually don't want to disable the test in this cause since it will mask new failures. Revert "Disable failing WebView layout tests." This reverts commit f2c1c734. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable failing WebView layout tests. > > TBR=timvolodine@chromium.org > > Bug: 998478 > Change-Id: Ib7b24f28474773be6cfa6b0dc3e9f1c3a8497be3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768343 > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691112} TBR=timvolodine@chromium.org,rayankans@chromium.org Change-Id: I3eca8341ddee027bfe4d477ba8d227a949d223f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774298Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691133}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2d5aec56fdf7..85ba9972c425 git log 2d5aec56fdf7..85ba9972c425 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 kron@webrtc.org Preserve min and max playout delay from RTP header extension 2019-08-28 nisse@webrtc.org Reland "Delete mac_utils.h and mac_utils.cc" 2019-08-28 sprang@webrtc.org Removes TransportSequenceNumberAllocator 2019-08-28 kron@webrtc.org Refactor to free up PacketBuffer as soon as possible 2019-08-28 nisse@webrtc.org Consolidate FEC book-keeping Created with: gclient setdep -r src/third_party/webrtc@85ba9972c425 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:none Change-Id: Idaf20ef21fc9c79a88773c509adbd064ff0f4cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691132}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I9c1ce705f7e6d705e0c52e30fb1eda4694b66f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768980Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691131}
-
Oskar Sundbom authored
This reverts commit 90e84c72. Reason for revert: DCHECK hit when displaying Wikipedia, see: https://crbug.com/998507 Original change's description: > [LayoutNG] Improve LayoutText::SetTextWithOffset() by reducing text shaping > > This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by > reusing |ShapeResult| of before and after replaced range for improving > performance, 10% to 15% faster but 3 times slower than legacy layout. > (Profile data: http://bit.ly/33B9rfg) > > From this patch, |SetTextWithOffset()| does: > 1. Get offset mapping to map DOM offsets to text content offsets for replaced > range. > 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted > text. > 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list > in step 2. > 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse > |ShapeResult|. > > This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because > new test case replaces this test and this test call |SetTextWithOffset()| with > wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of > |"before".replaceData(1, 4, "after")|. > > Bug: 707656 > Change-Id: I078b19615d6f7e31362c1e6398aac88fb17b29c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729330 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691080} TBR=yosin@chromium.org,eae@chromium.org,kojii@chromium.org Change-Id: I25cfbae64041a61e3c2b763c709129e00f818119 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 707656, 998507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768595Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691130}
-
Nico Weber authored
Bug: none Change-Id: I5014cfa494469325cf197ebaf15a66bc4137d191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773749 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#691129}
-
Mohamed Amir Yosef authored
This CL introduces the field PasswordForm.date_last_used and make sure it's gets populated when a login is added/updated from the UI or via Sync. In addition, it migrates the data stored in login database such that any preferred login has a more recent PasswordForm.date_last_used than the non-preferred counter-part. This is in preparation to replace the "PasswordForm.preferred" field. The plan is to land this CL for M78, and in M79 we deprecate the "PasswordForm.preferred" field and use the PasswordForm.date_last_used field instead to pick the login to show to the user in case they have multiple logins with different usernames. This change will simplify the Password Manager logic especially with the upcoming Butter4Passwords. Change-Id: Id9af62764052f556f2405c4cb3123b54ba5161ab Big: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768320 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#691128}
-
henrika authored
This is a minor change on how the audio format is setup for low-latency input streams on Windows in combination with a microphone with 4 channels. Previous changes have resolved mutli-channel issues in combination with DISCRETE channel layout but this particular device reports QUAD and we must therefore change how the channel mask parameter is acquired. Before this patch we asked the device and it said QUAD but that does not match the fact that the core audio layer forces number of channels to 2 for multi-channel cases. Hence, we had a conflict of 2 channels and QUAD. With the fix below, the final format will contain 2 channels and STEREO and it resolves the issue. In summary: avoid asking the device about it channel format since it can conflict with what the CoreAudioUtil class has set. The change has been verified by a reporting user and I have tested it on other multi-channel devices as well. Bug: 933976 Change-Id: I3b566afbd35bcf3afb9684b81bf06ee9bd4daded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772877 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#691127}
-
Ivan Sandrk authored
Add a new policy type to wrap remote commands into policy data. See go/cros-secure-commands Option 1 for details. This is a sync of server side CLs cl/265498483 & cl/265476022. Bug: 891222 Change-Id: I018ee312c9a5856112cb4a2b02a2bdc4a2a62e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774439 Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691126}
-
Antonio Gomes authored
This is phase 1.5 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ rtc_stats.cc|h define various classes, eg RTCStats, RTCStatsMember and RTCStatsReport. This CL moves both cc and h files to renderer/platform/peerconnection, and exposes factory methods to their functionality keep being accessible to content/ The factory methods are placed on the existing header web_rtc_stats.h. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0255c8283175d15aa6b4558f4486b371c67c8b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772550 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#691125}
-
Huanzhong Huang authored
Surface the cookie controls toggle in privacy settings. Implemented behind the ImprovedCookieControls flag. Bug: 967668 Change-Id: I0ed43b7ac7f3022c1678261a372aa8aa0e1964f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677170 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#691124}
-
Oskar Sundbom authored
This reverts commit 62dc00e2. Reason for revert: The test is flaky, see: https://crbug.com/998467 Original change's description: > Detects a client redirect loop with DeferAllScript > > Navigating to some websites with DeferAllScript enabled for that site > could cause a client redirect loop. A previous CL > (https://chromium-review.googlesource.com/c/chromium/src/+/1739493) > implemented this in a different way but that CL is not > mergeable back. > > This CL alternates it in a different way which also fixes the problem > and can be merged back. > > All the logic is behind a finch parameter and so can be easil turned off > using finch. > > Tested by commenting out the older code. This will also > be tested by beta builders using browser tests. > > Change-Id: Icb1075580d12890fe0ee9e902925eaf212744d37 > Bug: 987062 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760667 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Auto-Submit: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690983} TBR=tbansal@chromium.org,dougarnett@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,mcrouse@chromium.org Change-Id: I92ea7e5e01a0c7471510dea85f1b7edc57a49233 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987062, 998467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768345Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691123}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6bdad04c621..8e42ececca71 git log b6bdad04c621..8e42ececca71 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 rmcilroy@chromium.org [Tracing] Remove runtimeStatsMetric Created with: gclient setdep -r src/third_party/catapult@8e42ececca71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:688342 Change-Id: I9fec171cf61aff5043c6379dcb274f2ccbd87e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691122}
-
Jan Krcal authored
This reverts commit 55420155. Reason for revert: We've instrumented a critical path that we're suspecting with debugging logs (https://chromium-review.googlesource.com/c/chromium/src/+/1771904). And we need to see a few flakes of the tests to look in the logs. I'll disable it again soon after. Original change's description: > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan > > The test is disabled due to high flakiness. > > TBR: treib@chromium.org > Bug: 997912 > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690763} TBR=treib@chromium.org,jkrcal@chromium.org Change-Id: I575243fb135ea5fe6cbcd0669f366b7eef51e456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774282Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691121}
-
Marc Treib authored
plus corresponding chrome://flags entry. It doesn't do anything yet. Bug: 998455 Change-Id: I8bb339702528bde41d451a6b4d57e41f61835b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768342Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691120}
-
Rayan Kanso authored
Bug: 980291 Change-Id: I951ce25bb15e17f48b974f30a8b8e074f83f8e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771975 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#691119}
-
Robert Sesek authored
OCMock prior to 3.3 is thread-hostile, and Chromium uses v3.1.5 currently. This is causing memory errors under ASan. Bug: 997782 Change-Id: I987139e2e1bc89743d8e51956010b8738cfdce7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773542Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691118}
-
Jérôme Lebel authored
SigninPromoViewMediator should not send update notification to its consumer when the sign-in is in progress. This is to avoid updating the sign-in promo from cold state to warm state while the sign-in is not over. Bug: 986746 Change-Id: I4f4386034549394eb556e6e48254d97dc4590656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718370 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#691117}
-
Christian Dullweber authored
Add a page action icon and a bubble view to control third-party cookie blocking. Replaces the "Cookies blocked" icon when enabled. https://screenshot.googleplex.com/3jFhD5uJj1W.png Bug: 967668 Change-Id: Id498f3f569ef940d1cb277dc8ea629c7de329cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685382 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691116}
-
Yasmin authored
Before: One device: Send to pixel 2XL Multiple device: Send to devices After: One device: https://screenshot.googleplex.com/h7ggmzB8TZz Multiple device: https://screenshot.googleplex.com/mduLZUSpqLb Bug: 996676 Change-Id: I775de0d561859b21f5b8ebf6721aa19fcea005c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768591Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691115}
-
Marc Treib authored
After crrev.com/c/1768775 it's unused, except for some tests. Some of these are updated to use GROUP_PASSWORD instead (the only remaining non-UI non-USS group, which will actually also be removed soon), and some, where that was not easily possible, are just removed. Bug: 853688 Change-Id: I361e27bfb85c22b781498ee4468b9f6dd57dbcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773138Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691114}
-
Jake Hughes authored
This is the first CL of an artefact investigating precise stack map support for garbage collection in Blink / V8 using experimental LLVM features. The bulk of this change is made up of two main components: - A parser for reading the .llvm_stackmap section (generated by LLVM) into a table for use by the GC. - A simple stack walking mechanism, which, once called, traverses the call stack bottom up frame by frame searching for a gc rootset in the root table. This also fleshes out a few helper API functions (see gc/gc_api.h) which can be used when calling into the gc library from user code. The idea for this gc/ directory is to be compiled as a library. It is then linked to user code which has be compiled with the relevent LLVM IR passes for generating stack maps at pre-defined safepoints. The code for which will be forthcoming in a separate CL. Bug: 978892 Change-Id: Ia2cb40881460b6a084babab9986df6c5303b41f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768770 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691113}
-
Rayan Kanso authored
TBR=timvolodine@chromium.org Bug: 998478 Change-Id: Ib7b24f28474773be6cfa6b0dc3e9f1c3a8497be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768343Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#691112}
-