- 17 Jun, 2020 40 commits
-
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#779331}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Id378f4f3ceaabbfeabb83a02779708f5707c4fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248762 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779330}
-
Fred Mello authored
This change will make sure that the availability logger ignores previously failed attempts. Bug: 1095136 Change-Id: I129bd9b2357fd831fe9a82749cdde2b85390ef85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248866Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779329}
-
Mikhail Khokhlov authored
Sched slices with utid = 0 correspond to the time when CPU is idle, so they don't contribute to the total power consumption. Bug: b/155073796 Change-Id: I072b2e9bb8984161518634633d9b4a7bf411eceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247893Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#779328}
-
Kent Tamura authored
Moves the following functions: - NGInlineLayoutAlgorithm::ComputeAnnotationOverflow() - LastLineTextLogicalBottom() in ng_block_layout_algorithm.cc - FirstLineTextLogicalTop() in ng_block_layout_algorithm.cc This CL has no behavior changes. Bug: 1069817 Change-Id: Ie59211a2644f81a4e43bcde5f7010f8765b2955a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249431 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779327}
-
Kristian Kirs authored
In this case compiler warns about function declared never referenced. Change-Id: If8f7458c930890182c74e776dd31bb168956a693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246167 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#779326}
-
Mike Wittman authored
https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc491a..11659d420a71 $ git log 046920fc4..11659d420 --date=short --no-merges --format='%ad %ae %s' 2020-06-15 wittman Make new upstream version build with Chrome 2020-06-15 wittman Update to upstream a7b4c5d25aeb 2020-06-16 wittman Streamline update process Created with: roll-dep src/third_party/libunwindstack Also includes updates to Chrome's native_unwinder_android.cc to account for libunwindstack interface changes: - split of Step() function into StepIfSignalHandler() and Step() - use CreateLocalProcessMemory() to create memory subclass for the current process Bug: 1004855 Change-Id: I54590d7c7ef3670fde42cc03ec1697c0f605d40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248759Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#779325}
-
Stephen McGruer authored
This reverts commit f1e5e2aa. Reason for revert: Broke WPT importer: crbug.com/1095643 TBR=robertma@chromium.org Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c Bug: 1095643 Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248061 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#779324}
-
Peter Kasting authored
No DoClose() implementation actually reads this argument. Bug: none Change-Id: Iee84eb6f912351eb80f7655b26aabc586d3fef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248464 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779323}
-
Alex Rudenko authored
This is a reland of aa42f61e Original change's description: > CDP: make a11y info optional > > This CL adds an attribute to the highlight config object to control > whether a11y info should be shown. The test expectations have been > updated accordingly. There is an accompanying CL in DevTools which makes > use of the new attribute[1]. > > [1] https://crrev.com/c/2238230 > > Bug: 1092841 > Change-Id: Ic4a888ecf134b852fd67430b924da3812f244dac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238828 > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778791} Bug: 1092841 TBR: caseq@chromium.org Change-Id: I9b14d446efe6355af0e8a8f43dcf1f866783a216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248680Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#779322}
-
Roman Sorokin authored
This CL fixes regression introduces in CL:2230472. Before *ForTesting methods checked if WC is created. After the offending CL WC is always created. So in this CL the methods also check if the WC is initialized Bug: 1094552 Change-Id: I603de486c6da5e62a406c7f6ecd407dafabf7762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247734 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#779321}
-
Peter Kasting authored
As far as I can tell from examining the affected locations, any possible behavior changes are either oversights or can't really happen. Bug: none Change-Id: I7bf4095d15c022a6a35f672871d123b96c96c604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248350 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#779320}
-
Victor Hugo Vianna Silva authored
This CL is essentially a revert of cc694e8d, the reason being that UX has decided not to have exceptions on this page anymore. The only two differences regarding the original commit are: hasDeviceOnlyPasswords_ and hasDeviceAndAccountPasswords_ are still replaced with a shared use of isNonEmpty_(); and the file documentation is updated to remove any mention to exceptions. Bug: 1049141 Change-Id: Ic95bf0042d6f4214ec40dd9dd0fedc492de56421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248683 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779319}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8dcbdb8aebf4..cac292283bfa 2020-06-17 aerotwist@chromium.org Removes First Meaningful Paint 2020-06-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-17 mathias@chromium.org Encode Python indentation style in .editorconfig If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096008 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib81836eac5978a58cb7faf5a0a8bfbab15cbd2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779318}
-
Marc Treib authored
PasswordBubbleInteractiveUiTest.BasicOpenAndClose contains some static_casts of the open passwords bubble (from PasswordBubbleViewBase to PasswordSaveUpdateView). However, if the feature EnablePasswordsAccountStorage is enabled, then instead of PasswordSaveUpdateView, PasswordSaveUpdateWithAccountStoreView is used - despite the similar name, an unrelated class, so the static_cast produced undefined results. This CL changes the static_cast to cast to the right thing, depending on the state of EnablePasswordsAccountStorage. Bug: 1093310 Change-Id: I555286ac9d6e428f2d565f458d2c9efb363a483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248566Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779317}
-
Jan Krcal authored
This CL removes an expired histogram in the Sync Directory code that is not used any more and will be deleted later in 2020. Bug: 1089542 Change-Id: I07a9c4f18d7676944ade32200a1a795c4271484c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248571 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779316}
-
Victor Hugo Vianna Silva authored
Bug: 1062344 Change-Id: I6b025432d75c74bfd71fb0ce54f71a29c84cd8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247830 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592384236-59c052c5d04aee966d200af8272c6f3b6edf1818.profdata to chrome-win64-master-1592394610-918984ddb97fe9042cd9fa15afdd7d2534645615.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibdde2caec205ab8e74682233f123d2e1fb3e92ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249707Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs to include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. TBR=ajgo Bug: 1031540 Change-Id: Ie89d33873b42f9cd5eaab867b1f986afb9c3ac44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247833 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#779313}
-
Thibaud Michaud authored
R=jochen@chromium.org CC=clemensb@chromium.org Bug: v8:10549 Change-Id: I6c2c5e1cd419ed7b217934a99d0032ce8667786e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247880Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779312}
-
Roger McFarlane authored
This CL renames/moved the GetVariationsVector method taking a set of collection key ids to be a private GetVariationsVectorImpl method and adjusts the call sites, tests and definition order to match. Bug: 1073600 Change-Id: Ia921ae158e82159a695037090a53e74d1ddf8fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243991 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#779311}
-
Marc Treib authored
This CL adds a check in PasswordManagerClientHelper so that it doesn't call PromptUserToMovePasswordToAccount() in incognito mode. Note that this does not actually change the overall behavior: The move prompt was already suppressed in incognito, but in a somewhat convoluted (and potentially fragile) way (see bug). Bug: 1094918, 1093310 Change-Id: Iccfaaae7095d585c5ea39d3bf409c75c288ab723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247828 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
arthursonzogni authored
Adds the cross-origin-opener-policy-access-reporting flag. - The cross-origin-opener-policy-reporting flag was about reporting browsing context switches [1]. - The cross-origin-opener-policy-access-reporting is about reporting access in between two windows blocked by COOP [2] We have two flags because: 1) [1] is simpler to implement than [2], we might have to ship them in different releases. 2) The feature is complex, the flag could be used as a kill-switch. We want to be able to disable only this part while preserving the other if needed. [1]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md#reporting-browsing-context-switches [2]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md#report-blocked-accesses-to-other-windows Bug: 1090273 Change-Id: Id9bada094fac34a30a2ed9da9c71baf1e51207a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247832Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#779309}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d12eb78c7c0..20aa34ea8ddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ioanap@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1082908 Tbr: ioanap@google.com Change-Id: I3888dd7b4ad297e49b11f4f11f426a1944e5acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249703Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779308}
-
Cezary Kulakowski authored
With current implementation of notifications on mac clicking on notification created by any active chromium browser will be registered in all the browsers. Additionally clicking in notification's button Settings will open settings page in all browsers. This commit adds new field to the notification: creator's pid which is checked with the pid of current process when the information about notification being clicked is send to the browser process from the NSUserNotificationCenter. If there is no match we do not process the notification. It doesn't solve the problem with the focus (all browsers gets it and the last one which got it will have it) but at least click on the notification is only registered in the proper browser. It also fixes the problem with button Settings. Bug: 1086899 Change-Id: Ia484c03c076f841ba3695b029ebced3c1191e6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a46fce2194df..ae1892d4e4ce 2020-06-17 terelius@webrtc.org Add simulation of robust throughput estimator to the event log analyzer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I221acd963c4b1519e4e9197a4afc3ef21a9f4dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249706Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c47d0ddea16..f5cd604cb9d0 2020-06-17 bsalomon@google.com GrMagnifierEffect uses child for src If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I3e797c833ccd99b85ab50c5cce58882e46cb3aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249705Reviewed-by:
-
Alice Wang authored
This CL destroys the account picker bottomsheet by registering a BottomSheetObserver object in BottomSheetController. Bug: 1063362 Change-Id: Ibfcc6e27fc8c5438589d49f4e753b76321d5604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241653 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#779304}
-
Ioana Pandele authored
TBR=rbpotter@chromium.org Bug: 1096016 Change-Id: I7d1fabccb14f55756e7e279938337fd44bf2e0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248684Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779303}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I547c30c97738aedf2e3974b8393d148da1c30ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249719Reviewed-by:
-
Jesse Schettler authored
Now that the method signature of ListScanners() matches that of ListScannersProto(), switch back to using ListScanners(). This allows the temporary ListScannersProto() method to be deleted, which is the last step in changing the method signature of ListScanners(). Bug: b:157577191 Change-Id: I5bec9b6d7f5efb5dee0a50ea594f86148e4e87c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248347 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779301}
-
Jan Krcal authored
This CL stops combining nigori commits with priority user type commits because nigori cannot get combined with encrypted commits and because we plan to break the guarantee that priority types are not encryptable. Impact of this change on traffic / latencies / etc. is negligible because nigori gets committed very rarely. Bug: 1084969 Change-Id: I2a7bb840a30def87813bb45394881e4a871f69b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247878 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592373607-cbb56276e9eec8291c1dfc389a85c83bce237656.profdata to chrome-mac-master-1592394610-7518c1df9a0c2bd855627c235c38489e194d3191.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I119b0376d24373fee369b94627f10c7de6238050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249704Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4504fd4faa5e25e65093a7b26dca12c022d587b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249718Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779298}
-
Henrik Boström authored
This CL plumbs base::PowerObserver::OnThermalStateChange with mojo from PeerConnectionTrackerHost in content/browser/ to PeerConnectionTracker in blink/renderer/modules/peerconnection/ which informs the RTCPeerConnectionHandler of the event. A mojom typemap for the enum is added to allow passing it and DEPS and audit_non_blink_usage.py is updated to allow the usage of base::PowerObserver::DeviceThermalState from blink. Tests verify that the signal reach the handler, but nothing is done with this signal yet. In a future CL, we will implement a webrtc::Resource to make use of it. Bug: chromium:1094844 Change-Id: I026e04238d89ced2d77672e015f58e7a497336f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246162 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#779297}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I19c04bf6b4fda716fea0af2a05fdb98756614821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249666Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#779296}
-
Benoit Lize authored
https://chromium-review.googlesource.com/c/chromium/src/+/2235695 didn't update the "PartitionAlloc everywhere" config. Fix it here. Bug: 998048 Change-Id: I57c5fe76d4aac50b47967bf9d246f224295e2e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249738Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d76df5326646..8dcbdb8aebf4 2020-06-17 tvanderlippe@chromium.org Remove `npm run start` script 2020-06-17 mathias@chromium.org Fix autofixable CSS lint issues 2020-06-17 yangguo@chromium.org Update and re-organize documentation 2020-06-17 tvanderlippe@chromium.org Default modes to vertical and horizontal orientation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1061037,chromium:1083142,chromium:1095614,chromium:1095988 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I744df89cc8df6b84532f32ced4ccc44179a4dee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249701Reviewed-by:
-
Olesia Marukhno authored
Bug: 1019129 Change-Id: Iaf69dce6cb29849c7dc8554493ecdbea029cde76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246501 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#779293}
-
Jérôme Lebel authored
The sign-in coordinator can be AdvancedSettingsSigninCoordinator, and this coordinator presents GoogleServicesSettingsCoordinator. This method has to stay, since it is needed by the Google services settings coordinator, and sub-coordinator. Bug: 971989 Change-Id: Ia3cc4a2da01c0ca430106e8e364e7a935c258997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247732Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#779292}
-
