- 05 Dec, 2017 40 commits
-
-
Mike Reed authored
Needed to land https://skia-review.googlesource.com/c/skia/+/76980 Bug: Change-Id: I07f1647b0d342baebadfa0549f54e5252ee4395d Reviewed-on: https://chromium-review.googlesource.com/809089Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#521755}
-
Devlin Cronin authored
Have WebLocalFrame::CallFunctionEvenIfScriptDisabled() return a v8::MaybeLocal instead of a v8::Local. This is more inline with the patterns v8 uses. Bug: None Change-Id: Id466ff9ba46d40123df77a835a7ec84a7c1442be Reviewed-on: https://chromium-review.googlesource.com/807405Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521754}
-
Alexandr Ilin authored
Bug: 792107 Change-Id: I4bcf739ee7413850d596cc2aff89465341eef7f8 TBR: mdjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/808976 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521753}
-
David Reveman authored
Version 2 provides clients with an interface to keep track of scale factors used by the shell. It provides a full list of supported scale factors and flags to indicate what the current and preferred scale factor is. Version 2 also adds a new request for setting the parent of a top level shell surface and specifying an initial location relative to parent. This also adds a new 'info' client that can be used for testing. The client connects to a compositor and prints all output related properties. Example output: geometry: x: 0 y: 0 physical width: 423 mm physical height: 317 mm subpixel: unknown make: unknown model: unknown transform: normal modes: 1600x1200: 60.00 Hz current preferred device scale factor: 1 scales: 0.500: 0.800: 1.000: preferred 1.200: 1.600: current Test: exo_unittests --gtest_filter=ShellSurfaceTest.SetParent Test: wayland_info_client Bug: 791672, 791681 Change-Id: Iab6869f5b54a6b5970dea40025edea46d0113c2c Reviewed-on: https://chromium-review.googlesource.com/805358 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#521752}
-
Jun Cai authored
This CL fixes the NewTabPageInterceptorTest.NoInterception browser test for network service by using https embedded test server instead of URLRequestMockHTTPJob::GetMockHttpsUrl(). Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4d1f911ec4db21a2f086c09d3d6a99e41ad75230 Reviewed-on: https://chromium-review.googlesource.com/802079Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521751}
-
Michael Spang authored
This adds supports for system tracing via trace.py. It is disabled by default but can be enable via the --systrace parameter. Requesting system tracing does no harm on devices where it is not available. This requires switching the way data is read back over the websocket, as the "ReportEvents" style cannot return data from secondary tracing agents such as CastTracingAgent. BUG=786091 Change-Id: I8b5b39c047ae03073d90d462a4febf1770a8ccd5 Reviewed-on: https://chromium-review.googlesource.com/804559 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521750}
-
jkereliuk authored
run_all_tests Change isLinux, isMac, isWindows to IsLinux, IsMac, IsWindows Bug: Change-Id: I28bcb3e753a5aaa0432350d6204b51b84d161fdd Reviewed-on: https://chromium-review.googlesource.com/809404Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521749}
-
Peter Beverloo authored
Its only responsibility is to forward calls to a NotificationHandler of a specific type, which should instead be done as an implementation detail of the notification system. Bug: Change-Id: Ia7e541c4b789b68d61209647294e420f9cde0681 Reviewed-on: https://chromium-review.googlesource.com/806220 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521748}
-
chrome://interventionsThanh Le authored
Logs messages of navigation are retained in PreviewsLogger bufffer, and on chrome://interventions-internals until the end of that session even when user history is cleared. Since ClearBlacklist event is triggered whenever history is cleared, removing all log message on the page, and all buffer messages in PreviewsLogger seems like a reasonable solution. Bug: 791774 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0f69f5ec89679826557cdd23bbd1f316957711ec Reviewed-on: https://chromium-review.googlesource.com/807397Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#521747}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/3dddccff31be..4fba4a97bc08 $ git log 3dddccff3..4fba4a97b --date=short --no-merges --format='%ad %ae %s' 2017-12-05 geofflang Include the D3D11 headers on Windows when OpenGL is enabled. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6a00b45125d0d0dec3edff05eb9c73f06d9519e8 Reviewed-on: https://chromium-review.googlesource.com/809290Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521746}
-
Andrew Grieve authored
Change-Id: I969673d9b2806d0215b30a425539ce1b15ee3618 Reviewed-on: https://chromium-review.googlesource.com/803948Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#521745}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e0dc203974cd..6b77e41141aa $ git log e0dc20397..6b77e4114 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 nednguyen Remove Telemetry's iprofiler Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0db325d24eaed93bf31e19b85bebd83480ea536f Reviewed-on: https://chromium-review.googlesource.com/809287 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521744}
-
Max Moroz authored
Bug: 790735 Change-Id: Ibf368a23b402dbe12c03afaed4032267abe52794 Reviewed-on: https://chromium-review.googlesource.com/808991Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#521743}
-
Gauthier Ambard authored
Having two stack views allow the animation to be focused on the location bar instead of having side effects on the buttons on the side. It also makes sure the toolbar is respecting the Safe Area on iPhone X landscape. Bug: 791933, 791944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6f0b3560c825cdfe67f5aca648ee0a2b96044a0 Reviewed-on: https://chromium-review.googlesource.com/807930 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521742}
-
Justin Novosad authored
BUG=790699 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I432ad3103df1d07732b2629384dc074cb6002a21 Reviewed-on: https://chromium-review.googlesource.com/806692Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521741}
-
Daniel Bratell authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... To save oursaves the mess that creates, they are now wrapped in a header, ui/gfx/x/x11.h, which puts those symbols in the x11 namespace and removes the global macros. Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida4d26422f44edda1a0120f52ffbaa4e437ab012 Reviewed-on: https://chromium-review.googlesource.com/805814Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521740}
-
Abhishek Arya authored
Also, improve documentation. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: Change-Id: Ic248caf2e7e73d84e29e8ce32689b7bfcd374e16 Reviewed-on: https://chromium-review.googlesource.com/809288 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521739}
-
Tom Sepez authored
Might fail if run as root as currently written. Make tighter test based on expected ids. Bug: 791696 Change-Id: I55e0febd8de570d4982c369782ce6cf74e2f3f39 Reviewed-on: https://chromium-review.googlesource.com/807248Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521738}
-
Eugene Ostroukhov authored
Frontend for IndexedDB live updating. Based on https://chromium-review.googlesource.com/676273 by Kristi Park. Bug: 729793 Change-Id: I8be1c8fafa0377c22eee261b0f00ab62f4bb6cc8 Reviewed-on: https://chromium-review.googlesource.com/798211 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521737}
-
Aleksey Kozyatinskiy authored
This reverts commit da300b52. Reason for revert: <INSERT REASONING HERE> Original change's description: > [DevTools] try to reenable PauseInSharedWorkerInitialization > > WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization. > This test is passing locally. > > TBR=dgozman@chromium.org > > Bug: chromium:432444 > Change-Id: I854aa9d72932d788f71724e84720a6529a6b5f4a > Reviewed-on: https://chromium-review.googlesource.com/806924 > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521512} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org Change-Id: I8b9e49420c2f62a994882d05a7c6ddb8174e80a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:432444 Reviewed-on: https://chromium-review.googlesource.com/809384Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521736}
-
Klaus Weidner authored
In preparation for GpuFence synchronization, track GVR acquire/submit times and report JavaScript waitForPreviousRender times back to VrShellGl via Mojo. Refactor waiting for previous transfer and render, using helper functions to unclutter submitFrame. Wait for previous transfer is only used for the Android surface path, move it there. Wait for previous render now support different choices for the execution point, including NEVER for the OpenVR path. The BEFORE_BITMAP choice is not yet active, it's intended for use with GpuFence-separated frames. It does work for the current render path too, but IIRC is a bit slower there due to less parallelism. BUG=761432 Change-Id: I9d24d6e0a133ad76cfda4f40c2bba84ffd7363ef Reviewed-on: https://chromium-review.googlesource.com/802756Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521735}
-
John Abd-El-Malek authored
This is used for UMA only, so we can remove the old path now. This is working towards eliminating LoaderDelegate interface, as it doesn't work with network service. Change-Id: Ie1e38dfc094cad75e71375c0a0fbeb6226e00567 Reviewed-on: https://chromium-review.googlesource.com/807590 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521734}
-
Evan Stade authored
This re-lands 61774b21. Now that NativeNotificationDisplay passes off to the MessageCenter for platform bridges that don't yet handle TRANSIENT, there will be no net change for those platforms. Bug: 783018 Change-Id: Iec09815faf6e71cc3622edddad299c357af4ee67 Reviewed-on: https://chromium-review.googlesource.com/807400Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521733}
-
Adithya Srinivasan authored
The only operations carried out on form_controls_ are insertions, removals and iterating through the entire list. Insertion and removal can be done faster with a DoublyLinkedList. Since the nodes for the DoublyLinkedList are Oilpan objects, this CL introduces HeapDoublyLinkedList that uses Member for the head and tail pointers, and traces the pointers. This improves the performance of HTMLInputElement::InsertedInto and HTMLInputElement: :RemovedFrom by ~15%. Change-Id: Ic6deac03e63cf0583ced9de9caccd1b533c6b88d Reviewed-on: https://chromium-review.googlesource.com/803944 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521732}
-
Vaclav Brozek authored
Vadym has been fixing bugs in the iOS part of password manager code, knows it well and should be an owner of it. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2623e35a2763cdd85a1c8808b44a1cc23887d22a Reviewed-on: https://chromium-review.googlesource.com/808266 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#521731}
-
xlai authored
Bug: 791315 Change-Id: I351a626d3d68657814e8c0fa3ed1d6f1eb153e80 Reviewed-on: https://chromium-review.googlesource.com/806296Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521730}
-
Herb Derby authored
The previous try had an msan problem. This should be fixed by: https://skia-review.googlesource.com/c/skia/+/79401 BUG=472742 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ifac7957e907f4b5b45a2086e58e79f39ade80669 Reviewed-on: https://chromium-review.googlesource.com/806674Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521729}
-
Geoff Lang authored
ANGLE is renaming the ANGLE_stream_producer_d3d_texture_nv12 extension to simply ANGLE_stream_producer_d3d_texture and allowing it to accept more texture formats. BUG=angleproject:2233 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6ad5653b37a74bbd25ea7742c8262193f763b1c6 Reviewed-on: https://chromium-review.googlesource.com/779087Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521728}
-
Tarun Bansal authored
When there is a change in the signal strength, the current network quality (using the older value of signal strength) is written to the cache. At the same time, the cached network quality (with the updated signal strength) is read. Currently, the reading/writing of cached network quality is enabled only for WiFi and Ethernet. This CL also enables reading/writing of cached network quality for all connection types. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Bug: 786997 Change-Id: Ifb9d838691a3b22bc05bd559d21b722c9d4a8529 Reviewed-on: https://chromium-review.googlesource.com/806798 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521727}
-
Hiroshige Hayashizaki authored
According to the spec comment, load events (instead of error events) should be fired for modules with non-fetch errors such as parse errors. Bug: 740886, 763597 Change-Id: I6074b36631e1299b90d52bc01e42c5ddeb957b31 Reviewed-on: https://chromium-review.googlesource.com/802251Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521726}
-
Brett Wilson authored
This constructor takes 28 arguments. It's much clearer to just set the members as desired. Do some minor C++11 updates. Change-Id: I357749f2631b6f6cd6fda2690a870918be769476 Reviewed-on: https://chromium-review.googlesource.com/804807 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#521725}
-
Sergey Poromov authored
We want to turn unexpected initialization of incognito mode to prevent incognito window creation when it's disabled by policy. These crashes are better to be reported though the crash infrastructure, to investigate and these fix access paths. BUG=789642 Change-Id: I040aa5b5e286df2be491952253d415c6daf0ac79 Reviewed-on: https://chromium-review.googlesource.com/806497 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521724}
-
Christian Fremerey authored
The Layout Test MediaStreamTrack-gc-no-crash.html was non-determinstic in that it depend on a race between the JavaScript side declaring the asynchronous test "finished" and the callback to GetUserMedia arriving. It appears there were at least 3 possible outcomes. The first case was that the finishJSTest() would be invoked before the call to GetUserMedia would do anything much, and the test would essentially verify nothing. The second case was that when finishJSTest() was invoked, GetUserMedia would have reach a point where it would have temporarily taken shared ownership of the blink document but the callbacks would not yet have been invoked. The third case would be that finishJSTest() would be invoked after the callback to GetUserMedia had finished running. It looks like in practice, at least on my local machine, the first case was the only one reached so far. When trying to activate the new video capture service with [1], the timing changed so that the second case would typically be reached. This case would lead to the leak detector running at the end of the test reporting leaked blink objects and failing the test. I verified that the same would happen without activating the video capture service, simply by making the call to FakeVideoCaptureDeviceFactory::GetDescriptors() taking a bit longer, via PlatformThread::Sleep(). After this CL, the test should deterministically always reach the third case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/719416 Bug: 789669 Test: third_party/WebKit/Tools/Scripts/run-webkit-tests --target gn_release --enable-leak-detection fast/mediastream/MediaStreamTrack-gc-no-crash.html Change-Id: I17c39e66cfd8c4af89f8f9b078d6512feaedbe6d Reviewed-on: https://chromium-review.googlesource.com/806442Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521723}
-
Shimi Zhang authored
Flakiness dashboard looks green, so remove @RetryOnFailure. Bug: 767180 Change-Id: I62d513b6c89836af85bf6933bdef18f6e9df468c Reviewed-on: https://chromium-review.googlesource.com/806318Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521722}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/614dd0f537d4..3dddccff31be $ git log 614dd0f53..3dddccff3 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 jgilbert Support RGB gl-tex-external stream consumers for StreamProducerNV12. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ibe2412da1211f4a665c0c0864102f0f4bc21e405 Reviewed-on: https://chromium-review.googlesource.com/808988Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521721}
-
Jose Dapena Paz authored
AXPlatformNodeAuraLinux was returning always 0 for GetIndexInParent, and adding an ATK specific implementation of get_index_in_parent. As a result, AX API would not return the right value, even if ATK would. This fix makes get_index_in_parent rely on GetIndexInParent, and GetIndexInParent use the delegate to obtain the value. Bug: None. Change-Id: Ic8d79da9f481c2cf92f28eefeb6b2030cce5e657 Reviewed-on: https://chromium-review.googlesource.com/806037 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521720}
-
Florin Malita authored
Not overriden in any derived classes. Change-Id: Ic31257df96803ea205834253385d760102a62f86 Reviewed-on: https://chromium-review.googlesource.com/808725Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#521719}
-
Finnur Thorarinsson authored
Bug: 789067, 656015 Change-Id: Ie4201d0b9db4add3321917c31b18152b5b441411 Reviewed-on: https://chromium-review.googlesource.com/808504Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#521718}
-
Justin Donnelly authored
Bug: 755643 Change-Id: Idfee763c036f7efa56bc4092a6826e2e6974e74b Reviewed-on: https://chromium-review.googlesource.com/807307 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521717}
-
Hui(Andy) Wu authored
One of the heristics rules is to capture a case like below: country-code(max_length=3), number-field(max_length=10). The first field will be country code and second and will be CITY_AND_NUMBER. This fails to capture some sites where they expect a longer length, where they expect people to put more formatting(or they do it for user), like instead of 5141231234, they expect (514)-123-1234. An example would be https://shop.lululemon.com/. This change increase autofill's heuristic expectation of length to 14 for this case. Change-Id: I89e08d1fce9c033d3076bc75971e762d8cdf3035 Reviewed-on: https://chromium-review.googlesource.com/804358Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521716}
-