- 14 Sep, 2019 39 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d4f6483..2af2515d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13a333635a37f29be5af355794abfaa9416ee0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804756Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696631}
-
Bettina authored
Bug: 1003962 Change-Id: I7deae76d9e7635b040b2adb1f8562f86c1b41376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804381 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#696630}
-
Tom Anderson authored
GetThemeProvider() will return nullptr before the view is added to the widget, so avoid using it in OmniboxTabSwitchButton and instead obtain the theme from OmniboxResultView. BUG=1004012 R=pkasting Change-Id: I464b7a81b73df06fb18d6c2f6a9a9180f0d79079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804820 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#696629}
-
Zhenyao Mo authored
We assumed GLContext::GetCurrent() will not return null, but it the wild it seems it could be null. So instead of DCHECK, we fail gracefully. BUG=1002637 TEST=crash reports R=sunnyps@chromium.org Change-Id: If3b83bd93c73353632baedfa7876cba77cebdf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804219 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#696628}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a75199c956a7..fdadc02909bf Created with: gclient setdep -r src-internal@fdadc02909bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:991788,chromium:None Change-Id: I86bfcc01c6296cb5b41a06dbeb9a86addc422dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696627}
-
Eric Seckler authored
This reverts commit fd8826a6. Reason for revert: suspecting this to be the cause of crbug.com/997610. Original change's description: > Reland "tracing: Enable startup tracing for spawned child processes" > > This is a reland of e40282f6. > > Includes a fix to BackgroundTracingActiveScenario, which could end up enabling > TraceLog without installing the TraceEventDataSource overrides on Android, see > patch set 1 -> 2. This likely caused the crashes observed in crbug.com/997582. > > Original change's description: > > tracing: Enable startup tracing for spawned child processes > > > > Enables startup tracing for child processes spawned by the browser while > > a tracing session is active. > > > > This allows us to collect early trace events in the period of time > > before the child connects to the tracing service. > > > > Bug: 968424 > > Change-Id: I1708cabae77cdd2ab3a33929c28cfab04eb723e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755746 > > Commit-Queue: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689599} > > Bug: 968424 > Change-Id: Id69f0821671caf05238896d4a0e1b581b5d5be44 > TBR: avi@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782812 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694981} TBR=avi@chromium.org,ssid@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968424, 997610 Change-Id: Ie7d48681d109d55204338ed6f2f4f0ed5920c1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804063Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#696626}
-
Erik Chen authored
Change-Id: I6755790c356541fb751f12d27dc379881120b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804375 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696625}
-
Alexis Savery authored
Add UMA histogram "Platform.StatefulUsedSpace" for Chrome OS. This tracks the space used for the stateful partition in GB. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1775464 Bug: chromium:999309 Test: ran validate_format.py Change-Id: If2638edf7b48f8420c1893b6cdc3f71623f5ae17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776853 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696624}
-
Robert Sesek authored
They are the only remaining files in that directory, so they can just go in wtf/ instead. Bug: 95729 Change-Id: I3f0d0647835d5cde29b2d3024005075d3feb7d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803764Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696623}
-
Robert Sesek authored
The internal signing job now always notarizes. Bug: 850199 Change-Id: I2450be540779e60049425065695555fa04296a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804581 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696622}
-
Koji Ishii authored
This patch fixes |may_break_inside| in |NGLineBreaker|. Issue 1002442 revealed an error case in |ShapingLineBreaker|. In that case, it returns a result whose size is larger than the available space. Before this patch, |NGLineBreaker| assumes that the line overflows if the result size is larger than the available size, and sets |may_break_inside| to |false|, which prevents breaking in |HandleOverflow()|. This can cause rather a large layout error. crrev.com/c/1797954 tried to fix the error in |ShapingLineBreaker|, but it looks like some tests is relying on the behavior and it was reverted. This patch instead makes |NGLineBreaker| more robust, by using the actual overflow state from |ShapingLineBreaker| to compute |may_break_inside|. The error in |ShapingLineBreaker| is not fixed yet, but with this fix, the worst result is to not able to fit a word that can fit by less than 1px or so. Further work for better correctness will be tracked in issue 1003742. Bug: 1002442, 1003742 Change-Id: I13a3172abc8a0d2f5f78b2dd0b57b85de593fdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803019Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696621}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf4deab60e30..2cb1315d99e4 git log cf4deab60e30..2cb1315d99e4 --date=short --no-merges --format='%ad %ae %s' 2019-09-13 khushalsagar@chromium.org Reland "gpu: Update GrGLCaps usage of fTextureRectangle with chromium." Created with: gclient setdep -r src/third_party/skia@2cb1315d99e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:900706,chromium:998038 Change-Id: I302f8f10d687862c5490a78e59dffa22274066a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696620}
-
Matt Reynolds authored
GamepadService is implemented as a global singleton. Typically there is only ever one GamepadService instance for the lifetime of the browser, but in tests a new instance may be created for each test case. Previously, when a new instance was created the previous instance would leak. This CL makes sure the previous instance is destroyed before a new one is created. At startup, the GamepadService is passed a service_manager::Connector to allow gamepad data fetchers to use the device service to enumerate and communicate with gamepads on the polling thread. The Connector must be destroyed on the same thread it is bound to. Since the polling thread is owned by GamepadProvider, the Connector has also been moved into GamepadProvider so it can be destroyed along with the polling thread. A pointer to the Connector is provided to the data fetcher when it is added to the GamepadProvider. BUG=961039 Change-Id: I66741b3ea5971cea3bbf2ba81bd1f734a7664ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777024 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696619}
-
Kyle Horimoto authored
This CL shows an error in the settings page when a Cellular network is not connectable. Bug: 947351 Change-Id: I68c270afec2cd99a773b4eeedf6c1e351486a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779348Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#696618}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/170e919274a2..b76d3875bc1b git log 170e919274a2..b76d3875bc1b --date=short --no-merges --format='%ad %ae %s' 2019-09-13 treehugger-gerrit@google.com Merge "Add 'chrome logs' probe to perfetto record config" Created with: gclient setdep -r src/third_party/perfetto@b76d3875bc1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I716a8d633979b5c353d04b3bbaebee54e392fe22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804775Reviewed-by:
-
Kush Sinha authored
This is a reland of 1e78e311 The performance issues in https://crbug.com/1001518 have been fixed. Original change's description: > Enable crOS Account Manager by default > > Chrome OS Account Manager has been enabled for 1% on Stable channel. > Enable it on ToT as preparation for 100% Stable ramp up. > > TBR=droger@chromium.org > > Bug: 816954 > Change-Id: I6e0097237600e40c39a98e59af063deddd1da9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761588 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689126} Bug: 816954 Change-Id: Ibbf78c4c598ba6ddb085ccea870a4409276c745c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801756Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#696616}
-
Manu Cornet authored
Change-Id: I7c9888e2bbd7e3646273b7b02456bec5cb82ffff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803660Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#696615}
-
Sergey Ulanov authored
Temporary workaround for the linked bug Bug: fuchsia: 36620 Change-Id: I2718ec630f070b653302cda961976581c083f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804835 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#696614}
-
rajendrant authored
Both the explicit and automatic lazyload should be disabled when the document is loaded for a background tab or prerendered. This is because interesection observer never fires for backgrounded/prerendered documents, until the background tab comes to foreground. Bug: 1000814 Change-Id: I3f6efe434d90cb3d0dd9d9f8df3afd2f89e8c05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787568 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#696613}
-
Lijin Shen authored
This CL tries to fix: 1. when one bookmark is being dragged while another dragging animation is on the progress, getAdapterPosition may return -1. 2. calling notifyDataSetChanged when recyclerview is computing or scrolling will also throw an error. Bug: 1002856 Change-Id: I2c22f7ad58c68245cc675b6cccbeb644bd1fbc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799469 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#696612}
-
Jan Wilken Dörrie authored
This is merged reland of da55edae and 8455bad4. Adds leak detection pref to PasswordsUITest suite in autofill_page_test.js. Without it the tests were breaking in debug_mode. The also reverted r696322 was cherry-picked into this, as it is closely related. Original change's description: > [Desktop] Configure leak detection toggle > > Makes toggle disabled and displayed as off when user is signed out. > Replaces old strings. > > Bug: 1003696 > Change-Id: Ie5a86e45db1d116dc7bd76926d1eae57c03bfcd2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789583 > Commit-Queue: Rafał Godlewski <rgod@google.com> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696318} Original change's description: > [Desktop] Make leak toggle available for signed in not syncing users > > Makes leak detection toggle not disabled for signed in users who are > not syncing. > > Bug: 1003696 > Change-Id: I8d39f53b84b4c7811171953ced431540ff882351 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800749 > Commit-Queue: Rafał Godlewski <rgod@google.com> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696322} TBR=dbeam@chromium.org Bug: 1003696 Change-Id: I10a502c0dd7e2b74ae83bd8f82de7c3f7f066403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803299Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#696611}
-
Michael Crouse authored
This change creates an OptimizationGuidePageLoadMetricsObserver to provide pageload metric data to the Optimization Guide. Initially, only the navigation timing, FCP, is captured. The metrics from this observer will be provided to the Slow Page Prediction Model. The next change will pass the metrics to the OptimizationGuideKeyedService and eventually to the OptimizationGuidePredictionManager for updating the features used to evaluate the Slow Page Prediction model. Bug: 1001194 Change-Id: Ibbde9150781a209f6c52d287ec98abc9b0540636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746593 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#696610}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6caa2652613b..d32dae1bb37c git log 6caa2652613b..d32dae1bb37c --date=short --no-merges --format='%ad %ae %s' 2019-09-13 zmo@chromium.org Revert "EGL: Implement EGL_KHR_no_config_context" Created with: gclient setdep -r src/third_party/angle@d32dae1bb37c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I74405b31c87a0895a0b51e55746a841fdb2e3461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804774Reviewed-by:
-
Lei Zhang authored
Use Set{Bool,Int,String}Key() instead of SetKey() when possible, to avoid having to explicitly construct base::Value objects. Change-Id: I3ed4acc31f388c09d6692f4b6068bca78f6a49df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790526 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#696608}
-
Alexander Cooper authored
This reverts commit d5dcd686. Reason for revert:1004004 Original change's description: > Handle angled screens for WMR headsets > > Send the full head-from-eye transformation matrix that includes both the > offset and rotation through mojo from the device process to blink. > Previously, the transformation matrix was constructed only from the > offset component. There aren't WMR headsets yet with significantly > angled screens, but this change should make them compatible if any are > made in the future. > > Bug: 980791 > Change-Id: I1ae4bc43ee31e4e0203252a1ce1924a1fb2194c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790467 > Commit-Queue: Jacob DeWitt <jacde@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694801} TBR=klausw@chromium.org,jacde@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 980791 Change-Id: I3d4a8a4b6ed0370e00f49d040ceb228e7600052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804689Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#696607}
-
Dmitry Gozman authored
Bug: 1000475 TBR=alph@chromium.org Change-Id: I9a9c3abcf731de3b76bcd701214e164790821f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804676Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696606}
-
David Tseng authored
Scenario: - chrome://settings - under advanced -> accessibility, click add accessibility features - Ctrl+w - Search+Right result: ChromeVox accessibility focus moves to the root of the settings page Explanation The sequence of events immediately after Ctrl+w are as follows: "focus webView" ... "ariaAttributeChanged window" "blur webView" "focus unknown" ... "ariaAttributeChanged window" "blur unknown" "focus link" ... "<accessibility event type> <target node's role>" The typical event stream from an interaction where a page gets initial focus always involves the "rootWebArea" getting focused (this is typically a child of the webView node). Fix The fix is to always refresh DesktopAutomationHandler's |lastRootUrl| state for every focus event not just ones on a rootWebArea. This state is used to prevent ChromeVox from trying to recover focus when a user has already started navigating into a page before the page has completely loaded. In the case where someone closes a window, the focus never actually lands on the rootWebArea first but instead on the webView only. The existing check is: - ChromeVox accessibility focus's root == the new focus's root and - the last root url == the new focus's root url Test: The cases that continue to work: - alt+tab (roots are different, root urls are different, focus recovery triggers) - reload (ctrl+r) - ctrl+tab - alt+left (root can actually be the same, but root urls different which triggers recovery) New: - Ctrl+w Verify all these cases recover to the previous place and Search+left/right work as expected after. Bug: 1003992 Change-Id: If09ab14a4aafb3e0a849266eebf69315b277d005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804048 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696605}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/05cd93068b0a553afc48f69acbceae10c6a17593..5ce7022394055e183c12368778d361461fe90a6e The following commits have Chromium bugs associated: 1e547722d Add OPENSSL_FALLTHROUGH to a few files. Bug: 997709 Change-Id: I072a592df46532383d9a1a1a3092b742ad822373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797388 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#696604}
-
Thomas Guilbert authored
Currently, tapping on the cast notifications' play/pause button in short succession only results in WMPI's play/pause state being updated half the time. The problem comes from the fact that there is no way to tell if WMPI's play/pause state toggled due to a user gesture, or due to the FlingingRenderer asking it to toggle to match the cast device's state. In both cases, we expect the remote device to transition, and we ignore transitory play state updates. This CL fixes the issue by saving the last state the remote device has sent, and comparing it against WMPI's play/pause commands. Change-Id: Ifa1cbe64fcfedb9e43d8550ad010ba07e68b4219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804223Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#696603}
-
Ben Pastene authored
This reverts commit cc615067. Reason for revert: test isolate has changed Should be safe to revert. Original change's description: > Mark sbox_validation_tests on 'Win7 (32) Tests' as non-idempotent. > > R=hypan, jbudorick, agable > TBR=jbudorick, agable > > Bug: 1003894 > Change-Id: I3cf1d6cd56da6f5335b96153c245068e6ddb65e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804217 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696501} TBR=agable@chromium.org,bpastene@chromium.org,jbudorick@chromium.org,hypan@google.com Change-Id: I170c56c4e01debae4a64d3d0f630d8391104273f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804834Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#696602}
-
sczs authored
- Makes SettingsNavigationController conform to UIAdaptivePresentationControllerDelegate this way it can cleanup properly once swipe down has occurred. - Adds shouldDismissViewControllerBySwipeDown to SettingsRootTableViewController. By default there will be no rubberband, but subclasses can override this to rubberband. - SettingsNavigationController now asks the current presenting VC if it shouldDismissViewControllerBySwipeDown. - Rubberbands on Edit Payments, Edit Addresseds and enter Passphrase. - Some light method renaming to reflect that the cleanup can occur after Settings has been dismissed. - Deletes the legacy CBD test since it would fail with this change and legacy CBD will be deleted soon, so instead of supporting it the test is being deleted. Bug: 980037 Change-Id: I5fd8da2108f3294842762488eb23b8093954a506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788026 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#696601}
-
Aaron Gable authored
Follows the example of crrev.com/c/1775217, using .Round() to ensure that the DCHECK still works when the values are nearly-saturated floats. Bug: 1002692 Change-Id: Ib9534325f2db89ba125a8f97b3f4d8b63e25204f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797173 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Avery Musbach authored
SplitViewController::OnWindowSnapped shall no longer activate the newly snapped window. In many workflows, such window activation is redundant or inappropriate (see the referenced issues on Monorail). Window activation shall be done separately by code for workflows where the snapped window actually does need to be activated. Bug: 982954, 983227, 991611, 995946 Change-Id: Ie111d90786764f0612aea73ba9cfa4ce640fe1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738338Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima (slow - perfing & gardening) <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#696599}
-
Lei Zhang authored
The internal printing code can only handle N-up for content from Blink or the PDF plugin. For any other plugin, which is effectively just Flash, the N-up setting does not work. So do not show the setting in the Print Preview UI in this case. To do this, take advantage of an earlier CL that exposes whether the content being printed is PDF or not, and plumb that setting into the Print Preview UI and show the pages-per-sheet control based on that. Change-Id: Ic57f50a451aba9ba6918b59be572a371a1b4beca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790256 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Jun Mukai authored
As commented in the code, page_view->RequestFocus() might cause ResetForShow(), which hides the embedded asssitant view, thus the assistant UI might go invisible in a weird situation. I hope I could find a holistic solution of controlling states within ContentsView, but so far this would be the simplest fix for the problem. Bug: b/140831868 Test: manually Change-Id: I9e1b551c2db448ff40c9f978130ce2a0225a4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803958 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696597}
-
Nico Weber authored
Like https://chromium-review.googlesource.com/c/chromium/src/+/1711087 but for generate_breakpad_symbols.py Also make sure hermetic otool is available at test execution time when it's available at build time. Bug: 984746,998873 Change-Id: I9646e48d3dae3f6f1076ed9e3ddbd91eb1e1cfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803805Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696596}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eaaaf41298ba..0dd37ce029f0 git log eaaaf41298ba..0dd37ce029f0 --date=short --no-merges --format='%ad %ae %s' 2019-09-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 47402026..9004bcf3 (696373:696490) Created with: gclient setdep -r src/third_party/webrtc@0dd37ce029f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I8e75761bf88c210e6b09d97a4ee1e49f4a0d7202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803981Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaf9eaf7f8d9868ab720c9591945be5355625cfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803982Reviewed-by:
-
Martin Kreichgauer authored
FidoDiscoveryFactory instances generally outlive a WebAuthn request, but some of the state is specific to a single request (caBLE pairing and QR code generation keys). This is currently not an issue, because AuthenticatorCommon explicitly resets all that state at the beginning of the request. But I worry that we accidentally break that and leak state between requests. To mitigate, introduce an explicit ResetRequestState function and call it in AuthenticatorCommon::Cleanup(). Change-Id: I8333a3b14d189d7977cde17cbfe44b4b8dcf6ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793792 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#696593}
-
- 13 Sep, 2019 1 commit
-
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: I0b8ef906f48722ba99398a291ba03e4298f6f1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802703 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696592}
-
