- 25 Feb, 2020 40 commits
-
-
Dong Hwi Lee authored
Name changes: - Collapse -> Fold (name borrowed form wikipedia/Code_folding) - Collapsible -> Folder - Collapsed -> Folded - Expanded -> Opened - collapse-button (in CSS) -> fold - expand-button (in CSS) -> open Improvements: - Remove createButton (only referenced by createCollapsibleButton). - Remove 'text' class as it's not actually used. Change-Id: I29899a9293be47764f1963f7683cdd313622deef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070968 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744176}
-
Eric Willigers authored
CreateWebApplicationWindow checks for disposition NEW_POPUP. AppBrowserControllerBrowserTest.WhiteThemeForSystemAppPopup now passes even when DesktopPWAsWithoutExtensions is enabled. Bug: 1055645 Change-Id: Ifb15712c7bcebffba813f82ca7b7009618b31aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071438Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744175}
-
Koji Ishii authored
No browsers have implemented the spec behavior for over a decade, but CSSWG did not agree to match implementations. https://github.com/w3c/csswg-drafts/issues/1518 TBR=ikilpatrick@chromium.org Bug: 1052201 Change-Id: Ic349cfe2f881cdce3ee9ddbfc17995983cfc6ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071180 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744174}
-
Zhuoyu Qian authored
This CL update the function DeleteOriginDataOnFileTaskRunner to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: Ieb797f641079f715ac2cd94e6ec3a86aa0c1c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007322 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744173}
-
Hirokazu Honda authored
GAVDA.InitializeResult is an important metrics to know the failure rate of ARC++ video decoder path. This extends the expiry by two years. Bug: 1053013 Test: None Change-Id: I6e69dd7dbc245c2749c1e0aca4f31c8d6cb53643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060363Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744172}
-
Nico Weber authored
Bug: 1039697 Change-Id: I18ede84f1632aedb29a0a34730e884fafc9cc4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071508 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#744171}
-
Lan Wei authored
Disable OobeZeroTouchInteractiveUITest.EndToEnd test on ChromeOS because OobeZeroTouchInteractiveUITestImpl/OobeZeroTouchInteractiveUITest.EndToEnd fails on Builder Linux Chromium OS ASan LSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 TBR=antrim@chromium.org Bug: 1054935 Change-Id: Ied762f5ff39e3b09a2eef83db2dc94a193a78c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071579Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744170}
-
tby authored
I've also fixed the units on one of our histograms being "units". Bug: 1052900 Change-Id: I770f0d3b2acf92156b61bc1c8366f92d04fb66c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068399Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#744169}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 664386 Change-Id: I4f53ada54759ec779f9e952a320925c845c8d248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071437Reviewed-by:
-
Kenichi Ishibashi authored
The feature is fully launched. Remove the virtual tests. Bug: 692909 Change-Id: Idb53d4683720c288c3c25a48118790f193581142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068067Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744167}
-
Leon Han authored
@Test(expected = InvalidNdefMessageException.class) indicates the test will and must throw an InvalidNdefMessageException, once the first exception gets thrown, the following code won't run and the test just goes to the end. So if a test would possibly throw more than one exception, it cannot use this mechanism. Instead we use a pattern like XXX xxx = null; try { xxx = getXXX(); } catch (XXXException e) { } assertNull(xxx); to confirm something went wrong inside getXXX(); Bug: 520391 Change-Id: Ibb681cbef1e0717ed695d7d7f2b9931739e6714c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071715 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#744166}
-
bttk authored
When observing user actions in Java code, native libraries may not be immediately available to record these actions. This change allows for deferred recording of user actions. Bug: 1048429 Change-Id: I66a151c163597622fdf08f9a7312f8c800da0e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040053 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#744165}
-
Victor Costan authored
This is a reland of 64e434bf This CL skips the diff hunk in appcache_group.cc from https://crrev.com/c/2071069 that caused failures in the WebKit ASAN builder. NOLINTNEXTLINE is added before the trouble lines, so other developers won't be tempted to apply the same clang-tidy fix. The CL was tested by reproducing the failure reported in https://crrev.com/c/2070838 on an ASAN build, then undoing the problematic change, and verifying that the failure does not reproduce. To avoid a similar issue in this CL, all LayoutTests under http/appcache/ were run under ASAN. Original change's description: > AppCache: Fix clang-tidy warnings. > > This CL fixes all currently-enabled clang-tidy warnings in > //content/browser/appcache. The main benefit here is to prevent > distractions while pursuing further refactoring in AppCache. > > This CL introduces no functional changes. > > Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744051} Change-Id: I01e31ce2111d3b06bb45b238847a5ffa318f5034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071069Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5d977fae3b7..a8b55bbfaabd git log b5d977fae3b7..a8b55bbfaabd --date=short --first-parent --format='%ad %ae %s' 2020-02-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a8b55bbfaabd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id3441ca9342c44e31aafba5d03f82155849dc2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744163}
-
yilkal authored
This cl saves the last reset time in AppTimeController in user pref. The value is saved every time the |AppTimeController:: reset_timer_| fires; the timer fires once every 24 hours. Last reset time value is read from the PrefService when AppTimeController is constructed. It is used to check if the reset time has been crossed while the device was off. Bug: 1050876 Change-Id: I11d189256a403b3c6f452905e2ccfc50f1660873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067242 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#744162}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9b2c573d..17069c35 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34552928b047c37bab02cefecab709bdf3cfbd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071595Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744161}
-
Jonah Chin authored
This is a reland of 2a3b1189 To fix the perf regression from the original CL (as seen in crbug.com/1054408): In Canvas2DLayerBridge::GetPaintCanvas, avoid the call to GetOrCreateResourceProvider() to skip the IsValid/ContextLost checks. GetPaintCanvas is used in a hot code path that is called by each javascript command, so checking the context every time we fetch the recording canvas results in unnecessary and expensive work. The context does not need to be valid at this point, since only the recording canvas is being used. TBR=fserb@chromium.org Original change's description: > Add a PaintRecorder to CanvasResourceProvider > > This CL is the first step in creating a PaintRecord backed resource > provider for canvas OOP-R. > > Changes of ownership: > - PaintRecorder entirely moved from Canvas2DLayerBridge to > CanvasResourceProvider. > - Management of needs_flush_ for MemoryManagedPaintRecorder moved to > CanvasResourceProvider. > - RestoreCanvasMatrixClipStack logic centralized to CanvasResourceHost > and can be accessed via callback > - Backing SkiaPaintCanvas now private to CanvasResourceProvider with no > external access. Any users of the backing SkiaPaintCanvas in > Canvas2DLayerBridge had their functionality moved to > CanvasResourceProvider (ie. new RestoreBackBuffer() function) > > Updates to test files: > - Addition of explicit FlushCanvas() calls in tests that used to expect > SkiaPaintCanvas to immediately update. > - Some tests expected the CanvasResourceProvider to be created on first > draw. This expectation has been changed since the > CanvasResourceProvider now gets set up on SetCanvasResourceHost(). > > Other new functionality: > - Display Item List now has a bit that tracks if it contains any draw > operations. This is used to see if there are draw ops to flush. > > Bug: 1019288 > Change-Id: I717b18e22d6699dc876d8f8121a25d147738579d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891292 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743002} Bug: 1019288 Change-Id: I4ad88fbaeff89cff665ea53038091ec2a814eac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067557 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744160}
-
Tanya Gupta authored
Bug: 1055288 Change-Id: Icbc384fbe92965eff27722c8ac095629a85a793b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070974Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#744159}
-
Kent Tamura authored
This makes LayoutNG transition easier. This CL has no behavior changes. Bug: 1040828 Change-Id: Id11187b3ee0130a8552b77a682b8d96b12bfda99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071535Reviewed-by:
-
Mikel Astiz authored
Change-Id: Ia70e53e59a35fee722ea210a729231adedcaa97c Fixed: 980464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054224 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744157}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e3aee0b42a11..4dc19c38c0c5 git log e3aee0b42a11..4dc19c38c0c5 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 geofflang@google.com Always use commit_id.py to generate commit.h 2020-02-24 geofflang@chromium.org Make Soong ignore build files in third_party 2020-02-24 jmadill@chromium.org Trace/Replay: Pass CallCapture to parameter replay writer. Created with: gclient setdep -r src/third_party/angle@4dc19c38c0c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I221f6190a8a9121ad46e37ca48c150247bd88c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070977Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61bf4177c413..9aa1a9673a3c git log 61bf4177c413..9aa1a9673a3c --date=short --first-parent --format='%ad %ae %s' 2020-02-25 ehmaldonado@google.com git-cl: Add GetAuthor method and cache GetLocalDescription results Created with: gclient setdep -r src/third_party/depot_tools@9aa1a9673a3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051631 Tbr: agable@chromium.org Change-Id: Ia0b5ed36a26720d3a836728a3a97d22e6eb6157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070980Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1249ada986fc..5a921f8fadba git log 1249ada986fc..5a921f8fadba --date=short --first-parent --format='%ad %ae %s' 2020-02-24 cwallez@chromium.org Roll third_party/swiftshader/ 8def9063c..bdfcfe9cf (11 commits) 2020-02-24 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@5a921f8fadba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I54dee66cd6eddc762100cc0164fda88a2e05fd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070979Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d5a5c4801756..8fd825d3f61e git log d5a5c4801756..8fd825d3f61e --date=short --first-parent --format='%ad %ae %s' 2020-02-25 fancl@chromium.org Reland "Fixing dashboard & sheriff-config push-on-green" Created with: gclient setdep -r src/third_party/catapult@8fd825d3f61e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I4d3c741c3fa9013f4c36f9f096f73c5b7f64c021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071282Reviewed-by:
-
Giovanni Ortuño Urquidi authored
There are two changes in this CL needed for show_in_launcher and additional_search_terms. 1. Re-publish apps once SystemWebAppManager syncs them. When ExtensionApps and WebApps get notified of a new app installation SystemWebAppManager is still unaware of them. This is an issue because we store information relevant to the app in SystemWebAppManager e.g. additional_keywords and show_in_launcher. To fix this, we change ExtensionsApps (and in a follow up WebApps) to listen for SystemWebAppManager::on_apps_synchronized() and refresh the info for SystemWebApps. 2. Retrieve additional_search_terms and show_in_launcher from SystemWebAppManager in ExtensionApps when on_apps_synchronized() gets called. Bug: 1054195 Change-Id: I5af5e24bd4d61d524e3ad383093c1d00767b4106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065194 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744152}
-
Mason Freed authored
This contains no material changes. TBR=schenney@chromium.org NOTRY=true Change-Id: If653f72901935e69ae0cf5a469d60fc34d497612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071738 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#744151}
-
Erik Jensen authored
This still has a couple of rough edges: * Some layouts lacking a keypad thousands separator will show a decimal separator at both NumpadDecimal and NumpadComma. * IntlBackslash will appear on layouts where it's not typically present (usually generating '<'). * Japanese and Korean IME keys are not included even where applicable. * When the user modifies the enabled keyboard layouts or settings, several layout messages can end up being sent in rapid succession as the changes are applied. * Probably other things that will be revealed during testing. Bug: 1026029 Change-Id: Icb511db3d3b5715ab563a0f433443c977e5c805c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063850 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#744150}
-
Peter Kotwicz authored
This CL: - Adds tests for the status bar color in overview mode. - Adds @Feature({"StatusBar"}) to all status bar tests - Adds documentation for why ThemeTestUtils#assertStatusBarColor() is L+ BUG=1015627 Change-Id: If17b35cad970942add9525229da3275ac31b6adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069501 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744149}
-
yilkal authored
This cl also saves app activities for AppActivityRegistry. The list of applications are stored. The stored information includes: the application ids, the application states, the running active time of the applications, and the list of their activities (i.e. timestamp ranges when the applications were active). The information is stored every five minutes and it is restored when AppActivityRegistry is instantiated. Bug: 1050876 Change-Id: I7086f7fbf20c969b58d7af0ef398f7716171607d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063677 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
-
Stephen Roe authored
The scp operations to retrieve test data from fuchsia VMs on arm64 machines have infrequent errors (about 1 out of 3,000 test suites fail this way). This CL adds logging scp output on error to get more information about the fails. Bug: 1050072 Change-Id: I36b88863e5b3e9f27f0b43ea16ab67509d9bf39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066489 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744147}
-
Nate Chapin authored
Bug: 1052723 Test: fast/dom/HTMLScriptElement/script-append-child-in-detached-document.html Change-Id: Id1f0ad773644cbc3d5c0b5f556070c2d257a331b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070957 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/05a90eab354e..16b67309ba83 git log 05a90eab354e..16b67309ba83 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 primiano@google.com Test: Improve FtraceProcfsIntegrationTest, skip if systrace is on Created with: gclient setdep -r src/third_party/perfetto@16b67309ba83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149677011 Tbr: perfetto-bugs@google.com Change-Id: I8f1b27016219832c526069caeea3dab59fea2718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070978Reviewed-by:
-
S. Ganesh authored
Bug: 1055546 Change-Id: I61fb39ecf5778737cfd1535a05b94efe91317427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070839Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744144}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Lock Screen page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I34d0dc898bfd1829ccb5a3bf94fb24dbef8cba60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067396 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#744143}
-
Kent Tamura authored
FileChooserImpl can outlive ListenerProxy. We should clear FileChooserImpl::proxy_ on ~ListenerProxy(). This CL has no tests. We don't know how to reproduce crashes. Bug: 1054260 Change-Id: I2be7a8957f2f725c51081961357ef09f6dabb823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067819 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#744142}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19304d88c8be..b5d977fae3b7 git log 19304d88c8be..b5d977fae3b7 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 bungeman@google.com Control opsz instead of CGFont in create_exact_copy. Created with: gclient setdep -r src/third_party/skia@b5d977fae3b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I822637c3cad35eb5ba5c06e97be8162b426cdb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071279Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f95054fa7d04..61bf4177c413 git log f95054fa7d04..61bf4177c413 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 ehmaldonado@google.com git-cl: Fix get_cl_statuses for Python 3 and add tests. Created with: gclient setdep -r src/third_party/depot_tools@61bf4177c413 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1002209 Tbr: agable@chromium.org Change-Id: I66764c20444b316e97ef14c7451ff71066cc39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071277Reviewed-by:
-
chromium-autoroll authored
They have to be rolled simultaneously due to a breaking change. https://swiftshader.googlesource.com/SwiftShader.git/+log/214ec337a0b2..e162b023f539 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/79f8caf9154a..4a80497a8885 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: angleproject:4425 Tbr: swiftshader-team+autoroll@google.com Change-Id: I217cab114ce54357e0214252a26cce99c8ba1feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068835 Commit-Queue: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744139}
-
Gabriel Charette authored
This cl was generated by the same script used for https://chromium-review.googlesource.com/c/chromium/src/+/2026350 but without requiring base:: in front of the API usage. This catches usage that relied on ADL (argument-dependent-lookup) to reach the base:: namespace. I don't think we should be using ADL for ThreadPool (and assume it was likely unintentional?). TBR=ajwong@chromium.org (mechanical change for //base API) Bug: 1026641 Change-Id: I51f56d389b903c528b0fda7b3baab0083818d2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026312 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#744138}
-
Darin Fisher authored
Bug: 1050143 Change-Id: I7b5ac5d5aba763e644f372120578532ba79da7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070822Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744137}
-
