GitLab

This CL is parameterizing the Java bridge instrumentation tests to
run with and without using Mojo in JavascriptInjector, running all
the relevant tests and using
JavaBridgeActivityTestRule#MojoTestParams for the ones that pass
and JavaBridgeActivityTestRule#LegacyTestParams for the ones that
fails. So, all tests still run for the old codepath.

Bug: 1105928
Change-Id: Idb3ee3ed4d1cb49fa0fc37d7609ac2e8ef166177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348488Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#798370}

The function decides whether we should update layout for
getComputedStyle().getPropertyValue("block/inline-size") on an element,
and it incorrectly returns false on SVG elements. This patch fixes it.

Note: This patch makes the function identical to
Width/Height::IsLayoutDependent().

Bug: 1115887
Change-Id: Ieb628e2e81ce02d95ac8a41a04b3aaa96d532829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354625
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798369}

This CL adds two new methods to the KaleidoscopeDataProvider API which
allow the page to query whether or not to show the first run experience
and to tell the browser when first run is successfully completed.

Bug: b:154517281
Change-Id: I18bafb0239b86384e42d45078b2184d8ed5d911b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354460Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798368}

The SWA uses a temporary icon and is hidden behind a feature flag that
is disabled by default.

Bug: 1059779
Change-Id: I9cee9b2de42a49285a8ee5ba2877d6394a7ca5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348539
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798367}

Bug: 1114873
Change-Id: If38541941c0cf90f9947642d208bd16bd820a719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357515Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Cr-Commit-Position: refs/heads/master@{#798366}

This CL adds a mojo::Remote<mojom::Logger> in CastAppDiscoveryService to
log unavailable (app_id, sink_id) pairs and socket not found errors.

Bug: 687380, b/154273698
Change-Id: Ie284e9cb6bb06cd80b33826ca7bbe73fe2539eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347369
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798365}

Change-Id: I661490736205537e9389cd5f7c1d029faff6f29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357132
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798364}

Fixes a DCHECK crash where the MetaTable has already
been created and we try to reuse it for the new DB.

Change-Id: Ib1b0a96ae4a65fa606872cb10ad3f5183ee02558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357750Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798363}

https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..a3fcf2574157

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I3212aef3679363229ba07dbb854accf2cb6fda9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798362}

Fix the ImageDecoderTest.CanDecodeType test failure when the AVIF
feature is disabled.

The ImageDecoderExternal::canDecodeType() method ultimately depends on
what is added to image_types_ in the MimeUtil constructor:

  MimeUtil::MimeUtil() {
    ...
    for (const char* type : kSupportedImageTypes)
      image_types_.insert(type);
  #if BUILDFLAG(ENABLE_AV1_DECODER)
    ...
    if (base::FeatureList::IsEnabled(features::kAVIF))
      image_types_.insert("image/avif");
  #endif

So the return value of ImageDecoderExternal::canDecodeType("image/avif")
should match base::FeatureList::IsEnabled(features::kAVIF).

Test:
blink_unittests --enable-features=AVIF \
    --gtest_filter=ImageDecoderTest.CanDecodeType
blink_unittests --disable-features=AVIF \
    --gtest_filter=ImageDecoderTest.CanDecodeType

Bug: 1116502
Change-Id: Idb5a13f5cc4e78c0d9671b7460601a412936bec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357961Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#798361}

https://android.googlesource.com/platform/external/perfetto.git/+log/a3fcf2574157..22e7f7a0d7d7

2020-08-14 fmayer@google.com Merge changes Iaec38c7f,Ie21b649d,If460143b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I1f1402520959c1ea9fdd85e6b4a21e73704120e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357555Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798360}

This change relands the probabilistic corruption recovery feature that
we previously had in our AppCache update job loading path.  The goal
with this change is to allow us to resolve corruption in some AppCaches
without needing larger changes throughout the AppCache code.

This was cherry picked (with merge conflicts resolved) from
https://crrev.com/c/1869122 / commit 8c09070f.

Bug: 1033703
Change-Id: Ib2a5dc70d3f64aad7e39461d8e0c888cd464b66b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350188
Commit-Queue: Chase Phillips <cmp@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798359}

This CL makes unit_tests to run in non-experimental mode so that it's
Sheriffed and can run on CQ by default.

Bug: 1116180
Change-Id: Id3b5554352eb52bb7ef7ab289ba805f6a5683ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357674Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798358}

This is needed as a first step to preserve grouping information for text
nodes within an SVG. Grouping information will help Select-to-Speak
properly re-order text nodes within an SVG to match a natural reading
order.

AX-Relnotes: n/a

R=dmazzoni@chromium.org

Bug: 892822
Change-Id: I29ad9db045df95fef0acb1a5bab5aa9337911211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352614Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#798357}

Replaces methods like DialogModel::OnButtonPressed() with
DialogModelButton::OnPressed(), so that those calls from DialogModelHost
don't have to go through DialogModel.

This also makes the callback for DialogModelButton mandatory and removes
it from Params. The dialog buttons OK and Cancel are the exceptions that
don't need one and use a NOTREACHED() lambda.

The change also adds util::PassKey<DialogModelHost> to additional
DialogModelField methods to narrow the public API from methods that are
unnecessary for public consumption.

Bug: 1106422
Change-Id: I8f50e1ce48b2862fce3be5054d6c788c41846f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354637
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798356}

Add the input methods list. The functions and tests are mostly carried
over from os_languages_page.
Spec: http://go/cros-lang-settings-ux slide 23.
Current view: http://screen/5af70811-07e6-4ff3-bc1d-5fdfcd872d7c

Note: All strings are not finalised so they are translateable false
and no screenshots required.

Bug: 1113439
Change-Id: Ib110db9290d27eacba6578a153843d6c93b67a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352452
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798355}

This reverts commit 72e0b5bb.

Reason for revert: xenial builderless pool now has some idle bots
Traffics back down; should be fine to re-enable experiments.

Original change's description:
> infra: Remove all CQ experiments while the CQ is overloaded.
> 
> A small attempt at reducing overall traffic to various pools.
> 
> Bug: 1116532
> Change-Id: I9c36e08a9babfa4a69d62bb246950ae48890e94c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357412
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798233}

TBR=estaab@chromium.org,bpastene@chromium.org,gbeaty@chromium.org

Change-Id: I1862724f7be1991b7545bd9ccf16c92f18e28394
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357466Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798354}

https://skia.googlesource.com/skia.git/+log/8b07b9f55a73..43f49b4d52a4

2020-08-14 herb@google.com static routines for direct map vertices
2020-08-14 herb@google.com signal no clipping required
2020-08-14 egdaniel@google.com Add support for vulkan non coherent advanced blends.
2020-08-14 mtklein@google.com Reland "move conditions for JIT into SkVM.h"
2020-08-14 egdaniel@google.com Support making a VkRenderPasses with self dependencies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: Ia278650db6d9ea83d85623701d1edb3047d733c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357417Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798353}

Model the frame tree within the transform tree by adding a new field,
|parent_frame_id|. This field can be used to determine the node of the
parent frame of a given transform node to provide faster attribution
that's less stateful.

Bug: 910421
Change-Id: I7ebfd25c181d9af5c47ce9820d3a959582c83424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355397Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#798352}

Bug: 1114873
Change-Id: I2a6c49bb74aedbd387dca743db0e7743cd284f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357757Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Cr-Commit-Position: refs/heads/master@{#798351}

This CL implements the jank metrics that track abrupt drop in smoothness
(i.e. increase in frame latency). Jank metrics histograms are reported
under the "Graphics.Smoothness.Jank" namespace and the histogram names
indicate the frame sequence tracker (and its effective thread type) each
jank metric is associated with (e.g.
Graphics.Smoothness.Jank.Main.WheelScroll). Each jank occurrence is also
visualized as a trace event spanning the duration of the janky frame.

Bug: 1073216
Change-Id: I50bf8983d9c94cda68234d0423308beed1f8d5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248173Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798350}

This ends up being necessary for the Extensions API, which relies on the WebContents as the Tab handle rather than the local tabstrip+index combination.

Change-Id: I22f0d78f3fa83a351216cf55b2425079e6f08f25
Bug: 930988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354597Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798349}

The test case is flaky, at least on Linux.

Bug: 1116606
Change-Id: If4c477e9bd2eafd0fb07b9d60ec74aa8b9f489f2
Tbr: droger@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357614Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798348}

Before this patch, Android payment app finder would determine the TWA
package name directly through the package manager, which prevented the
C++ browser tests from mocking the TWA package name through the test
delegate.

This patch changes Android payment app finder to look up the TWA package
name through PaymentAppFactoryParams. The PaymentRequestImpl implements
the Params interface through the test delegate, which the C++ tests can
modify.

After this patch, android browser tests can simulate running inside of a
TWA.

Bug: 1061503
Change-Id: I4d5df8d10f80fbb81678e877496285bc8cedf8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300179
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798347}

Similar to IsWinNativeApiAuthenticator() and IsTouchIdAuthenticator(),
add IsChromeOSAuthenticator() which is only compiled on ChromeOS.

Bug: crbug:1115811, b:144861739
Change-Id: I80b88392e1c9edf501709ced7709db889370774b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357954
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#798346}

This makes it so icons there were downloaded more than 30 days ago
are removed. This is done to prevent the database from indefinitely
growing.

BUG=1076463
TEST=covered by tests

Change-Id: I9df9407124dd9364517bd31949ecf718fd7a9bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356050
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798345}

This change further implements the functionality of AutofillOfferManager. AutofillManager now accesses a singleton AutofillOfferManager via the AutofillOfferManagerFactory. AutofillOfferManager then prepares a request which is sent to the PaymentsClient to retrieve offer data. In further CLs, the data retrieved during these calls will stored and used.

Change-Id: I384c95f26b9b3094d9b3387d467134ef5998396e
Bug: 1093057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258154
Commit-Queue: Ben Blake <fiorito@google.com>
Reviewed-by: Anne Lim <annelim@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798344}

Using wpt-import in Chromium 19c29702.
With Chromium commits locally applied on WPT:
c71b9857 "Portals: Prevent closing of the portal window."
f99cd179 "[blink][wpt] Add more module evaluation order tests"
c4e342f7 "[COOP] access reporting: use camelCase for attributes."
e3ef31f6 "Fix typo s/Remove/Remote/."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I649ca9a9bc71719fbffe1a7300a04f4a5cbcfa4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357149Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798343}

This test occasionally triggers a fatal failure in
DataDecoder::GetService().

Bug: 1115762
Change-Id: I12a46b8ac2f9e3805269e3c4fef3985e0e961147
Tbr: khmel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357617Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798342}

testNonImmersiveStopsDuringImmersive is flaky because we receive a non-
immersive rAF callback, while there is an immersive session.
https://crrev.com/c/2354537 ensured that the frame loop will not be
started back until the page has been notified that the session ends, but
it is possible that a non-immersive frame has been scheduled already when
the session returns. This change speculatively patches the test by
allowing at most one frame to be received during an immersive session.
If this removes the flakiness, a more thorough product fix will be
investigated.

Bug: 1116261
Change-Id: I11d8b06c2a9c80503c30a687da97922ef3a04c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355014
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798341}

Screenshot with feature enabled:
https://screenshot.googleplex.com/tWdvKkwxU8G

RTL Screenshot with feature enabled:
https://screenshot.googleplex.com/QS1n2b9ytxr

Screenshot with feature disabled:
https://screenshot.googleplex.com/jtp4wPe9Ng1

Change-Id: I56896520e26fe877584850d37a1e3095317910dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327835Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Siddharth Shah <siashah@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#798340}

Change-Id: I498e2f963f28f83ba3e90822d45b25d2af98c525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354837
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798339}

This will allow clients to notify their users when a submitted username
password combination is determined to be leaked.

Change-Id: Ibcef0106c49084b2e9a5931b1c1970e13d58758b
Bug: 1096281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303553
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798338}

I think this is the lowest level where we can use the streaming
tokenizer directly without severe complications. A CSS value can contain
a custom property reference at any point, which necessitates switching
from parsing using the property's grammar, to parsing as an unresolved
value. That means either we have to buffer tokens at some point, or we
have to rewind the stream back to the start of the value and repeat
tokenization. I'm aiming towards the former because it's more compatible
with existing code and less likely to cause perf regression.

With that in mind, this CL also introduces CSSTokenizedValue to hold the
token range plus a view on the original string, for consumption by the
custom property handler in an upcoming CL. I've added a test to ensure
the string is captured correctly in the presence of !important.

Bug: 661854
Change-Id: Ic3bb882e0b766fc09d0c64e0dbee10690c475c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332374
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798337}

Found while rolling new WebGPU tests into Chromium. Sometimes they
output lines of only spaces (inadvertently, but still).

Without this, m.group(1) is sometimes None, and this crashes.

Bug: None
Change-Id: I181289c2d913285272abc7312f1d4e21b00a8bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357932Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798336}

This CL fix store rfh in bf cache when current navigation entry
is replaced (e.g from JS window.location.replace(url))
because in this case we don't store navigation entry and
we don't need store corresponding rfh in bfcache.

Bug: 1002978
Change-Id: Iaa15e13c5cb7c0b063d0db7b6d2eb54bc604a755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247033
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Auto-Submit: Alexandr Rakov <alrakov@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#798335}

Follow up after https://chromium-review.googlesource.com/c/chromium/src/+/2317956

Bug: 1090802
Change-Id: I58a849c2487b46aed5f3b68c610e17e69c36d726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353462
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798334}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

Bug: 1110266
Change-Id: I28ed9c686e52799b8b1efe159db1fb81443395f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352023
Commit-Queue: Sean McAllister <smcallis@google.com>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798333}

ChromeOS release for extensions side from 13408.0.0 should have the
new maps.

Bug: b/162803395
Change-Id: I744986aaa6c0e275cd08127c2395dcc29d96fc05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342486
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798332}

This code is for testing, so it's allowed to use explicit
colors/sizes.

BUG=none
TEST=none

Change-Id: I36fc232b27a4938c670bb44e8abbc2815c78f8df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357953Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798331}