- 27 Jan, 2018 40 commits
-
-
Vaclav Brozek authored
The user needs to reauthenticate both to view/copy and to export passwords. Once reauthenticated, the authentication is skipped for the next 60 seconds. Through authentication, the user grants an easy access to anybody holding their device in the next 60 seconds to the passwords on their device. The explanation message of the reauth prompt includes the scope of the approval (e.g., "to view your passwords" or "to export your passwords") of the _first_ reason to reauthenticate. To protect the privacy of the user, if they grant the access for a one-at-a-time access (e.g., viewing passwords) but then a bulk access (e.g., export of all passwords) is requested within the grace period of 60 seconds, Chrome ignores the grace period and requests the reauth again. Bug: 800686 Change-Id: Icc96bf490b13ba7ba172bc88fdef0ffdefaf97f2 Reviewed-on: https://chromium-review.googlesource.com/883525 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532254}
-
Scott Violet authored
Specifically this converts back to setting the ConfigurationPolicyProviders *before* the PolicyService is created. There is a subtle difference between this code and the way the code was before my patch. Specifically previously the code did the following: 1. ChromeBrowserPolicyConnector created, which added a bunch of providers from constructor. 2. BrowserPolicyConnectorBase::GetPolicyService is called, which creates the service and pushes the providers to the PolicyServiceImpl 3. local state/field-trials created. 4. BrowserPolicyConnector::InitInternal was called, which in turn called Init() on the providers. With this patch, order is now: 1. ChromeBrowserPolicyConnector constructor does very little 2. ChromeBrowserPolicyConnector::InitPolicyProviders is called, which creates the providers. 3. BrowserPolicyConnectorBase::SetPolicyProviders is called, which creates the PolicyService and calls Init() on all the providers and sets is_initialized_. 4. BrowserPolicyConnectorBase::GetPolicyService is called, creating the PolicyService. 5. local state/field-trials created. 6. BrowserPolicyConnector::InitInternal is called. Key differences: . ConfigurationPolicyProvider::Init() is called earlier. . Had to remove DCHECK in BrowserPolicyConnector::InitInternal() because SetProviders sets is_initialized_. BUG=806538 TEST=none Change-Id: I0981419cb1734208789639cc1713e49ac8e901c7 Reviewed-on: https://chromium-review.googlesource.com/889500 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#532253}
-
John Chen authored
This is a reland of aa7860c7, with the change to enable the ChromeDriver tests on release bot only. The original commit was reverted due to flakiness of the tests on debug build. The reason for the flakiness is debug build of Chrome takes a long time to start, usually between 20 to 40 seconds. The timeout for the test is 30 seconds, thus it can either succeed or fail depending on whether Chrome started quick enough or not. While it is possible to increase the timeout, spending over 30 seconds per test appears to be too much overhead in the long run. Also, the purpose of running these tests is to catch incompatibilities that can develop between Chrome and ChromeDriver, and running these tests on release builds should suffice for that purpose. Original change's description: > [ChromeDriver] Add ChromeDriver tests to Commit Queue > > This is the initial check-in of the feature to add ChromeDriver tests > to commit queue. It includes the following: > > * A new test target chromedriver_py_tests, to encapsulate dependencies > needed to run the Python-based ChromeDriver tests. This target is > currently enabled on Linux only. Other platforms will be added later. > > * Only a single test case is enabled. Enabling additional test cases > will be done later. > > Bug: 793370 > Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47 > Reviewed-on: https://chromium-review.googlesource.com/874816 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531234} Bug: 793370 Change-Id: Ic8873c326dfcd676552083d6f90aba29cc046e67 Reviewed-on: https://chromium-review.googlesource.com/885082Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532252}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fc20008819f3..d3c1b84a6e26 $ git log fc2000881..d3c1b84a6 --date=short --no-merges --format='%ad %ae %s' 2018-01-27 fmalita [skottie] Render DM frames out-of-order 2018-01-27 mtklein Revert "hide picture virtuals (no public callers)" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I02b187e0d3afe1434aeb43bff6e54f8785c0d303 Reviewed-on: https://chromium-review.googlesource.com/890460 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532251}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 712abc66. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11096 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: I7e040b7dabbfa5217aa0d5240f4d71ad1464d4e7 Reviewed-on: https://chromium-review.googlesource.com/889952 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532250}
-
Tom Anderson authored
BUG=806340 TBR=hamelphi@chromium.org Change-Id: Ib4e5091212d874d9ad88f3e9a1fdfee3ed7e0d5e Reviewed-on: https://chromium-review.googlesource.com/890059Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532249}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3ebeca61c483721c96b597c406910637d920fcb Reviewed-on: https://chromium-review.googlesource.com/887558Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#532248}
-
Thomas Anderson authored
This reverts commit 93f7aa87. Reason for revert: Causes failure in WebContentsVideoCaptureDeviceBrowserTest on Linux Tests (dbg)(1)(32): https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/47651 Original change's description: > FrameSinkVideoCapturer: Fix refresh logic for damaged sources. > > Fixes a couple of issues where frame capture becomes frozen or choppy, > with the following changes: > > 1. Move the "source dirty" logic out of VideoCaptureOracle and into > FrameSinkVideoCapturerImpl. > > 2. More-agressive response to frame refresh requests (needed for > improved mouse cursor update response). > > 3. Remove the distinction between passive and active refreshes from > VideoCaptureOracle. FrameSinkVideoCapturer now tracks source damage, and > can execute any refresh passively when there is no damage. > > 4. Add logic to ensure that FrameSinkVideoCapturerImpl provides > consumers with a refresh frame whenever key events occur; such as params > changes, capture target changes, etc.; that are known to require a full > update. > > 5. Re-enable the content_browsertests that were disabled due to > flakiness. > > Bug: 785072, 754872 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I402f3f928de61e6754e04014327421e4f6917d5f > Reviewed-on: https://chromium-review.googlesource.com/884996 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532161} TBR=miu@chromium.org,kylechar@chromium.org,xjz@chromium.org Change-Id: I32fd2fb0bf1e1dc32c026198809d12ff2ecc69f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785072, 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/890380Reviewed-by:
-
dpapad authored
Bug: 800773 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I546e25b3748e455449ee3c0a541c5a6658ee2504 Reviewed-on: https://chromium-review.googlesource.com/884847 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532246}
-
Scott Violet authored
the viz::FrameSinkId is not used when mus is hosting viz (the current code DCHECKs in mus as we end up supplying an invalid FrameSinkId, which triggers a DCHECK). To address this address a struct with param traits to ensure the FrameSinkId is set when appropriate. BUG=804508 TEST=covered by tests Change-Id: I1949d546d7aa7db39dc0ad2116694b614b3b875f Reviewed-on: https://chromium-review.googlesource.com/887619 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Yi Gu authored
The current cc/animations logic assumes a single animation has a single keyframe effect and can only affect a single layer. To enable animations with multiple keyframe effects, cc::AnimationPlayer need to support multiple AnimationTickers each corresponding to one keyframe effect. Currently there is a 1:1 relationship between AnimationPlayer and AnimationTicker. This patch is to extend it to 1:n. Here is a summary of changes: - Introduce a sub-class of AnimationPlayer, a.k.a SingleTickerAnimationPlayer, to handle the existing logic (single effect). SingleTickerAnimationPlayer owns only one AnimationTicker as the AnimationPlayer does today. - Currently a AnimationTicker is created upon creating AnimationPlayer. In this patch, tickers are created separately and added to the player afterwards. Tickers that the player owns may belong to different targets therefore the player needs to coordinate with AnimationHost regarding this situation. - Adjust existing unit tests according to the changes above. Bug: 767043 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibd2ed2f396effec9fbc206ff52c7b94474342d39 Reviewed-on: https://chromium-review.googlesource.com/742162 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#532244}
-
Alexei Filippov authored
BUG=803276 Change-Id: I1722ef6d2a9b529919189d7babb767bfc7cbbf83 Reviewed-on: https://chromium-review.googlesource.com/888328 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532243}
-
Alexei Filippov authored
The profile type is put behind a hidden experiment. BUG=803276 Change-Id: Ieb16c0eda7653ac90ef5ce8fc2008b724b2af4e8 Reviewed-on: https://chromium-review.googlesource.com/884574 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL makes sure that Blink code that needs to consult the current input event considers events going either through WebViewImpl or through a WebFrameWidgetImpl. The CL removes separately maintained |current_input_event_| fields from WebViewImpl and WebFrameWidgetImpl (the latter was never read anyway) and consolidates them into a new class - CurrentInputEvent. Bug: 804838 Change-Id: I89430f3a73f38ef5842c57635602fb079c1a34ef Reviewed-on: https://chromium-review.googlesource.com/887346Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#532241}
-
Ian Vollick authored
This CL uses base::Versions built-in comparison logic rather than my incorrect, hand-rolled code. It also swaps out the color scheme when the component has a gradient. Also reduces the number of stars used with these environments. Bug: 806452,806471 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I250692105e680e1f3d0fee372f6886f35f2ced95 Reviewed-on: https://chromium-review.googlesource.com/889842 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#532240}
-
Ryan Sleevi authored
As documented at security.googleblog.com/2017/09/chromes-plan-to-distrust-symantec.html, support for Legacy Symantec Certificates issued prior to 2016-06-01 is being removed in Chrome 66. As part of removing such support, this simplifies the API for the console warning message, as now there is only one pending deprecation. Bug: 805459 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6c2c8b59f1ad016914ab8f1eaeb4f35bb367df3d Reviewed-on: https://chromium-review.googlesource.com/883728Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532239}
-
Jiaquan He authored
Use callbacks instead of returned values to match mojo implementation in the future. Bug: 733662 Change-Id: Ia79a4667117da433d8c335d9c533d80300ae03a4 Reviewed-on: https://chromium-review.googlesource.com/885622Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#532238}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10264240..b4e468e1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4e9e711ab061b26540cc4eb8c3d2e1ee691aabe3 Reviewed-on: https://chromium-review.googlesource.com/889770Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532237}
-
Nico Weber authored
Bug: 177475 R=vollick@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib6d33bcaf7f42728bd996b1e7bfac42033a293fd Reviewed-on: https://chromium-review.googlesource.com/889786Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=jinho.bang@samsung.com Bug: 177475 Change-Id: I36c993f60404a15fb343c4ae174ea5cb18e959c6 Reviewed-on: https://chromium-review.googlesource.com/889944Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#532235}
-
Nico Weber authored
This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 177475 Change-Id: Ic2b13759fe218e4c4113d8c11f7cd53e13a4d173 Reviewed-on: https://chromium-review.googlesource.com/890066Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#532234}
-
Alexei Filippov authored
It retrieves the currently collected native heap sampling snapshot. The renderer process had to be started with --sampling-heap-profiler flag to obtain the snapshot. BUG=803276 Change-Id: I26ffe5e366abb33245d2f83ffa02bd4350737b7a Reviewed-on: https://chromium-review.googlesource.com/882290 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 177475 Change-Id: Id02b3a1603067804da2cc6bcb494dabba3cb1a57 Reviewed-on: https://chromium-review.googlesource.com/889730Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#532232}
-
Fabio Tirelo authored
This fixes two accessibility issues: - title not updated when state changes; - focus changed to the end of the page when UI is updated. Bug: 806324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a274a96b1bb5fabca8278e8241d91fb0a4be93c Reviewed-on: https://chromium-review.googlesource.com/889578Reviewed-by:
-
Abhishek Bhardwaj authored
The instance can't set wake up alarms due to not having the CAP_WAKE_ALARM capability. This change adds a mojo service that will let the instance set wake up timers by calling into this service that will eventually call into powerd using Dbus. BUG=b:64581307 TEST=Tested manually by verifying the instance client gets callbacks. Change-Id: I98115694062efb9f3a8ce962a6f232a548493298 Reviewed-on: https://chromium-review.googlesource.com/714880 Commit-Queue: Abhishek Bhardwaj <abhishekbh@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#532230}
-
Yuta Kitamura authored
This patch removes a method from WebTaskRunner. At this point, WebTask- Runner is functionally identical to base::SingleThreadTaskRunner, and we can start working on the actual removal of WebTaskRunner. WebViewSchedulerImplTest is also modified so it doesn't depend on the removed function. Bug: 794845 Change-Id: I2945c890e7e957f7187103f46f71a314c77c90fb Reviewed-on: https://chromium-review.googlesource.com/888378Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#532229}
-
Khushal authored
Ensure that the memory returned when serializing a filter is resized to the number of bytes written. Otherwise the message serializes the complete buffer allocated initially. R=rockot@chromium.org, tsepez@chromium.org Bug: 805585 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia85688cbd77529c2f6e9c044de9a83a254787442 Reviewed-on: https://chromium-review.googlesource.com/885511Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Matt Mueller authored
Also call SetGlobalCertNetFetcher on OS_FUCHSIA (where CertVerifyProcBuiltin is the default). Bug: 649017,762380 Change-Id: I39ee5de34dd96914189f323ecbaffabfc645b642 Reviewed-on: https://chromium-review.googlesource.com/884841Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=svillar@igalia.com Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie848e8562e5cfac15458e83142bee69df76c4c88 Reviewed-on: https://chromium-review.googlesource.com/889727Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532226}
-
Nico Weber authored
This CL was uploaded by git cl split. R=fmalita@chromium.org Bug: 177475 Change-Id: I0a26702441737b9c47b5608f0908f66e5d8340fe Reviewed-on: https://chromium-review.googlesource.com/890062Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#532225}
-
Findit authored
This reverts commit 69f0b0d2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 532221 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY5ZjBiMGQyMWRjNmEzZDk3YmZhNGNiMDU5MTkzZGI5OWNiMDAwNTEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/44876 Original change's description: > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > to it. > > BUG=805507 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > Reviewed-on: https://chromium-review.googlesource.com/889916 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532221} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If84b7f7f1159d8e5ee525ef0bf7104f867fb933b Reviewed-on: https://chromium-review.googlesource.com/890539 Cr-Commit-Position: refs/heads/master@{#532224}
-
Dmitry Gozman authored
- linear lookup changed to map; - NotifyNavigated just once per frame; - do not attach to service worker from each OOPIF. Bug: 805757 Change-Id: I1c912cf52fb74afc5eeb8a9fe8ae35f422eda8c9 Reviewed-on: https://chromium-review.googlesource.com/885244 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
We now fully support network from OOPIFs, so the notice is not needed anymore. Bug: 750901 Change-Id: If7bc2a291a35cbc9acc55c9248dd3a9f0efa994c Reviewed-on: https://chromium-review.googlesource.com/887630Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532222}
-
Alexander Alekseev authored
This CL limits Sync settings screen to Google Chrome build and adds Chrome logo to it. BUG=805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 Reviewed-on: https://chromium-review.googlesource.com/889916Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#532221}
-
Dmitry Gozman authored
To support this, we issue inspect element command to the agent beforehand, and dispatch it in the next session which attaches (or the existing one if any). This moves InspectElement from DevToolsSession interface to DevToolsAgent interface, as there might be no session yet. Note this could fail in case of multiple sessions, one of which is DevTools frontend, by choosing the wrong one. This is a rare case though, so we can tolerate that. TBR=alexclarke@chromium.org Bug: 755515, 804100 Change-Id: I331bfb7f5410868fd47bfe8d558b54b7a30de00c Reviewed-on: https://chromium-review.googlesource.com/881522Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Katie Dektar authored
This will be launched in Chrome 65 (see launch bug). Bug: 785018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd26e1bbede7e21c547df51a5edc7397167a74b5 Reviewed-on: https://chromium-review.googlesource.com/813076Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532219}
-
Nico Weber authored
This CL was uploaded by git cl split. R=dtapuska@chromium.org Bug: 177475 Change-Id: I78e1026f86a8defe0fb7fb3683dd288f7b376dcd Reviewed-on: https://chromium-review.googlesource.com/889734Reviewed-by:
-
Raphael Kubo da Costa authored
Architecturally, there is nothing really preventing garbage-collected types from being used with Optional<T> other than avoiding misuse. Relax the existing checks by removing the ones in place in Optional.h itself, but keep OptionalGarbageCollected in //tools/clang/blink_gc_plugin. In practice, this is a relaxation of the rules that: * Allows Optional<HeapVector<T>> (and other Oilpan containers). These containers do not inherit from GarbageCollected or GarbageCollectedMixin, but do have the IS_GARBAGE_COLLECTED_TYPE() macro in their declarations. As we are moving to replace the binding layer's Nullable<T> with wtf's Optional<T>, doing so makes things uniform by letting Optional<> be used with both Vector and HeapVector types so that Web IDL's sequence<long>? and sequence<Document>? are both translated into C++ as Optional<T>. * Types that do inherit from GarbageCollected or GarbageCollectedMixin are still disallowed by the checks in blink_gc_plugin since none of the changes to get rid of Nullable<T> require them to be turned off or relaxed. Web IDL's Document? is still represented as Document* in C++. TraceTrait<T> had to be augmented with a specialization for Optional<T>, as we may need to Trace() its inner type if it's a GC container type. Bug: 798464 Change-Id: I12cad41976219654985f5a8d560e7db3f4cedf82 Reviewed-on: https://chromium-review.googlesource.com/888918Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#532217}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/143d9c6f..10264240 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic68f0c33cddf21e7048467e39ecf0a840542d912 Reviewed-on: https://chromium-review.googlesource.com/890359Reviewed-by:
-
Dave Tapuska authored
It appears ipc_channel_mojo only calls ChannelError when the remote side is closed. If we are in a blocking object wait on the UI thread in the browser the ChannelClosing message won't be posted until the UI thread is unblocked. The ChannelClosing message is sent when the host side of the channel is actually closed; not when the remote site closes the channel. SynchronousCompositorBrowserFilter appears to be the only object that waits on an object like this. BUG=722928 Change-Id: Ie1fd2a4cf651317fdc197d3e260b2b7bd759d9cd Reviewed-on: https://chromium-review.googlesource.com/887289 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
