GitLab

This patch changes the sampling rate of `powermetrics` from 20hz to the default - 5s.  We don't need the extra resolution for our measurements and it seems that increasing the sampling rate draws power in and of itself which affects what's being measured.

BUG=None

Review URL: https://codereview.chromium.org/322423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245436

Review URL: https://codereview.chromium.org/324953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276596 0039d316-1c4b-4281-b951-d872f2087c98

To use, make a BPF program return ErrorCode(ERR_TRACE + ret_data), where
ret_data is a 16 bit value that will be available to the tracing process
via PTRACE_GETEVENTMSG.

BUG=231000

Review URL: https://codereview.chromium.org/278583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276595 0039d316-1c4b-4281-b951-d872f2087c98

Knowing which window managers Chrome is most often used on will help in testing in new feature development.

BUG=372580
TEST=None

Review URL: https://codereview.chromium.org/330493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276593 0039d316-1c4b-4281-b951-d872f2087c98

Finding whether you are running 64-bit or 32-bit is proving tricky for users
since the chrome://version page is not linked anywhere.

This adds "64-bit" string to the chrome://chrome page for 64-bit builds.

BUG=381246

Review URL: https://codereview.chromium.org/326773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276592 0039d316-1c4b-4281-b951-d872f2087c98

- Make observers to external services sticky over re-initialization.
- Leave SyncWorker NULL when non sign-in state.
- Observe sign-in event and trigger initialization on it.

BUG=374101,380615

Review URL: https://codereview.chromium.org/324343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276591 0039d316-1c4b-4281-b951-d872f2087c98

VideoCaptureDevice Win: Enumerate devices' supported formats when they don't have a DevicePath property.

BUG=380939

Review URL: https://codereview.chromium.org/328463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276590 0039d316-1c4b-4281-b951-d872f2087c98

Add a global device color profile cache and use it to extract the
color profile associated with screen display devices.

TEST=ui_unittests.exe --gtest_filter="ColorProfileTest*"
BUG=368694

Review URL: https://codereview.chromium.org/312723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276589 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/326303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276588 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step in refactoring the (overly-gigantic)
extension_service_unittest.cc

BUG=381251

TBR=atwilson@chromium.org (c/b/background/)
TBR=bauerb@chromium.org (c/b/managed_mode/)
TBR=battre@chromium.org (c/b/profile_resetter/)
TBR=pkotwicz@chromium.org (c/b/themes)
TBR=koz@chromium.org (c/b/ui/app_list)
All TBRs are for simple mechanical changes (primarily namespace move).

Review URL: https://codereview.chromium.org/318863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276587 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds GinJavaMethodInvocationHelper class which serves
for coercion of arguments and return values of Java methods to / from
base::Value and GinJavaBridgeValue.

The coercion code is taken from the existing implementation
(JavaBoundObject) with required conversions to use base::Value and
GinJavaBridgeValue instead of NPVARIANT and friends.

There are extensive Java tests for coercion, so here we only add some
unit tests for edge cases.

This patch also adds a trivial EventLog class for writing into Android
Event Log from C++ code.

BUG=355644
R=bulach@chromium.org, torne@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/302173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276586 0039d316-1c4b-4281-b951-d872f2087c98

This is to fix permission breakage on extension background pages after
blink patch r173044. Before this patch, permission settings were loaded
on V8 context initialize. However, the blink patch deferred the V8
context initialize until its first use.

This patch adds a call to |Dispatcher::InitOriginPermissions| on
|Dispatcher::OnActivateExtension| which is called when render process
for the extension is created.

TEST=Manually confirmed that Files.app image viewer can load images
on its first load.
BUG=380346, 380502

Review URL: https://codereview.chromium.org/315143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276585 0039d316-1c4b-4281-b951-d872f2087c98

Two remaining issues:
1. It seems that WebviewGuest doesn't support SharedWorker yet, so this CL
   doesn't include the changes for SharedWorker.
2. To request file system access for operations like getFile(), removeFile() etc., I have to set "unlimitedstorage"
   permission in manifest.json, otherwise will get QuotaExceededError (request persistent storage without "unlimitedstorage" permission). Any idea?  


BUG=343382

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276251

Review URL: https://codereview.chromium.org/306473012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383430

Review URL: https://codereview.chromium.org/333443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276583 0039d316-1c4b-4281-b951-d872f2087c98

 Used to maximize menu as well.

Toggle home card when ctrl-l is pressed.

BUG=380438
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/332463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276582 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276581 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175950:175978&mode=html
TBR=yhirano@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276580 0039d316-1c4b-4281-b951-d872f2087c98

r249463 was intended for this, but it turned out --prerender=enabled is
specified by default for Android and prerender is enabled for 100%
users.

BUG=341056

Review URL: https://codereview.chromium.org/321943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276579 0039d316-1c4b-4281-b951-d872f2087c98

* add vendor id and custom display name to media selection
* propagate selected media size in PrintSettings Related 
Сhanges in JS:
* Use media custom diaply name received from the native layer 
* Make sure media size selection is propagated to the native layer

BUG=239879
NOTRY=true

Review URL: https://codereview.chromium.org/325313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379961
NOTRY=true

Review URL: https://codereview.chromium.org/329033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276577 0039d316-1c4b-4281-b951-d872f2087c98

While trying to figure out why Firefox does not work with the peerconnection.html page I discovered we never caught the actual error message for RTCPeerConnection and createAnswer/Offer in the error callbacks.


TEST=P2P calls between tabs using Firefox and Chrome.
BUG=378199

Review URL: https://codereview.chromium.org/306033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276576 0039d316-1c4b-4281-b951-d872f2087c98

(This CL merges changes until last Friday).

Change the QUIC TLP to send new data instead of retransmitting old data
when new data is available.

Also tighten up the QuicSentPacketManagerTest for TLP per avd's request.

Merge internal change: 68731782
https://codereview.chromium.org/327383002/


Use override consistently instead of virtual.

Merge internal change: 68717267
https://codereview.chromium.org/325373002/


QUIC - added code to read kUAID in the server code from the CHLO
message.

The following is the list of kUAID strings for chrome built by google.

The following is true for all platforms for clients built by
google (android, posix, windows and chromeos).

UAID: "unknown Chrome/37.0.2029.0" chrome developer's builds.
UAID: " Chrome/37.0.2029.0"        Stable
UAID: "canary Chrome/37.0.2029.0"  Canary
UAID: "dev Chrome/37.0.2029.0"     Dev
UAID: "beta Chrome/37.0.2029.0"    Beta

Merge internal change: 68715745
https://codereview.chromium.org/333523002/


Minor change to keep the code similar between chromium and internal
source tree.

+ use SupportedVersions.
+ One line per argument.
+ Minor fixes to comments.

Merge internal change: 68659711
https://codereview.chromium.org/335433002/


Changed  SetIpInfoInCmsg to return the length of the packet info
structure used.

Merge internal change: 68639530
https://codereview.chromium.org/329223003/


(minor) rename frames_ to buffered_frames_ in QuicStreamSequencer

Merge internal change: 68571729
https://codereview.chromium.org/329403003/


Enables PacketGenerator's use of PacketCreator's FEC primitives.

Adds methods in PacketGenerator that enable use of the PacketCreator's
FEC primitives, and adds tests for these methods.

Merge internal change: 68558082
https://codereview.chromium.org/326403006/


Connection level flow control (CLFC) accounting on receipt of FIN/RST
for already closed streams.

This implements the following behavior discussed internally.

  Proposal: implement rch/jar's solution from earlier in the thread, in
  which "bytes sent" is added to the RST frame, and each endpoint must
  send a FIN or RST containing "bytes sent" on stream termination.

  This gets the job done pretty simply, and will make our flow control
  very similar to SPDY. We can investigate more exotic dynamic stream
  window scaling (as per avd's suggestion earlier in the thread) in
  future if SPDY-style flow control is shown to be a problem.

A stream *must* send either a FIN or a RST on termination, either of
which contain enough data that the peer can definitively determine how
many bytes were sent on that stream (this is already implemented). This
CL implements the correct CLFC accounting of these frames when received
after the stream has been closed locally.

Motivating example: Client sends GET+FIN, Server sends response. Before
response arrives, client RSTs the stream (user closed tab?), tearing
down local state. Before this CL, when the server response arrives it
just gets dropped - but the server has counted the bytes sent against
its CLFC _send_ window. The client will not count these bytes against
it's CLFC _receive_ window, and so the endpoint states are now out of
sync.

To fix this, when a stream is closed we store the current "last bytes
received offset" in a map in the session, and handle a FIN/RST for a
closed stream by removing the difference between the final byte offset
from FIN/RST and the stored value from the map to the CLFC receive
window.

QUIC: Connection level flow control accounting on receipt of FIN/RST for
already closed streams. Protected behind existing flag:
FLAGS_enable_quic_connection_flow_control

Merge internal change: 68555475
https://codereview.chromium.org/320263003/


Add QuicStreamSequencerPeer to quic/test_tools, to make stream sequencer
tests more consistent with other tests.

Merge internal change: 68553409
https://codereview.chromium.org/318333002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/327393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276575 0039d316-1c4b-4281-b951-d872f2087c98

MediaSource renderer wasn't marking keyframes properly, and as result
SourceBuffer would keep all data it receives forever. Also added
explicit remove() call to cleanup the buffers before each keyframe.

Beside that changed default duration to a correct value instead of 1s
It currently doesn't cause any problems, but it may in the future if 
MediaSource implementation is changed to handle overlapping frames
differently.

BUG=321825

Review URL: https://codereview.chromium.org/329663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383100

Review URL: https://codereview.chromium.org/332513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383153

Review URL: https://codereview.chromium.org/321363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276572 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kalman@chromium.org
BUG=383452

Review URL: https://codereview.chromium.org/327243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372291
TEST=None

Review URL: https://codereview.chromium.org/305533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276570 0039d316-1c4b-4281-b951-d872f2087c98

For some devices, we does not include 2x theme assets.  But the devices can be
connected HiDPI displays. In that case, 2x assets are routed to fallback 1x
assets. To show the fallbacks in correct size, we need to specify the icon size
explicitly.

BUG=382971
TEST=remove chrome_200_percent.pak and launch chrome with '--force-device-scale-factor=2'
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/335563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276569 0039d316-1c4b-4281-b951-d872f2087c98

Make page_runner more tolerant to cloudStorageError (crbug.com/369611).

BUG=368061

Review URL: https://codereview.chromium.org/329143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276568 0039d316-1c4b-4281-b951-d872f2087c98

The new translate UX uses bubbles instead of infobars.
Views uses the new UX by default, Mac will soon too.
(IDRs x-plat API should be removed after Mac switches)

Remove code unused since r248162 (4 months ago).
Stub out ChromeTranslateClient::CreateInfoBar for Views.

This should simplify Elliot's WIP MenuButton CL:
https://codereview.chromium.org/298813002
(these applied TextButtonBorders to MenuButtons instances)

BUG=276181,288554,241691,383235,155363
TEST=No Translate behavior changes; no complaints.
R=sky@chromium.org,pkasting@chromium.org,toyoshim@chromium.org
TBR=hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/325483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276567 0039d316-1c4b-4281-b951-d872f2087c98

The original r276450 was reverted in r276476 for leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954
Fixed here by calling AddChildView(title_) on Tab (duh).

Add a Label view to Tab for displaying the title.
Remove Tab::PaintTitle, bounds and font members.
Remove unnecessary Tab::Get[Title|Icon]Bounds helpers.
Update the text on Tab::SetData, not during paint.
Use gfx::DirectionalityMode, remove the Label enum.

Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment.
Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD.
Always flip left/right in Label::SetHorizontalAlignment.
Have Tab and MessageBoxView use ALIGN_TO_HEAD.

Update comments and tests, related minor cleanup.

TODO: Make Label cache RenderText objects.
TODO: Make RenderText support ALIGN_TO_HEAD.

BUG=240037
TEST=No visible Views tab title changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/329813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/323763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380987

Review URL: https://codereview.chromium.org/327943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276564 0039d316-1c4b-4281-b951-d872f2087c98

Rename HistoryService::NotifyRenderProcessHostDestruction to
ClearCachedDataForContextID.

BUG=371827
R=sdefresne
TBR=sky (chrome/test/base/testing_profile.cc)

Review URL: https://codereview.chromium.org/322983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383153

Review URL: https://codereview.chromium.org/329723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276562 0039d316-1c4b-4281-b951-d872f2087c98

The idea here is to elminate the ambiguity about who owns what and protect
about misuse by callers.

BUG=381710

Review URL: https://codereview.chromium.org/318143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276561 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276560 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grd[p] to work well with the
translation tools.

This patch should precede using upstream libaddressinput to ensure that
the upstream libaddressinput has the correct strings well ahead of using
it in Chrome.

Although the strings include postal code examples and links for error
messages, these features are optional and can be turned off if
undesired.

BUG=327046

Review URL: https://codereview.chromium.org/304223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276559 0039d316-1c4b-4281-b951-d872f2087c98

Blink-side change: https://codereview.chromium.org/324003002/

BUG=380988

Review URL: https://codereview.chromium.org/328973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276558 0039d316-1c4b-4281-b951-d872f2087c98

Changed the layout of the App Info Dialog according to UI feedback. This
includes removing the tabs, and replacing it with a single, scrollable
dialog that has all the information in a single pane.

BUG=364681,266739

Review URL: https://codereview.chromium.org/327743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276557 0039d316-1c4b-4281-b951-d872f2087c98