- 10 Nov, 2020 40 commits
-
-
Tom Anderson authored
The default GTK error handler exits the process, which we don't want. We used to reset the error handler at some point after GTK initialization, but this became lost after r815319. Also refactor the XlibLoader instance to be global so it doesn't have to be created multiple times for each connection. R=sky Bug: 1145929 Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825585}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/26e2a89598d6..32b14552d662 2020-11-09 wl@gnu.org * src/type42/t42parse.c (t42_parse_sfnts): More tracing messages. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: Ia093dde5916f38386b323910bb6f1288e79aa324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825584}
-
Christopher Lam authored
This CL disabled the Python 3 version of the GRIT presubmit as it causes bots to hang when running test_suite_all.py. Bug: 1145395 Change-Id: I90426733f40496a97a029d79e83cb0a91945bb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518306 Auto-Submit: calamity <calamity@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#825583}
-
Alexander Bolodurin authored
It was dropped in https://crrev.com/c/2464518 which may result in all errors being reported as base::File::FILE_ERROR_NOT_FOUND. Bug: 1049966 Change-Id: I78e1ac5bf664c49ecebf130d23737f8dad3721a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505341 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825582}
-
Liquan (Max) Gu authored
Before the CL, PaymentRequestUi takes waitForUpdatedDetails from CPRService by PaymentUiService.Delegate.waitForUpdatedDetails(). Using a delegate is not as simplified as a method parameter. After the CL, PaymentRequestUi takes the value by method parameters. Change-Id: Icb61a32c6df6d6f2b01d6f6669483cd4b2111b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527543 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825581}
-
Sigurdur Asgeirsson authored
It's replaced by base::ScopedObservation for observing a single source, or base::ScopedMultiSourceObservation for observing multiple sources. Bug: 1145565 Change-Id: Iadc2e3efee7860e1b17b86b077d4c6a2566b6a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527541 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825580}
-
Yuke Liao authored
This CL cleans up checkout_presubmit_ash_chrome DEPS hook because all CI/CQ builders have been switched to build ash-chrome from ToT. Bug: 1129223 Change-Id: I9de1f832ae29d3fe7eea85d67cd822b8c999c767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518080 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825579}
-
Christopher Cameron authored
This flag gates whether or not we specify kCGLPFAAllowOfflineRenderers, and whether or not we call CGLSetVirtualScreen to manually migrate our compositing/raster contexts on GPU switch. ARM DTKs only have the single integrated AGX GPU, and do not recognize external GPUs, so this is necessarily untested. Indications are that it would be a good idea to add this to our initial ARM shipping build. Note that this would enable the flag even on single-GPU systems, because we haven't been able to test multi-GPU detection code on multi-GPU ARM machines (and so this could end up being unused if that code failed to detect the multi-GPU configuration). Bug: 1131312 Change-Id: I38404a8fc380d9f7542f0aaf93f969893815fac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522431Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#825578}
-
zhiyuancai authored
This CL corrects the message card close button color in incognito mode under dark theme. Bug: 1145869 Change-Id: I4803b7d9c078b7c16f4e6b39aca7be99228e0f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527342Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#825577}
-
Michael Lippautz authored
Avoid using blink::* types in WTF where easily possible. Bug: chromium:1056170 Change-Id: I78da26f10a3e1f0b049aff00f5ab064273fe9ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527422 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#825576}
-
Tomasz Wiszkowski authored
This change ensures that certain specialized suggestion types are not used to backfill the suggestions list when the AutcompleteController did not get the chance to complete collecting results. These suggestions are particularly important to be removed, because: 1. these are zero-prefix suggestions and should not be shown when the user is typing and 2. these suggestions are expensive to create, causing a noticeable slowdown of the user interface. Bug: 1145722 Change-Id: I6e5024cde7d2033f942af6e07db24b62d98e0bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522631Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#825575}
-
Anupam Snigdha authored
Added helper functions that check whether a given node has list or list items tags. This is used in editing commands for list related operations. Bug: 942133 Change-Id: I950a0c8a5e0b87eeed091d68cebab921ddc55d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527961 Auto-Submit: Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825574}
-
Tom Anderson authored
This CL removes the link-time dependency for Xlib, at least for //ui/gfx/x. There are still some lingering components (eg. Angle) that link against Xlib, which I'm going to investigate separately. R=sky Bug: 1066670 Change-Id: I699a29f28077d51c98f2c021944c10aca9ff5b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508226 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5de0b38dd133..823b1537f71e 2020-11-09 kjlubick@google.com [canvaskit] Add config key and manual mode to unit test harness. 2020-11-09 mtklein@google.com align SkAlignedSTStorage<N,T> to T 2020-11-09 jvanverth@google.com Update code-signing script to have better error messages. 2020-11-09 mtklein@google.com re-enable tests on GCC (and Clang o_O) 2020-11-09 johnstiles@google.com Add unit test for fuzzer-detected error with in vars. 2020-11-09 mtklein@google.com init SkSTArray storage before passing to SkTArray If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I643834add167c7c09c57b6e7d1e8a6237e1253e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527786Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=boliu@chromium.org Change-Id: I788f679615f4890fc58eb0411f6e8209daa46d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525766 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825571}
-
Kevin McNee authored
Several of the functions here are never called. Several others are only called from WebView::ApplyWebPreferences which is within blink so it can simply call the RuntimeEnabledFeatures functions directly. We also correct links in related documentation. Bug: None Change-Id: I2317f0c5ce328db14cb1e1e2c2ccf3d45bb13c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522002Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#825570}
-
Sajjad Mirza authored
This assignment was overridden immediately afterward, and is duplicated later, so it's safe to delete here. Change-Id: I5b5f607de57909f097d6eb5df629cd954f619a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523523 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825569}
-
Chan Li authored
This reverts commit 11931d6d. Reason for revert: ResultDB bq_export is back to normal Original change's description: > Temporarily disable test results export to GPU-specific bq tables > > TBR=nodir,bsheedy,vadimsh,gbeaty > > Bug: 1145735 > Change-Id: Ia6793aa3c3198ab0b425ec9048c15490f353c32a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519879 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824189} TBR=vadimsh@chromium.org,nodir@chromium.org,robertocn@chromium.org,bsheedy@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145735 Change-Id: I841fbb611971416fb434e0e96aec4e378a0a1b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527735Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825568}
-
Erik Chen authored
There is no system tray on ChromeOS so it does not make sense to create status icons. Bug: 1128963 Change-Id: I1a14371bd5a9d8c5e70ea72179308681917a1fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528126 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
Since SVGImage::PopulatePaintRecordForCurrentFrameForContainer() is downstream of both of the PaintImageForCurrentFrame() implementations, just let it set the completion state and don't expose this state publicly on SVGImage. Change-Id: Icb3a4a1aa263a04098cb6358f5d7bbb9923e37a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526427 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825566}
-
Chan Li authored
This reverts commit 5083892c. Reason for revert: ResultDB bq_export is back to normal Original change's description: > Temporarily disable test results export to GPU-try bq tables > > TBR=nodir,bsheedy,vadimsh,gbeaty > > Bug: 1145735 > Change-Id: Id7921fbacb0fedfd3500fd86953173fa63eb80b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518699 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824198} TBR=vadimsh@chromium.org,nodir@chromium.org,robertocn@chromium.org,bsheedy@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145735 Change-Id: Ib023d524b4673ed3eecb8ca8b38ed450f18f031b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528570Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825565}
-
Clark DuVall authored
This change implements multi-level splits by first merging all the second level DFMs into the parent module, then splitting them out using DexSplitter. This is simpler than trying to use TraceReferences, and seems to work better for now (minus some workarounds needed for DexSplitter problems, see crbug.com/1145287 for more details). I want to try enabling this in canary to see if we have any issues. This is behind another gn flag so it can be easily turned off if necessary. We currently don't support using @CalledByNative methods in isolated splits since it will require some work on the JNI side, so the vr module is left merged in the chrome module. This change also moves all the R.java classes into the base module to match the resources, these are the changes in write_build_config.py. Bug: 1145287 Change-Id: I4b530b0ee470c72712f203df55fba0e2b67718a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518184Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825564}
-
Bill Budge authored
- Removes Flash plugin metadata, to help plugin tests pass. Bug: chromium:977738 Change-Id: I6e131c9afe92793c3f449d7702088ab8198bdbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523556Reviewed-by:
-
Michael Hansen authored
This disables the contact visibility card radio buttons until contacts are successfully downloaded. Screenshot: https://screenshot.googleplex.com/C8KWKrp7AivjbQx.png Bug: b:168841167 Change-Id: I62f44111bb5f1a55c035576e0d5cfc14869ab2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523443Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#825562}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5226a88fe0de..59992a0fea40 2020-11-09 jalyn@microsoft.com Settings: Fix keyboard navigation of shortcuts list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62e49cbba67b936a1808ecdcfbe2b9ed710fa2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527785Reviewed-by:
-
Xing Liu authored
Add accessibility strings for bookmark bottom sheet. Bug: 1133496 Change-Id: If5b4ef63e27fc0f0439cfd19b09e022adc85517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523731Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825560}
-
Domenic Denicola authored
* Flips the pass condition for worker interaction. A module worker does not impact the import map of the outer page, since its constructor takes a URL, not a specifier that needs resolution. * Removes leftover built-in module support and @std references. * Removes .tentative filename suffixes. * Renames "common" to "data-driven". * Renames parsing.tentative.https.html to parsing-internal.https.html so that all internal tests to have -internal in the name. We should move them out of WPT (or convert them to not require internals), eventually, but for now making the difference clear is good. * Moves "core" tests up to the top level. * Removes references to future fetch-based import maps and Chromium implementation limitations. * Adds OWNERS and META.yml Bug: 1026809 Change-Id: I1807468a813ebee416cd8e05a272dbae6ea157bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491616Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825559}
-
Darwin Huang authored
Bug: 1146675 Change-Id: I382dcb5c0b09a26e3c397ebef46947f626e2aef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527065Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825558}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/934ac6ebdf6b..982b2a757087 2020-11-09 sokcevic@google.com Add move change to Gerrit recipes 2020-11-09 tandrii@google.com Temporarily remove iannucci@ from OWNERS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147155 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I409d3a9f7d8d59d041dd522fc03ad086045df1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527789Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0bec1380d03d..9b7f81867ddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88419d08994b5406f8a4a798b6d354b95ad13ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527885Reviewed-by:
-
Curt Clemens authored
When multiple files are shared, instead of showing the filename as a preview, we show the file count, i.e. "3 Files". Bug: b/163036847 Change-Id: I6aa28ca8f769538c7244268661bec9a4e23b73b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522909Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
sebsg authored
Change-Id: I399ec1b246536e906c56f6ae4e84659e1c4a032b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522975 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#825554}
-
Ian Kilpatrick authored
As above. This change implements the behaviour described by: https://github.com/whatwg/html/pull/5936/files This introduces an internal pseudo class ":-internal-modal" which applies the additional style rules when the dialog goes modal. Intent-to-ship/change: https://groups.google.com/a/chromium.org/g/blink-dev/c/Ow63WaHuTgc Change-Id: I6d807fffd64b4f9c8ea57a2993ac755b23df8287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258897 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825553}
-
Mike Jackson authored
This is a reland of b94143e8 The OSHookType when uninstalling mac app shim was incorrect, fixing to pass the correct parameter. Original change's description: > dpwas: Move delete shared mac shim to behind shortcuts > > While working on Run On OS Login for Mac, I noticed that the shared > app shims were being deleted when toggling Run On OS Login. This happens > because the app shims unconditionally delete the app shims. > > This change moves the code to delete the shared app shims behind > the shortcut check. On Mac you can have both per profile shims, > and shared shims, so the callbacks are chained together only on > that platform. > > Bug: 897302 > Change-Id: I318137ac0f34e4f2429a5119d47e3fe5c3c96892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519877 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825165} Bug: 897302 Change-Id: Icc376223a9b5bccd19ac1c9c92bda9397487dc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525284Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#825552}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9217d49db032..489f2c838bb7 2020-11-09 jmadill@chromium.org Perf Tests: Trace multiple threads. 2020-11-09 jmadill@chromium.org Vulkan: Make feature names consistent. 2020-11-09 syoussefi@chromium.org Fix expectations file for prerotation dEQP executables 2020-11-09 m.maiya@samsung.com Vulkan: Rewrite interpolateAtOffset to account for Y-flip 2020-11-09 jmadill@chromium.org Fix trace writing in angle_perftests. 2020-11-09 m.maiya@samsung.com Vulkan: Support VK_KHR_image_format_list for AHB backed EGL image 2020-11-09 stha09@googlemail.com Vulkan: add explicit template specialization for barrierImpl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_end2end_tests.exe Change-Id: I2b6c9690735ccf482263faf781f7291b17a010dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527670Reviewed-by:
-
Clark DuVall authored
The fix in https://crrev.com/c/2522511 almost worked, but ended up crashing when inflating layouts. This change replaces the underlying ClassLoader from the ContextImpl for each Activity. Bug: 1146745 Change-Id: I23fc0b15fcd5ef80b78c82de2ab83245af1146d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526627Reviewed-by:
-
Mark Pearson authored
This reverts commit dde3defc. Reason for revert: browser_tests on linux-lacros-tester-rel consistently fail after this landed in https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4381 Failures are: MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys MediaKeysListenerManagerImplTest.PressPlayPauseKey MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController They all crash: [ RUN ] MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys DevTools listening on ws://127.0.0.1:37255/devtools/browser/5be580d5-fcf2-46b2-8f43-033ac20657af [22277:22277:1109/134807.593313:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55ec232b31d9 base::debug::CollectStackTrace() #1 0x55ec2322bc63 base::debug::StackTrace::StackTrace() #2 0x55ec22e77786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f5f63b034c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55ec20957235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x55ec22e76577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x55ec22f20fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x55ec226b9896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ec22b09c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ec226b8877 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ec226bb278 content::BrowserMainRunnerImpl::Initialize() #11 0x55ec226b6f68 content::BrowserMain() #12 0x55ec218feeb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ec218feaa6 content::ContentMainRunnerImpl::Run() #14 0x55ec218fbf54 content::RunContentProcess() #15 0x55ec218fc8dc content::ContentMain() #16 0x55ec22e75f8c content::BrowserTestBase::SetUp() #17 0x55ec21670678 testing::Test::Run() #18 0x55ec2167150f testing::TestInfo::Run() #19 0x55ec21671ef7 testing::TestSuite::Run() #20 0x55ec2167f677 testing::internal::UnitTestImpl::RunAllTests() #21 0x55ec2167efdf testing::UnitTest::Run() #22 0x55ec22ebf284 base::TestSuite::Run() #23 0x55ec22e48027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x55ec22e9a871 content::LaunchTests() #25 0x55ec22e47fe0 main #26 0x7f5f63aee840 __libc_start_main #27 0x55ec1fce43ea _start [ RUN ] MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController DevTools listening on ws://127.0.0.1:37481/devtools/browser/4cec391a-3d7f-4854-bdcf-7c8abf8b0cbe BrowserTestBase received signal: Segmentation fault. Backtrace: [25621:25621:1109/134831.864948:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. #0 0x5636f5a041d9 base::debug::CollectStackTrace() #1 0x5636f597cc63 base::debug::StackTrace::StackTrace() #2 0x5636f55c8786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fbfcb8e44c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5636f30a8235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5636f55c7577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5636f5671fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5636f4e0a896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5636f525ac33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5636f4e09877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5636f4e0c278 content::BrowserMainRunnerImpl::Initialize() #11 0x5636f4e07f68 content::BrowserMain() #12 0x5636f404feb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5636f404faa6 content::ContentMainRunnerImpl::Run() #14 0x5636f404cf54 content::RunContentProcess() #15 0x5636f404d8dc content::ContentMain() #16 0x5636f55c6f8c content::BrowserTestBase::SetUp() #17 0x5636f3dc1678 testing::Test::Run() #18 0x5636f3dc250f testing::TestInfo::Run() #19 0x5636f3dc2ef7 testing::TestSuite::Run() #20 0x5636f3dd0677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5636f3dcffdf testing::UnitTest::Run() #22 0x5636f5610284 base::TestSuite::Run() #23 0x5636f5599027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5636f55eb871 content::LaunchTests() #25 0x5636f5598fe0 main #26 0x7fbfcb8cf840 __libc_start_main #27 0x5636f24353ea _start [ RUN ] MediaKeysListenerManagerImplTest.PressPlayPauseKey DevTools listening on ws://127.0.0.1:36939/devtools/browser/4a443d13-30b6-430d-a4b3-503ecbbdc73e [4137:4137:1109/134809.976176:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x5647f92c11d9 base::debug::CollectStackTrace() #1 0x5647f9239c63 base::debug::StackTrace::StackTrace() #2 0x5647f8e85786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f6dac3524c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5647f6965235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5647f8e84577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5647f8f2efde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5647f86c7896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5647f8b17c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5647f86c6877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5647f86c9278 content::BrowserMainRunnerImpl::Initialize() #11 0x5647f86c4f68 content::BrowserMain() #12 0x5647f790ceb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5647f790caa6 content::ContentMainRunnerImpl::Run() #14 0x5647f7909f54 content::RunContentProcess() #15 0x5647f790a8dc content::ContentMain() #16 0x5647f8e83f8c content::BrowserTestBase::SetUp() #17 0x5647f767e678 testing::Test::Run() #18 0x5647f767f50f testing::TestInfo::Run() #19 0x5647f767fef7 testing::TestSuite::Run() #20 0x5647f768d677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5647f768cfdf testing::UnitTest::Run() #22 0x5647f8ecd284 base::TestSuite::Run() #23 0x5647f8e56027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5647f8ea8871 content::LaunchTests() #25 0x5647f8e55fe0 main #26 0x7f6dac33d840 __libc_start_main #27 0x5647f5cf23ea _start Original change's description: > Reland "[Media Session] Fix for Lacros" > > This is a reland of ddb531f7 > > There is a fix in media_session_service.cc to allow the tests to pass > when ash-chrome is not running. > > Original change's description: > > [Media Session] Fix for Lacros > > > > At the moment in Lacros there are two instances of the > > Media Session Service (MSS) one hosted in ash-chrome and > > the other in lacros-chrome. This means that sessions in > > either browser process cannot see sessions from the other. > > > > This changes it so when a client asks for lacros-chrome > > MSS instead of providing a locally hosted MSS it binds > > the MSS in ash-chrome. > > > > BUG=1140215 > > > > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825016} > > Bug: 1140215 > Change-Id: I64834d9be778998b42bf3447444a6955265215ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825439} TBR=avi@chromium.org,dcheng@chromium.org,erikchen@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I284aea77c32a39c8641df70d83baa5b2e09b8641 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528306Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825549}
-
Vincent Boisselle authored
We also re-baseline the goldens by incrementing the version number since the testRender_FocusFakeBox test had its baseline golden with the new feed header UI enabled which we don't want anymore since the features flags related to that UI change are now disabled. Bug: 1146197 Change-Id: I0bb2525102dea745a3e419d2b8252abf1525811b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525741Reviewed-by:
-
Yulun Wu authored
Bug: 1143063 Change-Id: Icd0ec2088508d633757ed20749790b80a1dc09d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508558Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825547}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604685414-0763f88efc3380eb5f7b102366bfe07c0bfcf724.profdata to chrome-win32-master-1604931688-79a6ca0d5aca76d3d27163162f00dd49eb38f0e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0fa1c97fdd9f6fe204bc9ac9c5b3582165ff26b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526609Reviewed-by:
-
