GitLab

Bug: 113734839
Test: "tell me a joke" reads the joke out through screen reader
Change-Id: I92832ff6e7eea298b59aec660763b0d1a4854eef
Reviewed-on: https://chromium-review.googlesource.com/1217751
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590541}

https://chromium.googlesource.com/catapult.git/+log/6333b6741efe..fc2514597ca6


git log 6333b6741efe..fc2514597ca6 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 bsheedy@chromium.org Add functional test quest args
2018-09-11 benjhayden@chromium.org Add more utility functions to v2spa.
2018-09-11 eakuefner@chromium.org Reland "[TBMv2] Support Chromium commit positions in legacy_json_converter"


Created with:
  gclient setdep -r src/third_party/catapult@fc2514597ca6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:881017,chromium:843643
TBR=sullivan@chromium.org

Change-Id: I3d8a43b120d45c76ddbac06cf2627853efb54bbb
Reviewed-on: https://chromium-review.googlesource.com/1220239Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590540}

As an example: P2PSocketTcpBase::DoRead already stops looping if result <= 0,
but a delayed read result handled by OnRead doesn't.
Earlier, the socket entered an ERROR state after OnError() was
called, which would stop reads from continuing.

This CL fixes that issue and similar issues when sending and when using UDP.

Bug: 881260
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If7cd62b36705f69cfd95a71908d610cc871561b0
Reviewed-on: https://chromium-review.googlesource.com/1219390Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590539}

If enable_video_with_mixed_audio is defined, unittests should not
include null_video source_set.

Bug: 80443515
Test: manual / CQ
Change-Id: I905edbdc019841f1d2dfe18169ef3ba0af92b270
Reviewed-on: https://chromium-review.googlesource.com/1220697Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sunil Kumar <skx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590538}

The function is called only on RootInlineBox, and makes sense only when
called on an entire line.

Hence, this patch moves it to RootInlineBox to reduce confusion.

Change-Id: I9a2f283de54a3cce0658b11245f24e14b91c5908
Reviewed-on: https://chromium-review.googlesource.com/1220705
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590537}

Make sure that FidoBleDiscovery stores list of all Cable devices it
found and never attempt to connect to Cable devices.

Bug: 880295
Change-Id: I3799103da15b9314a8f8bdb57e0f1d42f7a99a28
Reviewed-on: https://chromium-review.googlesource.com/1214182
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590536}

Falls back to sync if unified consent is not given, or hasn't been offered.

Also checks on offering search suggestions, since that seems logical.

Bug: 877850

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8daab9213c3a6b71b2bd8a1dd921973b51b7db8e
Reviewed-on: https://chromium-review.googlesource.com/1189702
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590535}

This also fixes bugs caused by revisions 489ad84c and e3e9da53, which moved functionality out of the code path.

Bug: 847237
Change-Id: Ib60046f52b19d510e1f838a9900c1074b62d8c68
Reviewed-on: https://chromium-review.googlesource.com/1217910Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590534}

Fix threading issue when adding and removing streams.

Change-Id: Ib2ff6ed87bc7d96a2d0956c604f741be38992c7c
Reviewed-on: https://chromium-review.googlesource.com/1220555Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Jimmy Tobin <jtobin@google.com>
Cr-Commit-Position: refs/heads/master@{#590533}

Design doc: go/switch-context-menu

Bug: 864796
Change-Id: I13f42784eabb54f1222a3e61c819e77cf9f17010
Reviewed-on: https://chromium-review.googlesource.com/1199817Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590532}

Windows 10 native notification seems to have memory leak issues on OS
builds older than 17134. See crbug.com/882622. This seems to be a Windows
issue which has been fixed in 17134.

Bug: 882622
Change-Id: Icb251eb9ebb88b19b20b8e09692d85f7fcec6b54
Reviewed-on: https://chromium-review.googlesource.com/1220569Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590531}

This copies behavior on chrome://settings pages where tapping
anywhere in the option box can change the state of the toggle,
or having keyboard focus on an toggle element and clicking 'enter'
changes the state.

Bug: 810333,810307
Change-Id: Ib6edc31fff72f2e32c5b9ce73264739a3d3194c1
Reviewed-on: https://chromium-review.googlesource.com/1214366Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590530}

Added UpdateShelfVisibility in ~TabletModeWindowDragDelegate to keep
shelf in correct state after drag a window from top.
Most of the cases shelf can achieve a correct state after drag except for
dragging a browser window from top. The problem is that we delete drag
details in EndingForDraggingWindow for app windows but we can't do the
same for browser window.
Then ShelfLayoutManager::IsDraggingWindowFromTopOrCaptionArea
will drop into wrong condition in this case, which will cause the shelf
into a wrong state at the end of drag.

Tried to UpdateShelfVisibility again in ~TabletModeWindowDragDelegate
when drag details has already been deleted for all the window drags.

Bug: 882962
Change-Id: I6915bcfd7ee1890d40ca5d422c913552a487daf1
Reviewed-on: https://chromium-review.googlesource.com/1219934Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590529}

BUG=875867

Change-Id: Ic70b274c96d000c2aa05fa2399475806bb3d640f
Reviewed-on: https://chromium-review.googlesource.com/1181524
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590528}

Also shorten the time to wait for stable offline to 20s.

Bug: 883020
Change-Id: If932810e0d4864fe00bd2fec980175086b43afbd
Reviewed-on: https://chromium-review.googlesource.com/1220049Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590527}

It is used in 4,300+ compilation units.
http://crrev.com/590155 increased its pre-processed size by 3.72MB, and
this CL fixes it.

Bug: 242216, 881537, 882997
Change-Id: If723b9d77dbd06fdde184498aa6ed7aa3e5e88e2
Reviewed-on: https://chromium-review.googlesource.com/1218388
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590526}

If the page exists in a maximized browser window before going to
tablet mode, the layout that results from going to tablet mode
does not change the size of the page viewport. Hence, the visual
properties of the renderer and the browser are not automatically
synchrnoized. But going to tablet mode enables the top-chrome
sliding feature (i.e. BrowserView::GetTopControlsHeight() now
returns a non-zero value).

This CL makees sure that we synchronize the visual properties
manually, so that the renderer can get the new top-controls
height whenever it changes.

BUG=867063
TEST=manual, added a browser test.

Change-Id: Ifbbc224e1de452b2582635ea8f9b4c3992a0dceb
Reviewed-on: https://chromium-review.googlesource.com/1217355Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590525}

Change-Id: If9f842fd326eedd659999531bc15293ee0137863
Reviewed-on: https://chromium-review.googlesource.com/1220043Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590524}

Modify ViewAccessibilityUtils::GetFocusedChildWidgetForAccessibility to
return any widget that is visible and focused.

Previously, this was limited to tab-modal dialogs. Other focused
widgets, like the Find bar, should be treated in the same way.

Bug: 869703
Change-Id: I720bdd1e9c8d665d839296aa9bfd4c9490805dbd
Reviewed-on: https://chromium-review.googlesource.com/1208810Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590523}

The ControllerDelegate was renamed to InputDelegate to reflect
that it handles more than just the controller raw input.

Bug: 875291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7415806cf7ba52a7e49899843dcf93079333c8d3
Reviewed-on: https://chromium-review.googlesource.com/1213874
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590522}

Based on https://codereview.chromium.org/2897463003/.

Test: Run update.py --force-local-build, remove https://cs.chromium.org/chromium/src/build/config/fuchsia/BUILD.gn?l=41 and referenced files, and rebuild some Fuchsia binaries
Test: Run package.py and verify the .a's are included.
Bug: 724204
Change-Id: If1492138829846a0f970d034f28a84d517554401
Reviewed-on: https://chromium-review.googlesource.com/1211879Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590521}

A code path enabled by the butter experiment was calling some
methods on the sync_service_. However, it can be null in
certain situations.

I updated the methods to handler the case where sync_service is null.

Bug: 883048
Change-Id: I64b4d52a5fc897381a99ad1502c0e6dbb937e447
Reviewed-on: https://chromium-review.googlesource.com/1220708
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590520}

Bug: 880737
Change-Id: I2c455762066d424a3cde4e91dc70eacfc1b4fb7c
Reviewed-on: https://chromium-review.googlesource.com/1217033Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590519}

This CL is adding events to help investigate crbug 882982.
We are observing strange interaction with the SamplerThread and the
Browser main thread.

We suspect the thread to be suspended for a longer period than expected.

This code is temporary to investigate sampler profiling issues.
Should be reverted in a few weeks.

R=wittman@chromium.org, ssid@chromium.org

Bug: 882982
Change-Id: I4aa1d733ea06100c64e884e014222b04d97b3492
Reviewed-on: https://chromium-review.googlesource.com/1220174Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590518}

The NavigationStateChangeObserver interface was renamed to
NavigationEventObserver in a previous CL. This CL finishes up the
rename by changing the file name too.

Change-Id: I6e1d17d7aadceb1736541be6bf4b8f8c40d7e81e
Reviewed-on: https://chromium-review.googlesource.com/1217515Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590517}

This is a very small set of machines, which have been exhibiting
- rendering artifacts when GPU compositing is enabled
- severe rendering artifacts when GPU raster is enabled

Bug: 875891
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie49a9111b9723977a2b8758f824bba7843238d32
Reviewed-on: https://chromium-review.googlesource.com/1220180Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590516}

This CL disables the MediaLauncherActivityTest tests that are flaking
due to a race condition.

TBR: mlamouri@chromium.org
Bug: 882938
Change-Id: I61ba23d0e4ed4a8890db8bcc0219ab4ea3804184
Reviewed-on: https://chromium-review.googlesource.com/1220701Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590515}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ie42fe469a9a86e83f9ce14cb428df1a792d427b5
Reviewed-on: https://chromium-review.googlesource.com/1220707
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590514}

Make --test-launcher-filter-file support multiple filter files separated
by ';'.

Bug: 881438
Change-Id: Ibe17d1e8443cbb490a2d1b8942bb003c96a79525
Reviewed-on: https://chromium-review.googlesource.com/1213866
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590513}

The controls sometimes disappear depending on the mouse interactions
with the window. For example, when the controls disappear automatically,
the controls should reappear when the user moves around the window.

Bug: 882615
Change-Id: Ic4c0a391d81ec6ea475d19be6cd60b40cb0ba277
Reviewed-on: https://chromium-review.googlesource.com/1217719
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590512}

This allows checking for potential data quality issues.
See b/112853960

Change-Id: I4d361cbc18dde8589d6da23026bbfa8d4db547cb
Reviewed-on: https://chromium-review.googlesource.com/1182291
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590511}

It appears to have enough bots. Will bump more if needed.

TBR=jbudorick@chromium.org

Bug: 646404
Change-Id: I4046177c2adb2916ec293cc1961753577739e4c9
Reviewed-on: https://chromium-review.googlesource.com/1220703Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590510}

Bug: 828468
Change-Id: Ib604bfe647900d3afca46ca6fdcdb5f365d25198
Reviewed-on: https://chromium-review.googlesource.com/1220572Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#590509}

It might? be the cause of a perf regression.

Bug: 882471,680657
Change-Id: Iec34a348426ccfdf5864a3b2cbe0c377da20ac0e
Reviewed-on: https://chromium-review.googlesource.com/1220468
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590508}

Disabling all tests in ProxySettingTest class as they can't be run on
Android platforms.
These tests require multiple sessions which is not supported on Android.

Change-Id: I6bf6cfbe8ba9f74b67d7beb84f68d79ee0a53966
Reviewed-on: https://chromium-review.googlesource.com/1220698Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590507}

Fix a bug in which AppListView crashes when layout()
is called. This is because
|app_list_background_shield_mask_| may not be
initialized when layout() is called.

Bug: 882553
Change-Id: I582be13c4998c262de89cc9c46543bbdcb9c9801
Reviewed-on: https://chromium-review.googlesource.com/1220033Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#590506}

This follows the page's logic of only interrupting for
some of the debugger commands.

To achieve this, we switch from running a tight loop with
only inspector tasks to a nested message loop (again, similar to
the main frame). This requires making some operations respect
PausableObject semantics, noticeably worker's ResourceFetcher,
post message and evaluating initial scripts.

WorkerInspectorProxy now either posts a regular task or
interrupting task similar to how DevToolsSession does it.

This is a preparation to unifying workers and page debugging
experience and implementation.

Bug: 775132
Change-Id: I1c8ccd98c2c9a35fa7ab0b91017b924a81a297b1
Reviewed-on: https://chromium-review.googlesource.com/1205802
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590505}

Aids with the integration of Contextual Search with Unified Consent by
recording whether the user was previously undecided when their
preference gets changed due to Unified Consent, and whether to throttle
for every request and when throttling is in effect.

BUG=829597

Change-Id: I28c10e10faee25dd6741243c4560d9ed74fa75ef
Reviewed-on: https://chromium-review.googlesource.com/1214402Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590504}

BUG=800033

Change-Id: I9e9b1904004b0f4e82806b53b0fa53e8abfea396
Reviewed-on: https://chromium-review.googlesource.com/1220551
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590503}

This reverts commit 65103ba6.

Reason for revert: A proper fix was sent to clank downstream by jbudorick@ (https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/670069), so this is no longer needed.

Original change's description:
> [Autofill] Bring back isAutofillEnabled and setAutofillEnabled
> 
> The functions are still used by Clank downstream and will be removed
> once only the new preferences are used by it.
> 
> TBR=mathp@chromium.org
> 
> Bug: 879384
> Change-Id: Ibee61db92a2bd3cd8b4124b79fc1c0d747d401d1
> Reviewed-on: https://chromium-review.googlesource.com/1198453
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587912}

TBR=ftirelo@chromium.org

Change-Id: I415c94a269e97637774af17289f7699215ed9a4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879384
Reviewed-on: https://chromium-review.googlesource.com/1199564Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590502}