GitLab

This reverts commit 5192ab32.

Reason for revert: crbug.com/746616 TL;DR: we're listening for compositor frame swap on browser-process compositor instead of on the renderer-process compositor (which composites the page, instead of the browser UI).

Original change's description:
> [Installed PWA] Waits for a frame swap before hiding a splash screen.
> 
> This patch fixes the flash of white between the splash screen and the
> web content in installed web apps. This is achieved with waiting for
> a compositor frame swap before starting splash screen hiding animation.
> 
> Adding callbacks for next frame swap in CompositorViewHolder might not
> be at the right level of abstraction - feedback welcome. I introduced
> a generic mechanism as we might need it different places as well.
> E.g. In CustomTabActivity the same issue is solved with a time delay,
> which I plan to change to this mechanism in a follow up patch.
> 
> Existing tests for a webapp splash screen cover showing/hiding it in
> various circumstances. Writing a specific test to assert flash of white
> is fixed would be more work than it's worth it.
> 
> FYI: On Google Pixel this causes the splash screen to be shown about
> 50-100 later, which seems like the time time when flash of white was
> visible.
> 
> Bug: 734500
> Change-Id: I70f8bde54f251c283e260d17a291685738f9e080
> Reviewed-on: https://chromium-review.googlesource.com/569552
> Commit-Queue: Piotr Swigon <piotrs@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487336}

TBR=mdjones@chromium.org,khushalsagar@chromium.org,dominickn@chromium.org,piotrs@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734500
Change-Id: Ib8afce105fa818b76492b8fce7da7d17c8e07e6a
Reviewed-on: https://chromium-review.googlesource.com/578631Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488141}

BUG=738595
TEST=existing tests pass
TBR=wolenetz

Change-Id: I1076fc1a74b7064bff021c5c124f20216fc0867e
Reviewed-on: https://chromium-review.googlesource.com/578656Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488140}

Bug: 706046
Change-Id: I9bd0ff5d297f93ff3dbdc92f668c307630d46dc5
Reviewed-on: https://chromium-review.googlesource.com/578659
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488139}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d7e07ff..2e867917

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I3e0211807103e7f6ce58386936e75d5570825d22
Reviewed-on: https://chromium-review.googlesource.com/578396Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488138}

https://pdfium.googlesource.com/pdfium.git/+log/67ccef73bf66..40870db0aade

$ git log 67ccef73b..40870db0a --date=short --no-merges --format='%ad %ae %s'
2017-07-19 drgage Add FPDFAnnot_GetFormFieldAtPoint() and embedder tests.
2017-07-19 drgage Add FPDFAnnot_GetFormFieldFlags() and associated embedder tests.
2017-07-19 tsepez Rename StringCs c_str() to unterminated_c_str().
2017-07-19 caryclark fix continue skia cache flush
2017-07-19 dsinclair Remove unused GetThisAppearanceStream
2017-07-19 dsinclair Create CPWL_AppStream.

Created with:
  roll-dep src/third_party/pdfium
BUG=59266,59266


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If4c2a89080c44d782e6ae44431cfd20c33b2ffff
Reviewed-on: https://chromium-review.googlesource.com/578678
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488137}

Bug: 745958
Change-Id: I87c0de5d5c7e9d5fc8b6fd38d95dec8013934db8
Reviewed-on: https://chromium-review.googlesource.com/576359
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488136}

This CL lands the client-side implementation of the mojom::VEA
and unit tests for it. It doesn't connect it yet, but the 
final result can be found in https://crrev.com/c/558846.

Bug: 736517
Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a

TBR=tsepez@ for adding [Sync] to the mojom interfaces
(that anyway reflects the current IPC).

Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a
Reviewed-on: https://chromium-review.googlesource.com/566145
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488135}

On OnMemoryDump, base::SharedMemory's IDs are used to create ownership
edges. However, there is no guarantee that the ID is still valid when
OnMemoryDump is called. Actually, some crashes [1] are found when
MemoryAllocatorDumpGuid::UseSharedMemoryBasedGUIDs() is true [2].

This CL fixes this bug to avoid dumping when shared memory id is
invalid (empty). Also, this CL changes OnMemoryDump use SharedMemory::
mapped_id(), that returns an valid ID only when the shared memory is
actually mapped, so that we can avoid unnecessary dumps.

[1] https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/501311
[2] This is now always false, but we plan to make this return true to
    use new ownership edges.

Bug: 604726
Change-Id: I2400ba334860e57b9b83a785cd69f4a32b8ef151
Reviewed-on: https://chromium-review.googlesource.com/571386Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488134}

Certain permissions are always denied for insecure (HTTP) origins, and
notifications is one of them. Fix SiteDetails.DefaultSettingSource by using a
secure (HTTPS) test origin instead.

This is to fix a test that broke after r488086 landed.

Change-Id: Ieac59f3ff7b19dd64d0d299fb678ce7f6e9ec89e
TBR: dschuyler@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/578534
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488133}

Now it is equivalent to domain == "net" && reason == ERROR_ABORTED.

Bug: None
Change-Id: Ia39d123a8a15d79a3efbcc86fd1c70f225c51439
Reviewed-on: https://chromium-review.googlesource.com/575112Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488132}

Bug: 706071
Change-Id: Idcf5feefa594463a1b7295dd30025c1cbc489345
Reviewed-on: https://chromium-review.googlesource.com/578227Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488131}

These will help us understand user translate behaviour and how it is affected
by various UI decisions. We don't log the cross
(source language, target language) as there are too many combinations to use as
histogram buckets.

Bug: 742684
Change-Id: Idf6a72a6418db820431e75ba1982f260d92bad21
Reviewed-on: https://chromium-review.googlesource.com/572486
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488130}

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

BUG=731600,740830,746768

Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846
Reviewed-on: https://chromium-review.googlesource.com/577374Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488129}

This CL replaces last use of MockCryptohomeClient by fake,
and then remove it.

BUG=739622
TEST=Ran trybot.

Change-Id: I9477b540b40789c663657147b8172f5ae189dfc3
Reviewed-on: https://chromium-review.googlesource.com/571244
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488128}

Two changes have landed recently which need to be reflected in
documentation for origin trials:

- Trials are disabled automatically in the virtual test suite, and do
    not have to be named explicitly in VirtualTestSuites.
- V8 bindings code is now generated automatically

This documentation change brings the developer docs up to date with reality.

BUG=685788, 615060

Change-Id: Icec69074b654bc749d790136de4e3a72855e3660
Reviewed-on: https://chromium-review.googlesource.com/578171Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488127}

In the process, removes an unnecessary
chrome::FocusLocationBar()
in
chrome/browser/policy/policy_browsertest.cc
because it's not necessary.  Two lines later,
the test calls
ui_test_utils::SendToOmniboxAndSubmit()
which immediately sets focus.

The current behavior causes a failure (DCHECK)
because the omnibox doesn't expect two consecutive
SetFocus calls.  (Everything else in the omnibox
edit system makes sure not bother sending a SetFocus
call if focus is already in the omnibox.)

TBR=pastarmovj
for the trivial change to the policy_browsertest

(I would like this to be submitted by branch point,
so not waiting for a review.)

Bug: 715274
Change-Id: I3c195c4dbd87c5e9c4eec20271d6142c252e3315
Reviewed-on: https://chromium-review.googlesource.com/576615
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488126}

This is an extension for CL https://chromium-review.googlesource.com/c/564903/.
In this patch,
we also replace the switchcase conversion code from CSS enum
to KeywordValue enum.
Gen diff: https://gist.github.com/nguyen-minh-duc/97f5a4942b006690bdc0f442f11dff12/revisions

https: //chromium-review.googlesource.com/c/564903/
Bug: 744203
Change-Id: I11cc3467aaa4911ff948a570d3d076e59114750e
Reviewed-on: https://chromium-review.googlesource.com/572884
Commit-Queue: Minh-Duc Nguyen <nmduc@google.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488125}

BUG=741214

Change-Id: I2184b489044fc07de51ca3abbe4d5a5836138411
Reviewed-on: https://chromium-review.googlesource.com/567244
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488124}

after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2.
As a follow-up of the refactoring, this CL inlines the alias to its users
in //base and //cc.

base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber
Change-Id: I343885b85cce413148ccd6aa9e5fa94913d7fecc
Reviewed-on: https://chromium-review.googlesource.com/568063Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488123}

This is one of the efforts to organize core/dom files.
See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing
for details.

See the similar CL, https://chromium-review.googlesource.com/c/569532/, as I did for
intersection_observer.

Bug: 738794
Change-Id: I1eb0b47341df4880faddc2df6c7ae9f1dd6ccdb7
Reviewed-on: https://chromium-review.googlesource.com/576597Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488122}

The network change observer notifies the offline signal later than the
actual failure in download request. The controller will immediately
retry since the state is still online.

This CL adds a delay to the retry logic, so it potentially can wait
for an actual online timing to retry.

Bug: 746082
Change-Id: I42e519618538f6db857b1c173a5bada828c6512d
Reviewed-on: https://chromium-review.googlesource.com/575572Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488121}

- Remove unused requesting_origin_
- Make destructor private
- Remove unused GetAcceptState() declaration

Change-Id: Ie8a8984d2a6975568cd8b26e57c0844c88acb594
Reviewed-on: https://chromium-review.googlesource.com/575737Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488120}

TBR=dimu@chromium.org

Change-Id: I951bdaf7e4c7ddc6bfd7b8f7d178c4990c28d870
Reviewed-on: https://chromium-review.googlesource.com/578216Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488119}

Update a few of the extensions unittests for native bindings. In
particular, create a NativeBindingsExtensionSystem in the
ModuleSystemTest in order to allow for catching and reporting
errors, and update a few of the JS files to handle either
native or JS-based bindings.

Bug: 653596
Change-Id: I0bfc04ef01887422fb87c050da9aec056b00d0c9
Reviewed-on: https://chromium-review.googlesource.com/574692
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488118}

https://skia.googlesource.com/skia.git/+log/7e872caaf618..e32500f0642d

$ git log 7e872caaf..e32500f06 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 reed Assume HQ is handled by pipeline, delete legacy code-path
2017-07-19 brianosman Strip out unused tracing macros
2017-07-19 bsalomon Remove GrBackendTextureDesc
2017-07-19 halcanary SkPDF:  minor cleanups of skpdfdevice

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Ie5ac9a80e2e2f267ce87a168a3e3d2b7dd985ad5
Reviewed-on: https://chromium-review.googlesource.com/578721Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488117}

Even though our dialogs are modal, it was still possible to execute
keyboard commands on the background content by clicking on the dialog
background, which refocuses the document body and allowed commands
to execute.

Bug: 742972
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01f9cb3060fd6a91a6fa5a832578f3f245712e0c
Reviewed-on: https://chromium-review.googlesource.com/575252Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488116}

In chrome/browser/safe_browsing, srt_chrome_prompt_impl.h includes a
generated Mojo header that comes from chrome_prompt.mojom inside
components/chrome_cleaner.

Change-Id: Ic7eb79c41dd06f8abb96b9845ba719a1dec10e54
Reviewed-on: https://chromium-review.googlesource.com/577309Reviewed-by: Robert Shield <robertshield@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488115}

And some related cleanup.

R=eae@chromium.org

Change-Id: I8b11f587877af569e188770004b09fc888c6fcc1
Reviewed-on: https://chromium-review.googlesource.com/578576Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488114}

Implement parseShorthand for border-[bottom|left|right|top], column-rule, flex-flow, list-style and text-decoration.

All these shorthand properties call the same helper function
ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in
one cl.

This cl also removes ConsumeShorthandGreedily from CSSPropertyParser, 
as it is now fully replaced by ConsumeShorthandGreedilyViaLonghandAPIs.

Bug: 668012
Diff: https://gist.github.com/3747ac6e05e864871ac92f82fd49a822/revisions
Change-Id: Ice96f50a33c609bab24f5ab677b942ed4d424e97
Reviewed-on: https://chromium-review.googlesource.com/575608Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488113}

Bug: 746084
Change-Id: I7fe25557ded4264887bb092107bf4a5c51988b36

Change-Id: I7fe25557ded4264887bb092107bf4a5c51988b36
Reviewed-on: https://chromium-review.googlesource.com/576408
Commit-Queue: Kelvin Poon <kelvinp@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488112}

Bug: 743118
Change-Id: I8f17eb898daf9d39ea270435b259b0a7bc15e5cb
Reviewed-on: https://chromium-review.googlesource.com/571293Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488111}

Bug: 735358
Change-Id: Ibe2a98bd93c1e6288e7c8e9a3633f21e3433350a
Reviewed-on: https://chromium-review.googlesource.com/577390Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488110}

EmbeddedContentPainter::IsSelected() is used to decide if paint 
 selection or not.
This function is strange because it refers selection_start/end.
That's because seletion_start/end means offset in the layout object
 and since replaced element neither be text nor have child 
LayoutObject.
Thus we should just consider SelectionState is kNone or not.

Bug: 739062
Change-Id: I249d8c2acef959ad437f3a636a490f42b61270e0
Reviewed-on: https://chromium-review.googlesource.com/575126Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488109}

This CL does the following:
1) If we choose a tool that is a "mode", the palette tray stays active.
2) If a tool that is a "mode" is active, tapping the palette tray deactives the tool.
3) Remove the checkmarks (because they can't be seen anymore with #2).
4) Add a seperator between tools that are "actions" and tools that are "modes".

Test: ash_unittests --gtest_filter="PaletteTrayTest.*"
Bug: 742524
Change-Id: I70d6e07a460250e7a22059973de036146dd753a6
Reviewed-on: https://chromium-review.googlesource.com/572066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488108}

Add the following metrics for WebSocket SafeBrowsing lookups:

* SafeBrowsing.WebSocket.Result is recorded for every WebSocket handshake that
  is checked.
* - SafeBrowsing.WebSocket.Elapsed.Safe
  - SafeBrowsing.WebSocket.Elapsed.Blocked
  - SafeBrowsing.WebSocket.Elapsed.Abandoned
  Record the time in milliseconds spent performing the SafeBrowsing lookup,
  including time spent on the interstitial page if applicable, broken down by
  result.

Because clicking "Back to safety" on the interstitial results in navigating away
from the page, it is recorded as "Abandoned", not "Blocked" as might be
expected. I haven't found a circumstance in which "Blocked" is recorded.

Tested manually with about:histograms.

Bug: 644744
Change-Id: I4ec902e122f48482c6c4d54537ce8035bbac92fc
Reviewed-on: https://chromium-review.googlesource.com/569942Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488107}

This allows onSafeBrowsingHit to be invoked with BackToSafety, even if
there is no page to go back to.

This is an issue for malicious subresources, since we actually navigate
backward. In this case, we load about:blank instead.

Bug: 746756
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingOnSafeBrowsingHitForSubresourceNoPreviousPage
Change-Id: I0e31d195ed7f87abeab3901725dc245c88f65299
Reviewed-on: https://chromium-review.googlesource.com/578577Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488106}

This patch introduces |AdjustSelectionStartToAvoidCrossingEditingBoundaries()|
for moving code for adjusting selection end code from
|AdjustSelectionToAvoidCrossingEditingBoundaries()| to simplify it for improving
code readability.

This patch is a preparation of the patch[1] and similar to the patch[2].

[1] http://crrev.com/c/575297: Refactor
VisibleSelectionTemplate::AdjustSelectionToAvoidCrossingEditingBoundaries()
[2] http://crrev.com/577338: Move code for adjusting selection end to avoid
crossing editing boundaries to a function

Bug: 230267
Change-Id: I25e020af333983e0e797c21eff2d934d6a03a589
Reviewed-on: https://chromium-review.googlesource.com/576606Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488105}

This CL fixes an issue where the sort button was not being updated when
the selected folder's children were updated.

Bug: 741308
Change-Id: I9876950def769551664a0d26f273b6ef6bdc0cc0
Reviewed-on: https://chromium-review.googlesource.com/569531
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488104}

Export intermediate keyboard states as UMA if it's
lingering too long (5 seconds).

- Made the UMA be exported on HIDDEN
- Checked chrome:histograms and confirmed only HIDDEN is exported.

Bug: 742724
Test: manually tested with a little tweak in the code.
Change-Id: I5954f1c169441ef80b70c08b3515cee1b11bfcb2
Reviewed-on: https://chromium-review.googlesource.com/572606Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488103}

We previously moved the two classes from stack to heap in order to make
TextNodeHandler also work with LayoutNG by polymorphism. However, the
on-going prototype (*) doesn't work in this way. Furthermore, we might
need a TextNodeHandler that works with both legacy and NG in order to
handle mixed layout tree.

Therefore, this patch makes the two classes stack allocated again.

(*) https://codereview.chromium.org/2968803002

Bug: 721957
Change-Id: I84ed1bff2acd92685fd53555e7b8f8ba62dbd4c3
Reviewed-on: https://chromium-review.googlesource.com/578715Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488102}