- 06 Jun, 2019 25 commits
-
-
Alex Danilo authored
CL:1631149 disabled two integration test for checking if the FilesApp can make the browser open a file that has been content sniffed as text/plain (e.g. if the file has no filename extension). This CL re-renables those tests as this is working correctly for browser display. Bug: 772600 Tests: Enabled integration tests again. Change-Id: Ia6ec09e5b9c3fcf541a95c3906afa8f3ee4533a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645133Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666550}
-
Marijn Kruisselbrink authored
No prompting for permissions is implemented yet, so all permissions are always denied unless chrome was launched with --enable-experimental-web-platform-features. This implements the plumbing/ground work on top of which prompting and a more complicated permission model will be added. Also operations don't actually check if permissions have been granted, that too will be added in a follow-up CL. Tbr: jbroman Bug: 878585 Change-Id: I2325fdcebbc3ccf1f688b101f01fd5b20437d3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636471 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#666549}
-
François Degros authored
Passed to ExitParser's constructor an object that actually implements the expected interface MetadataParserLogger. Change-Id: Ifad809c2bed7d334c62fc4ecd1c244d5ef218c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646795Reviewed-by:
-
Ahmed Fakhry authored
Per PM/UX request, when a minimized window is dragged to another desk, it should show up in the mini_view, and should be unminimized in the target desk after it has been move to it. Otherwise, the experience will be confusing since it will just disappear once dropped. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=971417#c2 BUG=971417 TEST=Manually, added test. Change-Id: I9da54f39cad662080a54c4e234254fb7ef651c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647187 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#666547}
-
Maggie Chen authored
Those header files are not used in gpu_watchdog_thread.h nor gpu_watch_thread.cc Bug: 949839 Change-Id: I08c38f2edf9d3de5462f03280c2f087e0fae549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647175 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666546}
-
Yue Li authored
Only sync status at the first init to prevent unexpected corner cases. Bug: 960509 Test: Manual Test Change-Id: I5f21f9467f6ee39a722b665a08c6e16c25141dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643610 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#666545}
-
Tommy Steimel authored
This CL adds logic to hide the System Media Transport Controls on the lock screen unless the media is currently playing. If media is playing on the lock screen and is then paused, we want to hide the SMTC after 5 seconds. Bug: 970353 Change-Id: I9fae652594381de05338ba0947fd18eed6ff7573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643733 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#666544}
-
Kristi Park authored
- Combine the mv-tile and mv-tile-container elements. - Combine the icon img and the icon container elements. - Remove the mv-title-container div. - Remove extraneous selectors from some CSS rules. Bug: 969818 Change-Id: I78d3c068fd70efc3d0f62555f2af8503e6f58bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644462Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666543}
-
Kenichi Ishibashi authored
This is similar to crrev.com/c/1630085 but for shared worker. Don't rely on the shadow page when creating WorkerSettings. Bug: 538751 Change-Id: I9d508fa5ec85d80ee1e0d38cf59e21e7323bea45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631245 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666542}
-
Antonio Gomes authored
Posted tasks are expected to be invoked once. Hence the use of CrossThreadBindOnce is appropriated. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: Ifdec982750fcb4179baa1936232e89c2ef74a743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646073 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666541}
-
Aaron Colwell authored
- Added logic to allow CreateForURL() to return a default SiteInstance for URLs that do not need to be isolated. - Added a --enable-default-site-instance command-line flag to turn on this new functionality so it isn't on by default yet. This flag allows the full set of changes needed to support default SiteInstances to be spread across multiple CLs. - Updated tests so they can pass when --enable-default-site-instance is specified. Bug: 958060 Change-Id: Ie3f9297f31f5c2e5803c2c27aa809b1541b4d76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612025Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#666540}
-
Alex Danilo authored
CL:1631149 disabled the integration test for checking if the quickview panel in FilesApp can display content in a file that has been content sniffed as text/plain (e.g. if the file has no filename extension). This CL re-renables that test as this is working correctly for quickview. Bug: 772600 Tests: Enabled integration test again. Change-Id: I69bf2feefe5e28860dfd62a47593cb179256bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644856Reviewed-by:
-
Peter Kasting authored
This will make it more feasible to replace child_count() with children().size(). This has a large number of followon effects. Bug: 956419 Change-Id: I2c4d1700571a7cd00cef926beb525661c7073e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636254 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#666538}
-
Sam Dallstream authored
Intent to ship discussion on blink-dev: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/wXbIl5mq4eo/GSyt-hXeBQAJ Bug: 923556 Change-Id: I805175cff562fe127a674b079023ff7dbc8ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627697 Commit-Queue: Samuel Dallstream <sadallst@microsoft.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee7921db7153..8a3738936814 git log ee7921db7153..8a3738936814 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8a3738936814 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ica5fe67c92119e60a564c70c81800caeacea9d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666536}
-
Lucas Tenório authored
This change adds the "Details" and "All Set" pages to the flow, as well as a class to manage the (now multiple) onboarding states. Another change is that we stop removing some webview listeners when we stop loading the page. This was causing the webview to never finish loading subsequent pages, getting stuck in the first blocking listener. Bug: 958995 Change-Id: Ib28f8d271263ffa832e05a5c6cefb7f7675b02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630223 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666535}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f5edb4f542e1..31200def0dec git log f5edb4f542e1..31200def0dec --date=short --no-merges --format='%ad %ae %s' 2019-06-05 absl-team@google.com Googletest export 2019-06-05 misterg@google.com Googletest export 2019-05-30 misterg@google.com Merge pull request #2264 from mbrobbel:suppress-cmp0048-warning 2019-05-30 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@31200def0dec The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com Change-Id: If4828c107a6a91f05fdb178bbcb54c77794c0bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644763Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#666534}
-
Collin Baker authored
Currently, ImageButton::SetImage() only schedules a paint when |for_state| matches the current state. However, this is wrong: any state that doesn't have an image falls back to the STATE_NORMAL image. Instead, this CL makes SetImage() always call SchedulePaint(). Bug: 920576 Change-Id: I8119a44b63754a11426db804394593e0e0c0d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644014 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#666533}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idc197bf8e16f3055fb445754cec196452d7dcf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646659Reviewed-by:
-
Yusuke Sato authored
The feature was punted to a later milestone. This CL put the following features behind the flag: * 'External storage preferences' submenu in chrome://settings/storage * "OPEN SETTINGS" button in the Files.app notification. * "Open settings" link in the Files.app toast. BUG=936814 TEST=try TEST=Show chrome://settings/storage, verify the new UI is hidden TEST=Plug a USB storage device, verify the new UI is hidden in Files.app Change-Id: I31eb74f673455b83ae0f56f2479a044072156970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636810 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
TransformationMatrix should not be used as a member in classes allocated on Oilpan heap. Bug: 970348 Change-Id: I21b6fa68e4e37a7ef95432e685b635c5915db174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642981Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666530}
-
Oystein Eftevaag authored
R=ssid@chromium.org CC=etienneb@chromium.org Change-Id: If3d32313d8202889a6765a4eef80a799b99d1508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630232 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#666529}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c4538b3. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font" 6222cc8d "[ElementTiming] Text support part 2" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I86168cadbe68fcf3027ef8d5210c1f2213fa1f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646372Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666528}
-
Min Qin authored
"Accept-Ranges" header are not required for servers supporting range requests. This CL changes the accept_range field in DownloadCreateInfo to use an enum so that we can experiment parallel download even if range support is unsure. BUG=917366 Change-Id: I9d6d444437650957b12225da0cada85d0cce5473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645480Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666527}
-
Lambros Lambrou authored
This updates the Mac postflight script to ignore errors from the config-upgrade tool, so that installation is successful in case of network failure or a missing config file. Bug: 971392 Change-Id: Ib7f487ff71c8a4ab636fbd938f36f11034f33541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647135 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#666526}
-
- 05 Jun, 2019 15 commits
-
-
Gabriel Charette authored
This is more consistent with other Vectors held in DEFINE_STATIC_LOCAL R=andruud@chromium.org, yosin@chromium.org Change-Id: I284527e376c7b7d31d986ca2e6fabdf72f353ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645832 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666525}
-
Kristi Park authored
Content width is calculated using the number of columns of MV tiles. This is inaccurate as of M69 since the tile width was changed. Update column count and content width to match the new tile width. Old content width: https://drive.google.com/open?id=1SbbJAa40gmfRG0tYT9UcR2q4Wy7cPBfq New content width: https://drive.google.com/open?id=1Ac6KlDH8-95YDdwbvpQ4PJtKSGI4TSXe Change-Id: I00d6113f48e7230a852ce0e1072f682615992ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642374Reviewed-by:
-
François Degros authored
Bug: 778674 Change-Id: I9b59fc0838db3998a17183e915c3c4f5264364d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644932 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
-
Aga Wronska authored
Making base class for ShelfView abstract simplifies a inheritance logic and allows to move some more code to derived classes. Bug: 948953 Change-Id: I3ebeffd91f856e7d4c3bda76a9df2a3994745ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642134 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
François Degros authored
Bug: 778674 Change-Id: Id0050985b19a05a2a73a87f429468f93f5ba70b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645112 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
-
Brandon Goddard authored
For users who don't use screen readers, the icon in the data grid communicates information about the type of document in the data grid. However, this icon lacked the document type information. This change adds the name of the type to the icon so it can be read via a screen reader. Bug: 963183 Change-Id: I6b3e717b270467327856c502e6ba47329386b31a https: //imgur.com/F0HyQ1L https: //imgur.com/xo1kz07 Change-Id: I6b3e717b270467327856c502e6ba47329386b31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644380Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b38f4ebe59f..900e4713287f Created with: gclient setdep -r src-internal@900e4713287f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:803846,chromium:957284,chromium:803846,chromium:803846 TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: If813b4c46aa545ffe3d94349176ae15b1247e38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666519}
-
May Lippert authored
If the "Surprise Me" feature has never been activated, the 'sync-daily-refresh-info-key' value from Chrome sync will be empty. This causes a JSON.parse exception which then causes an early return from the chrome.storage.onChanged listener. BUG=687722 Change-Id: I6837faee9d8b5738425e1d760badd9abf4e27f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633025Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#666518}
-
Eric Aleshire authored
These two ChromeEarlGrey shared helpers are only used in these tests, so they can be moved to be private helpers. Bug: 922813 Change-Id: I5e4e70837aa8a8b24d78e4307793594cc03c80be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646133 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666517}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d90c84e42f..6b43c30cd702 git log e0d90c84e42f..6b43c30cd702 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 mtklein@google.com add mad_unorm8 instruction 2019-06-05 mtklein@google.com use u32 in mul_unorm8 2019-06-05 mtklein@google.com tidy up register allocation Created with: gclient setdep -r src/third_party/skia@6b43c30cd702 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ieb1d0f381d488539549978a12e36fb9012d3c083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646895Reviewed-by:
-
Xianzhu Wang authored
We are already using physical coordinates for frame and document geometries. This CL just changes the type of the geometry data. This includes - removal of LayoutRect/LayoutPoint version of frame coordinate mapping functions, - change callsites of frame coordinate mapping functions to use physical coordinate types, - change of type of ScrollIntoView parameter and return values. R=bokan@chromium.org,skobes@chromium.org TBR=aboxhall@chromium.org for simple passive change under renderer/modules/accessibility TBR=fserb@chromium.org for simple passive change under renderer/modules/canvas Bug: 969383 Change-Id: Id6e70c672cc1a6402cf2baff55e62ffd076d3736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639527 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666515}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d38d709..c843aa75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2b1b707b2e06646b339a8a7ef90665f665284d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646913Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666514}
-
Luum Habtemariam authored
DDoc: go/cups-plugin This socket manager handles the actual proxying of the IPP requests to the CUPS daemon, via the default named UNIX domain socket, /run/cups/cups.sock. Bug: chromium:945409 Test: Passes added unittests. Change-Id: I3ed529bf0dc55f8aa1ee9eadbc0accf236f47000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600132Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#666513}
-
Alex Danilo authored
CL:154436 added a flag to control the feedback panel for FilesApp. This CL removes 'new' from the description and code comments as that was flagged in the original CL after merge. Bug: 947388 Change-Id: Iec61c601acfb56d8baf5fb2405958cfbd3f2bd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644712Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666512}
-
Mei Liang authored
Change-Id: I7b9f5952f1cf16a2bc60699f8862ffe859f59837 Bug: 970267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643107 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666511}
-
