GitLab

After the ebuild update, Chrome can assume there's only one version
of the Highlights app existing at a time, and it's the correct version
so board checking is not necessary.


Bug: 819404
Change-Id: I29b837131376a1c47ac3458bb98643c0bfa14e7d
Reviewed-on: https://chromium-review.googlesource.com/1197364
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587823}

ExtensionActionRunnerBrowserTest.ActiveScriptsAreDisplayedAndDelayExecution
has been flaky on Windows. Looking at the test, this could be caused by
not waiting a sufficient amount of time after loading the extension for
the extension background page to register a listener for the tab update.
This, in turn, would result in the extension not appearing to want to
run when it should.

Solve this potential issue by dispatching a "ready" message from the
extension once it has registered the listener, and waiting for that
message in the C++ before creating the new tab. Also explicitly wait
for the script to be injected in the case of automatic injection, and
wait for the blocked action to be added for the case of requiring
consent.

Additionally, break apart the test from being a single test that
exercised four different expectations to four tests, each managing a
single expectation. This eliminates the chance of any of the test steps
interfering with one another.

Bug: 867882

Change-Id: I2859bd35573415080e3c70a3e08bf2108430ee28
Reviewed-on: https://chromium-review.googlesource.com/1195844
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587822}

Bookmarks caches the tableView scroll offset, so whenever
bookmarks is closed and re-opened, we maintain the scroll offset
and the user is in the same position as before dismissal.

As part of supporting dynamic type on Bookmarks this approach is
no longer valid since:
-The row height might change due to the size of the font.
-The row height is not calculated unless the cell is dequeued,
this means that when the content offset is set to the cached value
(when re-oppening Bookmarks) the position offset is correct, but
the content being displayed are not. This happens because the cells
that weren't displayed when setting the offset manually used the
estimatedRowHeight instead of their real height. This messes up the
cache value.

In order to support dynamic height/type this CL changes the cache
so it stores the tableView row instead of the tableView scroll
offset. It also updates the pref values so they store an int instead
of a double.

It also deletes BookmarkHomeSharedState cellHeightPt and updates
the estimatedRowHeight value to 65.

This CL doesn't introduce dynamic height yet, that will be done in
a follow up CL.

Bug: 869671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6cd5f8baa8b385d3045ab5e9d0ff54a9d8202b63
Reviewed-on: https://chromium-review.googlesource.com/1157684
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587821}

Bug: 879306
Change-Id: Ia1458ab7275bbcfeeb24e358b5702cb5d5e57c2e
Reviewed-on: https://chromium-review.googlesource.com/1196025
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587820}

https://chromium.googlesource.com/angle/angle.git/+log/5fdc38cf171b..44b2c0b1d349


git log 5fdc38cf171b..44b2c0b1d349 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 fjhenigman@chromium.org Avoid rebase_path() in BUILD.gn.
2018-08-30 fjhenigman@chromium.org Avoid rebase_path() in tests/BUILD.gn.


Created with:
  gclient setdep -r src/third_party/angle@44b2c0b1d349

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Iac641dda1c8d0220973eeb890f303fd856245546
Reviewed-on: https://chromium-review.googlesource.com/1197293Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587819}

Before we may set auth token while assistant manager is creating, now
we wait for it to reach running state to refresh token.  This may happen
during start and settings toggles.

Bug: b:113591813
Test: locally compile
Change-Id: Iccc672844734be3a25d4b6cc761cc16cbe8e0d34
Reviewed-on: https://chromium-review.googlesource.com/1197844Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587818}

Previously, only gestures (i.e. tap) would trigger the controls to hide
after a certain period of time. This change also adds this behavior for
keyboard interaction to avoid forcing the user to blur the window to
hide the controls.

Bug: 879294
Change-Id: I697099c317c05a8e206acfab24848b8fd0ce149d
Reviewed-on: https://chromium-review.googlesource.com/1197408Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587817}

The new metrics are as follows:
- The number of apps user selected.
- The ratio of selected and recommended apps.
- Whether the reocmmend apps screen is shown.
- The user action on the recommend apps screen.

Bug: 835029
Change-Id: Ibdb3e14d1405693f9569bf4e6161027ce3fd7fbc
Reviewed-on: https://chromium-review.googlesource.com/1196037
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587816}

This CL adds a summary string for 'Google activity controls' that is
shown if there's a child account on the device.

Bug: 814728
Change-Id: I0e36d7c8adbaa32ac9e857c9a7ccb6846d570771
Reviewed-on: https://chromium-review.googlesource.com/1196603
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587815}

Create a KeyDerivationParams struct that encapsulates all information
needed to derive a key from a password. This includes the key derivation
method and any other method-specific parameters. Unhardcode the constant
salt for scrypt and accept a salt via KeyDerivationParams, as a
method-specific parameter.

Effectively replace *all* instances of KeyDerivationMethod with
KeyDerivationParams, since KeyDerivationMethod is no longer enough
information to be able to properly derive a key. The only mentions of
KeyDerivationMethod remain in SyncEncryptionHandlerImpl and its unit
tests, as they need to serialize and deserialize the method and
method-specific parameters separately in Nigori.

Add generation of a random salt to the code path where a new encryption
passphrase is set (only when we are using scrypt for key derivation;
PBKDF2 still uses the old hardcoded salt for compatibility reasons) and
persist it in Nigori. Read the salt when constructing a
KeyDerivationParams instance from an existing Nigori.

TBR=treib@chromium.org,sdefresne@chromium.org

Bug: 878890
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie4bde573d68a0bfeeec375c0d5d59e3d8c4e3437
Reviewed-on: https://chromium-review.googlesource.com/1196380
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587814}

Right now we have a active_touch_in_progress_ to indicate whether there
is an active touch or not. It is true when we receive ACK for touch
start and false at touch end.

From the current crash report, we are seeing multiple consecutive ack
for touch end, without any ack for touch start in between.

This CL changes the active_touch_in_progress_ to num_of_active_touches_.
It is increased by one when we receive ack for touch start and decrease
by one at touch end. At touch end, we only reset touch action when this
number is zero.

In theory, touch start and associated touch end should arrive in pair.
This CL does a DumpWithoutCrashing if this number is ever larger than
one.

Bug: 851644
Change-Id: I584f1aad56bf5bc5c08e20e3ae4ca36d5f9e3586
Reviewed-on: https://chromium-review.googlesource.com/1196696Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587813}

This adds an optional "ProxyErrorClient" client to the NetworkContext which
receives notifications of errors in the PAC script, as well as notifications
of failed URL loads that may have been proxy related.

Bug: 876568,851609
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I645ef91875135fcc81a7bd113442a0b65c661e65
Reviewed-on: https://chromium-review.googlesource.com/1192123Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587812}

Previously we were running the cc::Surface for Videos project on the media thread.
This was found to cause some smoothness regressions. This CL fixes that by pushing the
work onto its own thread.

TBR=gab@chromium.org

Bug: 866508
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide12cb6cebc9dea83a7686c09e6688537bf3389a
Reviewed-on: https://chromium-review.googlesource.com/1176879
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587811}

This adds the bridge code to allow Android Chrome to access the native
Query in Omnibox implementation that lives within the omnibox/
component.

Bug: 874592
Change-Id: I6d6721c648b9de453f4a17791bc91001ac104b1a
Reviewed-on: https://chromium-review.googlesource.com/1196162
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587810}

This change updates the service_manager::Instance code to reference its
options_.instance_sharing value instead of "service_manager:all_users"
and "service_manager:singleton" in the "required" section of its
interface provider specs.
Tests and existing manifests were updated accordingly.

Bug: 866967
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I699ec3411b7ec84023fbb56f85186ad5519515c4
Reviewed-on: https://chromium-review.googlesource.com/1195892Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587809}

This CL removes the restriction on the maximum number of WebAPK share targets
by switching from a checked-in ShareActivity{{index}} to an activity alias.

Bug=None

Change-Id: I40567760615da5a9e0c218621df6eac749cf80d0
Reviewed-on: https://chromium-review.googlesource.com/1191088
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587808}

AudioOutputDevice needs to be destroyed on non-UI thread
to avoid blocking.

Bug: b/112782871
Test: Manual test with DCHECK on.
Change-Id: I8e7fd7d9656ff8a9152f10d48d4575055763bd63
Reviewed-on: https://chromium-review.googlesource.com/1197046
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587807}

This reverts commit d63515c2.

Reason for revert: breaking all webview benchmark

BUG:878965

Original change's description:
> Remove unneeded list from event_stream_logger.js
> 
> Change-Id: I8494b52cd7a38d2b52184f4fb02030d3a05da776
> Reviewed-on: https://chromium-review.googlesource.com/1187861
> Reviewed-by: Yuki Awano <yawano@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Eriko Kurimoto <elkurin@google.com>
> Cr-Commit-Position: refs/heads/master@{#585742}

TBR=dtseng@chromium.org,yawano@chromium.org,elkurin@google.com,sarakato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I65b1079c6496f83cbe2a332d8e7570eb3a92d244
Reviewed-on: https://chromium-review.googlesource.com/1196840Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587806}

https://chromium.googlesource.com/catapult.git/+log/d539d9382241..7a770735549a


git log d539d9382241..7a770735549a --date=short --no-merges --format='%ad %ae %s'
2018-08-30 benjhayden@chromium.org Remove /change_internal_only.
2018-08-30 benjhayden@chromium.org .


Created with:
  gclient setdep -r src/third_party/catapult@7a770735549a

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:868512
TBR=sullivan@chromium.org

Change-Id: If64c1988054ec11e6d8208bedb519b999b5aebf7
Reviewed-on: https://chromium-review.googlesource.com/1197291Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587805}

https://pdfium.googlesource.com/pdfium.git/+log/678f5418d36f..b6e7d49ad5f3


git log 678f5418d36f..b6e7d49ad5f3 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 thestig@chromium.org Roll v8 to 19afaa14
2018-08-30 thestig@chromium.org Stop using deprecated V8 APIs in CFXJSE_Value.
2018-08-30 thestig@chromium.org Add check on CGATS memory allocation in littlecms.


Created with:
  gclient setdep -r src/third_party/pdfium@b6e7d49ad5f3

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:872189
TBR=dsinclair@chromium.org

Change-Id: I3b08c657e82321c78a6dee42ac3cf2801ecb2020
Reviewed-on: https://chromium-review.googlesource.com/1197290Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587804}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33cd3245d62e..049f97004fb6


Created with:
  gclient setdep -r src-internal@049f97004fb6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I48457368ab729987e789161c32a7766d61e5058f
Reviewed-on: https://chromium-review.googlesource.com/1197289Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587803}

Removing focus ring when focusing on diabled options on "customize this
page" dialog.

Bug: 878769
Change-Id: I71466a87f4f1ea76022a09c072894d5ee9af1ed0
Reviewed-on: https://chromium-review.googlesource.com/1195932Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587802}

This CL fixes a bug in reporting counts of sync entities for USS data
types (introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1131747).

Previously, also tombstones were recorded as entities which were not
recorded for directory data types. After this CL, only non-deleted
entities are consistently recorded for all data types.

Bug: 859859
Change-Id: I8ee885ca6901f77feba6c5e8420b28a4b9bf8ce6
Reviewed-on: https://chromium-review.googlesource.com/1196449
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587801}

These are bots that were deleted ages ago.

Bug: 878327
Change-Id: If1d894c4ecd53b1421bd2e989b1e15a35b131b1b
Reviewed-on: https://chromium-review.googlesource.com/1195731Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587800}

The new Baseline Alignment algorithm states that items with sizing
cyclic dependencies must be excluded from any baseline context they
participate in. One of these cyclic dependencies can happen with
intrinsic sized grid areas and relative items.

The grid spec states [1] that flex-sized tracks should be considered
as content-sized when the grid container has an indefinite size. We
were using the AvailableSize(direction) function to determine whether
the grid container is indefinite or not. However, this function may
provide different results during the different phases of the grid
layout logic. This issue causes assert violations like the one
described in the bugs listed below.

The new Baseline Alignment logic is now integrated in the Grid Track
sizing algorithm. Hence, we need to ensure that an item that
participates in any baseline alignment context during the track sizing
also does during the alignment phase, at the end of the grid layout
logic. In order to achieve that, this CL forces a new computation of
the Baseline offsets during the step 3 of the Grid sizing algorith,
since during this step the available space is not indefinite anymore.

It's worth mentioning that this change assumes the issue grid items
being excluded and included of Baseline Context during the different
phases of the Grid sizing algorithm, which I hope we can clarify in
the issue [2] I filed for the CSS WG.

[1] https://drafts.csswg.org/css-grid/#fr-unit
[2] https://github.com/w3c/csswg-drafts/issues/3046

Bug: 867833, 874861, 876593
Change-Id: I668d399b920c9280a8e20b3e8362f562eded4770
Reviewed-on: https://chromium-review.googlesource.com/1177757Reviewed-by: Sergio Villar <svillar@igalia.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#587799}

UI network quality estimator service no longer needs to implement
network quality provider since we now have network quality
tracker. This CL simplifies the logic in UI network quality
estimator service by removing the unnecessary code.

Bug: 878844
Change-Id: I7d97bc29452a73d5a6f522b58cca3c67e5368e77
Reviewed-on: https://chromium-review.googlesource.com/1196005Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587798}

Bubble widgets no longer have a visible arrow, this simplifies
the bounds layout calculation.
This CL removes redundant constants that are either 0 or equal
to other constants in BubbleBorderTest.GetBoundsOriginTest.

Bug: 877032
Change-Id: Icb886704647f926acbf29c23df0695ea36cd9b5b
Reviewed-on: https://chromium-review.googlesource.com/1195244Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587797}

ProcessedLocalAudioSource is changed to either create a
MediaStreamAudioProcessor or an AudioServiceAudioProcessorProxy depending
on whether the WebRtcApmInAudioService flag is set.

AudioServiceAudioProcessorProxy proxies GetStats and AECDump calls to
the remote audio processor. Although the JavaScript getStats call is
asynchronous, we currently collect stats synchronously inside Chrome.
Ideally, this would be changed. For now, the proxy overcomes this
mismatch by polling the remote audio processor for stats at regular
intervals. It uses a heuristic to determine the rate at which the user
is calling getStats and tries to match that, within some reasonable
limits. 878764 has been filed to fix this.

For AECDumps, we already get a file-handle from the browser, so it can
just be sent along to the audio service. So the audio service does not
need to be able to create files for this to work.

For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing
It's accessible to everyone @chromium.org.

No-try since the test timing out is unrelated.

No-Try: true
Bug: 851959, 878764, 879133, 879243, 879296
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7473c068aa691d69f6ba90dce2550534c9cb3d8a
Reviewed-on: https://chromium-review.googlesource.com/1169471
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587796}

In this CL, we create a new autofill_private api function in order to trigger migration from settings page. We have to construct autofill_client, payments_client, personal_data_manager and local_card_migration_manager in the api for triggering migration and uploading the cards.

The following CL will be use the added IsMigratable, syncStatus and experimental flag to check the migration requirement and trigger this api when meets the requirements.

Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i

Bug: 852904
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I75a4a952efaf33c3f9187348a6e39f3abd4471a4
Reviewed-on: https://chromium-review.googlesource.com/1178683Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#587795}

Refactor the launcher overview animation to share some code.

Test: manual
Bug: 873394
Change-Id: I6c94719a559eea04e354d2bc131efc4cf14650df
Reviewed-on: https://chromium-review.googlesource.com/1196910Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587794}

Bug: 860119
Change-Id: I1545e820cd53d46ef6a20b6d923d33f727070901
Reviewed-on: https://chromium-review.googlesource.com/1195897Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#587793}

Similar to the output CL, processing settings are plumbed into the audio
service. InputControllers join the processing group and get notified by
the appropriate output controller is started. It can then reconfigure
itself as necessary; to either start monitoring the output stream or to
ask what device it is using and call SetOutputDeviceForAec on its
AudioInputStream.

For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing
It's accessible to everyone @chromium.org.

Bug: 851959
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I138cd290295821467e836a7e7e6eb7d7ad364bdc
Reviewed-on: https://chromium-review.googlesource.com/1174835
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587792}

~NetworkService happens before task scheduler shutdown, and so some tasks
in things like cookies and disk_cache can outlive it, and those want to use
the NetLog sometimes --- so the NetLog can't be destroyed in ~NetworkService

Bug: 878428
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I53f89982f6683ff2ab326198691670627e7fbbb8
Reviewed-on: https://chromium-review.googlesource.com/1195549Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587791}

Add Google Payments account check. We only offer credit card migration when user already has a Google Payments account.

We get the PrefService from the Profile and then we can get whether user has a google payments accout from the PrefService.

Bug: 852904
Change-Id: I06d326417cdc4fded5a15635f8883ebabbe0a1f5
Reviewed-on: https://chromium-review.googlesource.com/1196013Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#587790}

Change-Id: I29fd4a91e943ecbda810c1ae4085a5476896e3f8
Reviewed-on: https://chromium-review.googlesource.com/1197288Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587789}

The buttons on other platforms handle the space key as well. This change
only adds the handling to toggle play/pause to Mac. The close button
is not handled since tabbing is not handled and there are no visual
affordances for which button is focused on Mac. These exist on other
platforms.

Bug: 879139
Change-Id: I40135a7c70fd8d737a2b3b368bfad968d0eeb225
Reviewed-on: https://chromium-review.googlesource.com/1196931Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587788}

The new instruction bubble's recommendation to "press Alt+F" won't work on
non-browser windows, so don't show the instructions unless the focused window is
a browser window and has a toolbar.

BUG=243164
R=sky

Change-Id: I1ab550ff57134009a2cbb0a1ee612775c1323e88
Reviewed-on: https://chromium-review.googlesource.com/1197343Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587787}

The message always used to say "Press Alt+F followed by X to exit".  The "X"
comes from the menu option "Exit".  But the accelerator may be different in
non-English languages.  This CL internationalizes the accelerator.

BUG=243164
R=sky

Change-Id: I695979eef5ea15f1764b891611b2c513302c4c0e
Reviewed-on: https://chromium-review.googlesource.com/1194976Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587786}

BUG=878604

Change-Id: I20d281d9b03fbb41c2cac72586a60949fc73a860
Reviewed-on: https://chromium-review.googlesource.com/1197269Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587785}

This reverts commit fa22a78c.

Reason for revert: I reverted the initial cl to prove that crash reports in crbug.com/868849 are not caused by it. Relanding it now since the crashes still happened after the revert.

Original change's description:
> Revert "Clean up DidStopFlinging IPC"
> 
> This reverts commit 7cb247dd.
> 
> Reason for revert: Check to see if the crash report in crbug.com/868849 goes away or not.
> 
> Original change's description:
> > Clean up DidStopFlinging IPC
> > 
> > This cl also removes TouchscreenFlingInProgress function that is no
> > longer needed.
> > 
> > Bug: 249063
> > Change-Id: Icc939d654cdfe0cf38c843933f2fd469f843b74c
> > Reviewed-on: https://chromium-review.googlesource.com/1145784
> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Sahel Sharify <sahel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#578410}
> 
> TBR=kenrb@chromium.org,pdr@chromium.org,dtapuska@chromium.org,sahel@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 249063
> Change-Id: Iee7200d3c4e388fccbc2dc6b86997a07a3a03f0a
> Reviewed-on: https://chromium-review.googlesource.com/1155169
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579166}

TBR=kenrb@chromium.org,pdr@chromium.org,dtapuska@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 249063
Change-Id: I47b3d00615ebb29b643aa03ef73b523381c092c6
Reviewed-on: https://chromium-review.googlesource.com/1197334Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587784}