- 25 Sep, 2019 40 commits
-
-
Randy Rossi authored
Mismatch in API caused chromecast extension to fail. Bug: 989413 Test: Manual display assistant Change-Id: Ib0855853ac0b49b1f24a4a80b75c45834f0a87db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814571Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699758}
-
Jérôme Lebel authored
SyncSettingsTableViewController class is only use with pre-unity UI. Unified consent feature flag is now always true. Bug: 1778868 Change-Id: Ifec7b9c6b10833899c62351fd3972f4b376e1afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781441Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699757}
-
Tanmoy Mollik authored
When AccountManagementFragment is destroyed after pressing add account in account picker it is not attached to any intent and causes crash on asynchronous call to AccountManagerFacade.createAddAccountIntent(). This cl should fix that crash. Bug: 1006682 Change-Id: I3c1f5be77cf279d7ad740d220297b11027844031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817607 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699756}
-
Matthias Körber authored
Change-Id: I64596bb4bdd4f32c758db760f81c2f5bee1c8233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824083Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#699755}
-
Peter Marshall authored
Right now when using UI.ToolbarComboBox, the caller has to remember to call setTitle() after constructing it, otherwise no aria-label will be set for the 'select' element. Some callers did not do this, but all select elements are user visible and must have aria-label set. To ensure that this mandatory property is set, this CL changes the constructor to require a title argument and sets the ARIA accessible name (thus setting aria-label) to the title. Remove the setTitle() method which was only used to add a title right after the creation of the object. Update all of the users of UI.ToolbarComboBox to provide a title, fixing accessibility issues for the users that did not already call setTitle(). Make accessibleName mandatory for ToolbarSettingComboBox as there is only one caller, and they provide it. Change-Id: Ib60e2edab763bbfaa4e71a1c76ed4fa4e21e3fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821904Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699754}
-
Matthias Körber authored
Change-Id: I1b9ac32e33d1e17f83e12887aa6782342e131a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823863Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#699753}
-
Chris Blume authored
There are two rounded corner tests that are also failing. This CL adds those tests to the pixel expectations. TBR=jonross@chromium.org Bug: 969855 Change-Id: I15a41b26a08786a477484a7f1a33910d9e54742c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824542Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#699752}
-
Matthias Körber authored
Change-Id: I1f98814ebec6acc2114d536b7daec93ebbab107e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824269Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#699751}
-
Sebastien Lalancette authored
TBR=sammiequon@chromium.org Change-Id: I54f8b70bba725f2bfefe36c2c6d72d40ad42c1de Bug: 1007961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825097Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#699750}
-
Matthias Körber authored
Change-Id: I76216781bd9336ca8f794ee12e84742b3b416716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824268Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#699749}
-
Monica Basta authored
Bug: 1006989 Change-Id: I8836648a04a8e987cf0163c2fa22f607db3f5342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824886Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#699748}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org BUG=chromium:878390 Change-Id: I0b3b27098424b89e63962b604f39a43e53cd6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816512 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#699747}
-
Matthias Körber authored
Change-Id: Ifc488d87f8e827cc8a34252a8011375ea24dbb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824270 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699746}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f269be63. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" a0586590 "Don't fold SaveAlphaLayer into DrawTextBlob" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia874c4cbca9b373d6165a57fb44c0dff815661cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823794Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699745}
-
Stephen McGruer authored
See https://drafts.csswg.org/web-animations-1/#current Bug: 1005848 Change-Id: I95981797ced813d6a7a0e57a1b719f3bb0bd736b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814200Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699744}
-
Matthias Körber authored
Change-Id: Ie4934e0944504674df6c0963b9004c4f4498a225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823866 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699743}
-
Oleh Lamzin authored
Implement dock mac address source handler which changes shill Ethernet property. More details about USB Ethernet MAC address source policy implementaion in shill: go/shill-dock-passthrough. Bug: b:132240657 TEST=unittests and manual test that shill receive policy on changes and chrome startup Change-Id: Ic3fc7dd416b60294bfcab122ebb64db7f7ea00da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700203Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#699742}
-
Gauthier Ambard authored
When failing a provisional navigation, the context might be nil (probably a race condition in the callbacks of the WKWebView). This issue was handled in handleCancelledError:forNavigation: provisionalLoad: but wasn't in the other callbacks. This CL makes sure that we handle it. The workaround in crrev.com/c/1700054 was probably preventing the crash from happening. Bug: 1004634 Change-Id: I1f94812617c908a63124c16a18a3ca71d9902d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816575 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699741}
-
Matthias Körber authored
Change-Id: I9a765517e989c259379c96ded5d2bdfe230100be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824885 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699740}
-
François Beaufort authored
This CL adds GPUObjectDescriptorBase dictionary as specified in https://gpuweb.github.io/gpuweb/#dictdef-gpuobjectdescriptorbase It will be used in upcoming CLs. Bug: 877147 Change-Id: Ib4e728309e01bb059ea91402fcc406ef577f9751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823860Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#699739}
-
Alex Ilin authored
This CL adds a new test DemoSignInTest::WebSignOut to the suite of live SignIn tests. The test does the following: - Sign in via settings menu - Accept Sync confirmation dialog - Check that Sync is enabled - Sign out on the web - Check that cookies are removed and tokens are in error state - Check that "Sync paused" UI is shown This CL also allows direct lookups for country-specific TLDs of "accounts.google.*" to make tests work correctly from different countries. Bug: 1006262 Change-Id: Ib4d94003bfbabec8dd9d2908c95715d2b1ecdc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822919 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699738}
-
Alex Clarke authored
We want to prioritize loading and compositing tasks until first first contentful paint, however that introduces some unintentional task re-ordering which breaks ChromeSitePerProcessBrowserPluginPDFTest.SendSyntheticTapGestureOOPIF. Changing BrowserPlugin::Initialize to post a loading task removes one source of reordering with the new scheduler policy, fixing the the browser test. Bug: 971191 Change-Id: I177d9189c980601893223425e36cd6657d058510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819254Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699737}
-
Tim van der Lippe authored
This allows us to use more modern features like Object spread. Change-Id: I3a8a119443cf43b27e3ac9390e188408976d82e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823847Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#699736}
-
Sergey Poromov authored
Temporary allow Camera component app to be disabled by policy as it's widely used by enterprises. The proper long-term fix should be to introduce CameraEnabled policy and then remove this fix. Camera app id: hfhhnacclhffhdffklopdkcgdhifgngh Bug: 993418 Test: Manual, configured ExtensionInstallBlacklist policy to include Change-Id: I9af2d6303d023b61b1af461f51533ffb25b00422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789312 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699735}
-
Julie Jeongeun Kim authored
This CL converts MessageReceiverPtr, MessageReceiverRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, and Receiver. It also updates OnConnection from secure_channel.mojom. Bug: 955171 Change-Id: Id630cb964ad03f439b696e93182bc29b13fa689d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820777 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699734}
-
Ella Ge authored
Bug: 988784 Change-Id: I7c26682dd7f82bb5a6abf985f9991518ea100180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822503Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#699733}
-
Sebastien Marchand authored
The code that was emitting this histogram has already been removed. Bug: 995542 Change-Id: I36fbc89b33ba483ecfb3d8b93e54cbbfc8336173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823217 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#699732}
-
Lowell Manners authored
NavigateInRenderer was using a non-standard method of waiting for navigations, (written in 2010). Now there is a much simpler way to do this. This cleanup has the pleasant side effect of fixing some test failures when BackForwardCache is enabled. Change-Id: I96b3d3d93fb9b58485cf0f7c7f33751a1abf55f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813350 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699731}
-
Xida Chen authored
In our current implementation, a custom property animation is composited regardless whether it is used by paint worklet or not. This CL makes changes such that a custom property animation is composited only when it may be used by off-thread paint worklet. Bug: 1002586 Change-Id: I305c1396495fb12477756c5e2d0e56404983a39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798889 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699730}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53bdbb292b71..0c127f488fdb git log 53bdbb292b71..0c127f488fdb --date=short --no-merges --format='%ad %ae %s' 2019-09-25 treehugger-gerrit@google.com Merge "Do not create variable for iterator we do not use." 2019-09-25 lalitm@google.com trace_processor: change RowMap::Select to return a RowMap Created with: gclient setdep -r src/third_party/perfetto@0c127f488fdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idbbc2d1966008fe2e07736199e45dcd67b2ff8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699729}
-
Paul Lewis authored
This CL converts the contents of the common/ folder over to ES modules from the current custom module system. It includes statements in each file that will pollute the global namespace, allowing the non-ESM code to continue working as before. Bug: 1006759 Change-Id: Ib591e49155000381f85999a5da6c467ad0160996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#699728}
-
Hajime Hoshi authored
This is a preparation to take the reason why the document is not cached and record it. Bug: 1004676 Change-Id: Ib87b4115566e227441b5b9d546722ef204f5c4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820404 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699727}
-
Christoph Schwering authored
Function isn't used. Change-Id: I8124be0ede96845bcc143d625d33690292ef4d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823838Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#699726}
-
Tomasz Moniuszko authored
Compiler complains about undefined DISALLOW_COPY_AND_ASSIGN if password_dialog_prompts.h is included from a file that doesn't include macros.h before. Change-Id: I58f161f325722591eb3ab3fbac38fc2862bb27dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821604Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#699725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70bc753cc6c6..90d6efbd4eb4 git log 70bc753cc6c6..90d6efbd4eb4 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ilnik@webrtc.org Revert "VP9 encoder: handle disabled layers correctly" 2019-09-25 gustaf@webrtc.org AEC3: Simplify use of SignalTransition 2019-09-25 srte@webrtc.org Moves contents of bitrate_controller to goog_cc 2019-09-25 ilnik@webrtc.org VP9 encoder: handle disabled layers correctly 2019-09-25 asapersson@webrtc.org Add unit tests for balanced degradation settings. Created with: gclient setdep -r src/third_party/webrtc@90d6efbd4eb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: Ie5c9b7239ed9e8c6f18dc0af68f7b2447bd83c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699724}
-
Pavol Marko authored
The underlying issue that has been causing many flakes here (https://crbug.com/1005082) has been fixed, so re-enable the browsertest. Bug: 1005084 Change-Id: I0147578787ca11d8ddbfd49158dfc5eda5bf8a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821482Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699723}
-
Armando Miraglia authored
This reverts commit fea48b7b. Reason for revert: while not visible, this broke webrtc tests the 20th of August (see https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Mac%20Tester/8622) Original change's description: > Speculatively re-enable TestVideoQualityH264. > > This was reported as flaky. I am unable to reproduce, which could mean > that the issue is fixed, or it could mean that it only flakes on certain > setups (OS, builds, hardware, etc). To aid investigation I am > speculatively re-enabling it; worst case it gets disabled again. > > Bug: 754684 > Change-Id: I866679464fce4facde927652751046e062ca1c81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761602 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688531} TBR=hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 754684, 1007937 Change-Id: I3c6f8954b2a007e3a1ff3ac8db154c896a4cbebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823842 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699722}
-
Boris Sazonov authored
This CL removes a significant chunk of org.chromium.chrome.browser.invalidation Java package, as Chrome is now using FCM for invalidations. After https://crrev.com/c/1763755, ChromeInvalidationClientService is no longer created and can be safely removed. Bug: 1002894 Change-Id: Ia2c2e4613c2c40b456cef97a83cff93c7f21fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821784Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699721}
-
Finnur Thorarinsson authored
This reverts commit 3594437b. Reason for revert: One or more of these tests have been consistently failing on the android-asan bot, since build 2270 (https://ci.chromium.org/p/chromium/builders/ci/android-asan/2270): PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages PooledSharedImageVideoProviderTest.GenerationIdChangeEmptiesPool PooledSharedImageVideoProviderTest.RequestImageReusesReturnedImages PooledSharedImageVideoProviderTest.SizeChangeEmptiesPool ... with errors such as: [ RUN ] PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages ================================================================= ==7769==ERROR: AddressSanitizer: heap-use-after-free on address 0x5ac43bfc at pc 0x94420df5 bp 0xbeb47190 sp 0xbeb4718c READ of size 4 at 0x5ac43bfc thread T0 (st:test_process) Original change's description: > Pool SharedImageVideo for MCVD. > > To reduce thread hops when generating VideoFrames, this CL adds > PooledSharedImageVideoProvider. It builds on the direct provider by > maintaining a pool of SharedImageVideo objects, which it hands out > on its own thread to clients. > > It also adds histograms to track VideoFrame creation time, so that > we can see which device(s) benefit from pooling. > > All of this is turned off by default; it must be switched on by > enabling UsePooledSharedImageVideoProvider. > > Change-Id: I4cfc03938dd4717252f3f527a3bcab0e7ae085a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699138 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698985} TBR=mpearson@chromium.org,sandersd@chromium.org,liberato@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic1d1b26dfa33eeabc49af497d58259b45607ee14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824081Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#699720}
-
Maksim Sisov authored
Wayland compositor provides supported format modifiers. Store them along with buffer formats and provide the WaylandBufferManagerGpu with them during initialization step. Then, GbmPixmapWayland can just use them if they are set. Bug: 1002463 Change-Id: I97f6367ad9315e3e22b0f9f37c8f1aec03df07a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795326Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#699719}
-