- 21 May, 2017 20 commits
-
-
sky authored
For mash/mushrome we need setting of touch state to happen in mus. This patch separates out setting into a separate class so that ash in mus/mash can plug in a class that makes mojo calls. BUG=705686 TEST=covered by tests R=oshima@chromium.org Review-Url: https://codereview.chromium.org/2887413004 Cr-Commit-Position: refs/heads/master@{#473474}
-
sky authored
There were a couple of values not being written. This updates the mojom and traits appropriately. BUG=718860 TEST=covered by tests R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2894763003 Cr-Commit-Position: refs/heads/master@{#473473}
-
fdoray authored
SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=miguelg@chromium.org Review-Url: https://codereview.chromium.org/2882653003 Cr-Commit-Position: refs/heads/master@{#473472}
-
Blink W3C Test Autoroller authored
Using wpt-import in Chromium 8235be2d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/102 Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html TBR=qyearsley@chromium.org NOEXPORT=true Change-Id: I8a0c6bc0d3aee764af04e088f0edeae7d1cbb3bc Reviewed-on: https://chromium-review.googlesource.com/509810Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473471}
-
fdoray authored
SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org Review-Url: https://codereview.chromium.org/2876983003 Cr-Commit-Position: refs/heads/master@{#473470}
-
fdoray authored
SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=fgorski@chromium.org Review-Url: https://codereview.chromium.org/2878873003 Cr-Commit-Position: refs/heads/master@{#473469}
-
fdoray authored
SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=nick@chromium.org Review-Url: https://codereview.chromium.org/2879943002 Cr-Commit-Position: refs/heads/master@{#473468}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/76149aa5fba3..d34edf3dc902 $ git log 76149aa5f..d34edf3dc --date=short --no-merges --format='%ad %ae %s' 2017-05-19 bsalomon Revert "Revert "Remove GrSurfaceDesc member from GrSurface."" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I86ffc0a73f24a3dc6fd60909e1827a3b3be5770d Reviewed-on: https://chromium-review.googlesource.com/510208Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473467}
-
xiaofeng.zhang authored
Reason for reland: Fix the compile fails in build target "jpeg_decode_accelerator_unittest" Original issue's description: > base::ScopedVector is deprecated, see bug. BUG=554289, 588249 TBR=alokp@chromium.org,bbudge@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2895573002 Cr-Commit-Position: refs/heads/master@{#473466}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5d7f2b5301f8..76149aa5fba3 $ git log 5d7f2b530..76149aa5f --date=short --no-merges --format='%ad %ae %s' 2017-05-21 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I487937b0a1ded85ecd6cfb22a28c259c831cebf9 Reviewed-on: https://chromium-review.googlesource.com/510027Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473465}
-
gyuyoung authored
As a step to reduce uses of wtf/Assertions.h, This CL changes all uses of ASSERT with DCHECK() or DCHECK_FOO() in core. BUG=596760 Review-Url: https://codereview.chromium.org/2899573002 Cr-Commit-Position: refs/heads/master@{#473464}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/893039d0..97dbf624 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2896693002 Cr-Commit-Position: refs/heads/master@{#473463}
-
nednguyen authored
BUG=715344 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2894363002 Cr-Commit-Position: refs/heads/master@{#473462}
-
horo authored
This CL pipes the DataSaver flag from the renderer process which creates a Shared Worker to the shared worker process. After this CL, both the worker script request and the fetch request from the shared worker will have "Save-Data: on" HTTP header if DataSaver is enabled. BUG=722774 Review-Url: https://codereview.chromium.org/2881073003 Cr-Commit-Position: refs/heads/master@{#473461}
-
tapted authored
Revert of Support finer grained font weights on Mac. (patchset #6 id:240001 of https://codereview.chromium.org/2869803005/ ) Reason for revert: Need to test 10.11 again. failures in the build cycle at https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/12666 Original issue's description: > Support finer grained font weights on Mac. > > We want to explore a MEDIUM weight for button text under Harmony. This > is consistent with MD and helps compensate for buttons not using solid > black for the font color. > > The San Francisco font in 10.11 and 10.12 has good support for finer > grained weights and is the font Chrome UI is mostly concerned with, so > focus testing on that but survey expectations for all supported OS > versions. > > BUG=691891 > > Review-Url: https://codereview.chromium.org/2869803005 > Cr-Commit-Position: refs/heads/master@{#473457} > Committed: https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb22b39ea87097 TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691891 Review-Url: https://codereview.chromium.org/2898613002 Cr-Commit-Position: refs/heads/master@{#473460}
-
dskiba authored
It was discovered that touching (to dirty pages) large regions of memory can be very costly on Android (~60ms per 10MiB on Nexus 5). We touch on IO thread, but still, it's better not to block it for long periods. With this CL we'll touch the ablation payload in chunks and we'll schedule each touch individually to let other things to happen in between. BUG=710048 Review-Url: https://codereview.chromium.org/2896523004 Cr-Commit-Position: refs/heads/master@{#473459}
-
rch authored
This does not change OnClose or OnError and the callback is not yet invoked on errors. That will happen after all the upcalls are replaced by async methods. BUG=716563 Review-Url: https://codereview.chromium.org/2873963003 Cr-Commit-Position: refs/heads/master@{#473458}
-
tapted authored
We want to explore a MEDIUM weight for button text under Harmony. This is consistent with MD and helps compensate for buttons not using solid black for the font color. The San Francisco font in 10.11 and 10.12 has good support for finer grained weights and is the font Chrome UI is mostly concerned with, so focus testing on that but survey expectations for all supported OS versions. BUG=691891 Review-Url: https://codereview.chromium.org/2869803005 Cr-Commit-Position: refs/heads/master@{#473457}
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#473456}
-
aleventhal authored
BUG=722530 Review-Url: https://codereview.chromium.org/2886963004 Cr-Commit-Position: refs/heads/master@{#473455}
-
- 20 May, 2017 20 commits
-
-
nednguyen authored
This doc explains: 1) How to write WebKit perf tests 2) How to add tracing metrics to a WebKit perf tests 3) How to run the tests BUG=715344 Review-Url: https://codereview.chromium.org/2875933005 Cr-Commit-Position: refs/heads/master@{#473454}
-
csharrison authored
This functionality is only needed in the //chrome layer. This CL doesn't change behavior. BUG=717590 Review-Url: https://codereview.chromium.org/2890253002 Cr-Commit-Position: refs/heads/master@{#473453}
-
dmazzoni authored
They were flaky a while ago, but the underlying flakiness should be fixed now. Also add cross-platform "blink" expectations, which will making catching flakiness even easier with more coverage. BUG=622387 Review-Url: https://codereview.chromium.org/2892773002 Cr-Commit-Position: refs/heads/master@{#473452}
-
Blink W3C Test Autoroller authored
Using wpt-import in Chromium 21e6d26f. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/99 TBR=qyearsley@chromium.org NOEXPORT=true Change-Id: I24cc41d4a30360f52ff612cd217cce9d0c8826a1 Reviewed-on: https://chromium-review.googlesource.com/509393Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#473451}
-
qyearsley authored
(This test was already marked flaky timeout before). TBR=sahel TBR_REASON=Making Mac 10.11 dbg green again BUG=724817,708499 Review-Url: https://codereview.chromium.org/2895063002 Cr-Commit-Position: refs/heads/master@{#473450}
-
qyearsley authored
TBR=hiroshige TBR_REASON=Sheriffing/gardening leak builder BUG=724818 Review-Url: https://codereview.chromium.org/2895053002 Cr-Commit-Position: refs/heads/master@{#473449}
-
szager authored
I speculate that WebAXObject::IsDetached() may not be as reliable as Document::IsDetached(). Also, add a SECURITY_CHECK in the place where I suspect the bad access is happening. BUG=722801 R=dmazzoni@chromium.org,skobes@chromium.org Review-Url: https://codereview.chromium.org/2892283002 Cr-Commit-Position: refs/heads/master@{#473448}
-
kinuko authored
Feature has shipped in M56 and two milestones have passed, we should be able to remove the runtime flag now. BUG=554834 Review-Url: https://codereview.chromium.org/2895543004 Cr-Commit-Position: refs/heads/master@{#473447}
-
amineer authored
Revert of android: Move most hooks to target_os-specific section. (patchset #3 id:40001 of https://codereview.chromium.org/2889323003/ ) Reason for revert: Causes build failures. BUG=724813 Original issue's description: > android: Move most hooks to target_os-specific section. > > gclient recently learned about os-specific hooks, so let's make it so > that only people working on android need to run the many, many > android-specific hooks. > > No intended behavior change. This depends on your gclient being > up-to-date -- it's supposed to auto-update every time you run > `gclient`, but that sometimes doesn't work. If you see issues > after this, `cd ~/src/depot_tools` and `git log` to verify > that your depot_tools is up-to-date (if it isn't, it's probably > easiest to delete and re-checkout depot_tools). > > BUG=none > > Review-Url: https://codereview.chromium.org/2889323003 > Cr-Commit-Position: refs/heads/master@{#473247} > Committed: https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c TBR=jbudorick@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review-Url: https://codereview.chromium.org/2900523002 Cr-Commit-Position: refs/heads/master@{#473446}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/766f9cd5553a..5d7f2b5301f8 $ git log 766f9cd55..5d7f2b530 --date=short --no-merges --format='%ad %ae %s' 2017-05-20 mtklein tidy up dither stage 2017-05-20 mtklein streamline SkRasterPipeline::run() 2017-05-20 mtklein Revert "dither copies when decreasing precision" Created with: roll-dep src/third_party/skia BUG=720105 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ib86a1f24e85a0316e559fa65b77b12ea86614a2f Reviewed-on: https://chromium-review.googlesource.com/509966Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473445}
-
kojii authored
NGInlineNode::CopyFragmentDataToLayoutBox copies geometry from inline NGFragment tree to RootInlineBox and InlineTextBox, but didn't include InlineFlowBox. This results in InlineFlowBox, generated for nested inline elements, to have (0,0). Their children are placed, but since parent InlineFlowBox is at (0,0), they were clipped. This fix turns several tests to fail. They used to pass because expected images did not render. This fix unhides such tests. BUG=636993, 723117 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2887623002 Cr-Commit-Position: refs/heads/master@{#473444}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2f687877835b..766f9cd5553a $ git log 2f6878778..766f9cd55 --date=short --no-merges --format='%ad %ae %s' 2017-05-19 mtklein dither copies when decreasing precision Created with: roll-dep src/third_party/skia BUG=720105 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I3cf00fe5b9cb0e8923d88166bbe89600cf360931 Reviewed-on: https://chromium-review.googlesource.com/509942Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473443}
-
mahmadi authored
BUG=602666 Review-Url: https://codereview.chromium.org/2896623002 Cr-Commit-Position: refs/heads/master@{#473442}
-
mkraynov authored
dataset property of HTMLElemenet converts all of its subproperties to string. So if someone writes 'element.dataset.subProp = false;', condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never fullfilled. uber.js had this bug in 'invokeMethodOnPage' function. So if the frame was reinited, methods on subpage in this frame were invoked immediately instead of waiting for 'pageReady' event. R=dbeam@chromium.org BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2894923002 Cr-Commit-Position: refs/heads/master@{#473441}
-
Blink W3C Test Autoroller authored
Using wpt-import in Chromium 507bbc4d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/97 Directory owners for changes in this CL: xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry-1 TBR=qyearsley@chromium.org NOEXPORT=true Change-Id: Ie424f254d865cf6536d2bc93fe765b9fd8bbbab6 Reviewed-on: https://chromium-review.googlesource.com/509729Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473440}
-
yzshen authored
BUG=699569 Review-Url: https://codereview.chromium.org/2891193002 Cr-Commit-Position: refs/heads/master@{#473439}
-
sebmarchand authored
pgomgr.exe has been moved to a different location in VS2017 so the logic that find it should be updated. It can't just be copied to the build directory because we always run the x64 bit version of this binary (and we don't want to mix x86 and x64 binaries in the same build dir) BUG=719319 Review-Url: https://codereview.chromium.org/2884613003 Cr-Commit-Position: refs/heads/master@{#473438}
-
kojii authored
Bot results up to 218 are included. 95 tests pass for a week and thus removed. BUG=591099 TBR=eae@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2900503003 Cr-Commit-Position: refs/heads/master@{#473437}
-
primiano authored
Minor cleanups lefts from the previous CL in preparation of larger upcoming refactoring. BUG=703184 Review-Url: https://codereview.chromium.org/2891113003 Cr-Commit-Position: refs/heads/master@{#473436}
-
elawrence authored
Replace use of Title Case in the Developer Tools' Security Panel to use sentence case, matching Chrome text standards. BUG=721176 Review-Url: https://codereview.chromium.org/2881513003 Cr-Commit-Position: refs/heads/master@{#473435}
-