- 19 Oct, 2018 40 commits
-
-
Ovidio Henriquez authored
This change updates the WebUsbAllowDevicesForUrls policy entry in policy_templates.json to have the future property set to true. This prevents the policy from being in documentation and the generated ADMX and linux.json file until the policy is visible in Site settings. Design document: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: Ib2c9a04fd992d8c6c88a52ec9c954a48ff9a673d Reviewed-on: https://chromium-review.googlesource.com/c/1262082 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601277}
-
Stephen Martinis authored
It appears that some return statements were accidentally omitted during an earlier refactor. This CL adds a few of them back. Bug: 896175 Change-Id: I218d8ae6fa347fea775d606b5aa04064662ff7e6 Reviewed-on: https://chromium-review.googlesource.com/c/1291787Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#601276}
-
chrome://connnection-helpCarlos IL authored
Added the Symantec cert error code to the bundled connection help that shows when clicking the 'Learn More' link in an interstitial triggers another interstitial. In this case the link is in the section with other cert errors instead of separate, since if the Symantec error shows up in the Chrome support site it is likely due to a captive portal or an extension, not due to the support site using Symantec certs. Change-Id: I3a0889e2e5f683d120f2bdf4a4ce76dae75fc225 Reviewed-on: https://chromium-review.googlesource.com/c/1292005 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#601275}
-
Alexander Alekseev authored
Bug: 896645 Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02 Reviewed-on: https://chromium-review.googlesource.com/c/1290200Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#601274}
-
Dan Harrington authored
Helper script to construct a gtest_filter. Change-Id: I370a36c96d9f6f4e3beb450dd1ca26a65154e56f Reviewed-on: https://chromium-review.googlesource.com/c/1265025 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601273}
-
Michael Giuffrida authored
Fixes the placeholder to match the version in chromium_strings.grd. Bug: 895201 Change-Id: I31e1aec017661597cad41f9d9a1fff6601000b3a Reviewed-on: https://chromium-review.googlesource.com/c/1288908Reviewed-by:
-
Ned Nguyen authored
This is a reland of 5f74e543. The original reland is in patch set 1, fixes are in subsequent patchset. The fix implements: If --release or --debug is specified and there are both more than one target dirs, it would try to choose the dir that match the configuration on args.gn Original change's description: >Automatically pick a target directory which exists for run_web_tests.py script > > This also updates how we compute the default for 'configuration'. First, we try to look for the > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the > value of configuration using the target value. > > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. > > > Bug: 893618 > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 > Reviewed-on: https://chromium-review.googlesource.com/c/1281043 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#600760} Bug: 893618 Change-Id: I386b8261fc4abddd51a5b4f290c5eb3ac6ce5361 Reviewed-on: https://chromium-review.googlesource.com/c/1289308 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Joe Downing authored
This reverts commit 66a392fa. Reason for revert: Causing component_unittest failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/23527 failing tests: SyncableServiceBasedBridgeTest.ShouldDecryptPreviousDirectoryDataAfterRestart SyncableServiceBasedBridgeTest.ShouldDecryptInitialRemoteData SyncableServiceBasedBridgeTest.ShouldDecryptForRemoteDeletion Original change's description: > Add encryption support to pseudo-USS > > This patch extends SyncableServiceBasedBridge (core to pseudo-USS) > with support for encryption, via a newly introduced interface > (ModelCryptographer), which needs to be usable in the model thread > (where the bridge lives). > > This should unblock the migration of PASSWORDS to pseudo-USS, because > password data must be encrypted at all times. This is a first step of > a proposal described in a dedicated section in the Design Doc: > https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot > > Actual usage of this functionality will be introduced in follow-up > patches. > > Bug: 870624 > Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1288594 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601254} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: Iab6463f9541ca242facdc8c5217f1cf4c114ba49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870624 Reviewed-on: https://chromium-review.googlesource.com/c/1292512Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601270}
-
Dianna Hu authored
The motivation is to prepare HpackVarintDecoder to conditionally support 62 bit integers as required by the QPACK specs. This will of course have to be flag protected. HpackVarintDecoder::MaxExtensionBytes() and MaxOffset() would need to return different values depending on the value of the flag. It's a lot easier to get rid of them instead. In HpackVarintDecoder::Resume(), use a locally defined const instead of MaxOffset(). In MarkDone() et al., use numeric_limits::max() instead of |MaxOffset() + 7|. This value is so large that it does not matter if HpackVarintDecoder is in up-to-28-bit-mode or up-to-62-bit-mode. Avoid using a method to cut down on clutter in release builds. In HpackVarintDecoderTest.ValueTooLarge, hardcode the large value. It does not hurt to reduce logic in tests anyway. This CL lands server change 214703557 by bnc. BUG=488484 Change-Id: Ie12bfda99b478549bcc5b126be54e51804c0d85c Reviewed-on: https://chromium-review.googlesource.com/c/1291592 Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601269}
-
Kenneth Russell authored
This reverts commit a337f08f. Reason for revert: this CL only re-enables the test on Windows; the failure seen was on macOS, which is a different platform and had a preexisting flaky expectation for this test. Investigation will continue on the bug into the flakiness on that platform. Original change's description: > Revert "Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash" > > This reverts commit 8bd7e583. > > Reason for revert: Still flaky :( https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/166516 > > Original change's description: > > Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash > > > > This was flaky, but should be fixed. > > > > Bug: 878258 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0 > > Reviewed-on: https://chromium-review.googlesource.com/c/1285526 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600813} > > TBR=kbr@chromium.org,enne@chromium.org > > Change-Id: I0dd172bd7db86982f9b1bf49e2a57c059958d348 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 878258 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1290950 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601098} TBR=kbr@chromium.org,enne@chromium.org,dullweber@chromium.org Change-Id: If1ca9d7ae9ef2122150edfa9d965e0a9cd5c442a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1292431Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601268}
-
Yue Cen authored
Bug: 885219 Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b Reviewed-on: https://chromium-review.googlesource.com/c/1290196Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601267}
-
Joe Downing authored
TBR=dtseng@chromium.org BUG=897249 Change-Id: I53918bf9b8c88f9ed2b5772c3e8258a70689fb2b Reviewed-on: https://chromium-review.googlesource.com/c/1292270Reviewed-by:
-
Dave Tapuska authored
Use appropriate types in scheduler code. BUG=879657 Change-Id: I51e83b9fd5e6ec48706110bc4ae832d2075e89ca Reviewed-on: https://chromium-review.googlesource.com/c/1287956 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601265}
-
Yuchen Liu authored
This is not supported by the SDK. Change-Id: I23a9affcdd4b69280b3b9dec978179eca54b790e Reviewed-on: https://chromium-review.googlesource.com/c/1289683Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601264}
-
Dianna Hu authored
These tests use HpackVarintEncoder to generate test data, hence they are in fact round trip tests. This CL lands server change 214689001 by bnc. BUG=488484 Change-Id: I27eb50471a83d44cfc21d7fa42fde1c1a7ef25c4 Reviewed-on: https://chromium-review.googlesource.com/c/1291809Reviewed-by:
-
Ben Pastene authored
Most of this should be unnecessary now that the GN rules for the tests list the pylibs as data. See https://chromium-review.googlesource.com/c/chromium/src/+/1291711/2 for an example CQ run of a change that touched //build/android/ w/ this patch applied. It ran all the tests on the android bots, but was mostly a no-op for the other bots. R=jbudorick, dpranke Change-Id: I25ba6260652508994144eb3d8e4bd7304a863e88 Reviewed-on: https://chromium-review.googlesource.com/c/1291782Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601262}
-
Jamie Madill authored
The decoder microbenchmarks suffer from fairly high variance. This should decrease the variance while not changing the absolute total. Also add a mode for a fast test run on the bots with DCHECK enabled. The test time on the perf bots should still be within one minute. Bug: angleproject:2763 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idf5fb0f4cb32205c8c640415b5e6ff22efa5b7b1 Reviewed-on: https://chromium-review.googlesource.com/c/1286753 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601261}
-
Nate Chapin authored
In the vein of WorkerTaskQueue, this provides an API for farming work out to a pool of background threads. However, it is built on top of the Worklet API, and also supposes addModule() to load and register tasks. Classes with a process() function can be created and registered via the global scope's registerTask() function. taskWorklet.postTask() can take a |name| string (rather than a function), look up whether a task was registered with that name, and call the appropriate process(). Bug: 879306 Change-Id: I7f7c23c3482be3641fde6b78d11f3152c437a460 Reviewed-on: https://chromium-review.googlesource.com/c/1278961 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601260}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf5c51bcd364..42bb3604bce4 git log cf5c51bcd364..42bb3604bce4 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 mtklein@google.com Revert "re-enable effect deserialization for flutter" 2018-10-19 mtklein@google.com override getTypeName() instead of using table 2018-10-19 brianosman@google.com Un-plumb dstColorSpace through GrTextureProducer 2018-10-19 egdaniel@google.com Reland "Revert "Use OpenGL sampler objects when available."" 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a9999ce938be..9e4d040cb93c (1 commits) 2018-10-19 brianosman@google.com Remove unused dstColorSpace from getROPixels 2018-10-19 michaelludwig@google.com Consolidate aa resolution for per-edge aa quads 2018-10-19 halcanary@google.com SkTArray: behave a little more like std::vector 2018-10-19 brianosman@google.com When checking color type in image shaders, trust SkBitmapProvider, not image 2018-10-19 halcanary@google.com SkBitSet: cleanup. Remove unused fn, more general exporter. 2018-10-19 michaelludwig@google.com Add quad type and persp/aa utilities to GrQuad 2018-10-19 mtklein@google.com clean up flattenable macro cruft 2018-10-19 brianosman@google.com Remove unused SkBitmapProvider functions 2018-10-19 brianosman@google.com Remove unused SkBitmapCacheDesc factory 2018-10-19 egdaniel@google.com Add ability for an SkDevice to handle the drawing of an SkDrawable. 2018-10-19 egdaniel@google.com Revert "ccpr: Unregister path listeners when their cache entries are evicted" 2018-10-19 bsalomon@google.com Revert "Revert "Use OpenGL sampler objects when available."" 2018-10-19 kjlubick@google.com [canvaskit] Disable effect_deserialization Created with: gclient setdep -r src/third_party/skia@42bb3604bce4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I0a44a1c4c93d163f25c8f32c7283eadc1f2ad6bd Reviewed-on: https://chromium-review.googlesource.com/c/1291911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601259}
-
Cathy Li authored
This fixes issues on smaller screens or "Large" displays where the 4th column is cut off Bug: 896492 Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b Reviewed-on: https://chromium-review.googlesource.com/c/1287253 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601258}
-
Mikel Astiz authored
ModelTypeWorker et al need to be updated to support PASSWORDS, which is the only datatype with a custom encryption mechanism (always encrypted). This involves implementing logic analogous to the directory counterpart, which uses passwords-specific proto fields and other requirements like clearing out certain fields if custom passphrase is set. The introduced code changes are not exercised in production yet because there's no USS (or pseudo-USS) implementation for PASSWORDS. Bug: 856941,870624 Change-Id: Iae7c9a9a76f87dbd2406ed8e56589dc629f07c6a Reviewed-on: https://chromium-review.googlesource.com/c/1288537 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601257}
-
Sahel Sharify authored
This cl enables BrowserSideFlingBrowserTest.TouchpadFlingBubblesFromOOPIF to see if it still flakes or not. I expect the test to be stable after the changes that landed in https://chromium-review.googlesource.com/c/chromium/src/+/1289515 TBR=creis@chromium.org Bug: 894703 Change-Id: I17164061e0d41886eb73537936cac94e61a91011 Reviewed-on: https://chromium-review.googlesource.com/c/1291811Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601256}
-
Roberto Carrillo authored
This is to validate that the merge logic is correct before adding larger targets. TBR=liaoyuke,stgao,jbudorick Change-Id: Ia7c53c8f1f9731b143aafff6aedccc1ac6cf5413 Reviewed-on: https://chromium-review.googlesource.com/c/1291991Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601255}
-
Mikel Astiz authored
This patch extends SyncableServiceBasedBridge (core to pseudo-USS) with support for encryption, via a newly introduced interface (ModelCryptographer), which needs to be usable in the model thread (where the bridge lives). This should unblock the migration of PASSWORDS to pseudo-USS, because password data must be encrypted at all times. This is a first step of a proposal described in a dedicated section in the Design Doc: https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot Actual usage of this functionality will be introduced in follow-up patches. Bug: 870624 Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 Reviewed-on: https://chromium-review.googlesource.com/c/1288594 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Steven Bennetts authored
The CL: * Introduces keyboard.mojom.KeyboardEnableState, an enum used to track the various states that control whether the virtual keyboard should be enabled. Some states enable the keyboard, others disable it. * Moves ownership of the states and the state machine to determine when the keyboard should be enabled to KeyboardController. * Adds mojo interfaces to set and clear states, get the current enabled state, and explicitly reload the keyboard. Note: All mojo API calls to change an enable state will also enable or disable the keyboard accordingly. This is consistent with existing logic where these calls are made so should not change any behavior. Note: Not all calls to keyboard_util.cc helpers have been replaced, including a few in src/chrome, only places where no additional re-factoring is required were changed. Bug: 843332 Change-Id: Ic1741188e2e1ccafda4ad95a71063462ac7f52ff From original CL: TBR=tsepez@chromium.org,shend@chromium.org Change-Id: Ic1741188e2e1ccafda4ad95a71063462ac7f52ff Reviewed-on: https://chromium-review.googlesource.com/c/1291350Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601253}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9ead811969b6..cdebbeb8cca2 git log 9ead811969b6..cdebbeb8cca2 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thestig@chromium.org Roll v8/ c623fabe5..604c50c84 (9 commits) Created with: gclient setdep -r src/third_party/pdfium@cdebbeb8cca2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I28cd2b9b4aab3c5db4f3da8c7dba5d33ba7bb805 Reviewed-on: https://chromium-review.googlesource.com/c/1291910Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab631ca2c962..0f44307feaae Created with: gclient setdep -r src-internal@0f44307feaae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If8e5e068f2904c12f52b6f2436ccdc77fc9ccc6a Reviewed-on: https://chromium-review.googlesource.com/c/1291753Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601251}
-
Ben Pastene authored
Bug: 896410 Change-Id: I1b2825dfe67c7895b1152c854303d79b9d4a20fb Reviewed-on: https://chromium-review.googlesource.com/c/1292049Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601250}
-
Jialiu Lin authored
Clean up my TODOs. Most of them are no longer needed. Change-Id: I1b9f84ebb40da23ec39c711f9ffef3428319b414 Reviewed-on: https://chromium-review.googlesource.com/c/1289777Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601249}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/429fb7c2bca7..0537b6aba1bd git log 429fb7c2bca7..0537b6aba1bd --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dproy@google.com Merge "Make chrome trace overview timeline very fast" 2018-10-19 dproy@google.com Merge "Add process grouping for chrome traces" Created with: gclient setdep -r src/third_party/perfetto@0537b6aba1bd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I482e0cd133ca550c00d9b7b64f7c556734f9d7de Reviewed-on: https://chromium-review.googlesource.com/c/1291755Reviewed-by:
-
Navid Zolghadr authored
We added a sampling scheme when ukm was introduced back in the day to control the amount of data we report to the server. Now that there is a general mechanism for controling the data we can remove our own version of resampling and rely only on the dashboard team to take care of that. Bug: 895463 Change-Id: If23332437205aa027b77a1140f28b9492692791a Reviewed-on: https://chromium-review.googlesource.com/c/1283941Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601247}
-
Chris Palmer authored
Make function names the same kinds of phrases (predicates: "IsFoo" and "HasFoo"); consistent use of curly braces to avoid visual confusion; use positive conditions (`DCHECK(success, ...)`). Bug: 879237 Change-Id: I0157f5676bddd7f8a806b5ece9e95792fbbe3ed0 Reviewed-on: https://chromium-review.googlesource.com/c/1289957 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#601246}
-
Leonard Grey authored
Change-Id: I0f1296099e03ea5c7e585bec8a9d8c57850b0d15 Reviewed-on: https://chromium-review.googlesource.com/c/1291233Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#601245}
-
Greg Kerr authored
The nacl loader process, used only on macOS, currently tries to load an invalid profile type under the V2 sandbox. This loads the correct type. This also adds necessary IOKit resource access to the nacl sandbox profile. Bug: 892554 Change-Id: I3118c00a17502efdd88545ef35e81e3a480d2f15 Reviewed-on: https://chromium-review.googlesource.com/c/1289070Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601244}
-
Xianzhu Wang authored
This is a reland of dcf5246f The fix is to ensure the logger has proper log level. Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} Bug: 896799 Change-Id: I7145e2aebf122c6fecf0732d56a81a808cffbe4d Reviewed-on: https://chromium-review.googlesource.com/c/1291358Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b4d999866772..a31f315c7410 git log b4d999866772..a31f315c7410 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dgarrett@google.com chromeos_config: Migrate master-paladin to swarming. Created with: gclient setdep -r src/third_party/chromite@a31f315c7410 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6d90a6f1db9520ba2d16a0ecd8fb1de6c41921b1 Reviewed-on: https://chromium-review.googlesource.com/c/1291750Reviewed-by:
-
Robert Liao authored
This provides more API coverage to the MaterialDesignController. BUG= TBR=sky@chromium.org base/test MaterialDesignController test changes. Change-Id: I3898ceb03e3aa7a4096d22aa059720b3ae368858 Reviewed-on: https://chromium-review.googlesource.com/c/1289991Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#601241}
-
Xiaocheng Hu authored
This patch refactors the function to reduce code duplicacy by reusing NGCaretPosition::ToPositionInDOMTreeWithAffinity(). The refactoring also helps implementation of bidi caret affinity. Bug: 894651 Change-Id: I114b65cfbf85966c3daf959da93e0a48a4fe170f Reviewed-on: https://chromium-review.googlesource.com/c/1291780 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#601240}
-
Scott Violet authored
on linux/chromeos with asan tests. This test occasionally triggers leaks, which leads to noise. BUG=897209 TEST=test only change TBR=hbos@chromium.org Change-Id: I62aa05f5213e85edcc4dfab138b0ec316eaf06d4 Reviewed-on: https://chromium-review.googlesource.com/c/1291990Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601239}
-
Ehsan Karamad authored
The static map from process ID to filter (introduced in CL 1240635) is created on UI thread where the (first) ExtensionsGuestViewMessageFilter is added and the subsequent insertions into the map is also done on UI thread. Due to some dependencies on GuestViewMessageFilter, ExtensionGuestViewMessageFilter is destroyed on the IO thread. This opens up a way to thread race bugs between IO and UI thread when inserting and deleting entries; possibly one instance of such bugs is a recent crash spiked after this CL. This CL fixes the issue by 1- Only setting the value of the map to nullptr when the filter is destroyed 2- Post task to UI thread to remove the actual key (with null nullptr) from the static map. Bug: 896791 Change-Id: I7b707f638fb37c8038ce78ca435f92ca3d2263bc Reviewed-on: https://chromium-review.googlesource.com/c/1291213Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601238}
-
