- 17 Oct, 2019 40 commits
-
-
Arthur Hemery authored
Geolocation support with BackForwardCache is now controlled by a chrome flag variation, similar to what exists with ServiceWorker support. Bug: 1015377 Change-Id: I4cc1fc5adef0a6bbb2281eb674276723eadf50b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864801Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706998}
-
Jack Lynch authored
Expandable container widgets with toolbar buttons, such as the Global listeners pane [1], are being read out incorrectly by screen readers. For example, the Global listeners header is read by NVDA as > Refresh global listeners Global Listeners link expanded when it should really just be "Global Listeners link expanded." This CL sets an aria-label on each ExpandableContainerWidget so that child buttons are not read out. [1] https://gyazo.com/3f9d3131f050c924eab597618ee50230 Bug: 963183 Change-Id: I11aab756c787406c7ce786a009f78caa7da12e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864567Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706997}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c06aef2ad1b3..c71d85bc4e71 git log c06aef2ad1b3..c71d85bc4e71 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 danilchap@webrtc.org Pass full RtpPacket to RtpVideoStreamReceiver::OnReceivedPayload 2019-10-17 shyamsadhwani@fb.com Width and Height was not associated and provided to decoder for H264 streams which have Nalus before SPS Created with: gclient setdep -r src/third_party/webrtc@c71d85bc4e71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5f44ccb81448e16e02786772828ad3808366ca77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706996}
-
Charlene Yan authored
Translation screenshots followed from these instructions: https://g.co/chrome/translation This needs lots of polishing most notably: - animations on each action - polish hover highlight Bug: 989174 Change-Id: I88658fc0587c1d4fa951c21a7166e1ff1443d884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856727 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#706995}
-
Yves Arrouye authored
This is a more accurate representation of who the user is than just the non-domain part of the email. Bug: chromium:1859676 Test: manual Change-Id: I7c63294a925c47184baa28b03be24af975700460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865600 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706994}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b925bcdd2c1..930722709254 Created with: gclient setdep -r src-internal@930722709254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I0949be0d9d4046a7c26b075e2e9014521c39c229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866618Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706993}
-
yilkal authored
The Back button should not be displayed when the error page is being shown in an iframe. Bug: 850328 Change-Id: Iaf7ea83abd1d1a84449a1489b296129311429333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832705Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706992}
-
Sasha McIntosh authored
Fix some comments about UYVY format in tests and remove remaining references to this format. Bug: 988538 Change-Id: Ib14051e146c49df7b654b6192b7d4a28935dc922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825080Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706991}
-
evliu authored
Bug: 724598 Change-Id: If27937335d5761a227e62218fe47cdf30bf20c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863357 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#706990}
-
Will Harris authored
Both of these experiments have been turned down, so save some space in the UMA log. BUG=726150,82385 Change-Id: I8d60e091df03f1e252d66ae38237c0bc43926b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860395Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706989}
-
Robert Flack authored
LayoutEmbeddedContent is constructed for HTMLPluginElement, HTMLFrameElement, HTMLPortalElement and HTMLIFrameElement. All of these are of type HTMLFrameOwnerElement so the dynamic casts and type checks are unnecessary. Unfortunately, since the LayoutEmbeddedContent object can outlive the HTMLFrameOwnerElement, null checks are still necessary. Bug: None Change-Id: I33d3fc5654d73f92f10d302429dc3713592455a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866016Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706988}
-
Philip Rogers authored
Change-Id: Ibb032646b53070c1d1d03dc853bfaf100c4d6371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860691 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706987}
-
John Budorick authored
This reverts commit a84f1c65. Reason for revert: wrong revert Original change's description: > Revert "[Trusted Types] Remove TrustedURL." > > This reverts commit 005483fe. > > Reason for revert: <INSERT REASONING HERE> > ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found > #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" > > Original change's description: > > [Trusted Types] Remove TrustedURL. > > > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > > to the spec. > > > > Bug: 1002555 > > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706886} > > TBR=vogelheim@chromium.org,mkwst@chromium.org > > Change-Id: I9012ad7c3f9f01389ab1aa7a90d5beb7873eab2c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1002555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866974 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706979} TBR=vogelheim@chromium.org,lanwei@chromium.org,mkwst@chromium.org Change-Id: Idfd715701037a3b3dfabe2adbb8f74b2e98625a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865686Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706986}
-
Brian Sheedy authored
This reverts commit 8e751655. Reason for revert: There are apparently more conversions required in third_party/webrtc Original change's description: > Switch WebRTC browser perf tests to histograms > > Switches uses of PrintResult in the WebRTC browser perf tests to > PerfResultReporter and whitelists browser_tests for conversion to > histograms before uploading to the perf dashboard. > > Bug: 923564 > Change-Id: I7ff090bcdeaf3906491b85993456f07313cd4a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856825 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706699} TBR=miu@chromium.org,phoglund@chromium.org,bsheedy@chromium.org Change-Id: I80e804f4b38699adaa6cce33b48a57769a2a6db5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866627Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706985}
-
John Abd-El-Malek authored
They've been running on Android Mojo FYI bot with no flakiness. Change-Id: Ic6c7b1bbc20c2d54c7a023a371e586a1e9047215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864358 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706984}
-
Chandani Shrestha authored
Screen-reader accessibility: Each palette is assigned a role button so, when user navigates to each palette it reads e.g. 'Color #3F51B5 button' This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 which has been broken down 1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344 2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875 3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873 4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Gif showing keyboard navigation which has been split out from this change https://imgur.com/m3iVkOj Bug: 963183 Change-Id: I244edc0cabf5aa5d6df51d3cf31efa00f64a666c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816875 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706983}
-
Haiyang Pan authored
Bug: 1001643 Change-Id: I46058d98b3f83810033c8074f2f9ad9965b2be71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861105Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#706982}
-
Gyuyoung Kim authored
This CL applies new Mojo types to VideoCaptureService interface. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote. Bug: 955171 Change-Id: I7a3f1663168d2bd954d17e8ce5cfddd56028b5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862920Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#706981}
-
Lan Wei authored
This reverts commit 8e1e2bb6. Reason for revert: <INSERT REASONING HERE> ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Highlight text fragment directives on page reload > > Fix the behavior where fragment anchors were only kept alive if a scroll > was needed, as is the behavior of element fragment anchors. This caused > text fragment anchors not to be kept alive and we didn't highlight on > reload. > > Note that *sometimes* we would highlight on reload, due to a race > condition with fragment anchors, where we process the fragment before > restoring scroll position (which is where should_scroll becomes false), > see crbug/839292. This change makes it so we highlight on reload > independent of whether a scroll is needed. > > Bug: 932551 > Change-Id: I38cc82c4920255d8bcae9f8b55ac80f24d1465da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864714 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706847} TBR=bokan@chromium.org,nburris@chromium.org Change-Id: Ifa4ea6a04c62662a1ec0a7b611247ed16d9d979b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 932551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866623Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706980}
-
Lan Wei authored
This reverts commit 005483fe. Reason for revert: <INSERT REASONING HERE> ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" Original change's description: > [Trusted Types] Remove TrustedURL. > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > to the spec. > > Bug: 1002555 > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706886} TBR=vogelheim@chromium.org,mkwst@chromium.org Change-Id: I9012ad7c3f9f01389ab1aa7a90d5beb7873eab2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866974Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706979}
-
Clark DuVall authored
Loading pak files was not quite working right in weblayer, since we were not loading locale paks. This caused text on e.g. submit buttons to not show up in some configurations like loading from monochrome. This change makes weblayer load pak assets similar to webview, and uses the webview pak deps for the weblayer support APK, since those should be sufficient for weblayer. As an added bonus this also allows l10n to work, so switching the default language of the device will show buttons and labels in that language. Change-Id: I1a2b47009e7bb74f1ea3c16dc6f52451e2b78066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865015Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706978}
-
Chandani Shrestha authored
Close button in color picker appears when user presses button rightmost arrow button to launch palette panel. This change updates focus from palette panel to close button. This is because earlier user had to press extra tab to reach to control. This change handles close button on ENTER, SPACEBAR and ESC key events. ESC key is for user to escape from the palette panel and return back to earlier state. Earlier, pressing ENTER would close the color picker this change handles it by consuming the event. Gif showing the change https://imgur.com/vt2saeT This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down 1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344 2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875 3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873 4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Bug: 963183 Change-Id: I573e74a0e6adb5130f524f34016760233e14f5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706977}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactory from //chrome and //extensions to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: I0379f56d1069252e482f3fd3d15d3ec2087344a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859971 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706976}
-
Raphael Kubo da Costa authored
This implements https://github.com/w3c/wake-lock/pull/242. WakeLockEvent just duplicates functionality that is available in Event itself, so just emit Events instead. ev.lock can be accessed via ev.target, which comes from Event itself. Bug: 1015320 Change-Id: Iadb4d48629520605bdb4332bb02a62d022fab16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865347 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#706975}
-
Daniel Cheng authored
This appears to be unused, undefined, and obsolete. Change-Id: If5e431f77db6c0392662ff76cee2adcd856c07ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865809Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706974}
-
Daniel Libby authored
First in a series of changes to get rid of the DisableCompositingQueryAsserts in PaintLayerPainter::Paint. kPaintLayerUncachedClipRects is only used to determine whether a paint layer should create a subsequence (for potential benefits of caching/ reusing the subsequence). However, it is currently only set if kGlobalPaintFlattenCompositingLayers is set (either manually in data_transfer.cc or via the code in PaintLayerPainter::Paint). If that global flag is set ShouldCreateSubsequence always returns false, so the kPaintLayerUncachedClipRects flag is unnecessary. Removing this code gets rid of 1 out of 3 compositing queries in this codepath. Bug: 1007989 Change-Id: I59cddc51a65c9acd8e134845d7c9c4b6320fc4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864414Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706973}
-
Daniel Libby authored
From the comment and linked bug history, this was introduced so that scroll code could identify main thread scrolling reasons. These have since moved to the scroll property tree, and no further compositing queries exist on this codepath (or at least are not hit by tests - this one is a pretty high-level disablement). Bug: 1007989, 625676 Change-Id: I86ee8d1ab864fe6334ba4c7c7aa35e07cdc937cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865424 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706972}
-
Joe DeBlasio authored
Change-Id: Ib0eb67560ac8b5d070ad85d8d5d4e6b2faf90d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866875 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706971}
-
Takumi Fujimoto authored
Enable the feature flag for the native DIAL MediaRouteProvider by default. Bug: 956621 Change-Id: Ied8686c0accfe46397b97890c9778f5876276484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864013Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#706970}
-
Lan Wei authored
This reverts commit 2000b5b1. Reason for revert: <INSERT REASONING HERE> inspector-protocol/accessibility/accessibility-getFullAXTree-display-locked.js is keeping failing on WebKit Linux MSAN. Original change's description: > DL: Fix flaky getFullAXTree & wrongly updated accessibility tests > > A devtoools display locking a11y test was marked as failing in MSAN bots > and is also flaky when tested locally, this CL updates that test and > fixes the cause of the failure (getFullAXTree might be called when > style/layout is dirty, which caused failing DCHECKs). > > Some other display locking a11y tests were not updated correctly, and is > updated in this CL as well. > > Bug: 996625 > Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706834} TBR=vmpstr@chromium.org,aboxhall@chromium.org,rakina@chromium.org Change-Id: I11a6bbc935ec0b88d9f72af37cc729cc28257766 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866620Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706969}
-
Robert Ogden authored
Adds a new method, GetLastVisitToOrigin, to the history stack which gets the last visit to any page on an origin within a time range. This call is successful if there were no previous visits to that origin but reports a null base::Time. Bug: 995437 Change-Id: I56b421161c85076f5b81c61fcf1e31ef08abfe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860733 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706968}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/989bc351863d..b594247e39a4 git log 989bc351863d..b594247e39a4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org Reland "depot_tools: Run recipe scripts using vpython." Created with: gclient setdep -r src/third_party/depot_tools@b594247e39a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I2e064ac8c7e012aa945ede3840763abe37c133a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706967}
-
Denis Kuznetsov authored
Previously OOBE UI Dialog size was controlled from JS code. This CL changes implementation so that dialog size is set according to UI specifications in C++ code, and web-based ui should just fully fit into given dialog. Note that code in ash/wm/lock_layout_manager / lock_window_state propagates bounds changes only to full-screen children, so OobeUIDialogDelegate will create full-screen Widget that will host WebUI dialog, receive all bound-changed events and update hosted dialog size according to specs. Bug: 1007294, 1007861 Change-Id: Ib81ec7f886cd406df98838de5af8401083de0b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841953Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#706966}
-
Mitsuru Oshima authored
1) getAppWindowInfo to retrieve the list of application windows with ids. 2) setAppWindowState to set the window state using the id. 3) closeAppWindow to close the window. Bug: 1010671 Test: Covered by unit test except for close. It'll be covered in next CL. Change-Id: Iaa71764a58663713ac5d745b550bfa7b46bb383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857603 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706965}
-
chrome://device-emulatordpapad authored
This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: Id8533d89043f288fee6aaa45fcbde5ef48bda51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865266Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706964}
-
Owen Min authored
Change MachineLevelUserCloudPolicyController to ChromeBrowserCloudManagementController Change MachineLevelUserCloudPolicyEnrollmentMetrics to ChromeBrowserCloudManagementEnrollmentMetrics IsMachineLevelUserCloudPolicyEnabled rename will be in the next CL. Bug: 1010704 Change-Id: I4e28f1e690237e7d310be42341d3b5f0ba47135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865674 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706963}
-
Denis Kuznetsov authored
Bug: 1000606 Change-Id: I35cb734412924fa0a315063c5ca80556f6bb40fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863094 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706962}
-
Maksim Sisov authored
By accident, we didn't pass the icon further to the XWindow from the PlatformWindowProperties. This CL fixes that. Based on the patch provided by mail@maciej.szmigiero.name. Bug: 1007996 Change-Id: I3718f5f1698438ed07c5f453cdb445cd50a48219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#706961}
-
Sebastien Marchand authored
Also rename some of the existing params while I'm here to make them more explicit. Bug: 1014976 Change-Id: I6fade2127172343f22084b762a500309a418920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#706960}
-
Daniel Vogelheim authored
The current Trusted Types spec no longer supports TrustedURL. This CL adapts to the spec. Reland after revert (crrev.com/c/1866406) Bug: 1002555 Change-Id: Ia683ad3ff4e7390ba59bf7313fd605c976cea3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#706886} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864798 Cr-Commit-Position: refs/heads/master@{#706959}
-