- 31 Oct, 2018 40 commits
-
-
Eric Seckler authored
Fixes the flakiness of buffer usage / known categories tests by resolving an accidental race condition. Also restricts disabling the other two tests to <= kitkat devices since those seem to be the only ones that show (inexplicable) flakiness. TBR=yfriedman@chromium.org Bug: 899894 Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4 Reviewed-on: https://chromium-review.googlesource.com/c/1307433Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#604209}
-
Eliot Courtney authored
It seems that WindowState::UpdatePipState was overwriting window visibility animation types set by other code. Modify it to be called earlier and only to update the window visibility animation type on transitions from and to PIP. as well (properly uses FADE type animation) Bug: 899432 Test: Animation to overview mode no longer has black backdrop animating Test: Dismiss animation for PIP still works on closing the PIP window. Change-Id: I9a575fbc55273cb4be7e26482f6f749e6d3ce15c Reviewed-on: https://chromium-review.googlesource.com/c/1306971Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#604208}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d8f48db9ef5..af730f2b44f6 git log 4d8f48db9ef5..af730f2b44f6 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 70942e2e8566..e36ca90f33e9 (1 commits) Created with: gclient setdep -r src/third_party/skia@af730f2b44f6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I0bb6b3ac4b255878b61ae0532b615df2ec355e96 Reviewed-on: https://chromium-review.googlesource.com/c/1309540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604207}
-
Mitsuru Oshima authored
* Pause occusion tracker during overview animation * Activate the text filter after animation * Don't animate backdrop window during overview animation. * Fix the bounds change issue in WindowGrid. It shouldn't change the parent window's bounds. in both clamshell and tabletmode. The web contents should load after animations without backdrop animation. No gap at the bottom of the screen after exiting overview mode. Bug: 898077, 897387 Test: no functional change. Manually tested visual change by entering/exiting overview mode Change-Id: I60c2709c5394a565bae6d0c4bfdd7006e2e76496 Reviewed-on: https://chromium-review.googlesource.com/c/1304973 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604206}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f577ab3d38f9..8b7d206d37ba git log f577ab3d38f9..8b7d206d37ba --date=short --no-merges --format='%ad %ae %s' 2018-10-31 peah@webrtc.org AEC3: Decrease latency until the delay has been detected Created with: gclient setdep -r src/third_party/webrtc@8b7d206d37ba The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:896334 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4959a12dc3a5557463627b200eac455332ce4249 Reviewed-on: https://chromium-review.googlesource.com/c/1309539Reviewed-by:
-
Tatsuhisa Yamaguchi authored
This is a follow-up of crrev.com/c/1306969. After that change it showed the tooltip for power status even when hovering on other parts of the tray. Bug: 888072 Change-Id: I26c5786a8ff19347f2eb58dd1430e2d5ea66d066 Reviewed-on: https://chromium-review.googlesource.com/c/1308961Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604204}
-
Sunny authored
When calling |RegisterNonPersistentNotificationListener| with an existed notification id, it will first dispatch a close event to old notification and set new listener into listener map. Currently the new listener is replaced immediately after calling |DispatchNonPersistentCloseEvent|, since it's an asynchronize call, it will remove the replaced listener unexpectedly, instead of removing the original listener. To fix this, we can postpone listener replacement after the close event finish it's cleaning job. For new created notification, the listener can be set immediately due to there is no close event need to be dispatched. Bug: 880266, 898486 Change-Id: I370d77386cf1a6636f368f1785d92d362a3b4263 Reviewed-on: https://chromium-review.googlesource.com/c/1303898Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#604203}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/600998aa..0ccf17e9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2065b11573e0f0a2911068dbdf371bdcbdddeb7 Reviewed-on: https://chromium-review.googlesource.com/c/1309308Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604202}
-
Stephen Kyle authored
The static |destructor_calls_| variables used with the HeapTest.Finalization and HeapTest.SimpleFinalization tests were not being reset to 0 on subsequent runs of the test (e.g. when running with --gtest_repeat). BUG=899757 Change-Id: I55419a946431267cf88122aae80ae46fcbe8f467 Reviewed-on: https://chromium-review.googlesource.com/c/1309693Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604201}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9662809abb16..e3f4b1f5ee13 git log 9662809abb16..e3f4b1f5ee13 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 sergiyb@chromium.org Flip the default for ensure_logs_on_timeout Created with: gclient setdep -r src/third_party/catapult@e3f4b1f5ee13 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899721 TBR=sullivan@chromium.org Change-Id: I41e617d6b3bd381fc038390eab703afd1434dc94 Reviewed-on: https://chromium-review.googlesource.com/c/1309538Reviewed-by:
-
Mythri Alle authored
This add layout tests to ensure javascript code caching is working as expected. This also adds virtual tests with ( --enable-features=IsolatedCodeCache --site-per-process) to test that the isolated code cache is behaving as expected. These tests test that: 1. code cache is created on the second visit to the script 2. code cache is consumed on the third visit to the script 3. code cache for the same script resource is not reused if requested from a different origin (for the virtual tests). Bug: chromium:879494 Change-Id: I05f92fa129dac2419c84fcc65e9d0c684b9d48e2 Reviewed-on: https://chromium-review.googlesource.com/c/1297363Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#604199}
-
Nico Weber authored
Apparenly preserving the user x bit isn't enough for remoting's installer. Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1301793 Bug: 900303,875279,870611 Change-Id: Ibbdf71b1d33941b0d6bde5e6cc3c964404a653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1308759Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604198}
-
Ioana Pandele authored
TBR=atotic@chromium.org Bug: 726520 Change-Id: I4711dc131a5c819dc47ef6b1ea4670e3642aa536 Reviewed-on: https://chromium-review.googlesource.com/c/1308939Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#604197}
-
Daniel Bratell authored
This allows third_party/cache_invalidation to be checked with gn check (as soon as it's enabled in //.gn). Bug: 898837 Change-Id: Ica669d8a7277178878d630b54879e1439350f566 Reviewed-on: https://chromium-review.googlesource.com/c/1307496Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99e9e292a1a3..abc8edfb888a Created with: gclient setdep -r src-internal@abc8edfb888a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie16f0d1ed3e5ad686f45c1e090cde32839b00b65 Reviewed-on: https://chromium-review.googlesource.com/c/1309537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604195}
-
Luciano Pacheco authored
This reverts commit b7ecb7e9. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > [Reland attempt #2] Refactor DirectoryTree > > Fix flakiness by adding call to this.expanded=true in EntryListItem. > > Change updateSubDirectories: > - use arrow function and const; > - change error callback calling style to match the same style used by > success callback (without if). > - change check from isFakeEntry to check for presence of the method > that's used "createReader". > > Change the sorting to be an method, so it can be customized per > sub-class, later it will be used to sort My files to show Linux and Play > files at the bottom. > > Fix unittest that started failing because it metadataModel was null. > > No changes in behaviour for users, the small change in behaviour is > EntryListItem.updateSubDirectories now reads its children using FS API > which isn't synchronous. > > CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup > > TBR: joelhockey@chromium.org > Bug: 899664 > Change-Id: I8a93616f74cf3bf2b99851dc2452249e1353d85e > Reviewed-on: https://chromium-review.googlesource.com/c/1306963 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604069} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: Ic7903e70225a59e3eca7d581ea44202462b01dee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899664 Reviewed-on: https://chromium-review.googlesource.com/c/1309570Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604194}
-
Luciano Pacheco authored
This reverts commit 2903236d. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > Change NavigationListModel to support MyFiles as Volume. > > Add MYFILES_VOLUME_ENABLED in private strings to be able to have the > feature flag in the JS/UI code. > > Change VolumeManager to use MyFiles folder for Downloads volume, the > method |GetMyFilesFolderForProfile| takes care of returning the right > value based on the feature flag MyFilesVolume. > > Change NavigationListModel to support MyFiles as Volume when > MyFilesVolume feature flag is enabled: > 1. MyFiles volume is the Downloads volume (after the feature flag is > removed we can rename it accordingly). Setup Downloads volume as > VolumeEntry, > 2. Create a NavigationModelFakeItem with "My files" label, based on the > VolumeEntry (step #1). > 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact > Downloads volume. > 4. Continue to add Linux and Play files to Myfiles. > > Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' > Bug: 873539 > Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 > Reviewed-on: https://chromium-review.googlesource.com/c/1308235 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604143} TBR=joelhockey@chromium.org,lucmult@chromium.org,ioanap@chromium.org Change-Id: I0c5b1fd5f23b2ec2b56ab13ab93a2d3a1ffd277a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873539 Reviewed-on: https://chromium-review.googlesource.com/c/1309569Reviewed-by:
-
Hiroki Nakagawa authored
This is a preparation CL for implementing off-the-main-thread worker top-level classic script loading. <Context of this change> Currently, a top-level worker classic script is loaded on the main thread with a parent document's context. In this case, MIME-type of the script is loosely checked for historical reasons. For example, 'text/html' can be executed as a script. On the other hand, once off-the-main-thread script loading is implemented, a top-level worker classic script is loaded on a worker thread with a worker's context and MIME-type of the script is strictly checked. This breaks bunch of web-platform-tests. To keep the backward compatibility, this CL allows WorkerClassicScriptLoader to specify whether to impose strict MIME-type checks regardless of the execution context type. A subsequent CL will disable it when off-the-main-thread top-level worker classic script loading: https://chromium-review.googlesource.com/c/chromium/src/+/1293432 <Possible cleanup in the future> The flag to disable the strict MIME-type check should actually be determined based on the 'fetch client' of script loading, so a subsequent cleanup CL may move the flag from WorkerClassicScriptLoader to FetchClientSettingsObject. Bug: 794548, 835717 Change-Id: I5cc8828966dd7619b30879f3d287505ad4b22fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1293097 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#604192}
-
yoshiki iguchi authored
This is a follow up of crrev.com/c/1303322. This CL adds a test for it. Bug: 897653 Test: passed the added test Change-Id: I546979f9e88c548201c733b446aa6c2f4ab2a7c9 Reviewed-on: https://chromium-review.googlesource.com/c/1308252 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b00b28ee5067..f577ab3d38f9 git log b00b28ee5067..f577ab3d38f9 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7e85c092..9996ac89 (604065:604166) Created with: gclient setdep -r src/third_party/webrtc@f577ab3d38f9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61583a2d3b39cb47a2caa88fe713d371e22e1f75 Reviewed-on: https://chromium-review.googlesource.com/c/1309536Reviewed-by:
-
Mario Sanchez Prada authored
Bug: 886600 Change-Id: Idd339ae91bffeeceaeee929accde53fedc9f804d Reviewed-on: https://chromium-review.googlesource.com/c/1299162Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#604189}
-
Hajime Hoshi authored
This CL makes binding initialization a little delayed so that |frame_| always exists when the local frame's binding is created. After this CL, more tasks via WebLocalFrameImpl are executed on a per- frame task runner. Bug: 786332 Change-Id: I2f632814acefa7cf1bb2411563405306c469b6fc Reviewed-on: https://chromium-review.googlesource.com/c/1298532Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
We only checked if we needed to update v0 shadow distribution before skipping style recalc for getComputedStyle and friends. Slot re- assignment for shadow dom v1 also needs to be done as it may affect inheritance ancestors for the element in question. This may be the reason for issue 900138, but we have no repro, so hard to say. Bug: 900138 Change-Id: Ie2ceae97141aabed0e26de3070b1f170e9eedeed Reviewed-on: https://chromium-review.googlesource.com/c/1307396Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604187}
-
Rijubrata Bhaumik authored
This is a JavaScript based test which is skipped if focusDistance is not supported. This test is run both on real cameras on some bots and also against the FakeVideoCaptureDevice. BUG=732807 Change-Id: I87be1cbf96aa79adcd539732f421bcfe69f92981 Reviewed-on: https://chromium-review.googlesource.com/c/1306498 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604186}
-
Luum Habtemariam authored
Re-adds the MissingKeyValueDelimiter unittest, accidentally removed in commit 9268d9a1. Bug: chromium:894274 Test: Tests still pass. Change-Id: I37228e812eaf71b1d51fb9982aedea70570311d2 Reviewed-on: https://chromium-review.googlesource.com/c/1306657 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Converts all HeapHashMap allocations from new to MakeGarbageCollected. Allocations using new will be banned from now on. Bug: 757708 Change-Id: Ib37cbfab74fd8209bf7355a36009165d0a7fdc09 Reviewed-on: https://chromium-review.googlesource.com/c/1307535 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9602f22485b..99e9e292a1a3 Created with: gclient setdep -r src-internal@99e9e292a1a3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1622827d0ab303370d6a876dcf588d94c069a183 Reviewed-on: https://chromium-review.googlesource.com/c/1309535Reviewed-by:
-
Mathias Carlen authored
This change introduces an on/off switch which is off by default and is inspired by SavePasswordsPreferences. It is tied to a shared preference, lives entirely in Java and gates instantiation of the UiController. R=gogerald@chromium.org Bug: 806868 Change-Id: I849b6c5568a0cf7bb787dea2e4e73dc8abbf2c75 Reviewed-on: https://chromium-review.googlesource.com/c/1301443 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#604182}
-
Dominic Farolino authored
R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 882344 Change-Id: I42e264f9fc1591129091aa9f18b258a4e2313181 Reviewed-on: https://chromium-review.googlesource.com/c/1249400 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#604181}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69a72945dcdd..4d8f48db9ef5 git log 69a72945dcdd..4d8f48db9ef5 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@4d8f48db9ef5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I63b3695a8e702e3c5f5d6ee9cacf50e03d4cd974 Reviewed-on: https://chromium-review.googlesource.com/c/1309533Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76eeb8565846..fa909263570e git log 76eeb8565846..fa909263570e --date=short --no-merges --format='%ad %ae %s' 2018-10-31 primiano@google.com Merge "probes + trace_processor: Polling of /proc/[pid]/status mem counters" Created with: gclient setdep -r src/third_party/perfetto@fa909263570e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I08dbf894960cd98ecf91f8a3fb681dfc4328fc42 Reviewed-on: https://chromium-review.googlesource.com/c/1309534Reviewed-by:
-
Adam Rice authored
Copying MessageChannel and other functions to the binding object caused a memory regression. As a temporary workaround, only copy them to the binding object when the TransferableStreams feature is enabled. BUG=897046,900141,899637 Change-Id: If312f2e0967a19e9db427f60125d96c48d45fdc7 Reviewed-on: https://chromium-review.googlesource.com/c/1307534Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Rijubrata Bhaumik authored
if |exposure_time| >= 0.0f, then we assume that |exposure_mode| is manual. FakeVideoCaptureDevice is an internal class, so such assumptions are reasonable. Suggested by Miguel at https://chromium-review.googlesource.com/c/chromium/src/+/1243288/6/media/capture/video/fake_video_capture_device.h#107 BUG=823316 Change-Id: I8e112be76854da0f2c4343a8d62a5619e3aa79e4 Reviewed-on: https://chromium-review.googlesource.com/c/1307397 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Bug: 888072 Change-Id: I398053dad885c14483be4a07021f0b601a785b97 Reviewed-on: https://chromium-review.googlesource.com/c/1306946 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Leon Han authored
After https://crrev.com/c/1238079, blink::SWContainerClient becomes a supplement of Document and its only user is blink::SWContainer. This indirection looks redundant, so this CL refactors SWContainer to be also a supplement of Document and makes it take over all code logic of SWContainerClient, then removes SWContainerClient completely. BUG=789857 Change-Id: If2ecede8530c5d3a922f2388853b46b860fbbb2f Reviewed-on: https://chromium-review.googlesource.com/c/1286434 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604175}
-
Jazz Xu authored
This CL modifies the MediaControlSliderElement's segment positioning algorithm to take into account how slider elements handle the thumb element's position (The slider width is slightly larger than the thumb's center's moving range). This fixes an issue where the progress bar wasn't always aligned with the timeline thumb. Bug:839673 Change-Id: I6dd07c27174571945e585ac5654da991d610f89c Reviewed-on: https://chromium-review.googlesource.com/c/1294843 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604174}
-
Tatsuhisa Yamaguchi authored
Bug: 888072 Change-Id: Ifaa3ccecf4d21ae23054523290b2b87b033688f5 Reviewed-on: https://chromium-review.googlesource.com/c/1306969Reviewed-by:
-
Roberto Carrillo authored
...into linux-code-coverage, using the machine allocated to linux-code-coverage-builder previously. This is so that the code coverage report can be generated without needing to transmit the instrumented binaries from the builder to the tester, in addition to uploading it to isolate. R=stgao,liaoyuke Change-Id: I5af90704c78eee81f4bc2c28c9237334966045e1 Reviewed-on: https://chromium-review.googlesource.com/c/1306786Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#604172}
-
Hirokazu Honda authored
This enables VideoFrameValidator in evey TestSimpleDecode test case, that is, the test case except TestDecodeTimeMedia (performance test) and NoCrash. Because an input stream is decoded repeatedly, the index in display order of video frame on PictureReady() needs to be passed to VideoFrameValidator. It seems there is no good way to get the frame index from Picture. So I just count up the index on PictureReady() and reset it to 0 on NotifyResetDone(). This seems a hacky way and only works with the current VDA unittest, which always rewind to the beginning of the stream and does not jump to the middle of the stream. BUG=chromium:856562 TEST=VDA unittest on eve with frame validator $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 --ozone-platform=gbm --test_import --frame_validator Change-Id: I8fbbf165254f4e26c69f8da27b41ff3b9f395224 Reviewed-on: https://chromium-review.googlesource.com/c/1304286 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d54a42bd9174..e9602f22485b Created with: gclient setdep -r src-internal@e9602f22485b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6d2442d98f682a1fbf90922e2cc20f39d3dc4bae Reviewed-on: https://chromium-review.googlesource.com/c/1309332Reviewed-by:
-
