- 10 Mar, 2020 40 commits
-
-
Rushan Suleymanov authored
Bug: 1048771 Change-Id: I9b6a201cb0ab4f7f9477a13c5cad10d27c72b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089676Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#748780}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c598caf81aa3..8cf4a76817cb git log c598caf81aa3..8cf4a76817cb --date=short --first-parent --format='%ad %ae %s' 2020-03-09 dburger@chromium.org Better failure message out of RevWorkOnEBuild. 2020-03-09 saklein@chromium.org cros flash-ap: Fix servo default port example. 2020-03-09 kinaba@google.com chrome_chromeos_lkgm: Skip betty. Created with: gclient setdep -r src/third_party/chromite@8cf4a76817cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie1c2b0ce3dd984261604181c9fdd99baf9cb329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748779}
-
Becca Hughes authored
Add a basic webui at chrome://media-feeds for debugging Media Feeds internals. BUG=1058187 Change-Id: Ia769f103bdd5abfd6ff00754c26117e684d2fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086331 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748778}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1f6408da19a..6c0bae98fece Created with: gclient setdep -r src-internal@6c0bae98fece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1e1a15c11baa13d6bb0f20870d4f227823d9e4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748777}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ifbef91dec1142962f1dcdd34dd2c6e0b2000cd13 Tbr: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092065 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#748776}
-
Brian White authored
Change-Id: I330fcde6b5413bee9f035866518f1bd4734220d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095343 Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#748775}
-
Xianzhu Wang authored
Pixel moving filters [1] can expand bounds of visual effect from the bounds of all descendants. We need reference box for all of them. [1] https://cs.chromium.org/chromium/src/cc/paint/filter_operations.cc?rcl=0b6c41a840ed2a011a989c5d2130b93cc038fc4d&l=82 Change-Id: I1a1fcce6b1db2d876820d263c1456fe6c482ba33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095958Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748774}
-
Omar Morsi authored
ECDSA support in chrome.enterprise.platformKeys support was introduced in this CL:1967468 and this CL mentions its usage in the API documentation. Bug: chromium:1058036 Change-Id: Ie9c57f1fe7024a47d350fd6fda5e5e8a51671118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087618Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#748773}
-
Michael Sun authored
A variable is initialized inside function MediaSessionPositionChanged to temporally store duration/length information or remain 0 if duration is not updated. This blocking the media position from updating as well. Fixing the issue by add a zero check for the duration before compare to the position. BUG=b:147365793 Change-Id: I51d853bf8d618e28ccf75b68cea3c1d02f03b031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095413 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748772}
-
Jamie Walch authored
macOS's extended chmod syntax can be used for either users or groups, and supports "user:<user>" and "group:<group>" to resolve ambiguities. This causes problems if the username is "user", as chmod can't parse the ACL in this case. This CL prepends "user:" to all ACLs to avoid this problem. Change-Id: I15c143b94a2c3113f518ed2b558f007ad769d0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088397 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#748771}
-
Jeff Yoon authored
* ci.star - ios13-beta-sim to run Chromium recipe * mb_config.pyl - GN arguments for ios13-beta-sim * testing/*.pyl, *.json - tests to bind to ios13-beta-sim * Replaced contents of ios-sim-cr-recipe with this as it is no longer needed. All introduced content (mixins, waterfall, test_suites) need a mapping, so I've replaced it as part of clean up as well. * gn_isolate_map.pyl - updating all iOS test targets to generated scripts. Remains backwards compatible to iOS as required files are still there for iOS recipe consumption. * BUILD.gn files - adding shard values for test targets that utilize parallelization via test runner. Bug: 1055164 Change-Id: Id36ffdecd2935cacdf4825c99f26d2f6b561200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085118Reviewed-by:John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#748770}
-
Rouslan Solomakhin authored
Before this patch, the only call site for RespondWithCallbacks::CreateForInvoke() always specified PAYMENT_REQUEST as the event type, which is redundant, because only PAYMENT_REQUEST event can invoke a payment app. This patch removes the event_type parameter from the CreateForInvoke() static method. After this patch, calling into RespondWithCallbacks::CreateForInvoke() does not require to specify an event type. Bug: 1005076 Change-Id: I9eb33b9c08585534c5ec451574ee5563efa3b52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090802 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#748769}
-
Gayane Petrosyan authored
Boilerplate code that adds properties for download button and qrcode bitmap. This CL also hooks up the download button to saveBitmap utility function. Bug: 993920 Change-Id: I1ebc7a6641a7294a1b3d9c63fd8cfdeb83fb7c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071510Reviewed-by:
Travis Skare <skare@google.com> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#748768}
-
Rushan Suleymanov authored
This patch propagates cached sync status from SyngEngineImpl to the SyncService. Also a new method to notify about changing in backed off data types set was introduced. These changes allow to turn off data types if they are in Backed off state. This is done for SharingMessage data type in this patch. Bug: 1058773 Change-Id: I34c9b12e8e9a50f3c8530ad3ff1c6ec6a34492c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093225 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#748767}
-
Ioana Pandele authored
The toggle allowing to re-enable saving should be displayed when the password field is focused, if saving is/was disabled for the the current origin when the page was loaded. The state of the toggle will reflect whether saving is now disabled or enabled (if the user chose to toggle it on). Bug: 1044930 Change-Id: I7c4b51d6f015f3ce8cfe8315259b8334771c7b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056913 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748766}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I7ebcae973f07c07a49e11cff23ee7c3dcc89f4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096388Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748765}
-
Ben Pastene authored
This uses the args file dropped under //build/args/chromeos/ for the amd64-generic bot instead of reading the args from an env var set by simple chrome sdk. Bug: 812428 Change-Id: I705167bddd80ed18ead543f79270d7afaebc386f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088508 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
The math on this line was using integers, which means it could end up dropping fractional parts so that the DCHECK against sizeimage could fail. This fixes that problem. BUG=b:147411004 TEST=Fixes DCHECK on trogdor vea tests Change-Id: Ia4034e790268323a9decdfffe0815b69da8cefbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086193 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#748763}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: Ie656f4ce74ad4dbaee0272ff6297b2d107440400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094247Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748762}
-
Haiyang Pan authored
KitKat CQ builder is short of test resources badly. Removie this test suite from it to improve performance. Bug: 1060245 Change-Id: I9b04d918bfdac894d813ba6f250c6acc9172fde2 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095354 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Robin Lewis authored
Also add this to future requests when it's available. Bug: 1043199 Change-Id: I466bd42d221aaf7f961f702e12306b12cae1de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096108Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#748760}
-
Haiyang Pan authored
They are flakily failed in android-pie-x86-fyi-rel Bug: 1059168 Change-Id: I545f2caf7ffb60f50ee4060bb80feabe3cb9feca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096099Reviewed-by:
-
Marijn Kruisselbrink authored
And remove tests for the old/soon to be removed writing API. Bug: 853326 Change-Id: Ief44f98be8b59844976de26c90df9b4933041188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095564Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748758}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ For these flags, ownership was claimed, but owners said these are already expired and should be removed. I have put M80 as the default for these flags. Though the flag ownership cleanup process will remind folks to remove expired flags, it is better if folks proactively remove the flag. Would the owners please remove the flag, or create a bug to remind themselves to remove the flag? Please lgtm for those flags where you have been named owner. Thanks! Bug: 1058614 Change-Id: I3200ea515df13bf36a6e7a31a043c91c980b2033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093693Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Ben Pastene authored
Betty ran the full set of CrOS tests, while betty-pi-arc only ran a subset of them. This swaps them since Arc has been uprev'ed to P, and N is on its way out. Bug: b/150926708 Change-Id: I6c5f1349d573e7db106a9b116c95dc3585dfebe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091709Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, the exact constructor for RespondWithCallback that payment_app_provider_impl.cc used depended only on the type of the callback object, which made the code harder to understand. This patch replaces the two constructors with two static methods: CreateForInvoke() and CreateForEvent(). After this patch, it is clear which code path is taken when reading the code. Bug: 1005076 Change-Id: Idc762c79077082088b81d8a564b5acc11e47ae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089616 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
This is a reland of c00d0991 I had added a target to "linux_symbols" that was unnecessary. > Enable GL_TEXTURE_2D for IO-Surface-backed textures on SwANGLE > > GL_ANGLE_rectangle_texture is unavailable on Swiftshader's Vulkan > frontend, so SwANGLE on Mac uses 2D textures instead. > > Bug: chromium:1015454 > Change-Id: Id99850fbfae798b33eaff4f3a285deb043b4ae7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056931 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#748322} Bug: chromium:1015454 Change-Id: Id198cfe72268cfa496e23bea190aea1893c6718c Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095348 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748754}
-
Lijin Shen authored
Reland of 76ed93dc Fix failure on TabStripTest suite Reason for revert: breaks org.chromium.chrome.browser.compositor.overlays.strip.TabStripTest suite Original change's description: > Fix chopped text on tab switcher long-press menu when text size is huge > > There exists some unknown issue on the measurement of a text view with > a compound drawable. Using a linear layout containing an imageview and > a textview inside can avoid this issue. > > Bug: 1053448 > Change-Id: Ibdcd220e0eba7218c1d500d870da17d37c7e767c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083729 > Commit-Queue: Lijin Shen <lazzzis@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747078} Bug: 1053448 Change-Id: Ib5c48a3010e7074ca9c92e2826ba407ffd76e9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090833 Commit-Queue: Lijin Shen <lazzzis@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748753}
-
Dave Tapuska authored
In order for the renderer to pass associated mojo channels they need to be on the correct thread. If we pass them on the IO thread they will be associated with the wrong channel. So in order to do this in a later CL we need to move these mojo messages first to the UI thread. When legacy IPC is removed this won't need to be a sync message anymore. CreateNewWindow was initially done like this in https://chromium.googlesource.com/chromium/src/+/95f01e92e7147bee4e66ce629712fd1f50808936%5E%21/#F24 Change-Id: I50a135260106b801db4d32527770b4beda3b5b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095347 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748752}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fae71fb596d0..2e307968fd54 git log fae71fb596d0..2e307968fd54 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 nifong@google.com Clean up Enums in Canvaskit Created with: gclient setdep -r src/third_party/skia@2e307968fd54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I6429cc965132ff8d724929bcb4621d22c14c8beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096543Reviewed-by:
-
Rahul Arakeri authored
This CL adds mouseMoveTo API to stabilize the test on Mac. Bug: 1058244, 1057355 Change-Id: I0be5ce4ffa508319ed58e37ac3e81f9fa5a88a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094816Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748750}
-
Robert Ogden authored
Plumbs DRP prefetch proxy hosts to where they will be used in IsolatedPrerender. Bug: 1042829 Change-Id: Id531927075470b37f79af4d7cf42b0352fe785ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090147Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#748749}
-
Rouslan Solomakhin authored
Before this patch, the salient difference between the two RespondWithCallbacks constructors was not obvious, making development brittle. This patch moves the common code for the two constructors into the common private constructor, which used by the two public constructors. After this patch, the difference between the two constructors for RespondWithCallbacks is more clear. Bug: 1005076 Change-Id: I8b5a80626c4ec2cfffb78439ed44bd159251ef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089615 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Colin Blundell authored
We are in the midst of componentizing ExternalNavigationHandler.java for reuse by WebLayer. The main remaining //chrome-level dependency is on TabRedirectHandler.java. Unlike other dependencies, this dependency can neither be easily componentized (it is essentially //chrome-level functionality) nor can it be easily abstracted through ExternalNavigationDelegate.java. The reason for the latter is that the TabRedirectHandler instance is necessarily accessed through the ExternalNavigationParams instance as it is tied to the navigation in question, and if we were to remove all knowledge of it from ExternalNavigationParams, there would be no straightforward way to plumb it into //chrome's ExternalNavigationDelegateImpl. This CL instead creates a RedirectHandler interface that contains the methods needed by ExternalNavigationHandler. ExternalNavigationParams and ExternalNavigationHandler are changed to talk in terms of this interface, which TabRedirectHandler implements. This approach has the additional benefit that it leaves existing logic coalesced within ExternalNavigationHandler, which will make it easier to adapt this logic in the WebLayer context as needed. For this initial delegate interface, we have preserved the shape of the interface to be the exact current usage by ExternalNavigationHandler.java. Future work can refine the interface to have it be as thin and logical as possible, potentially coalescing some low-level methods into a smaller number of higher-level ones. Bug: 1031465 Change-Id: I5b9568f371c248e8fd2d52429725ed0a44a098a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095719 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#748747}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ddc82494f77..82e00fd235e4 git log 3ddc82494f77..82e00fd235e4 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 lalitm@google.com Merge "tp: fix dynamic table lifetime scoping" Created with: gclient setdep -r src/third_party/perfetto@82e00fd235e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ief1b2e907e7325335575a20c5ce4909d37c778c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096546Reviewed-by:
-
Jesse Schettler authored
Bug: 1059779 Change-Id: Ib345da98f093452a21d575071fdc3872cd52619a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088403Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#748745}
-
Shouqun Liu authored
Bug: none Change-Id: I4d4059891719368e04f1fa4391dbe07fdda4e846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094067Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748744}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I5a3ce15915d122ee6c12d2f5aaf9bc559758c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095200Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Alex Ilin authored
At the end of the remote consent flow, the browser makes the second issueToken request. This request must use a login token of an account that the user has chosen in the consent UI. Gaia returns an id of this account in a consent result. This CL updates IdentityGetAuthTokenFunction to use the id returned in a consent result instead of the one that was originally chosen by Chrome. This CL also moves IdentityTokenCacheValue to use static factory methods instead of multiple constructor overloads. This makes obvious what type of a cache value is created instead of relying on argument types. Bug: 1026237 Change-Id: I59d5eefa7bbca91b59bb3d8cd69deca600580150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095302 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#748742}
-
Ehimare Okoyomon authored
Add strings for four-state radio buttons that will be used in cookie settings. Designs can be found in the bug. Bug: 1060118 Change-Id: I11ca66811510d93b3f00e730fcac639afaa7fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096637 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#748741}
-
