- 14 Dec, 2017 40 commits
-
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/fe9d640ea90c..df4f30eaaa46 $ git log fe9d640ea..df4f30eaa --date=short --no-merges --format='%ad %ae %s' 2017-12-14 dsinclair Add types to the CXFA_Node::Get*{Child|Sibling}* methods 2017-12-14 dsinclair Change CXFA_Node::GetChild to return proper types 2017-12-14 rharrison Reduce XFA image fuzzer size limit to 64MB 2017-12-14 dsinclair Fold CXFA_ScriptData into CXFA_Script 2017-12-14 dsinclair Fold CXFA_SubmitData into CXFA_Submit 2017-12-14 dsinclair Fold CXFA_TextData into CXFA_Text 2017-12-14 dsinclair Fold CXFA_ValueData into CXFA_Value 2017-12-14 dsinclair Fold CXFA_ValidateData into CXFA_Validate Created with: roll-dep src/third_party/pdfiumBUG=794351 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5d6fcd65e6263a4523da381a114de118e0e1b2c3 Reviewed-on: https://chromium-review.googlesource.com/827787 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524211}
-
agrieve authored
This reverts commit f174f4de. Reason for revert: Breaks apk_merger.py (see bug) Original change's description: > Reland "Use Aapt2 for final apk resource packaging" > > This reverts commit db213ff6. > > Reason for reland: Downstream issue fixed. No changes here. > > This CL makes aapt2 perform the final resource processing and packaging for an > apk as well as outputting proguard files. > > TBR=agrieve > > Bug: 782316 > Change-Id: I1b35f49f2e4b4d503cc7ae07dabc18d9014abea5 > Reviewed-on: https://chromium-review.googlesource.com/817377 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523456} TBR=tedchoc@chromium.org,agrieve@chromium.org,ctzsm@chromium.org,mheikal@chromium.org Bug: 782316 Change-Id: Idd57f012b1bc32330c9659e9d63fba5eec27615d Reviewed-on: https://chromium-review.googlesource.com/827900Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#524210}
-
Yuwei Huang authored
If the slide-down top-chrome is available in fullscreen mode then we don't need to show the fullscreen exit UI since the user can use the top-chrome to exit fullscreen. Bug: 758456 Change-Id: I1298279ca97e5fea00629e888e6a56ade23bc67f Reviewed-on: https://chromium-review.googlesource.com/827608Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#524209}
-
Lukasz Anforowicz authored
The move allows returning ContentBrowserClient::GetOriginsRequiringDedicatedProcess from SiteIsolationPolicy::GetIsolatedOrigins. No expected behavior change. This is a "reland" of r521893 (which got reverted in r521907). Bug: 792162 Change-Id: I87cd203a12f1f5784dd9aa2745064a2b96532336 Tbr: alexmos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/827537Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#524208}
-
James Cook authored
Partial revert of commit 8f1e606d, which introduced a crash in ash when opening the keyboard shortcuts viewer from the keyboard settings webui. The code that caused the crash was reverted separately to make it easier to backport. More generally, any mojo interface Foo in ash that has both a persistent client (a SetClient() method) and other methods (a DoBar() method) might end up with multiple bindings: * The persistent binding from FooClient in chrome * A temporary binding from other code in chrome that happens to request the Foo interface and call DoBar I've reverted most of the places I changed, since new code might add calls to DoBar() methods outside of FooClient, and in general I think we should support that use case. (Otherwise we have to route all calls in chrome through FooClient::Get()->DoBar() wrapper methods, which isn't desirable in general.) Bug: 794581 Test: ash_unittests, chrome unit_tests and browser_tests, manually open keyboard shortcut overlay from webui settings > keyboard section Change-Id: I3d974b459f60f7a720d7d345862af8197ddb37df Reviewed-on: https://chromium-review.googlesource.com/825959 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#524207}
-
CrystalFaith authored
Update Hosting Side nav contained updates related to hosting released in 2014. This documentation outlines the updated standard and re-organizes the sidebar. Bug: Change-Id: I0496ca0a4fb2c56fdfda8ba31dbf869851713ed1 Reviewed-on: https://chromium-review.googlesource.com/722062 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524206}
-
Ted Choc authored
BUG=794769 Change-Id: I43530b4b5ec76ab60ede516e8f736e85956270f4 Reviewed-on: https://chromium-review.googlesource.com/826567Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524205}
-
Justin Novosad authored
This change refactors the existing CanvasResource_Skia to make it store a StaticBitmapImage instead of an SkImage intenally. This simplifies the gpu mailbox management code by re-using the functionality provided by StaticBitmapImage. It also bring the code closer to unifying OffscreenCanvasResourceProvider with CanvasResourceProvider BUG=788439,776801 TBR=bajones@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia57a68e1a61763daa158403e258b89b56a82a6f7 Reviewed-on: https://chromium-review.googlesource.com/820251 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#524204}
-
Ryan Sturm authored
pingback will also have this information Bug: 793373 Change-Id: I0c999c35b5e968f6b2e19696a08a722b3399d0d9 Reviewed-on: https://chromium-review.googlesource.com/823176Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524203}
-
danakj authored
This removes its use of the ClientSharedBitmapManager in the renderer process, freeing up one use toward removing it. This also means the Display in the SynchronousLayerTreeFrameSink will not allocate shared memory for RenderPass resources, as the ServerSharedBitmapManager will use normal memory allocations. R=boliu@chromium.org Bug: 730660 Change-Id: Ibb05a8f1787a221351232907704412c5b682e85f Reviewed-on: https://chromium-review.googlesource.com/826182Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#524202}
-
Mohamed Heikal authored
Bug affects java targets with no deps. Change-Id: I3b85d3a1affcdf9996743d9ff6bf304753af992c Reviewed-on: https://chromium-review.googlesource.com/827726Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524201}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e8d8348b857..6e5d5a6a7c91 $ git log 2e8d8348b..6e5d5a6a7 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 jchinlee Kick recipes and add trigger_build file. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Iadf9305c055701831235f15f2d593be22ff82907 Reviewed-on: https://chromium-review.googlesource.com/827533Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524200}
-
Max Moroz authored
Threaded versions of the tools make processing code coverage data and generating code coverage reports an order of magnitude faster. See the experiments data in https://bugs.chromium.org/p/chromium/issues/detail?id=759794#c34. Bug: 759794 Change-Id: Ia5776de8d250d2e4bb23de79dd921e22e78a3095 Reviewed-on: https://chromium-review.googlesource.com/825985Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#524199}
-
Lei Zhang authored
Fold some small methods that are only called once into their callers. Change-Id: Ib3e9563113292dc381e0393da09eb6c8f1935088 Reviewed-on: https://chromium-review.googlesource.com/827587Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524198}
-
Alexei Filippov authored
BUG=648548 NOTRY=true Change-Id: If61eef633f510b192dd7587acec5b97709e60f50 Reviewed-on: https://chromium-review.googlesource.com/826127Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#524197}
-
Dave Rodgman authored
Remove hard-coded benchmark options from story_expection_validator. Instead, automatically generate default values for these options based on the parser options provided in the benchmark (i.e., behave as if the benchmark had been run without providing any additional options). Change-Id: Id9a49bf7b928c428cd50012866443ed7096a856b Signed-off-by:
Dave Rodgman <dave.rodgman@arm.com> Reviewed-on: https://chromium-review.googlesource.com/823848Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524196}
-
Mostyn Bramley-Moore authored
fake_platform_sensor_and_provider.h also contains a MockPlatformSensorClient class, which collides in jumbo builds. BUG=794692 Change-Id: Ib3769a25bb0927766757ba5b37ec99fc4f15768f Reviewed-on: https://chromium-review.googlesource.com/827766Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#524195}
-
Ryan Sturm authored
This tracks per host data savings for offline previews as well as cleaning up the code somewhat. Bug: 794642 Change-Id: I2660beeee2c6ef8f7939eff4861b78203dab63d6 Reviewed-on: https://chromium-review.googlesource.com/825362 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524194}
-
Yash Malik authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I27c2689ebf8b4c5027cb272cf8359f68a6e2918a Reviewed-on: https://chromium-review.googlesource.com/822234 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524193}
-
Charlie Andrews authored
Disable flaky smoothness.tough_texture_cases story on Android One TBR=vmiura@chromium.org, nednguyen@google.com Bug: 795060 Change-Id: I9dbaa1e3563b60ad95f20f4ee18935637ee09925 Reviewed-on: https://chromium-review.googlesource.com/827530Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524192}
-
Dmitry Gozman authored
This is a reland of 5fc3b9d0 Original change's description: > [DevTools] Implement waitForDebugger for OOPIFs > > Using NavigationThrottle for this. Since during throttling > the navigation has not committed yet, we have to create > agent host for soon-to-be-committed frame in advance. > > Bug: 750901 > Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200 > Reviewed-on: https://chromium-review.googlesource.com/818076 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523835} TBR=pfeldman Bug: 750901 Change-Id: I96e6c083aa0de96799fbd4a529ae97019738ed87 Reviewed-on: https://chromium-review.googlesource.com/826318Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524191}
-
Nektarios Paisios authored
1. Stopped using the value attribute to hold the inner text of spin buttons and other range controls because this could result in showing the inner text as the control's value which, depending on the control's author, could be totally meaningless. For spin buttons, now the value attribute only holds the contents of aria-valuetext if present. 2. Took the opportunity to write some more tests and clean up some of our Blink code. R=dmazzoni@chromium.org, aleventhal@chromium.org Also: Bug: 792056 Change-Id: Ib4eb98c2c1a351f40e2ac144b1967142040f0675 Tested: manually with dropdowns on kayak.com, browser tests, sample HTML snippet of an ARIA spin button Reviewed-on: https://chromium-review.googlesource.com/823136 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524190}
-
Jungshik Shin authored
Add a test for German time format (12hr with AM/PM marker). It has 3 changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/e3b480d..94d819f 2017-12-13 jshin@chromium.org Update German AM/PM marker to the previous value 2017-12-13 jshin@chromium.org Cherry-pick an upstream fix for UTF8 to UTF8 conversion 2017-12-12 jshin@chromium.org Cherry-pick an upstream fix for Calendar class Bug: 794737,794390,792537 Test: base_unittests --gtest_filter=TimeFormat*.*TimeOfDayDE Test: crbug.com/794737#c2 Change-Id: Ifa6d31624cbd9d4edc1b776e34527d8e842f7290 Reviewed-on: https://chromium-review.googlesource.com/826363 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#524189}
-
Miriam Gershenson authored
The special error handling for this case is strange and I want to delete it. This histogram will track how often it's useful so we can decide whether it's okay to delete. Bug: 779589 Change-Id: Ieadcb1214486bd468e5e9c18d2f06915b6ee1fff Reviewed-on: https://chromium-review.googlesource.com/822832Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524188}
-
Aaron Leventhal authored
Windows includes trailing space/punctuation in selection of a word or move by word (Ctrl+right). This code change makes views consistent with Blink and with other apps on Windows. This is perhaps a subtle difference for most users, however, it is an important bug fix for screen reader users who need to hear the word they land upon rather than the previous word. Bug: 196326 Change-Id: I31244da3e73af68b810027b5f825f1cb71d19124 Reviewed-on: https://chromium-review.googlesource.com/824802 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#524187}
-
Mike Wasserman authored
Add AshWindowTreeHostMusUnified and AshWindowTreeHostMusMirroringUnified. (near copies of AshWindowTreeHostUnified and AshWindowTreeHostMirroringUnified) Make ShellPortMus::CreateAshWindowTreeHost construct these like AshWindowTreeHost::Create. Loosen DisplayManager::SetDisplayConfiguration restrictions for unified (w/o viz). Do not show the PlatformDisplay's window for the virtual/offscreen unified display. TODO: Fix targeting of events on the second display during capture. TODO: Fix a crash on shutdown when unified mode is still active. Bug: 764472,770243 TBR: dpranke@chromium.org Test: Unified mode works reasonably in Mus (needs event handling work) Change-Id: I25a4f2f917275b4fd9f73cb62a5f22aaf01806ca Reviewed-on: https://chromium-review.googlesource.com/817761 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524186}
-
David Valleau authored
R=hcarmona@chromium.org, skau@chromium.org Bug: 780284 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9508803a34cde2c957cf4ca03047990039e3a29 Reviewed-on: https://chromium-review.googlesource.com/809536Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#524185}
-
Joel Einbinder authored
Bug: 725710 Change-Id: I356edbb435a5f877726b0f480130fb715f36f9ce Reviewed-on: https://chromium-review.googlesource.com/826052Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#524184}
-
Michael Thiessen authored
We were resizing the content window based off of an uninitialized projection matrix, causing it to be very large. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fabecefefe75c78bfecef746ec298e24da5b771 Reviewed-on: https://chromium-review.googlesource.com/827625Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#524183}
-
Darren Shen authored
When setting multiple values on a non list valued property, we resolved to throw a TypeError. Spec: https://github.com/w3c/css-houdini-drafts/issues/512 Bug: 785132 Change-Id: I2a1a06ffc3eb6db66e08e2537eeaa570feaff0d3 Reviewed-on: https://chromium-review.googlesource.com/826744Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524182}
-
Darren Shen authored
This patch changes all the TODO(shend)s into either FIXMEs or TODO(crbug.com/XXX). There are also some outdated TODOs. Change-Id: I3ea6eb1807c9332d07700a7e0664eec2e07ef1e1 Reviewed-on: https://chromium-review.googlesource.com/826831Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524181}
-
Marc-Antoine Courteau authored
This policy forces spellcheck to be enabled for a set of languages. The user can still enable spellcheck for other languages. Bug: 246628 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3e1322f1c6fd1e74a5c2587d6fd582ac31bae7b Reviewed-on: https://chromium-review.googlesource.com/820154Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#524180}
-
Alexei Filippov authored
Bug: Change-Id: I4177e94f6dc7cbb55392f6c70f0c7a711023edf8 Reviewed-on: https://chromium-review.googlesource.com/826364Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#524179}
-
Christos Froussios authored
This reverts commit a22b9873. Reason for revert: Password Manager initialisation depends on oscrypt, which creates the possibility of deadlock. See crbug/795019 Original change's description: > [OSCrypt][Password Manager] Introduce TaskRunner for libsecret > > A SequencedTaskRunner will be used to guarantee no race conditions > between the two clients of libsecret. > > Bug: 782851 > Change-Id: I6549f867a14378d019404429bab42008fca548a7 > Reviewed-on: https://chromium-review.googlesource.com/803954 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523409} TBR=vabr@chromium.org,cfroussios@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782851,795019 Change-Id: Ie435a623de544767189571b80f929777af881012 Reviewed-on: https://chromium-review.googlesource.com/826070Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#524178}
-
Kenneth Russell authored
Studying the code in src/build/android/test_runner.py and related files (like test_instance_factory and gtest_test_instance), there were no dependencies on this specific argument's name. Change to use the standard one so that Android works the same as the other platforms. BUG=794767 Change-Id: I22f3eea9cb9d1029b778b1d4a878d0e74dc6449c Reviewed-on: https://chromium-review.googlesource.com/826490Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524177}
-
Christos Froussios authored
This reverts commit 96bca08b. Reason for revert: Initialisation of password manager depends on OSCrypt. This introduces a deadlock, as seen crbug/795019 Additionally, this CL failed to schedule the destruction of the KeyStorage on the dedicated thread. Original change's description: > [OSCrypt] KWallet/dbus implementation should use dbus' thread > > Dbus, which we use to communicate with KWallet, requires to be called > on a dedicated thread. > > Bug: 782851 > Change-Id: I7c55c0c6cec03d3cf688b6f1ad60326e4d5f417f > Reviewed-on: https://chromium-review.googlesource.com/803481 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520980} TBR=thestig@chromium.org,vabr@chromium.org,cfroussios@chromium.org Bug: 782851, 775843, 795019 Change-Id: I8b5d4c4ed8c2fe6949591336904befe80ef4fb42 Reviewed-on: https://chromium-review.googlesource.com/826069 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#524176}
-
Gabriel Charette authored
R=thestig@chromium.org Bug: Returns scoped object which should never go unused, warn for good measure. Change-Id: I15992a1cd0d1d83157a66532f883311e36f4e621 Reviewed-on: https://chromium-review.googlesource.com/827133Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524175}
-
Koji Ishii authored
Following bot results are included. 2486 2490 2492 511 lines were removed by consecutive passes since 2446. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia8574e9f56b10c70d8fad0a4d4b910b62682fa66 Reviewed-on: https://chromium-review.googlesource.com/827044 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524174}
-
kylechar authored
These tests were failing because of a flag not being passed which has been fixed. Bug: 793302 Change-Id: Ia5eb10f390011b27179e93e50392d97421b75101 Reviewed-on: https://chromium-review.googlesource.com/826868Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524173}
-
Mike Reed authored
Bug: Change-Id: I33cde31a43e54240e4753177809445f7e28b3e9e Reviewed-on: https://chromium-review.googlesource.com/826170Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#524172}
-