GitLab

BUG=51055
TEST=no bug_51055 suppressions used in memory test:net

Review URL: http://codereview.chromium.org/3175029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

TBR=dumi

Review URL: http://codereview.chromium.org/3111025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46153
TEST=manual

Patch by morrita@google
Original code review: http://codereview.chromium.org/3139007/show

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57025 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr
BUG=53044
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3134025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57024 0039d316-1c4b-4281-b951-d872f2087c98

The fix uncovers a few things.  Previously, when we had an unclaimed
push stream, we'd leave it as an "active" stream, even if the EOF had
already been received on that stream.  I changed it so that the push
stream is removed from the active stream as soon as it is inactive,
but it remains on the unclaimed_pushed_streams list.  This seems more
correct.

The hardest part of the test was getting the test to verify the fix.
To verify the fix, I modified the Push tests so that we leave the
session open (e.g. terminate the list of reads with an ERR_IO_PENDING
rather than an EOF so that it sits open), which gives us the opportunity
to check if there are active streams left on the session when we 
completed the test.  If so, then we'll pop an error.

BUG=52898
TEST=Updated existing tests.


Review URL: http://codereview.chromium.org/3108038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57023 0039d316-1c4b-4281-b951-d872f2087c98

It's a bit hardcoded (port 443, NPN/SPDY2), but it is just for
testing purposes.

To use this mode, run chrome with:
   chrome.exe --use-spdy=npn,force-alt-protocols

BUG=none
TEST=http_alternate_protocols_unittest.cc

Review URL: http://codereview.chromium.org/3195015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57022 0039d316-1c4b-4281-b951-d872f2087c98

- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
  instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
  yaks.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3159031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=good spellers are slightly happier

Review URL: http://codereview.chromium.org/3143037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3061044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57017 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57015 0039d316-1c4b-4281-b951-d872f2087c98

TEST=included unit test
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57014 0039d316-1c4b-4281-b951-d872f2087c98

- Remove this obscure function since it was called only once.
- Use Environment::GetVar instead.

BUG=52951
TEST=trybots

Review URL: http://codereview.chromium.org/3135036

TBR=tfarina@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57013 0039d316-1c4b-4281-b951-d872f2087c98

This removes wstrings from BookmarkIndex.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3112027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=things aren't as green as they should be
TEST=things get greener

Review URL: http://codereview.chromium.org/3125035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3191018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57009 0039d316-1c4b-4281-b951-d872f2087c98

This converts the text parameter in GetBookmarksContainingText() and
DoesBookmarkContainText() to string16. (The languages parameter will wait until
I decide what I want for languages parameters in general.)

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3197009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57008 0039d316-1c4b-4281-b951-d872f2087c98

This actually converts TreeNodeModel::SetTitle(node, title); this is used by
bookmarks.

BUG=23581
TEST=builds nad passes tests

Review URL: http://codereview.chromium.org/3111024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57007 0039d316-1c4b-4281-b951-d872f2087c98

Hookup role descriptions for webkit specific strings.  Only doing this for accessibility roles we know about.
BUG=none.
TEST=Use VoiceOver to confirm the proper role descriptions are read.
Review URL: http://codereview.chromium.org/3200001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57006 0039d316-1c4b-4281-b951-d872f2087c98

Allow net::DirectoryLister to be used to recursively list the directory, and add a FULL_PATH sort option.

BUG=41762
TEST=unit test

Review URL: http://codereview.chromium.org/3175023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57005 0039d316-1c4b-4281-b951-d872f2087c98

Some of the X.509 parsing tests rely on a certain number of principals being returned, and will crash otherwise. Change the checks to be ASSERT_, so that the test fails gracefully rather than bringing down net_unittests

BUG=none
TEST=X509CertificateTest.*

Review URL: http://codereview.chromium.org/3142016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57004 0039d316-1c4b-4281-b951-d872f2087c98

On OS X and Linux (cocoa/gtk), the original X509Certificate pointer supplied in SSLCertRequestInfo's client_certs is the one returned when a user selects a certificate.

On Windows, a new X509Certificate is created from the selected certificate and returned, rather than the original X509Certificate. This translates to a dependency on X509Certificate::Cache to return the same certificate, which, while presently is true, is an implementation specific detail that should not be relied upon.

BUG=none
TEST=SSL client authentication continues to work on Windows

Review URL: http://codereview.chromium.org/3170019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57003 0039d316-1c4b-4281-b951-d872f2087c98

targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.

Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.

In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.

BUG=52680

Review URL: http://codereview.chromium.org/3161037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3140022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57000 0039d316-1c4b-4281-b951-d872f2087c98

Fix search engine dialog top image for RTL languages.  The search engine dialog shows an image of the omnibox at the top of the dialog box; in RTL languages, this image needs to be reversed and moved to the left.

BUG=52769
TEST=search engine dialog looks correct in RTL languages.

Review URL: http://codereview.chromium.org/3198006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56997 0039d316-1c4b-4281-b951-d872f2087c98

Convert lots of uses of the wstring BookmarkNode::GetTitle() in browser/cocoa.

BUG=23581
TEST=builds and passes

Review URL: http://codereview.chromium.org/3113028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/3136025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52957
TBR=glider
Review URL: http://codereview.chromium.org/3148033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56994 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56992 0039d316-1c4b-4281-b951-d872f2087c98

(Breaks on py2.4 on win)

This makes it easy to digest pass/fail status for individual tests ("OK" is more discoverable than '.' in the output log). And makes it easier to associate LOG messages from chrome with the individual tests triggering them.

BUG=42148

Review URL: http://codereview.chromium.org/3191014

TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/3126027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
CID=12578

Review URL: http://codereview.chromium.org/3166025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56989 0039d316-1c4b-4281-b951-d872f2087c98

It is causing the extension blacklist and whitelist to be not found.

BUG=47085
TEST=None

Review URL: http://codereview.chromium.org/3125030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56988 0039d316-1c4b-4281-b951-d872f2087c98

(Attempt 2 at landing this, this time with changes to fix Enabledness unit test)

BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning


Review URL: http://codereview.chromium.org/3166023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3161030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56986 0039d316-1c4b-4281-b951-d872f2087c98

Remove the wstring version of BookmarkModel::SetTitle().

BUG=23581
TEST=builds and passes enough tests

Review URL: http://codereview.chromium.org/3142030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56985 0039d316-1c4b-4281-b951-d872f2087c98

The dispatcher host code is just a stub.

BUG=32277
TESTS=none; will be added later

Review URL: http://codereview.chromium.org/3107026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56984 0039d316-1c4b-4281-b951-d872f2087c98

The HttpNetworkTransaction refactor intercepts the client auth
handling and moves it out of DoLoop. Because HandleCertificateRequest
often switches states, this caused a DCHECK and crash in some
circumstances.

This reintegrates it and adds unit tests to catch the DCHECK. We really
want to test sending a legitimate certificate, as well as more
checking interesting errors, but we cannot import temporary keys yet.

We also add a patch for tlslite to send a non-empty certificate_types.
Apple's SSL implementation raises a protocol error otherwise.

BUG=52744,51132,52778
TEST=SSLClientSocketTest.ConnectClientAuth*,URLRequestTest.ClientAuthTest

Review URL: http://codereview.chromium.org/3141026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56983 0039d316-1c4b-4281-b951-d872f2087c98

Currently, tlslite only supports the caller passing in a list of CAs pre-encoded for the TLS CertificateRequest message. This CL improves that, by providing a means of extracting the DER-encoded subject name from an X509 certificate, supplying a list of such names to tlslite's server routines, and having tlslite encode the list of CAs as part of the CertificateRequest.

BUG=47656, 47658
TEST=net_unittests

Review URL: http://codereview.chromium.org/3177015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=it compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56939

Review URL: http://codereview.chromium.org/3177020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56981 0039d316-1c4b-4281-b951-d872f2087c98