- 25 Mar, 2018 8 commits
-
-
Quinten Yearsley authored
I believe this might be dead code; I'm not sure if the layout test runner is used to run any Blink performance tests. The last related change was last year: https://codereview.chromium.org/2734823006 Before that, all changes seem to be from about 5 years ago. Change-Id: Ib1a23055391112c83b97e000707f0b2f333040e5 Reviewed-on: https://chromium-review.googlesource.com/966484 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545710}
-
Chris Kuiper authored
This sets a proper default ducking multiplier used in Chromium's MediaSession (see Chromium change 942055 for reference). Two cases: 1) On AThings speakers running CMA backend, which does its own ducking, disable ducking in the Chromium MediaSession by setting its ducking multiplier to 1.0. 2) For speakers not running CMA backend and relying on the Chromium MediaSession to duck, set an appropriate ducking multiplier (-30dB) that is inline with Cast's ducking levels [-35..-20]dB. Note that this is a simplification of Cast's ducking logic and more fine-tuning of this is desirable. Bug: internal b/69630398, internal b/73907369 Test: Ran on Android Things speakers w/ and w/o CMA backend, observed proper ducking. Change-Id: I5fe5a7e46750b88a7d44af1b38ec3f094a7c387d Reviewed-on: https://chromium-review.googlesource.com/979261 Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Reviewed-by:Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545709}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/191c7ea0..0351f2cb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6d77f729d2c1decc55eaf28eb10d6424f1ffa28e Reviewed-on: https://chromium-review.googlesource.com/979202Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545708}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6139afa10f8..44123785ca9a $ git log e6139afa1..44123785c --date=short --no-merges --format='%ad %ae %s' 2018-03-24 ihf chromeos-config: mark eve-arcnext-chrome-pfq important. 2018-03-23 achuith cros_vm: Determine SDK version outside SDK shell. Created with: roll-dep src/third_party/chromite BUG=chromium:825539,chromium:823996 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icb8dcad2d3ee70b331e2446f9f873e2c21c385d8 Reviewed-on: https://chromium-review.googlesource.com/979598Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545707}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ae313c8..191c7ea0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I324e0c21be55a90414e0ee80e4e15444b25b895e Reviewed-on: https://chromium-review.googlesource.com/979200Reviewed-by:
-
Andrew Grieve authored
Change-Id: Ie1112d1c1c657a55b5fee9b2732528c49f2f1b26 Reviewed-on: https://chromium-review.googlesource.com/978449Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545705}
-
Christopher Grant authored
I used a grep/awk/wc command to find constants that existed in only a single spot. BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I79b277dd15a5442cf6a72fc6bc32bed04a282ded Reviewed-on: https://chromium-review.googlesource.com/977953 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545704}
-
https://webrtc.googlesource.com/src.git/+log/883f470d605d..0bf0c3d7aa27 $ git log 883f470d6..0bf0c3d7a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6ebeae9524531ff6960ebc37bef746c7f469a830 Reviewed-on: https://chromium-review.googlesource.com/979404Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545703}
-
- 24 Mar, 2018 32 commits
-
-
Ian Vollick authored
This CL changes constants and strings to match the spec. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2d94a15c72e247cfc047fc54e9c7cdeda3b4a4f6 Reviewed-on: https://chromium-review.googlesource.com/979411Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545702}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7eb272ed..9ae313c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib8653e58a8173753da5f12d47d309655188af8c2 Reviewed-on: https://chromium-review.googlesource.com/979552Reviewed-by:
-
Luum Habtemariam authored
Now checking that print_job_ is not null before updating the notification object. Looking into how the print_job ended up being nullptr in the first place. May lead to possible refactor. Bug: 817521 Test: Passes all chrome unittests Change-Id: I27dd7d571e708d56a8e9abf8def12041cefbe8ea Reviewed-on: https://chromium-review.googlesource.com/961102 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#545700}
-
https://chromium.googlesource.com/catapult.git/+log/8d87482f68b6..bffbf166f004 $ git log 8d87482f6..bffbf166f --date=short --no-merges --format='%ad %ae %s' 2018-03-22 simonhatch HistogramSet - Only merge histograms with stories. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I07de3d5ced3b7faa2c034d19e30d07fe29da98fc Reviewed-on: https://chromium-review.googlesource.com/979403Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545699}
-
Yash Malik authored
The user can have a really old version of the gvr keyboard apk which doesn't support dynamic loading. In this case, we get a ClassNotFoundException, and we should just fail load the sdk instead of throwing an exception. When the user tries to use the keyboard in this case, we show the update prompt as usual. Bug: 825117 Change-Id: Id908d74f9643b6f0756355f01b7aea5a62992701 Reviewed-on: https://chromium-review.googlesource.com/978853Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#545698}
-
https://webrtc.googlesource.com/src.git/+log/2bd41f9e0ea2..883f470d605d $ git log 2bd41f9e0..883f470d6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a8d2dd67f50a63a18993d6ddf92de3f9962dbb2 Reviewed-on: https://chromium-review.googlesource.com/979401Reviewed-by:
-
Stephen McGruer authored
Upstream the spec has removed the *ReadOnly interfaces and merged their behavior into the non-ReadOnly ones. See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change. TBR=bashi,dgozman Bug: 823384 Change-Id: I01c515b7c60b029cb878ac3b7ace928d9ccc59cd Reviewed-on: https://chromium-review.googlesource.com/971943Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545696}
-
https://skia.googlesource.com/skia.git/+log/b2ec726e3776..33477889c58b $ git log b2ec726e3..33477889c --date=short --no-merges --format='%ad %ae %s' 2018-03-24 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ d9500cbd4..a50fa23a3 (1 commit) 2018-03-24 update-docs Update markdown files 2018-03-24 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e6a40d07d..26ed93d7d (2 commits) 2018-03-23 bsalomon Hide GrBackendTexture/RenderTarget constructors that take a GrPixelConfig 2018-03-23 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d779f6a98..e6a40d07d (3 commits) 2018-03-23 csmartdalton Revert "Implement Sk2f::Store2" 2018-03-23 bsalomon Remove legacy GrContext factories function and supporting code/types. 2018-03-23 bsalomon Move GrPixelConfig to GrTypesPriv 2018-03-23 bsalomon Remove legacy SkSurface::MakeFromBackendRenderTarget that does not take SkColorType 2018-03-23 bsalomon Move a bunch of internal types from GrTypes to GrTypesPriv 2018-03-23 robertphillips Get @constructor feature of SKSL working 2018-03-23 csmartdalton Implement Sk2f::Store2 2018-03-23 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ a6f932c91..d9500cbd4 (1 commit) 2018-03-21 halcanary Reland "CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2." 2018-03-23 liyuqian Use DAA for small cubics and non-convex paths that fit into a mask 2018-03-23 robertphillips Disable DDL assert to unblock Chrome 2018-03-23 fmalita [skottie] Clean up SkottieProperties 2018-03-23 bsalomon Fix leak of backend texture in GrContext_maxSurfaceSamplesForColorType test 2018-03-23 robertphillips Add error return, upon mask creation failure, in sw_draw_with_mask_filter 2018-03-23 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 2b5c77024..a6f932c91 (1 commit) 2018-03-23 halcanary Revert "CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2." 2018-03-23 jvanverth Revert "Add color fonts." 2018-03-23 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 068e70308..d779f6a98 (3 commits) 2018-03-23 robertphillips Revert "Remove std::move from GrSimpleTextureEffect" Created with: roll-dep src/third_party/skia BUG=chromium:822680,chromium:822680 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I1a33e474238714bfd70b784619457d011bcc9786 Reviewed-on: https://chromium-review.googlesource.com/979402Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545695}
-
Koji Ishii authored
Following bot results are included. 4339 4340 4342 4343 4346 4349 4352 4355 4356 4357 4360 4361 19 lines were removed and 3 lines were deflaked by consecutive results since 4296. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I406473bdb2a13b2531e46983319a9b0ea670bbef Reviewed-on: https://chromium-review.googlesource.com/974664 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545694}
-
Kevin Bailey authored
This CL adds the ability to customize MdTextButton's so that their corners are rounded. This CL then makes the tab switch button round. Bug: 780835 Change-Id: I2c46481caef074db009e681491d4f0b6822be861 Reviewed-on: https://chromium-review.googlesource.com/963836 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#545693}
-
https://chromium.googlesource.com/catapult.git/+log/85462f12f67c..8d87482f68b6 $ git log 85462f12f..8d87482f6 --date=short --no-merges --format='%ad %ae %s' 2018-03-24 oneumyvakin Support encoding for 'edit' command Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I164ca955317248b60fcd6bc6b0f73f18dff15b84 Reviewed-on: https://chromium-review.googlesource.com/979400Reviewed-by:
-
Stephen McGruer authored
Upstream the spec has removed the *ReadOnly interfaces and merged their behavior into the non-ReadOnly ones. See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change. Bug: 823384 TBR=dgozman Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6f6fe6b5f620ab5c9b83d2da6cb312b199e1d208 Reviewed-on: https://chromium-review.googlesource.com/971807Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545691}
-
Morten Stenshorne authored
The column balancer expects the flow thread offset to be 0 when it's done, but the DCHECK for that could fail in saturated arithmetic situations. Bug: 824748 Change-Id: I5de094e18b1ba691c1f165cd15ffe16b10cf0a50 Reviewed-on: https://chromium-review.googlesource.com/978141Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#545690}
-
Mostyn Bramley-Moore authored
Avoid "error: private field 'last_system_time_' is not used" warnings which are promoted to errors. This was somehow triggered by this CL: https://chromium-review.googlesource.com/973943 (But I'm not sure how- the CL did not remove any direct uses of that variable.) Speculative fix applied to the openbsd and freebsd implementations. TBR=dcheng@chromium.org Bug: 819289 Change-Id: I862d9c22a8e181ac5dd3f1a644432e5570419a0b Reviewed-on: https://chromium-review.googlesource.com/979432Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#545689}
-
junweifu authored
Since this operation is not cancellable, it's better to guarantee that |AsyncCallbackInternal| will be called instead of canceling, but |callback_| still need to take weak reference count so that it will not be run if its object has been already destroyed. This would simplify callers since they would not need to own the result returned by Create. BUG=790843 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I640cbe769c999ef20d6b9310038023c4fd3d7714 Reviewed-on: https://chromium-review.googlesource.com/968121Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#545688}
-
Stephen McGruer authored
This reverts commit f2ead72d. Reason for revert: Appears to be cause of compile failure on WIN MSVC64 (dbg): https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/4171 ../..\base/logging.h(778): error C2220: warning treated as error - no 'object' file generated ../../third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp(1095): note: see reference to function template instantiation 'std::string *logging::CheckEQImpl<unsigned int,blink::SVGSMILElement::ActiveState>(const t1 &,const t2 &,const char *)' being compiled with [ t1=unsigned int, t2=blink::SVGSMILElement::ActiveState ] ../..\base/logging.h(778): warning C4389: '==': signed/unsigned mismatch ../..\base/logging.h(779): warning C4389: '!=': signed/unsigned mismatch ../../third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp(1101): note: see reference to function template instantiation 'std::string *logging::CheckNEImpl<unsigned int,blink::SVGSMILElement::ActiveState>(const t1 &,const t2 &,const char *)' being compiled with [ t1=unsigned int, t2=blink::SVGSMILElement::ActiveState ] Original change's description: > [PE] Don't reparse "restart" and "fill" repeatedly > > Rather than doing an attribute lookup in GetRestart() and Fill(), just > map the attributes in ParseAttribute. > Also get rid of the static AtomicStrings. > > Noticed while looking at the referenced bug. > > Bug: 823473 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I19d1244c6034430c30e65c09e20c8f04552b1e5f > Reviewed-on: https://chromium-review.googlesource.com/978246 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#545686} TBR=pdr@chromium.org,fs@opera.com,schenney@chromium.org Change-Id: I78e7691c5753d6d5ef25249d0cb3a5fff0b517c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/979413Reviewed-by:
-
Fredrik Söderquist authored
Rather than doing an attribute lookup in GetRestart() and Fill(), just map the attributes in ParseAttribute. Also get rid of the static AtomicStrings. Noticed while looking at the referenced bug. Bug: 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I19d1244c6034430c30e65c09e20c8f04552b1e5f Reviewed-on: https://chromium-review.googlesource.com/978246Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#545686}
-
Lei Zhang authored
This is in preparation for adding and using base::RefCountedShm to avoid copying data from base::SharedMemory. All the printing code being changed only needs the generic base::RefCountedMemory interface and do not specifically need base::RefCountedBytes. Also fix most lint errors. Change-Id: I4071b869e75350d922bcb7077aeda269df59ee12 Reviewed-on: https://chromium-review.googlesource.com/978649 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#545685}
-
Ken Rockot authored
Wires the system API up to a new mojo_core shared library iff the GN arg |enable_mojo_core_library| is set to |true|. It is unconditionally set to |false| for now. mojo/edk:core is templated and stamped out into two targets, mojo/edk:impl_for_edk and mojo/edk:impl_for_mojo_core, repurposing the core sources sources to build mojo_core without EDK symbol exports. The public system API is updated with the addition of a trivial MojoInitialize() call. Applications consuming mojo_core must call this instead of mojo::edk::Init etc. A follow-up CL will enable the library on Chrome OS and Linux, add mojo_core_unittests to some buildbots, and update what gets packaged with the binary distribution. Doc is here: https://goo.gl/jyCYRe (google.com only) Bug: 822034 Test: Manually enable |enable_mojo_core_library| and run mojo_core_unittests Change-Id: Iff45f3687f5a1830691026a3dc4030994d33e70a Reviewed-on: https://chromium-review.googlesource.com/978361 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545684}
-
https://chromium.googlesource.com/catapult.git/+log/fe230b67399b..85462f12f67c $ git log fe230b673..85462f12f --date=short --no-merges --format='%ad %ae %s' 2018-03-22 eakuefner [TBMv2] Add GenericSet.GetOnlyElement in Python Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If3dc8a8f9d9cb7250e73c14ee854e7f521b5e6fa Reviewed-on: https://chromium-review.googlesource.com/979333Reviewed-by:
-
Philip Rogers authored
With Slimming Paint v1.75 (SPv175), PaintLayerPainter paints layer contents in the containing transform node's space. Not all layers create a transform space, such as a layer only used as a stacking context. This patch adjusts the painted output of a drag image by the offset from the layer to the layer's transform space. Bug: 823259 Change-Id: Ibd5bdba70979e94e07fd4398999c07eeef62548d Reviewed-on: https://chromium-review.googlesource.com/979166 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545682}
-
Morten Stenshorne authored
Add a LayoutNGBlockFragmentation flag (which implies LayoutNG). Not enabled by default. When enabled, we will use NG's current block fragmentation implementation (which is incomplete). When disabled, we'll fall back to legacy layout for anything that needs block fragmentation. This flag is deliberately not enabled on the layout_ng trybot, so now a bunch of multicol / pagination / printing tests will start to pass there. In order to retain test coverage for NG's block fragmentation implementation, the plan is to enable this new flag in some virtual testsuite for fast/multicol/ & co. Will deal with that in a separate CL. Bug: 824918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4053ba291d5086e495c7ceca30118c5379b99840 Reviewed-on: https://chromium-review.googlesource.com/976223Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a03592f3d2e2..e6139afa10f8 $ git log a03592f3d..e6139afa1 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 chrome-bot Update config settings by config-updater. 2018-03-14 dgarrett som_alerts_dispatcher: Switch to Legoland build URLs. Created with: roll-dep src/third_party/chromite BUG=chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iace3252ba634e64e9c089d36e06a2fca77cdbba6 Reviewed-on: https://chromium-review.googlesource.com/979337Reviewed-by:
-
Jennifer Apacible authored
Keep track of the id of the video currently in Picture-in-Picture mode. This is used for controlling video playback, such as play and pause. First of several patches relevant to controlling the video from the PiP'd window. BUG: 726619 Change-Id: Ie07dcc78d59c7b95e549e350479ee4d154400762 Reviewed-on: https://chromium-review.googlesource.com/960565 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#545679}
-
Vaclav Brozek authored
Currently, _CheckUmaHistogramChanges detects use of undefined histogram names in (Objective-)C++ files. This CL extends that support to Java as well. Bug: 821981 Change-Id: Ida931db191f0793927b0e957e64bf6dac699d502 Reviewed-on: https://chromium-review.googlesource.com/978163 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
qi1988.yang authored
For long username, it will be truncated but can't be copied. Use <input> instead of <div> to make it can be copied easily. Bug: Signed-off-by:
qi1988.yang <qi1988.yang@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3e7826db375ba8120d1828154b2f9bee276e8492 Reviewed-on: https://chromium-review.googlesource.com/973321Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#545677}
-
Vaclav Brozek authored
Currently, _CheckUmaHistogramChanges detects the cases like calling UMA_HISTOGRAM_BOOLEAN("NonexistingHistogram.Typo", true) when "NonexistingHistogram.Typo" is not a histogram name defined in histograms.xml. However, it won't detect the case when the name is after a line break: UMA_HISTOGRAM_BOOLEAN( "NonexistingHistogram.VeeeeeeeryLoooooooongName.WithSubitems", true) This will be often the case once the check gets extended to Java, where the UMA_HISTOGRAM* macros are replaced with the RecordHistogram.record*Histogram methods, which have longer names. Bug: 821981 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71d01f3b7012e8a8d6c4628d67a470c57005cd56 Reviewed-on: https://chromium-review.googlesource.com/978219 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: -
Nasko Oskov authored
This CL tries to verify that whenever WCO::ReadyToCommitNavigation has been dispatched, subsequent WCO::DidFinishNavigation will return the same RenderFrameHost consistently. Change-Id: I3797b6c55b038941a65a92aa3439526e3ca62537 Reviewed-on: https://chromium-review.googlesource.com/977050 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545675}
-
wutao authored
This cl adds a11y support to pronounce how many search results are displaying Keyboard Shortcut Viewer (KSV). Bug: 757261, 817622 Test: manual test. Change-Id: Iaa79cb83dc3f97bb0e2ceb73b946116af39ad9de Reviewed-on: https://chromium-review.googlesource.com/978457 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545674}
-
Dale Curtis authored
This moves the upload stage to VideoFrameStream via a new mechanism called "preparation." Callers can provide a PrepareCB to the stream which is called when there is sufficient space in |ready_outputs_|. This is an improvement over the current copy done by VideoRendererImpl because the VideoFrameStream (which sits between the renderer and the decoder) may hold undelivered frames until a subsequent Read(). At which point the frame still needs to be copied. This approach builds on top of lessons learned from the decoder based upload approach, https://crrev.com/c/947383, by avoiding upload of outputs as soon as they are delivered to OutputCB. This prevents a large memory regression with bursts of outputs. Performance is still improved just like the decoder wrapper approach, but just like there, it's a small improvement: ~16% reduction in read time for 4000 4K60 VP9 frames: https://www.youtube.com/watch?v=1La4QzGeaaQ (4K60 VP9) The real improvement will come later when we paralleize the decoding for offloaded decoders: https://crrev.com/c/945029 BUG=801245 TEST=updated VideoFrameStream unittests. VRI tests still pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib4fa788dad14631caff3f877484fa89fdebca119 Reviewed-on: https://chromium-review.googlesource.com/976582 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545673}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82a6480a3a0d..dbbf350a34ab $ git log 82a6480a3..dbbf350a3 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 iannucci Fix trailing whitespace test. 2018-03-23 iannucci Fix actual pylint errors. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825290,chromium:825174,chromium:825290,chromium:825174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If3ca536bc4f21f1f692b3c6ebdffae05203db93b Reviewed-on: https://chromium-review.googlesource.com/979293Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545672}
-
Shimi Zhang authored
This CL is introducing an interface allow us to add more menu items under certain circumstance. A doc to explain weird decisions is here: https://docs.google.com/document/d/1Zzeg9w0LQDG7hUkuJY4YNXFVKEknNiH8tv2zAOUh4G0 Bug: 808510, b/70523982 Change-Id: I3bec6ad76ad8ec5a3a54b406d0e47f7c0c2168ac Reviewed-on: https://chromium-review.googlesource.com/977222Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#545671}
-
